Help - Modifying EA

hello all
modification "JJN-Nugget.mq4" need help.
I tried to merge "and NUGET BIG TREND" in EA but it does not work and I can not find the error can you help me?
if the buy signal equal to the value displayed = 0. if the signal equal sell everything is ok so I think it is a problem initializing or convertion indicator expert advisor.
thank you very much
cordially

Converting an indicator into an EA is not as simple as commenting out a few lines and adding some code to send orders. If you have little or no experience you probably won't get it to work.
What errors are you getting–click on the Journals tab after running it in the Strategy Tester?

Why don't you use the iCustom function?

hello
no error but when the signal is buy, value or it triggers the buy is equal to 0.
sell the works.
thank you for your help.

hello all.
Well I think as usual I have no answer :-)
it's okay I'm used to.
@ +.

I'm not understanding what you are trying to accomplish here.

Are you looking for this program to make trades based on what you've coded?

hello and thank you for answered.
EA not put this on a graph and you will see that there is a hen buy signal value is zero. (he does not order it just gives a signal)

I took this flag that I put it gives signals of purchase and sale with a value or triggers the buy and sell, my problem is that the hen there is a buy signal value my rest zero and I do not understand why?
thank you for your help.
friendly

I put this indicator in the EA for this indicator only works on the pair or I put it in the EA works on any pair from a single graphics except buy does not work or sometimes on some I hurt pairs short transcribed indicator in my EA but I do not know where is (my or my mistakes)

What you have coded will never return anything but zero for a trade, because it's just an indicator. There is no order accounting, or opening.

And it's no ever going to allow that to happen, because it uses the indicator functions only.

If you want to make it an EA, you need to use the "Expert Advisor" template to start.

It's more complicated than that, but at least it will put you on the right path.

why it works with signals sell?
Can you help me?
I already put everything in one EA.
see post 1.

thank you

Here is a screen copy of my EA is not automatic because I do not believe in 100% automatic system is to show you that I work hard and that inciteras a person to solve my last problem.
thank you

take this with a grain of salt as i have only looked at the code for a minute in notepad...

but this looks horrible
first you test if something AND something else is true (i assume this is your 'buy signal'). if that isn't true then you do 2 tests for an opposite type of set of signals. if THAT then fails you resort to setting empty_value.

bad bad bad bad bad bad bad code. the first test has 2 opportunities to fail, same with the second, and then you tag on the end of this horrible if structure a final 'i give up' value.

'if then else if then else if then else' type of run-on structures are plain bad. don't ever 'else if'... separate the concepts into logical blocks.

it is far easier to see what section belongs to what tests and where the evaluations will resolve themselves to. again, don't EVER 'else if'.

also, use proper bracketing with your evaluations. don't run-on tests... 'if (a < b && c = d || f > g && x * y = 5 - 3)'. use brackets

if (((a < b) && (c == d)) || ((f > g) && (x * y = 2)) { }

there is usually a defined order of operations that dictate the order a set of operations will be evaluated, but there's no reason to rely on that rule (which could change between languages) and which also makes it infinitely more difficult to read what the evaluations are meant to individually be and how they group together as a whole.

don't run-on if blocks, and don't run-on evaluations or assignments.

you should re-write the code to something like this which has far less chance of having typographic errors creep-in as well as being far more readable. then you can go from there to figure-out what the actual problem is.


edit :

possibly why the code looks so crap... but why is there obviously DECOMPILED MQL in the first posts attachment? are you a thief?

I did see post 1. In fact, I downloaded, compiled it, and tried to run it.

It didn't take any trades. And I'm not surprised.

I stopped it, because it is PONDEROUSLY slow, and uses a ton of CPU power.

You need to strip off all the useless junk that creates objects on every tick, and get to the bare essence of what this is supposed to do. That's the short answer.

And I still don't believe it will take any trades whatsoever, because nowhere is there an OrderSend(), or any other trade function. There's some jumbled almost indecipherable lines of code that looks for "lastprice", and an attempt to account for the broker digits. Those are the only things I see that even try to talk about anything price related. But as I said, nothing with regards to actual trade functions.

I have no clue how to try to help, because there's no way to figure out exactly what your EA is looking for with regards to conditions for entry.

thank you very much for your advice but what you tell me is a level that is not mine unfortunately in 1 or 2 years so probably not but it's too complicated for me.

can you correct me my little EA (post 1) If you have the time?

anyway thank you for your help.

it is normal that it does not take order because it is not the goal.

post 13 is nubcake

?!!!!!!

Then what are you trying to do? It looks like a big dashboard that accounts for current price, and open orders already. If you're not looking for making trades with it, what's the point of not just using it as is for you?

attention to my problem is not in the EA indicator that it works well.
if someone could correct me to work and consumes fewer resources that would be very very nice.
thank you

nope. i don't have the time. plus it looks like you have decompiled someone elses code.

I just want the signal then thanks to my EA (copy screen I take the decision) but I absolutely need this information to complete my EA to decision support.

i am fairly sure the problem is that his english or english translation is not that great, and that the issue is purely the logic of the whole thing is broken... NOT anything at all regarding opening or closing orders. he's trying to crawl before walk, but you are talking about running. it's not even a consideration at this point. your attention is on the wrong thing due to poor english and poor descriptions of the problem.