ZigZag Problem in EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

ZIGZAG Indicator 56 replies

Zigzag indicator with pip count? 9 replies

Compiler problem or code problem ? 3 replies

problem, problem, is it MT4 platform or EA, Please help................ 1 reply

Alert for zigzag? 1 reply

ZigZag Problem in EA

  • #1
  • First Post: Jul 21, 2012 11:07am Jul 21, 2012 11:07am
Hi,
I use standard Zigzag indy in my EA. I use the following code to determine the Zigzag nodes. I noticed that sometimes the MT4 returns the Zigzag nodes from the wrong time frame. I use loop to change TF value from PERIOD_H1 to PERIOD_H4, and to PERIOD_M15.

PHP Code
void vGetNode2(int TF,double& lwnd2[2],double& hgnd2[2])
{ int t=0; int p=0; int q=0; double nd2i;  
  for (i=0; i<=150; i++)
      { nd2i=iCustom(NULL,TF,"ZigZag",13,8,5,0,i);
        if (nd2i==iLow(NULL,TF,i))  {if (p<=1) {lwnd2=nd2i; p++;}}         
        if (nd2i==iHigh(NULL,TF,i)) {if (q<=1) {hgnd2[q]=nd2i; q++;}}
        if (p==2 && q==2) break; 
      }
  return;
}
I am not sure if anyone has similar problem with MT4 returning wrong Zigzag values. Any help will be appreciated. Many Thanks.
FFJason
  • #2
  • Last Post: Jul 24, 2012 10:35am Jul 24, 2012 10:35am
Hi there FFJason,
If I understand correctly, I think the issue is not the time frames- these seem correct, it looks like there is issue with the search. perhaps try increasing the search number to a much larger number. Another option is to add an iBarShift function that will get the total number of bars on the target time frame. Try changing your code as follows:
Inserted Code
void vGetNode2(int TF,double& lwnd2[2],double& hgnd2[2]) 
{   int p=0; int q=0; int max=iBarShift(NULL,TF,0); double nd2i;   
   for (int i=0; i<max; i++) 
      {
         nd2i=iCustom(NULL,TF,"ZigZag",13,8,5,0,i); 
            if (nd2i==iLow(NULL,TF,i))  {if (p<=1) {lwnd2=nd2i; p++;}}          
            if (nd2i==iHigh(NULL,TF,i)) {if (q<=1) {hgnd2[q]=nd2i; q++;}} 
            if (p==2 && q==2) break;  
      }
  return; 
}

Good luck
:nerd: Kobi
0 traders viewing now