Need Help with Ordermodify Error 1 | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Why ordermodify error 1? 9 replies

OrderModify error 1 HELP PLEASE 5 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify error 1 ?? 0 replies

Need Help with Ordermodify Error 1

  • #1
  • First Post: Apr 25, 2012 11:00pm Apr 25, 2012 11:00pm
Im not really sure what to do here.....Anyone can help me out by adding the codes in?

PHP Code
void DoModify1()
{
   int atr=ATR(1);
   for(int i=0;i<OrdersTotal(); i++)  
   {
      RefreshRates();
      bool b=OrderSelect(i,SELECT_BY_POS,MODE_TRADES);     
      if (!b) continue;
      if (OrderSymbol()!=Symbol()) continue;
      if (OrderMagicNumber()!=Magic) continue;     
          if (OrderType()==OP_BUY)
            {  
               if(OrderStopLoss()==0)
               {
                  double sl= OrderOpenPrice()-atr*myPoint*AtrPecSL;
                     OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,Red); 
               }
               else if(OrderTakeProfit()==0 && ! IsClosePer)
               {
                  double tp= OrderOpenPrice()+atr*myPoint*AtrPecTP;
                     OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),tp,0,Green); 
               }
               else if(IsClosePer && OrderTakeProfit()!=0)
               {
                   OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),0,0,White); 
               }
            }     
          else if (OrderType()==OP_SELL)
            {               
               if(OrderStopLoss()==0)
               {
                  sl= OrderOpenPrice()+atr*myPoint*AtrPecSL;
                     OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,Red); 
               }
               else if(OrderTakeProfit()==0 && ! IsClosePer)
               {
                  tp= OrderOpenPrice()-atr*myPoint*AtrPecTP;
                     OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),tp,0,Green); 
               }
               else if(IsClosePer && OrderTakeProfit()!=0)
               {
                   OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),0,0,White); 
               }
            }  
  } 
}
  • #2
  • May 1, 2012 10:39am May 1, 2012 10:39am
Just a quick look, but you need to use normalisedouble on the calculated sl and tp, ie

OrderModify(OrderTicket(),0,NormalizeDouble(sl,Digits),OrderTakeProfit(),0,Red);


Also, OrderModify() doesn't like an unchanged value being passed to it. So don't pass OrderOpenPrice() to it, use 0 instead.
  • #3
  • May 1, 2012 2:50pm May 1, 2012 2:50pm
Not sure if this is what you're asking, but OrderModify() returns error 1 if none of the parameters are changed as a result of the attempt to modify.
  • #4
  • May 1, 2012 9:27pm May 1, 2012 9:27pm
Quoting Okane
Just a quick look, but you need to use normalisedouble on the calculated sl and tp, ie

OrderModify(OrderTicket(),0,NormalizeDouble(sl,Digits),OrderTakeProfit(),0,Red);


Also, OrderModify() doesn't like an unchanged value being passed to it. So don't pass OrderOpenPrice() to it, use 0 instead.
Hmm....ok. Let me do the changes and test again. THanks.
  • #5
  • May 1, 2012 11:17pm May 1, 2012 11:17pm
Quoting hanover
Not sure if this is what you're asking, but OrderModify() returns error 1 if none of the parameters are changed as a result of the attempt to modify.
Ya...Just that im not sure how to solve the problem.
  • #6
  • Last Post: May 2, 2012 3:05am May 2, 2012 3:05am
Quoting Okane
Just a quick look, but you need to use normalisedouble on the calculated sl and tp, ie

OrderModify(OrderTicket(),0,NormalizeDouble(sl,Digits),OrderTakeProfit(),0,Red);


Also, OrderModify() doesn't like an unchanged value being passed to it. So don't pass OrderOpenPrice() to it, use 0 instead.
I've made some changes should it look like this? Coz now it gave me Error 130...lol.

PHP Code
void DoModify1()
{
int atr=ATR(1);
for(int i=0;i<OrdersTotal(); i++) 
{
RefreshRates();
bool b=OrderSelect(i,SELECT_BY_POS,MODE_TRADES); 
if (!b) continue;
if (OrderSymbol()!=Symbol()) continue;
if (OrderMagicNumber()!=Magic) continue; 
if (OrderType()==OP_BUY)
{ 
if(OrderStopLoss()==0)
{
double sl= OrderOpenPrice()-atr*myPoint*AtrPecSL;
OrderModify(OrderTicket(),0,NormalizeDouble(sl,Digits),OrderTakeProfit(),0,Red);
}
else if(OrderTakeProfit()==0 && ! IsClosePer)
{
double tp= OrderOpenPrice()+atr*myPoint*AtrPecTP;
OrderModify(OrderTicket(),0,NormalizeDouble(tp,Digits),OrderStopLoss(),0,Green);
}
else if(IsClosePer && OrderTakeProfit()!=0)
{
OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),0,0,White); 
}
} 
else if (OrderType()==OP_SELL)
{ 
if(OrderStopLoss()==0)
{
sl= OrderOpenPrice()+atr*myPoint*AtrPecSL;
OrderModify(OrderTicket(),0,NormalizeDouble(sl,Digits),OrderTakeProfit(),0,Red);
}
else if(OrderTakeProfit()==0 && ! IsClosePer)
{
tp= OrderOpenPrice()-atr*myPoint*AtrPecTP;
OrderModify(OrderTicket(),0,NormalizeDouble(tp,Digits),OrderStopLoss(),0,Green);
}
else if(IsClosePer && OrderTakeProfit()!=0)
{
OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),0,0,White); 
}
} 
}
0 traders viewing now