EA not working at all | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA working with a broker, not working with another 0 replies

Lies, broken promises,working strategies.....4 all newbies=me 21 replies

MT4 Demo not working.. 2 replies

Ex4 files not working in Metatrader4 2 replies

Right now My metatrader3 is not working is yours working? 0 replies

EA not working at all

  • #1
  • First Post: Apr 9, 2012 2:26pm Apr 9, 2012 2:26pm
I took some time since my last thread to go through the MQ4 tutorials and learn more about coding.

Thats my first attempt to code a EA from scratch, since the last one had some borrowed code on it.

The idea is to have a buy order open as soon as a "Bid" is detected above the 10MA and have another identical sell order open at the first "Ask" below the 10MA

Unfortunately it still does not work at all.

I'm not looking for somebody to code something for me but to point what I'm doing wrong since my goal is to learn how to code.

Thanks in advance for the help



Inserted Code
double MA;
double bid;
int ticketbuy;
int ticketsell;

int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   bid=Bid;
   
   MA=iMA(NULL,0,10,0,MODE_SMA,PRICE_CLOSE,0);
   
 if (bid > MA && ticketbuy<0 ) //first bid above MA will trigger buy order
                               //if buy order is not already open
 
 
 ticketbuy=OrderSend(Symbol(),Ask,1,Ask,3,Ask-25*Point,Ask+25*Point,"My order #2",16001,0,Green);// trigger command
   
       
 if (Ask < MA && ticketsell<0 ) //first Ask below MA will trigger sell order
                               //if sell order is not already open
 
 
 
 
 ticketsell=OrderSend(Symbol(),Bid,1,Bid,3,Bid-25*Point,Bid+25*Point,"My order #0",16000,0,Green);// trigger command
     
     
     
     if(ticketbuy<0)    
       {
        Print("OrderSend failed with error #",GetLastError());//erros report
        return(0);
       
       
       
       if(ticketsell<0)
       {
        Print("OrderSend failed with error #",GetLastError());//erros report
        return(0);
       
    



//----
   return(0);
  }
}
}



//+------------------------------------------------------------------+
  • #2
  • Apr 9, 2012 2:48pm Apr 9, 2012 2:48pm
You didn't initialize the variables ticketbuy and ticketsell but you're assuming they're initially < 0. I suspect the default initial values for these is 0 so it'll never make the first trade.
You are in a maze of twisty little passages, all alike.
  • #3
  • Apr 9, 2012 2:56pm Apr 9, 2012 2:56pm
Thanks for the tip Steve, let me see what I can do about it
  • #4
  • Apr 9, 2012 3:05pm Apr 9, 2012 3:05pm
Quoting stevegee58
You didn't initialize the variables ticketbuy and ticketsell but you're assuming they're initially < 0. I suspect the default initial values for these is 0 so it'll never make the first trade.
Steve or somebody else that decide to reply.

According to the tutorials MQ4 returns -1 for a "no trade" so a ticketsell or ticketbuy with a value < 0 would be ok.

Actually it is there to validate the trigger since I don't want multiple orders of the same, just one order at a given time.
  • #5
  • Apr 9, 2012 3:09pm Apr 9, 2012 3:09pm
Use OrdersTotal to see if there are any orders open it's much easier.

Also if you're a beginner do yourself a favor and use one of the example EAs provided with MetaTrader as your starting point. They cover many of the basics that all EAs need.
You are in a maze of twisty little passages, all alike.
  • #6
  • Apr 9, 2012 3:22pm Apr 9, 2012 3:22pm
Quoting stevegee58
Use OrdersTotal to see if there are any orders open it's much easier.

Also if you're a beginner do yourself a favor and use one of the example EAs provided with MetaTrader as your starting point. They cover many of the basics that all EAs need.
Thats what I did on my first thread. But their examples of finished EAs are very complicated for me so I decided to try something simple.

What I'm trying to accomplish is to the EA to compare the MA with the Bid.

As soon as the Bid goes above the MA and there is no open buy the command will be passed to the OrderSend()

So if the Bid is > the MA value and ticketbuy < than 0 (-1 according to the tutorials)

It seems to me that if ( Bid > MA && ticketbuy < 0) describes it correctely, no?
  • #7
  • Apr 9, 2012 3:37pm Apr 9, 2012 3:37pm
Unless you use OrdersTotal you won't know when the current trade has closed from hitting SL or TP. So if you fix the ordernumber initialization your EA will open 1 trade and not open any more until you restart it.

The complexity you see in the examples is there for a reason to handle all these cases.
You are in a maze of twisty little passages, all alike.
  • #8
  • Apr 9, 2012 3:39pm Apr 9, 2012 3:39pm
Solved:

Inserted Code
extern int SL = 100;
extern int TP = 100;
extern int MA_Period = 10;
int init()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
 double MA;
static int ticketbuy, ticketsell;
static bool buy=false, sell=false;
 
   MA=iMA(NULL,0,MA_Period,0,MODE_SMA,PRICE_CLOSE,0);
 
   if(OrderSelect(ticketbuy,SELECT_BY_TICKET)==true)
      if(OrderCloseTime()!=0)
         buy=false;
 
   if(OrderSelect(ticketsell,SELECT_BY_TICKET)==true)
      if(OrderCloseTime()!=0)
         sell=false;
 
 if (Bid> MA && buy==false)
 {
     ticketbuy=OrderSend(Symbol(),OP_BUY,1,Ask,3,Ask-SL*Point,Ask+TP*Point,"My order #2",16001,0,Green);// trigger command
     buy=true;
 }
 
 
 if (Ask < MA && sell==false)
 {
     ticketsell=OrderSend(Symbol(),OP_SELL,1,Bid,3,Bid+SL*Point,Bid-TP*Point,"My order #0",16000,0,Green);// trigger command
     sell=true;
 }
 
 
 
     if(ticketbuy<0)    
       {
        Print("OrderSend failed with error #",GetLastError());//erros report
        return(0);
 
 
 
       if(ticketsell<0)
       {
        Print("OrderSend failed with error #",GetLastError());//erros report
        return(0);
 
 
 
//----
   return(0);
  }
}
}

Change the SL and TP to the pips you want.
  • #9
  • Apr 9, 2012 3:41pm Apr 9, 2012 3:41pm
Quoting jamb0
Hey quadruplex what if the price for a buy for example hits the SL or the TP, do you open another buy if the bid is still above MA or wait for a sell? I'm coding your EA, tell me.
Yes if TP or SL occur a new buy order can occur. But no 2 buys or 2 sells at the same time.
  • #10
  • Apr 9, 2012 3:42pm Apr 9, 2012 3:42pm
Quoting QuadrupleX
Yes if TP or SL occur a new buy order can occur. But no 2 buys or 2 sells at the same time.
OK, solved then with the code above
  • #11
  • Last Post: Apr 9, 2012 3:46pm Apr 9, 2012 3:46pm
Quoting jamb0
OK, solved then with the code above
Oh buy! I thought the code would be a lot simpler. Thats why I was messing up even that sinple concept takes more skills than I have now.

Thanks for the help everybody specially jamb0 that took time to code it, I'm gonna study your code and try to learn from it!

Thanks again folks!
0 traders viewing now