Question about the following code to close 2 active orders | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How to get Net Floating Pip Count from all Open Active Orders? 6 replies

Code EA to close orders at TP but only after 2 mins open 5 replies

Code to close partial orders 4 replies

script to "close open orders" and "open opposite orders" 3 replies

Almost ready EA, code works for BUY orders, but not SELL orders 6 replies

Question about the following code to close 2 active orders

  • #1
  • First Post: Apr 9, 2012 3:24am Apr 9, 2012 3:24am
My goal with the bold scripts below is to try to close 2 active orders.

Assume that we are using an MT4 account with fifo rules. Thus...the oldest of the 2 orders must be closed first. Here is the code.....


OrderSelect(0,SELECT_BY_POS,MODE_TRADES);


if (OrdersTotal() == 2 && AccountProfit() > 100 && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots (),Bid,50,Green);
Sleep(3000);
OrderClose(OrderTicket(),OrderLots( ),Bid,50,Green);}

My question about the above code is as follows.......

Lets assume that the 'if' condition is true.....then the rest of the commands must then follow, correct?

OK....lets say the first order(position 0) closes as it should. Now....notice that 2nd OrderClose line which I was hoping would close the 2nd order.
Will that indeed close the 2nd order or will it be trying to close the 1st order(pos 0) that was just closed. Would'nt the program have to finish the loop and wait for the next tick before it registers that that first position was closed?

Would the better code be?............


OrderSelect(0,SELECT_BY_POS,MODE_TRADES);


if (OrdersTotal() == 2 && AccountProfit() > 100 && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots (),Bid,50,Green);
Sleep(3000);
OrderSelect(1,SELECT_BY_POS,MODE_TRADES);
OrderClose(OrderTicket(),OrderLots( ),Bid,50,Green);}

 I know there are better ways to write the code but I am really interested in finding out if the OrderSelect() positions are changed instantaneously when an order is closed. Or...does it not change until the next tick where by the program returns to the start function??

Any help with the answer to this would be most appreciated.
  • #2
  • Apr 9, 2012 3:51am Apr 9, 2012 3:51am
I guess I could add the following red bold commands below to assist with the answer. It will either print a 1 or a 2 at that point and then the active ticket?


OrderSelect(0,SELECT_BY_POS,MODE_TR ADES);


if (OrdersTotal() == 2 && AccountProfit() > 100 && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots (),Bid,50,Green);
Sleep(3000);
Print (OrdersTotal()); Print (OrderTicket());
OrderClose(OrderTicket(),OrderLots( ),Bid,50,Green);}
  • #3
  • Apr 9, 2012 5:05am Apr 9, 2012 5:05am
Quoting 60minman
My goal with the bold scripts below is to try to close 2 active orders.

Assume that we are using an MT4 account with fifo rules. Thus...the oldest of the 2 orders must be closed first. Here is the code.....


OrderSelect(0,SELECT_BY_POS,MODE_TRADES);


if (OrdersTotal() == 2 && AccountProfit() > 100 && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots (),Bid,50,Green);
Sleep(3000);
OrderClose(OrderTicket(),OrderLots( ),Bid,50,Green);}

My question about the above...
60mm,
your code snippet is out of context.
And please use the # button and
insert the code snippet between the 2 "code" with brackets.

if you have a loop ( hard to say since you did not post it ) around the snippet, then the condition
Inserted Code
[b]if (OrdersTotal() == 2 && AccountProfit() > 100 && OrderType() == OP_BUY)[/b]
will only get you 1 order closed because
OrdersTotal() == 2 would not be the case after the first position
has been closed.

Therefore you have to make sure both orders get closed inside the
Inserted Code
{ ......    }
.

How to do that ?
Several ways.

You could store the ticket numbers or insert them manually into the script.
Would look like this:
Inserted Code
int ticket1;  
int ticket2;
Then
Inserted Code
[b]if (OrdersTotal() == 2 && AccountProfit() > 100 && OrderType() == OP_BUY)  
{
    [/b][b]OrderSelect(ticket1,SELECT_BY_POS,MODE_TRADES);[/b]
    [b]OrderClose(ticket1,OrderLots  (),Bid,50,Green);
    Sleep(3000);
    [/b][b]OrderSelect(ticket2,SELECT_BY_POS,MODE_TRADES);[/b]
[b]      OrderClose(ticket2,OrderLots(  ),Bid,50,Green); 
}[/b]
Just one way to do it.
With the context it would be easier to do it.
  • #4
  • Apr 9, 2012 6:05am Apr 9, 2012 6:05am
Try this:

Inserted Code
int i;
 
for(i=0; i<OrdersTotal(); i++)
{
if(OrderSelect(i, SELECT_BY_POS)==true)
if(AccountProfit() > 100)
if(OrderType() == OP_BUY)
OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
else if(OrderType() == OP_SELL)
OrderClose(OrderTicket(),OrderLots(),Ask,50,Red);
}

This would close all your active orders, if you want only close the 2 first orders change for(i=0; i<OrdersTotal(); i++) by for(i=0; i<2; i++)
  • #5
  • Last Post: Apr 9, 2012 6:29am Apr 9, 2012 6:29am
ok...great....thanks for the help!
0 traders viewing now