Not sure whats wrong with code | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

whats wrong with my technique? 9 replies

whats wrong with this piece of code? 14 replies

Indicator fix...code included.. WHATS WRONG?!? 4 replies

Whats wrong with this? 6 replies

Whats wrong with CAD and NZD weekly charts? 0 replies

Not sure whats wrong with code

  • #1
  • First Post: Apr 6, 2012 2:42am Apr 6, 2012 2:42am
Hello all,

Not much of a programmer here...but I have managed to put some MT4 code together a time or two. Anyhow....the following code is my attempt to close a bundle of 3 trades and obey the fifo rules. For some reason though...I cannot get the code to work. It only closes the 1st order of 3. I need all the orders to close once the if condition is met. Here is the part of the code.


if (otot == 3 && z0 >= 50 && z1 >= 50 && z2 >= 50 && apr >= LT3A && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
Sleep(3000);
OrderSelect(0,SELECT_BY_POS,MODE_TRADES);
OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
Sleep(3000);
OrderSelect(0,SELECT_BY_POS,MODE_TRADES);
OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
if (OrdersTotal() > 0)
OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);}


Again....the above code carrys out the 1st Orderclose....but it does not carry out the rest of the trade. Is the sleep command the problem?

I know there are better ways to write this but I am puzzled why the above wont work. Any help would be appreciated.
  • #2
  • Apr 6, 2012 2:53am Apr 6, 2012 2:53am
Or could the following work?......

OrderSelect(0,SELECT_BY_POS,MODE_TRADES);

if (otot == 3 && z0 >= 50 && z1 >= 50 && z2 >= 50 && apr >= LT3A && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
Sleep(3000);
if (OrdersTotal() > 0) OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
Sleep(3000);
if (OrdersTotal() > 0) OrderClose(OrderTicket(),OrderLots(),Bid,50,Green); }
  • #3
  • Last Post: Apr 6, 2012 6:36am Apr 6, 2012 6:36am
Quoting 60minman
Or could the following work?......

OrderSelect(0,SELECT_BY_POS,MODE_TRADES);

if (otot == 3 && z0 >= 50 && z1 >= 50 && z2 >= 50 && apr >= LT3A && OrderType() == OP_BUY)
{OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
Sleep(3000);
if (OrdersTotal() > 0) OrderClose(OrderTicket(),OrderLots(),Bid,50,Green);
Sleep(3000);
if (OrdersTotal() > 0) OrderClose(OrderTicket(),OrderLots(),Bid,50,Green); }
Try it.
If it doesn't then use this:
Inserted Code
  int    i,type,err,Slippage=3;
   double price;
   bool   result;
if (otot == 3 && z0 >= 50 && z1 >= 50 && z2 >= 50 && apr >= LT3A && OrderType() == OP_BUY){
 //----
for(i=OrdersTotal()-1;i>=0;i--){
  if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
    if((type==OP_BUY || type==OP_SELL) && OrderProfit()>500){
      while(true){
         if(type==OP_BUY) price=MarketInfo(OrderSymbol(),MODE_BID);
         else price=MarketInfo(OrderSymbol(),MODE_ASK);
           result=OrderClose(OrderTicket(),OrderLots(),price,Slippage,CLR_NONE);
           if(result!=true) {err=GetLastError(); Print("LastError = ",err);}
           else err=0;
           if(err==135) RefreshRates();
           else break;
         }
         } 
         }
      else Print( "When selecting a trade, error ",GetLastError()," occurred");
      }
0 traders viewing now