EA-Help Closing Position | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Closing Multiple Position By Magic Number 2 replies

Closing half of my position on Oanda 5 replies

closing half of a position on oanda 3 replies

Trader, What would be your average time holding on to a position before closing it? 10 replies

About closing a position 3 replies

EA-Help Closing Position

  • #1
  • First Post: Mar 26, 2012 10:25am Mar 26, 2012 10:25am
I'm going crazy! I have no idea whats is wrong!
I need to close the open position (buy or sell) after new bar is close below the early bar if the position is buy or close when next bar closing under the earler bar close then the sell is close.
please help me with this code!
Thanks

http://iv.pl/images/66713794647321163687.jpg

Inserted Code

 if(iClose(NULL,PERIOD_M30,0)<iClose(NULL,PERIOD_M30,1))  CloseBuy=1;
 if(iClose(NULL,PERIOD_M30,0)>iClose(NULL,PERIOD_M30,1)) CloseSell=1;


if(OrdersTotal()>0){
  for(i=1; i<=OrdersTotal(); i++)          // Cycle searching in orders
     {
      if (OrderSelect(i-1,SELECT_BY_POS)==true) // If the next is available
        {
          if(OrderMagicNumber()==MagicNumber1) {int halt1=1;}
          if(OrderMagicNumber()==MagicNumber2) {int halt2=1;}

        }
     }
}
.....
// Open buy direct
if(BarOneUp==1&&BarTwoUp==1&&BarThreeUp==1&&halt1!=1){
 int openbuy=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,slb,tpb,"Candle bug buy order",MagicNumber1,0,Blue);
 if(ReverseClose==true)closesell=1;
 }
// Open sell direct
if(BarOneDown==1&&BarTwoDown==1&&BarThreeDown==1&&halt2!=1){
 int opensell=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,sls,tps,"Candle bug sell order",MagicNumber2,0,Green);
 if(ReverseClose==true)closebuy=1;
.......
if(closesell==1||closebuy==1){// start



   if(OrdersTotal()>0){
      for(i=1; i<=OrdersTotal(); i++){          // Cycle searching in orders

            if (OrderSelect(i-1,SELECT_BY_POS)==true){ // If the next is available
                  
                       if(OrderMagicNumber()==MagicNumber1&&closebuy==1&& CloseBuy==1) { OrderClose(OrderTicket(),OrderLots(),Bid,Slippage,CLR_NONE)   ;}
         
                           if(OrderMagicNumber()==MagicNumber2&&closesell==1&& CloseSell==1) { OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,CLR_NONE); }
      
                            
   
                              }
                    }
                                      
                                 }
                                            }   
}
  • #2
  • Mar 26, 2012 10:55am Mar 26, 2012 10:55am
maybe you have another solution hav to close this position ...
  • #3
  • Mar 26, 2012 7:02pm Mar 26, 2012 7:02pm
Quoting pietra
maybe you have another solution hav to close this position ...
By definition you can't get the close of the current bar until its closed.
I don't know if you are checking once per bar or Each Tick.

Have you tried using:
Inserted Code
 if(iClose(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,2))  CloseBuy=1;
 if(iClose(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,2)) CloseSell=1;

If that does not work for you then post the whole EA and I'll take a look at it.
  • #4
  • Mar 27, 2012 3:33am Mar 27, 2012 3:33am
Quoting cyber1

Have you tried using:
Inserted Code
 if(iClose(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,2))  CloseBuy=1;
 if(iClose(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,2)) CloseSell=1;

If that does not work for you then post the whole EA and I'll take a look at it.
It's better, now It's closing position, earlier was close only on stop loss.
But It's not I want in 100%.

I have something like this:

Inserted Code
extern double    Lots=0.1;
extern int       Slip=5;
extern double    TakeProfit=500;
extern double    StopLoss=50;

extern bool      ReverseClose=true;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
int err=GetLastError();
int digits=MarketInfo("EURUSD",MODE_DIGITS);
if(digits==5){int StopMultd=10;} else{StopMultd=1;}
int Slippage=Slip*StopMultd;
int MagicNumber1=2001,MagicNumber2=2002,i,closesell=0,closebuy=0,CloseBuy=0,CloseSell=0;
double TP=NormalizeDouble(TakeProfit*StopMultd,Digits);
double SL=NormalizeDouble(StopLoss*StopMultd,Digits);


double slb=NormalizeDouble(Ask-SL*Point,Digits);
double sls=NormalizeDouble(Bid+SL*Point,Digits);


double tpb=NormalizeDouble(Ask+TP*Point,Digits);
double tps=NormalizeDouble(Bid-TP*Point,Digits);

//-------------------------------------------------------------------+
//Check open orders
//-------------------------------------------------------------------+
 if(iOpen(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,1)) int BarOneUp=1;
 if(iOpen(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,1)) int BarOneDown=1;

 if(iOpen(NULL,PERIOD_M30,2)<iClose(NULL,PERIOD_M30,2)) int BarTwoUp=1;
 if(iOpen(NULL,PERIOD_M30,2)>iClose(NULL,PERIOD_M30,2)) int BarTwoDown=1;

 if(iOpen(NULL,PERIOD_M30,3)<iClose(NULL,PERIOD_M30,3)) int BarThreeUp=1;
 if(iOpen(NULL,PERIOD_M30,3)>iClose(NULL,PERIOD_M30,3)) int BarThreeDown=1;
 
 if(iClose(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,2))  CloseBuy=1;
 if(iClose(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,2)) CloseSell=1;

if(OrdersTotal()>0){
  for(i=1; i<=OrdersTotal(); i++)          // Cycle searching in orders
     {
      if (OrderSelect(i-1,SELECT_BY_POS)==true) // If the next is available
        {
          if(OrderMagicNumber()==MagicNumber1) {int halt1=1;}
          if(OrderMagicNumber()==MagicNumber2) {int halt2=1;}

        }
     }
}
RefreshRates();
Comment(BarOneUp,BarOneDown,BarTwoUp,BarTwoDown,BarThreeUp,BarThreeDown);
//-----------------------------------------------------------------------------------------------------
// Opening criteria
//-----------------------------------------------------------------------------------------------------


if(Hour()>7 && 21>Hour()){

RefreshRates();
// Open buy direct
if(BarOneUp==1&&BarTwoUp==1&&BarThreeUp==1&&halt1!=1){
 int openbuy=OrderSend(Symbol(),OP_BUY,Lots,Ask,1,0,tpb,"Candle bug buy order",MagicNumber1,0,Blue);
 if(ReverseClose==true)closesell=1;
 }
// Open sell direct
if(BarOneDown==1&&BarTwoDown==1&&BarThreeDown==1&&halt2!=1){
 int opensell=OrderSend(Symbol(),OP_SELL,Lots,Bid,1,0,tps,"Candle bug sell order",MagicNumber2,0,Green);
 if(ReverseClose==true)closebuy=1;
 }


RefreshRates();
//-------------------------------------------------------------------------------------------------
// Closing criteria
//-----------------------------------------------------------------------------------------------
if(closesell==1||closebuy==1){// start

if(OrdersTotal()>0){
  for(i=1; i<=OrdersTotal(); i++){          // Cycle searching in orders
  
      if (OrderSelect(i-1,SELECT_BY_POS)==true){ // If the next is available
        
          if(OrderMagicNumber()==MagicNumber1&&closebuy==1&&CloseBuy==1) {OrderClose(OrderTicket(),OrderLots(),Bid,Slippage,CLR_NONE); }
           if(OrderMagicNumber()==MagicNumber2&&closesell==1&&CloseSell==1) {OrderClose(OrderTicket(),OrderLots(),Bid,Slippage,CLR_NONE);OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,CLR_NONE); 
          
           }

        }
     }
     }
     }
}
}// stop
//---------------------------------------------------------zamykanie----------------------------

                     
return(0);

I'll be 100% satisfied when my EA will do this:
http://www.picshot.pl/pfiles/81399/CLOSE.jpg
  • #5
  • Edited 4:15am Mar 27, 2012 3:57am | Edited 4:15am
if(iClose(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,2)) CloseBuy=1;
if(iClose(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,2)) CloseSell=1;


should be ....

if(iClose(NULL,PERIOD_M30,1) < iOpen(NULL,PERIOD_M30,1))
CloseBuy=1;
if(iClose(NULL,PERIOD_M30,1) > iOpen(NULL,PERIOD_M30,1))
CloseSell=1;

At least that is what I think may be wrong.

Does your journal show any 'errors' when you think it should be closing?
If you think I'm mad, I must be mad
  • #6
  • Mar 27, 2012 4:30am Mar 27, 2012 4:30am
Quoting futurespec
if(iClose(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,2)) CloseBuy=1;
if(iClose(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,2)) CloseSell=1;


should be ....

if(iClose(NULL,PERIOD_M30,1) < iOpen(NULL,PERIOD_M30,1))
CloseBuy=1;
if(iClose(NULL,PERIOD_M30,1) > iOpen(NULL,PERIOD_M30,1))
CloseSell=1;

At least that is what I think may be wrong.
now it's worse;/
Maybe It's ok, but i think that problem is with price. Do I realy need to normalize the price?Why he lost the CLOSING bars?


http://iv.pl/images/60300269086430139032.jpg
  • #7
  • Mar 27, 2012 4:47am Mar 27, 2012 4:47am
yes prices need to be 'normalised' just to keep MT4 happy.

ERR_INVALID_PRICE_PARAM (4107),
ERR_INVALID_TICKET (4108),

you are getting lots of errors ... need yo find why
1 reason is selecting the wrong ticket number
the other is possibly non-normalised prices although I have not checked your code
If you think I'm mad, I must be mad
  • #8
  • Mar 27, 2012 5:40am Mar 27, 2012 5:40am
Why do you have..

if(OrderMagicNumber()==MagicNumber2&&closesell==1&&CloseSell==1) {OrderClose(OrderTicket(),OrderLots(),Bid,Slippage,CLR_NONE);OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,CLR_NONE); }

Is that not trying to close the same ticket no twice!

(That is why I hate code stretching beyond end of screen ... cannot see what is there and it gets missed!)
If you think I'm mad, I must be mad
  • #9
  • Mar 28, 2012 2:31am Mar 28, 2012 2:31am
I don't understand you .

closesell==1 and CloseSell==1 is not the same variable.
  • #10
  • Mar 28, 2012 2:41am Mar 28, 2012 2:41am
I can see that they are not the same (but to me that is bad naming practise ... too alike).

You have if condition is met...
if(OrderMagicNumber()==MagicNumber2 &&closesell==1&&CloseSell==1)


{
OrderClose(OrderTicket(),OrderLots (),Bid,Slippage,CLR_NONE);

OrderClose(OrderTicket(),OrderLots(),Ask,Sli ppage,CLR_NONE);
}

So to me the 2nd order close is trying to close the same ticket number as the 1st order close


If I am wrong then I apologise for misleading you.
If you think I'm mad, I must be mad
  • #11
  • Mar 28, 2012 3:01am Mar 28, 2012 3:01am
ohh I see sorry my mistake.
That shouldn't be there twice
  • #12
  • Apr 4, 2012 6:57am Apr 4, 2012 6:57am
Ok I have something like that, ther is no error but doesn't close position after new bar ;/ anybody know what is wrong?

Inserted Code
if(Hour()>7 && 21>Hour()){


// Open buy direct
if(BarOneUp==1&&BarTwoUp==1&&BarThreeUp==1&&halt1!=1){
 ticket=OrderSend(Symbol(),OP_BUY,Lots,NormalizeDouble(Ask,Digits),1,slb,tpb,"Candle bug buy order",MagicNumber1,0,Blue);
 closebuy=1;
 }
// Open sell direct
if(BarOneDown==1&&BarTwoDown==1&&BarThreeDown==1&&halt2!=1){
  ticket1=OrderSend(Symbol(),OP_SELL,Lots,NormalizeDouble(Bid,Digits),1,sls,tps,"Candle bug sell order",MagicNumber2,0,Green);
closebuy=1;
 }
}
//-------------------------------------------------------------------------------------------------
// Closing criteria
//-----------------------------------------------------------------------------------------------
if(Volume[0]>1) return;
                                 if(iOpen(NULL,PERIOD_M30,1)>iClose(NULL,PERIOD_M30,1))int CloseBuy=1;
                                 if(iOpen(NULL,PERIOD_M30,1)<iClose(NULL,PERIOD_M30,1))int CloseSell=1;
                                 Comment(CloseBuy,CloseSell);
if(closesell==1||closebuy==1){// start

                  
                           if(OrdersTotal()>0){
                               
                             for(i=1; i<=OrdersTotal(); i++){          // Cycle searching in orders
  
           if (OrderSelect(i-1,SELECT_BY_POS)==true){ // If the next is available
        
          
          if(OrderMagicNumber()==MagicNumber1&&CloseBuy==1) { OrderClose(ticket,OrderLots(),NormalizeDouble(Bid,Digits),Slippage,CLR_NONE); }
          
          if(OrderMagicNumber()==MagicNumber2&&CloseSell==1) { OrderClose(ticket1,OrderLots(),NormalizeDouble(Ask,Digits),Slippage,CLR_NONE); }
}                                   
                                }
                           }
                           }

}// stop
  • #13
  • Apr 4, 2012 8:09am Apr 4, 2012 8:09am
You have....

if(Volume[0]>1) return;

Does this not mean that your code will not reach the closing conditions further below.

Suggest you put a comment in lower in code to see if execution is actually reaching that part of code.
If you think I'm mad, I must be mad
  • #14
  • Last Post: Apr 4, 2012 11:42am Apr 4, 2012 11:42am
Quoting futurespec
You have....

if(Volume[0]>1) return;

Does this not mean that your code will not reach the closing conditions further below.

Suggest you put a comment in lower in code to see if execution is actually reaching that part of code.
if(Volume[0]>1) return;
that mean go to the next bar, perhaps it's wrong
0 traders viewing now