Please help with timed trades EA | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

A hedging solution for timed trades 7 replies

Post-timed order placement 1 reply

GMT timed MA Crossover EA 0 replies

timed on and off for an ea 3 replies

Time Frames. Big picture vs. Timed entry 4 replies

Attachments: Please help with timed trades EA
Exit Attachments

Please help with timed trades EA

  • #1
  • First Post: Mar 28, 2012 5:32am Mar 28, 2012 5:32am
I want to code an EA that sends 2 pending orders at a specific hour at day, lets say, at 8am: a buylimit order 10 pips above the last day's minimum and a selllimit order 10 pips below the last day's maximum, both with 20 pips of SL and 90 pips of TP, but I don't know how , here is my temporal code, but it sends thousands of orders, I only want 1 per day, please help me:

double H, L;
int tiket_buy, tiket_sell;

H = iHigh(NULL, PERIOD_H1, 24);
L = iLow(NULL, PERIOD_H1, 24);

Print("LOW: ", L, " HIGH: ", H);

tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1,H-0.001,5,H+0.002,H-0.009,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1,L+0.001,5,L-0.002,L+0.009,"BUYLIMIT",20000,0,Green);
  • #2
  • Mar 28, 2012 6:27am Mar 28, 2012 6:27am
One simple way to do this:

Inserted Code
double H, L;
int tiket_buy, tiket_sell;
bool orders_ placed = false;
 
H = iHigh(NULL, PERIOD_H1, 24);
L = iLow(NULL, PERIOD_H1, 24);

Print("LOW: ", L, "    HIGH: ", H);

if(orders_placed==false) {
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,H-0.001,5,H+0.002,H-0.009,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1,  L+0.001,5,L-0.002,L+0.009,"BUYLIMIT",20000,0,Green);
orders_placed=true;  }
  • #3
  • Mar 28, 2012 6:41am Mar 28, 2012 6:41am
Quoting fxtr51
One simple way to do this:

Inserted Code
double H, L;
int tiket_buy, tiket_sell;
bool orders_ placed = false;
 
H = iHigh(NULL, PERIOD_H1, 24);
L = iLow(NULL, PERIOD_H1, 24);
 
Print("LOW: ", L, "    HIGH: ", H);
 
if(orders_placed==false) {
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,H-0.001,5,H+0.002,H-0.009,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1,  L+0.001,5,L-0.002,L+0.009,"BUYLIMIT",20000,0,Green);
orders_placed=true;  }
Thank you for the response, but it still sending thousands of orders per day...

Maybe activating/deactivating the boolean at some hour and minute of day...

I'm trying with:

Inserted Code
double H, L;
int tiket_buy, tiket_sell;
bool orders_placed = false;
 
if(orders_placed==false && Hour()==8 && Minute()==0) {
 
H = iHigh(NULL, PERIOD_H1, 24);
L = iLow(NULL, PERIOD_H1, 24);
Print("LOW: ", L, " HIGH: ", H);
 
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1 ,H-0.001,5,H+0.002,H-0.009,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1, L+0.001,5,L-0.002,L+0.009,"BUYLIMIT",20000,0,Green);
orders_placed=true; }

But still sending dozens of orders and only the first day of the backtesting
  • #4
  • Edited 7:18am Mar 28, 2012 7:03am | Edited 7:18am
I've solved partially the problem, changing bool by static bool, now only sends 3 selllimits and 3 buylimits per day, but still not running properly:

Inserted Code
double H, L;
int tiket_buy, tiket_sell;
static bool orders_placed = false;
 
if(Hour()==8 && Minute()==0)
{
   if(OrderSelect(tiket_sell, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_sell);
   if(OrderSelect(tiket_buy, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_buy);
 
   orders_placed=false;
}
 
if(orders_placed==false && Hour()==8 && Minute()==1) {
 
H = iHigh(NULL, PERIOD_H1, 24);
L = iLow(NULL, PERIOD_H1, 24);
Print("LOW: ", L, "    HIGH: ", H);
 
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,H-0.001,5,H+0.002,H-0.009,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1,  L+0.001,5,L-0.002,L+0.009,"BUYLIMIT",20000,0,Green);
orders_placed=true;  }
  • #5
  • Mar 28, 2012 7:05am Mar 28, 2012 7:05am
Local variables of a function do not retain their values between calls to a function. Use static or global variables. Also, learn to indent your code. http://en.wikipedia.org/wiki/Indent_style
  • #6
  • Mar 28, 2012 7:12am Mar 28, 2012 7:12am
Quoting Xaphod
Local variables of a function do not retain their values between calls to a function. Use static or global variables. Also, learn to indent your code. http://en.wikipedia.org/wiki/Indent_style
Yes, Xaphod
Of course the bool for the order_placed belongs into global variables, not in
the start routine.

I thought he knew this, but .....he didnīt .
  • #7
  • Mar 28, 2012 7:27am Mar 28, 2012 7:27am
This is the only problem I have left to solve, sometimes it sends 3 selllimits in a row, and sometimes only buylimit or selllimit:

Attached Image (click to enlarge)
Click to Enlarge Name: EA.png Size: 43 KB


Thank you guys for your responses!, they are helping me.
  • #8
  • Mar 28, 2012 7:34am Mar 28, 2012 7:34am
If you want help, post complete examples of code, not a few lines of code and screen shots of trades.
  • #9
  • Edited 8:52am Mar 28, 2012 8:01am | Edited 8:52am
Quoting Xaphod
If you want help, post complete examples of code, not a few lines of code and screen shots of trades.
...

Here you have the complete code:

Inserted Code
 
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int start()
  {
 
    double H, L;
int tiket_buy, tiket_sell;
static bool orders_placed = false;
 
RefreshRates();
 
if(Hour()==8 && Minute()==0)
{
   if(OrderSelect(tiket_sell, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_sell);
   if(OrderSelect(tiket_buy, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_buy);
 
   orders_placed=false;
}
 
if(orders_placed==false && Hour()==8 && Minute()==1) {
 
H = iHigh(NULL, PERIOD_D1, 1);
L = iLow(NULL, PERIOD_D1, 1);
Print("LOW: ", L, "    HIGH: ", H);
 
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,H-0.001,5,H+0.002,H-0.009,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1,  L+0.001,5,L-0.002,L+0.009,"BUYLIMIT",20000,0,Green);
orders_placed=true;  }
 
//----
   return(0);
  }
  • #10
  • Edited 8:41am Mar 28, 2012 8:18am | Edited 8:41am
Now I know why sometimes the orders not send: Order send error 130 (invalid stops), but the stops seem to be well, maybe because the slippage?

Edit: no it's not the slippage, I think the reason is because buy and sell orders are too close because the high and low days are not well calculated...

I have change the code with this:
H = iHigh(NULL, PERIOD_D1, 1);
L = iLow(NULL, PERIOD_D1, 1);
instead of:
H = iHigh(NULL, PERIOD_H1, 24);
L = iLow(NULL, PERIOD_H1, 24);

(edited above)

Here is the diary of the first 10 days of 2012:

2012.03.28 15:24:14 2012.01.09 08:01 SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 15:24:14 2012.01.09 08:01 SL_TP EURUSD,Daily: open #9 sell limit 0.10 EURUSD at 1.28021 sl: 1.28321 tp: 1.27221 ok
2012.03.28 15:24:14 2012.01.09 08:01 SL_TP EURUSD,Daily: LOW: 1.2697 HIGH: 1.2812
2012.03.28 15:24:14 2012.01.06 08:01 SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 15:24:14 2012.01.06 08:01 SL_TP EURUSD,Daily: open #8 sell limit 0.10 EURUSD at 1.29361 sl: 1.29661 tp: 1.28561 ok
2012.03.28 15:24:14 2012.01.06 08:01 SL_TP EURUSD,Daily: LOW: 1.277 HIGH: 1.2946
2012.03.28 15:24:14 2012.01.05 10:51 Tester: stop loss #7 at 1.28771 (1.28771 / 1.28787)
2012.03.28 15:24:14 2012.01.05 10:50 Tester: stop loss #2 at 1.28835 (1.28835 / 1.28851)
2012.03.28 15:24:14 2012.01.05 10:43 Tester: order #7, buy 0.10 EURUSD is opened at 1.29071
2012.03.28 15:24:14 2012.01.05 08:01 SL_TP EURUSD,Daily: open #7 buy limit 0.10 EURUSD at 1.29071 sl: 1.28771 tp: 1.29871 ok
2012.03.28 15:24:14 2012.01.05 08:01 SL_TP EURUSD,Daily: open #6 sell limit 0.10 EURUSD at 1.30622 sl: 1.30922 tp: 1.29822 ok
2012.03.28 15:24:14 2012.01.05 08:01 SL_TP EURUSD,Daily: LOW: 1.2897 HIGH: 1.3072
2012.03.28 15:24:14 2012.01.04 17:38 Tester: stop loss #3 at 1.28971 (1.28971 / 1.28987)
2012.03.28 15:24:14 2012.01.04 17:32 Tester: stop loss #5 at 1.29112 (1.29112 / 1.29128)
2012.03.28 15:24:14 2012.01.04 17:32 Tester: order #2, buy 0.10 EURUSD is opened at 1.29135
2012.03.28 15:24:14 2012.01.04 17:17 Tester: order #3, buy 0.10 EURUSD is opened at 1.29271
2012.03.28 15:24:14 2012.01.04 15:57 Tester: order #5, buy 0.10 EURUSD is opened at 1.29412
2012.03.28 15:24:14 2012.01.04 13:26 Tester: take profit #4 at 1.29862 (1.29846 / 1.29862)
2012.03.28 15:24:14 2012.01.04 10:07 Tester: order #4, sell 0.10 EURUSD is opened at 1.30662
2012.03.28 15:24:14 2012.01.04 08:01 SL_TP EURUSD,Daily: open #5 buy limit 0.10 EURUSD at 1.29412 sl: 1.29112 tp: 1.30212 ok
2012.03.28 15:24:14 2012.01.04 08:01 SL_TP EURUSD,Daily: open #4 sell limit 0.10 EURUSD at 1.30662 sl: 1.30962 tp: 1.29862 ok
2012.03.28 15:24:14 2012.01.04 08:01 SL_TP EURUSD,Daily: LOW: 1.2931 HIGH: 1.3076
2012.03.28 15:24:14 2012.01.03 11:52 Tester: stop loss #1 at 1.30184 (1.30168 / 1.30184)
2012.03.28 15:24:14 2012.01.03 08:01 SL_TP EURUSD,Daily: open #3 buy limit 0.10 EURUSD at 1.29271 sl: 1.28971 tp: 1.30071 ok
2012.03.28 15:24:14 2012.01.03 08:01 SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 15:24:14 2012.01.03 08:01 SL_TP EURUSD,Daily: LOW: 1.2917 HIGH: 1.297
2012.03.28 15:24:14 2012.01.03 04:07 Tester: order #1, sell 0.10 EURUSD is opened at 1.29884
2012.03.28 15:24:14 2012.01.02 08:01 SL_TP EURUSD,Daily: open #2 buy limit 0.10 EURUSD at 1.29135 sl: 1.28835 tp: 1.29935 ok
2012.03.28 15:24:14 2012.01.02 08:01 SL_TP EURUSD,Daily: open #1 sell limit 0.10 EURUSD at 1.29884 sl: 1.30184 tp: 1.29084 ok
2012.03.28 15:24:14 2012.01.02 08:01 SL_TP EURUSD,Daily: LOW: 1.2904 HIGH: 1.2998
2012.03.28 15:24:14 SL_TP test started

Highs and lows from the EA, and below the real H/Ls (H/L are of the day before of date):

...
2012.01.04: LOW: 1.2931 HIGH: 1.3076
REAL: LOW:1.29312 HIGH: 1.30762
2012.01.03: LOW: 1.2917 HIGH: 1.297
REAL: LOW: 1.29171 HIGH: 1.29703
2012.01.02: LOW: 1.2904 HIGH: 1.2998
REAL: LOW: 1.29035 HIGH: 1.29984

EDIT: The H/Ls are aproximately well calculated... But the problem still with the stops (130)...
  • #11
  • Mar 28, 2012 8:31am Mar 28, 2012 8:31am
Market orders should be opened at the bid or ask price.
Call RefreshRates() before opening an order, especially if you have already performed a command that takes an unpredictable amount of time. Ex. after a previous order.

Use GetLastError() to check for errors after opening a ticket. Also, a failed order will return a ticket nr of 0.

Print out the Ask, Bid, Openprice, SL and TP for your orders to verify the data you are sending to the server is correct.
  • #12
  • Mar 28, 2012 8:50am Mar 28, 2012 8:50am
Quoting Xaphod
Market orders should be opened at the bid or ask price.
Call RefreshRates() before opening an order, especially if you have already performed a command that takes an unpredictable amount of time. Ex. after a previous order.

Use GetLastError() to check for errors after opening a ticket. Also, a failed order will return a ticket nr of 0.

Print out the Ask, Bid, Openprice, SL and TP for your orders to verify the data you are sending to the server is correct.
Thank you, added RefreshRates() at the beggining of the code, now the orders change but still some orders not open because invalid stops

But I don't know when the orders are gonna trigger, because are pending orders..., so, how to print the Ask and Bid price when the order is triggered?
  • #13
  • Mar 28, 2012 9:06am Mar 28, 2012 9:06am
Quoting jamb0
Thank you, added RefreshRates() at the beggining of the code, now the orders change but still some orders not open because invalid stops

But I don't know when the orders are gonna trigger, because are pending orders..., so, how to print the Ask and Bid price when the order is triggered?
Disregard that. I did not realize they where pending orders.

Are you using the 'every tick' model in strategy tester?
  • #14
  • Mar 28, 2012 9:11am Mar 28, 2012 9:11am
Quoting Xaphod
Are you using the 'every tick' model in strategy tester?

Yes...
  • #15
  • Mar 28, 2012 9:19am Mar 28, 2012 9:19am
Have you tried printing out the parameters used in ordersend() to verify that they are correct.
  • #16
  • Mar 28, 2012 9:30am Mar 28, 2012 9:30am
Done!, here is the code, I'm looking the diary...

Inserted Code
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int start()
  {
//----
double H, L;
int tiket_buy, tiket_sell;
static bool orders_placed = false;
double price_sell, price_buy, SL_sell, SL_buy, TP_sell, TP_buy, SL, TP, distance;
int error;
 
RefreshRates();

error=GetLastError();

     if(error==130)
        Print("ERROR (",error,") Ask: ",Ask, "Bid: ", Bid);
 
if(Hour()==8 && Minute()==0)
{
   if(OrderSelect(tiket_sell, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_sell);
   if(OrderSelect(tiket_buy, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_buy);
   
   orders_placed=false;
}
 
if(orders_placed==false && Hour()==8 && Minute()==1) 
{
 
H = iHigh(NULL, PERIOD_D1, 1);
L = iLow(NULL, PERIOD_D1, 1);
Print("LOW: ", L, "    HIGH: ", H);
 
TP = 0.009;
SL = 0.002;
distance = 0.001;
price_sell= H-distance;
price_buy= L+distance;
SL_sell= H+SL;
SL_buy= L-SL;
TP_sell= H-TP;
TP_buy= L+TP;
 
Print("SELL order: Price:", price_sell, " SL: ", SL_sell, " TP: ", TP_sell);
Print("BUY order: Price:", price_buy, " SL: ", SL_buy, " TP: ", TP_buy);
 
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,price_sell,50,SL_sell,TP_sell,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1, price_buy ,50,SL_buy, TP_buy,"BUYLIMIT",20000,0,Green);

orders_placed=true;  
}
   
//----
   return(0);
  }
  • #17
  • Mar 28, 2012 9:35am Mar 28, 2012 9:35am
Here is the diary for the first week of the year:

Inserted Code
2012.03.28 16:31:08 2012.01.06 08:01  SL_TP EURUSD,Daily: ERROR (130) Ask: 1.2771Bid: 1.2769
2012.03.28 16:31:08 2012.01.06 08:01  SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 16:31:08 2012.01.06 08:01  SL_TP EURUSD,Daily: open #8 sell limit 0.10 EURUSD at 1.29361 sl: 1.29661 tp: 1.28561 ok
2012.03.28 16:31:08 2012.01.06 08:01  SL_TP EURUSD,Daily: BUY order: Price:1.278 SL: 1.275 TP: 1.286
2012.03.28 16:31:08 2012.01.06 08:01  SL_TP EURUSD,Daily: SELL order: Price:1.2936 SL: 1.2966 TP: 1.2856
2012.03.28 16:31:08 2012.01.06 08:01  SL_TP EURUSD,Daily: LOW: 1.277    HIGH: 1.2946
 
 
 
2012.03.28 16:31:08 2012.01.05 10:51  Tester: stop loss #7 at 1.28771 (1.28771 / 1.28788)
2012.03.28 16:31:08 2012.01.05 10:50  Tester: stop loss #2 at 1.28835 (1.28835 / 1.28852)
2012.03.28 16:31:08 2012.01.05 10:45  Tester: order #7, buy 0.10 EURUSD is opened at 1.29071
 
 
 
2012.03.28 16:31:08 2012.01.05 08:01  SL_TP EURUSD,Daily: open #7 buy limit 0.10 EURUSD at 1.29071 sl: 1.28771 tp: 1.29871 ok
2012.03.28 16:31:08 2012.01.05 08:01  SL_TP EURUSD,Daily: open #6 sell limit 0.10 EURUSD at 1.30622 sl: 1.30922 tp: 1.29822 ok
2012.03.28 16:31:08 2012.01.05 08:01  SL_TP EURUSD,Daily: BUY order: Price:1.2907 SL: 1.2877 TP: 1.2987
2012.03.28 16:31:08 2012.01.05 08:01  SL_TP EURUSD,Daily: SELL order: Price:1.3062 SL: 1.3092 TP: 1.2982
2012.03.28 16:31:08 2012.01.05 08:01  SL_TP EURUSD,Daily: LOW: 1.2897    HIGH: 1.3072
 
 
 
2012.03.28 16:31:08 2012.01.04 17:38  Tester: stop loss #3 at 1.28971 (1.28971 / 1.28988)
2012.03.28 16:31:08 2012.01.04 17:32  Tester: stop loss #5 at 1.29112 (1.29112 / 1.29129)
2012.03.28 16:31:08 2012.01.04 17:32  Tester: order #2, buy 0.10 EURUSD is opened at 1.29135
2012.03.28 16:31:08 2012.01.04 17:17  Tester: order #3, buy 0.10 EURUSD is opened at 1.29271
2012.03.28 16:31:08 2012.01.04 15:57  Tester: order #5, buy 0.10 EURUSD is opened at 1.29412
2012.03.28 16:31:08 2012.01.04 13:26  Tester: take profit #4 at 1.29862 (1.29845 / 1.29862)
2012.03.28 16:31:08 2012.01.04 10:07  Tester: order #4, sell 0.10 EURUSD is opened at 1.30662
 
 
 
2012.03.28 16:31:08 2012.01.04 08:01  SL_TP EURUSD,Daily: open #5 buy limit 0.10 EURUSD at 1.29412 sl: 1.29112 tp: 1.30212 ok
2012.03.28 16:31:08 2012.01.04 08:01  SL_TP EURUSD,Daily: open #4 sell limit 0.10 EURUSD at 1.30662 sl: 1.30962 tp: 1.29862 ok
2012.03.28 16:31:08 2012.01.04 08:01  SL_TP EURUSD,Daily: BUY order: Price:1.2941 SL: 1.2911 TP: 1.3021
2012.03.28 16:31:08 2012.01.04 08:01  SL_TP EURUSD,Daily: SELL order: Price:1.3066 SL: 1.3096 TP: 1.2986
2012.03.28 16:31:08 2012.01.04 08:01  SL_TP EURUSD,Daily: LOW: 1.2931    HIGH: 1.3076
 
 
 
2012.03.28 16:31:08 2012.01.03 11:52  Tester: stop loss #1 at 1.30184 (1.30167 / 1.30184)
 
 
 
2012.03.28 16:31:08 2012.01.03 08:01  SL_TP EURUSD,Daily: open #3 buy limit 0.10 EURUSD at 1.29271 sl: 1.28971 tp: 1.30071 ok
2012.03.28 16:31:08 2012.01.03 08:01  SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 16:31:08 2012.01.03 08:01  SL_TP EURUSD,Daily: BUY order: Price:1.2927 SL: 1.2897 TP: 1.3007
2012.03.28 16:31:08 2012.01.03 08:01  SL_TP EURUSD,Daily: SELL order: Price:1.296 SL: 1.299 TP: 1.288
2012.03.28 16:31:08 2012.01.03 08:01  SL_TP EURUSD,Daily: LOW: 1.2917    HIGH: 1.297
 
 
 
2012.03.28 16:31:08 2012.01.03 04:07  Tester: order #1, sell 0.10 EURUSD is opened at 1.29884
 
 
 
2012.03.28 16:31:08 2012.01.02 08:01  SL_TP EURUSD,Daily: open #2 buy limit 0.10 EURUSD at 1.29135 sl: 1.28835 tp: 1.29935 ok
2012.03.28 16:31:08 2012.01.02 08:01  SL_TP EURUSD,Daily: open #1 sell limit 0.10 EURUSD at 1.29884 sl: 1.30184 tp: 1.29084 ok
2012.03.28 16:31:08 2012.01.02 08:01  SL_TP EURUSD,Daily: BUY order: Price:1.2914 SL: 1.2884 TP: 1.2994
2012.03.28 16:31:08 2012.01.02 08:01  SL_TP EURUSD,Daily: SELL order: Price:1.2988 SL: 1.3018 TP: 1.2908
2012.03.28 16:31:08 2012.01.02 08:01  SL_TP EURUSD,Daily: LOW: 1.2904    HIGH: 1.2998
 
 
 
2012.03.28 16:31:08 SL_TP test started
2012.03.28 16:31:01 SL_TP EURUSD,Daily: loaded successfully

And the image:
Attached Image (click to enlarge)
Click to Enlarge Name: EA2.png Size: 51 KB


Any thoughts?

The last order send error:

Inserted Code
2012.03.28 16:31:08 2012.01.06 08:01 SL_TP EURUSD,Daily: ERROR (130) Ask: 1.2771Bid: 1.2769
2012.03.28 16:31:08 2012.01.06 08:01 SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 16:31:08 2012.01.06 08:01 SL_TP EURUSD,Daily: open #8 sell limit 0.10 EURUSD at 1.29361 sl: 1.29661 tp: 1.28561 ok
2012.03.28 16:31:08 2012.01.06 08:01 SL_TP EURUSD,Daily: BUY order: Price:1.278 SL: 1.275 TP: 1.286
2012.03.28 16:31:08 2012.01.06 08:01 SL_TP EURUSD,Daily: SELL order: Price:1.2936 SL: 1.2966 TP: 1.2856
2012.03.28 16:31:08 2012.01.06 08:01 SL_TP EURUSD,Daily: LOW: 1.277 HIGH: 1.2946
  • #18
  • Mar 28, 2012 9:36am Mar 28, 2012 9:36am
Use normalizedouble() to round any price data you are using in ordersend().
  • #19
  • Mar 28, 2012 9:49am Mar 28, 2012 9:49am
Quoting Xaphod
Use normalizedouble() to round any price data you are using in ordersend().
Done, but I get exactly the same errors than above:

Inserted Code
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int start()
  {
//----
double H, L;
int tiket_buy, tiket_sell;
static bool orders_placed = false;
double price_sell, price_buy, SL_sell, SL_buy, TP_sell, TP_buy, SL, TP, distance;
int error;
 
RefreshRates();
 
error=GetLastError();
 
     if(error==130)
        Print("ERROR (",error,") Ask: ",Ask, "Bid: ", Bid);
 
if(Hour()==8 && Minute()==0)
{
   if(OrderSelect(tiket_sell, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_sell);
   if(OrderSelect(tiket_buy, SELECT_BY_TICKET)==true)
      OrderDelete(tiket_buy);
 
   orders_placed=false;
}
 
if(orders_placed==false && Hour()==8 && Minute()==1) 
{
 
H = NormalizeDouble(iHigh(NULL, PERIOD_D1, 1),4);
L = NormalizeDouble(iLow(NULL, PERIOD_D1, 1),4);
Print("LOW: ", L, "    HIGH: ", H);
 
TP = 0.009;
SL = 0.002;
distance = 0.001;
price_sell= NormalizeDouble(H-distance,4);
price_buy= NormalizeDouble(L+distance,4);
SL_sell= NormalizeDouble(H+SL,4);
SL_buy= NormalizeDouble(L-SL,4);
TP_sell= NormalizeDouble(H-TP,4);
TP_buy= NormalizeDouble(L+TP,4);
 
Print("SELL order: Price:", price_sell, " SL: ", SL_sell, " TP: ", TP_sell);
Print("BUY order: Price:", price_buy, " SL: ", SL_buy, " TP: ", TP_buy);
 
tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,price_sell,50,SL_sell,TP_sell,"SELLLIMIT",10000,0,Red);
tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1, price_buy ,50,SL_buy, TP_buy,"BUYLIMIT",20000,0,Green);
 
orders_placed=true;  
}
 
//----
   return(0);
  }

The last error from the diary:
Inserted Code
2012.03.28 16:50:13 2012.01.06 08:01  SL_TP EURUSD,Daily: ERROR (130) Ask: 1.2771Bid: 1.2769
2012.03.28 16:50:13 2012.01.06 08:01  SL_TP EURUSD,Daily: OrderSend error 130
2012.03.28 16:50:13 2012.01.06 08:01  SL_TP EURUSD,Daily: open #8 sell limit 0.10 EURUSD at 1.29360 sl: 1.29660 tp: 1.28560 ok
2012.03.28 16:50:13 2012.01.06 08:01  SL_TP EURUSD,Daily: BUY order: Price:1.278 SL: 1.275 TP: 1.286
2012.03.28 16:50:13 2012.01.06 08:01  SL_TP EURUSD,Daily: SELL order: Price:1.2936 SL: 1.2966 TP: 1.2856
2012.03.28 16:50:13 2012.01.06 08:01  SL_TP EURUSD,Daily: LOW: 1.277    HIGH: 1.2946
  • #20
  • Mar 28, 2012 10:21am Mar 28, 2012 10:21am
Incorrect use of order types BUYSTOP/BUYLIMIT and SELLSTOP/SELLLIMIT. Use the correct order type depending on which side of the price you are at when placing the order.

Always use normalizedouble() when passing variables/calculated data to order send.

Inserted Code
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()  {
   return(0);
}


//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int start()  {
   double H, L;
   int tiket_buy, tiket_sell;
   static bool orders_placed = false;
   double price_sell, price_buy, SL_sell, SL_buy, TP_sell, TP_buy, SL, TP, distance;
   int error;
 
   if(Hour()==8 && Minute()==0) {
      if(OrderSelect(tiket_sell, SELECT_BY_TICKET)==true)
         OrderDelete(tiket_sell);
      if(OrderSelect(tiket_buy, SELECT_BY_TICKET)==true)
         OrderDelete(tiket_buy);
   
      orders_placed=false;
   }
 
   if(orders_placed==false && Hour()==8 && Minute()==1) {
      H = iHigh(NULL, PERIOD_D1, 1);
      L = iLow(NULL, PERIOD_D1, 1);
      //Print("LOW: ", L, "    HIGH: ", H);
 
      TP = 0.009;
      SL = 0.002;
      distance = 0.001;
      price_sell= NormalizeDouble(H-distance,Digits);
      price_buy= NormalizeDouble(L+distance,Digits);
      SL_sell= NormalizeDouble(H+SL,Digits);
      SL_buy= NormalizeDouble(L-SL,Digits);
      TP_sell= NormalizeDouble(H-TP,Digits);
      TP_buy= NormalizeDouble(L+TP,Digits);
      
      if (Bid>price_sell)
        Print("You cannot open a sell limit order if Bid>price_sell. Bid="+Bid+" price_sell="+price_sell);
      tiket_sell = OrderSend(Symbol(),OP_SELLLIMIT,0.1  ,price_sell,50,SL_sell,TP_sell,"SELLLIMIT",10000,0,Red);
      if (tiket_sell<0) {
        error=GetLastError();
        Print("SELL order Error: "+error+" Bid="+Bid+"  Price:", price_sell, " SL: ", SL_sell, " TP: ", TP_sell);     
      }
      
      if (Ask<price_buy)
        Print("You cannot open a buy limit order if Ask<price_buy. Ask="+Ask+" price_buy="+price_buy);
      tiket_buy = OrderSend(Symbol(),OP_BUYLIMIT,0.1, price_buy ,50,SL_buy, TP_buy,"BUYLIMIT",20000,0,Green);
      if (tiket_buy<0) {
        error=GetLastError();
        Print("BUY order Error: "+error+" Ask="+Ask+"  Price:", price_buy, " SL: ", SL_buy, " TP: ", TP_buy);
      }

      orders_placed=true;  
   }
   
   return(0);
}
0 traders viewing now