Attachments: Mega Behemoth SOB Indicator is kicking my butt

Mega Behemoth SOB Indicator is kicking my butt

#1
First Post: Feb 12, 2012 1:07am Feb 12, 2012 1:07am

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

Hi.

I'm building an eagle-eye market view indicator but am getting a stack overflow when I compile because my programming knowledge is limited and I'm trying to organize a lot of information. The indicator is based on this Concept spreadsheet. I used to update it manually every day because it was a good way for me to see how things were moving as a beginner. Well, now I have an actual strategy which generates signals on the higher timeframes and I wanted to use this top-down view to locate good entries.

Anyway, check out the screenshot cause it has the details of the indi (instructions on how to use, basically). Screenshot.

There's a lot of repetition in the code right now cause I'm not a programmer. But I'm hoping someone is nice enough to look at it and perhaps help me break some of this stuff down by using a couple simple functions I just don't know about. I pretty much just cannibalized this from another dead project of mine and.... it turned into another programming failure.

So... any help is hugely appreciated.

There's a lot of mindless customization that has to be done to get everything spaced correctly. I can do all that stuff. I just want to be able to get this running a bit cleaner at the fundamental level and am absolutely dead in the water at the moment.

Thank you for reading and hopefully for helping, too

I'm gonna attach the existing work I've done on the indi to the bottom of this post (.mq4).

Cheers...

Attached File(s)

_HEADSUP_H4_below_trend.mq4 49 KB | 333 downloads

#2
Feb 12, 2012 3:42am Feb 12, 2012 3:42am

One day!
Joined Jul 2009 | Status: ...or there about! | 220 Posts

I have had a quick glance at your code - not enough to figure out what is causing the overflow, but I did notice a lot of repetition that could be avoided and therefore simplify things.

When I am creating numerous objects, I create arrays to hold things such as object names, colours, lineweights etc, etc. With these set up, you can then use a for loop with one block of objectcreate code. Eg:

String array of object names:

PHP Code

string   A_strInfoBoxObjects[6]  =  {"InfBoxLn:1","InfBoxLn:2","InfBoxLn:3","InfBoxLn:4","InfBoxLn:5","InfBoxLn:6"};

for loop that creates 6 objects:

PHP Code

 for(int a = 0; a < ArraySize(A_strInfoBoxObjects); a++){
      //Print("name = ",A_strInfoBoxObjects[a]);
      ObjectCreate(A_strInfoBoxObjects[a],OBJ_LABEL,0,0,0);
      ObjectSet   (A_strInfoBoxObjects[a],OBJPROP_XDISTANCE, intText_X);
      ObjectSet   (A_strInfoBoxObjects[a],OBJPROP_YDISTANCE, (intText_Y +(intText_Space * a)));
      ObjectSet   (A_strInfoBoxObjects[a],OBJPROP_CORNER, intText_Corner);
      ObjectSet   (A_strInfoBoxObjects[a],OBJPROP_COLOR, clrText_Colour);
   }

The above is an excerpt from one of my indicators so no use in yours, but hopefully it gives you an idea of the structure that you can use....

Good luck!

#3
Feb 12, 2012 5:52am Feb 12, 2012 5:52am

cyber1
Joined Jan 2011 | Status: Trader | 1,299 Posts

Quoting ra457

Disliked

Hi.

I'm building an eagle-eye market view indicator but am getting a stack overflow when I compile because my programming knowledge is limited and I'm trying to organize a lot of information. The indicator is based on this Concept spreadsheet. I used to update it manually every day because it was a good way for me to see how things were moving as a beginner. Well, now I have an actual strategy which generates signals on the higher timeframes and I wanted to use this top-down view to locate good entries....

Ignored

You picked one of the most difficult types of indicators to code too.
The first thing I would suggest is pick part other "Dashboard" indicators, preferably something simple and understand how it works, then use what you have learned for your project.
Here is one example:
http://www.forexfactory.com/showthre...76#post4123776

At the very least arrays are a necessity for the Symbols and the Timeframes and the objects should be built using a function.
And start small 2 or 3 pairs and maybe 2 Timeframes. Get them working then adding additional ones will be fairly simple.

#4
Feb 12, 2012 6:11am Feb 12, 2012 6:11am

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

Quote

Disliked

The above is an excerpt from one of my indicators so no use in yours, but hopefully it gives you an idea of the structure that you can use....

It does... thank you.

Quote

Disliked

You picked one of the most difficult types of indicators to code too.
The first thing I would suggest is pick part other "Dashboard" indicators, preferably something simple and understand how it works, then use what you have learned for your project.
Here is one example:

Thanks for linking that indicator. I've deconstructed 3 or 4 other dashboard indis but havent seen this one yet. Let me see what I can do with it.

Much appreciated, both of you.

#5
Feb 12, 2012 7:31am Feb 12, 2012 7:31am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

forget that, and forget the pm i sent you. some suggest this is a difficult task. perhaps i'm about to blow some fucking minds....

you barely started the indi and coded yourself into a corner after over 800+ lines of code. have a look at what you wrote, and then look at what i literally just threw together this afternoon based on what you had done.

this is how an experienced coder like myself does it (and in only 333 lines of code) :

Inserted Code

#property indicator_separate_window

#property indicator_minimum 0
#property indicator_maximum 1

extern bool ShowIntroduction = True;

extern bool ShowEUR = true;
extern bool ShowGBP = true;
extern bool ShowUSD = true;
extern bool ShowJPY = true;
extern bool ShowAUD = true;
extern bool ShowNZD = true;
extern bool ShowCAD = true;
extern bool ShowCHF = true;
extern bool ShowDKK = true;

extern int ColumnSpacers = 10;

extern string SymbolPrefix = "";
extern string SymbolMiddleSplitter = "";
extern string SymbolSuffix = "";

extern string EqualChar = "=";
extern color EqualColor = White;
extern string LessThanChar = "-";
extern color LessThanColor = Red;
extern string GreaterThanChar = "+";
extern color GreaterThanColor = Lime;

extern color LabelDefaultColor = White;
extern string LabelFontName = "Verdana";
extern int LabelFontSize = 10;
extern int LabelXDist = 20;
extern int LabelYDist = 20;
extern int LabelXSpacing = 10;
extern int LabelYSpacing = 20;

#define thisshortname "TFObserver"

#define objprefix "tfobsobj_"

string reg_objectnamearray[];

int xdist, ydist;  //absolute values, not relative values
bool updatexdist, updateydist;
color labelcolor;

int windowindex;

///// object cleanup funcs

void RegisterObject(string objname) {
  int i, i2;
  bool found;
  
  i = ArraySize(reg_objectnamearray);
  i2 = 0;
  found = false;
  while (i2 < i) {
    if (reg_objectnamearray[i2] == objname) {
      i2 = i;
      found = true;
    }
    
    i2++;
  }
  
  if (!found) {
    ArrayResize(reg_objectnamearray, i + 1);
    reg_objectnamearray[i] = objname;
  }
}

void DeleteRegisteredObjects() {
  int i;
  
  i = ArraySize(reg_objectnamearray);
  while (i > 0) {
    ObjectDelete(reg_objectnamearray[i-1]);
    i--;
  }
  ArrayResize(reg_objectnamearray, 0);
}

///// end of object cleanup funcs

void UpdateLabel(string labelname, string labeltext) {
  labelname = objprefix + labelname;

  RegisterObject(labelname);

  if (ObjectFind(labelname) < 0) ObjectCreate(labelname, OBJ_LABEL, windowindex, 0, 0);
   ObjectSetText(labelname, labeltext, LabelFontSize, LabelFontName, labelcolor);
   ObjectSet(labelname, OBJPROP_CORNER, 0);
   ObjectSet(labelname, OBJPROP_XDISTANCE, xdist);
   ObjectSet(labelname, OBJPROP_YDISTANCE, ydist);
   
   if (updatexdist) xdist += (LabelXSpacing * StringLen(labeltext));
   if (updateydist) ydist += LabelYSpacing;
}

void SetXDist(int newxdist) { xdist = LabelXDist + newxdist; }
void SetYDist(int newydist) { ydist = LabelYDist + newydist; }

void SetXYDist(int newxdist, int newydist) {
  SetXDist(newxdist);
  SetYDist(newydist);
}

color f_DecideColor(double d1, double d2) {
  color col;
  
  col = EqualColor;
  if (d1 > d2) col = GreaterThanColor;
  if (d1 < d2) col = LessThanColor;
  
  return (col);
}

string f_DecideChar(double d1, double d2) {
  string s;
  
  s = EqualChar;
  if (d1 > d2) s = GreaterThanChar;
  if (d1 < d2) s = LessThanChar;
  
  return(s);
}

void PopulateLine(string currency1, string currency2, int startingxdist) {
  string thissymbol, s;
  double d1, d2;
  int i;
  
  thissymbol = SymbolPrefix + currency1 + SymbolMiddleSplitter + currency2 + SymbolSuffix;
  
  updatexdist = true;
  updateydist = false;
  
  xdist = LabelXDist + startingxdist;
  
  labelcolor = LabelDefaultColor;
  UpdateLabel("header_" + currency1 + currency2, thissymbol + " ");
      
  for (i = 1; i < 8; i++) {  
    d1 = iClose(thissymbol,PERIOD_M1, i);
    d2 = iClose(thissymbol,PERIOD_M1, i + 1);
    labelcolor = f_DecideColor(d1, d2);
    s = f_DecideChar(d1, d2);
    UpdateLabel(thissymbol + "_m1_" + i, s);
  }
  
  xdist += LabelXSpacing;  
  for (i = 1; i < 4; i++) {  
    d1 = iClose(thissymbol,PERIOD_M5, i);
    d2 = iClose(thissymbol,PERIOD_M5, i + 1);
    labelcolor = f_DecideColor(d1, d2);
    s = f_DecideChar(d1, d2);
    UpdateLabel(thissymbol + "_m5_" + i, s);
  }
  
  xdist += LabelXSpacing;  
  for (i = 1; i < 4; i++) {  
    d1 = iClose(thissymbol,PERIOD_M15, i);
    d2 = iClose(thissymbol,PERIOD_M15, i + 1);
    labelcolor = f_DecideColor(d1, d2);
    s = f_DecideChar(d1, d2);
    UpdateLabel(thissymbol + "_m15_" + i, s);
  }

  xdist += LabelXSpacing;  
  for (i = 1; i < 4; i++) {  
    d1 = iClose(thissymbol,PERIOD_H1, i);
    d2 = iClose(thissymbol,PERIOD_H1, i + 1);
    labelcolor = f_DecideColor(d1, d2);
    s = f_DecideChar(d1, d2);
    UpdateLabel(thissymbol + "_h1_" + i, s);
  }
  
  xdist += LabelXSpacing;  
  for (i = 1; i < 4; i++) {  
    d1 = iClose(thissymbol,PERIOD_H4, i);
    d2 = iClose(thissymbol,PERIOD_H4, i + 1);
    labelcolor = f_DecideColor(d1, d2);
    s = f_DecideChar(d1, d2);
    UpdateLabel(thissymbol + "_h4_" + i, s);
  }
  
  ydist += LabelYSpacing;
}

void IterateCurrencies(string base, int xdist) {
  if (base != "USD") PopulateLine(base, "USD", xdist);  
  if (base != "EUR") PopulateLine(base, "EUR", xdist);    
  if (base != "GBP") PopulateLine(base, "GBP", xdist);
  if (base != "CAD") PopulateLine(base, "CAD", xdist);
  if (base != "JPY") PopulateLine(base, "JPY", xdist);
  if (base != "AUD") PopulateLine(base, "AUD", xdist);
  if (base != "NZD") PopulateLine(base, "NZD", xdist);    
  if (base != "CHF") PopulateLine(base, "CHF", xdist);
  if (base != "DKK") PopulateLine(base, "DKK", xdist);
}

int init() {
  IndicatorShortName(thisshortname);
  
  labelcolor = LabelDefaultColor;

  return(0);
}

int deinit() {
  DeleteRegisteredObjects();

  return(0);
}

int start() {
  int startingydist;  //this is an absolute value, not a relative value
  int col2xdist;

  windowindex = WindowFind(thisshortname);
  
  SetXYDist(0, 0);
  updatexdist = false;
  updateydist = false;

  labelcolor = LabelDefaultColor;

  //introduction
  if (ShowIntroduction) {
    updateydist = true;
    
    UpdateLabel("title_instr1", "This indicator is for use determining entry and exit points for");
    UpdateLabel("title_instr2", "trades based on larger timeframes (H4 and larger). The indi");
    UpdateLabel("title_instr3", "shows the real body direction of the most recent candles in the");
    UpdateLabel("title_instr4", "time frames. They are to be read from LEFT to RIGHT with the");
    UpdateLabel("title_instr5", "most recent candle being on the left side. If the most recent");
    UpdateLabel("title_instr6","candle close was bullish in relation to the one before it, the");
    UpdateLabel("title_instr7","signal will be green. Otherwise, it will be red. If there is no");
    UpdateLabel("title_instr8","price change b/t the two, it will be white. This indi watches");
    UpdateLabel("title_instr9","the most recent 7 M1 candles and the most recent 3 candles");
    UpdateLabel("title_instr10","from each of the other timeframes.");
  
    SetXDist(100);
    UpdateLabel("title_instr11","Good luck!     -Rich");
    ydist += LabelYSpacing;  //create a blank line
    
    SetXDist(0);
    UpdateLabel("title_nubcake", "... code reworked by the mighty nubcake! ...");
    ydist += LabelYSpacing;  //create a blank line
  }  
  ///// end of introduction
  
  startingydist = ydist;

  // column 1
  updatexdist = true;
  updateydist = false;
  
  SetXDist(LabelXSpacing * 7);
  UpdateLabel("header_col1_m1", "M1      ");
  UpdateLabel("header_col1_m5", "M5  ");
  UpdateLabel("header_col1_m15", "M15 ");
  UpdateLabel("header_col1_h1", "H1  ");
  updateydist = true;
  UpdateLabel("header_col1_h4", "H4");
  
  if (ShowEUR) {
    IterateCurrencies("EUR", 0);
    ydist += LabelYSpacing;
  }
  
  if (ShowGBP) {  
    IterateCurrencies("GBP", 0);
    ydist += LabelYSpacing;
  }
  
  if (ShowUSD) {
    IterateCurrencies("USD", 0);
    ydist += LabelYSpacing;
  }
  
  if (ShowJPY) {
    IterateCurrencies("JPY", 0);
    ydist += LabelYSpacing;
  }  
  
  //column 2
  labelcolor = LabelDefaultColor;
  
  updatexdist = true;
  updateydist = false;
  
  col2xdist = (LabelXSpacing * 30) + (LabelXSpacing * ColumnSpacers);
  
  ydist = startingydist;
  
  SetXDist(col2xdist + (LabelXSpacing * 7));
  UpdateLabel("header_col2_m1", "M1      ");
  UpdateLabel("header_col2_m5", "M5  ");
  UpdateLabel("header_col2_m15", "M15 ");
  UpdateLabel("header_col2_h1", "H1  ");
  updateydist = true;
  UpdateLabel("header_col2_h4", "H4");

  if (ShowAUD) {
    IterateCurrencies("AUD", col2xdist);
    ydist += LabelYSpacing;
  }
  
  if (ShowNZD) {
    IterateCurrencies("NZD", col2xdist);
    ydist += LabelYSpacing;
  }
  
  if (ShowCAD) {
    IterateCurrencies("CAD", col2xdist);
    ydist += LabelYSpacing;
  }
  
  if (ShowCHF) {
    IterateCurrencies("CHF", col2xdist);
    ydist += LabelYSpacing;
  }
  
  if (ShowDKK) {
    IterateCurrencies("DKK", col2xdist);
  }

  return(0);
}

i've done minimal debugging, so it's entirely possible that it's actually broken somewhere. but it compiles, runs, and appears to function correctly within a basic backtest for that particular currency pair.

forget any other coding guru wannabe fucks who don't know a fucking thing other than how to read the last open and close value. this is how shit gets done. i don't expect you to understand this. in fact, i don't expect anyone to understand what i've done. kudos to anyone who actually can follow it and who isn't a wannabe. what i've done isn't difficult at all. it's just more complex than the typical script kiddy bullshit. it is what it is.

have a look. have a think. toy with it. break it. fix it. once you trace through the start function a few times with your mind you should start to get an idea of how it all fits together. it's really not complex at all.

Congratulations ScalaFX for coming out of the closet!

#6
Feb 12, 2012 7:46am Feb 12, 2012 7:46am

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

well you blew me out of the water. im responding to your PM again but basically, you just made something like a sand fortress with a nuclear reactor while I was throwing around sandbags. Actually, I wasn't even being that precise with my approach. It seems more like I was just sort of laying on my stomach quietly eating sand like a dumbass.

I can't wait to see it live. It visually looks like it's gonna do what it should.

Thanks again...

R

#7
Feb 12, 2012 8:34am Feb 12, 2012 8:34am

zznbrm
Joined Jul 2008 | Status: Trader | 878 Posts

Quoting nubcake

Disliked

forget any other coding guru wannabe fucks who don't know a fucking thing other than how to read the last open and close value. this is how shit gets done. i don't expect you to understand this. in fact, i don't expect anyone to understand what i've done. kudos to anyone who actually can follow it and who isn't a wannabe. what i've done isn't difficult at all. it's just more complex than the typical script kiddy bullshit. it is what it is.

Ignored

Let this be a lesson to you kids...always take pride and have confidence in your work.

This reminds me of Hopwood proclaiming himself as a coding god...except, in this case, it appears nubcake actually knows what he is doing!

I can almost picture nubcake leaning above the bow of the Titanic screaming "I'm the king of the world".

#8
Feb 12, 2012 8:53am Feb 12, 2012 8:53am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

Quoting zznbrm

Disliked

This reminds me of Hopwood proclaiming himself as a coding god...except, in this case, it appears nubcake actually knows what he is doing!

Ignored

funny you should mention that. what i originally wrote but then edited in fact referenced mr limpwood as an example of the type of constant turd scripting i was referring to. what was originally more of a "fuck those lame shitcunts" now sounds much more like an "i'm so awesome".

either way, fucked if i care! it is what it is. my work isn't great and could easily be made better, and i expect it will. but i'm not here trying to suck my own dick just because of a little mql, unlike some others.

anyways. my work here is done.

Congratulations ScalaFX for coming out of the closet!

#9
Edited 11:02am Feb 12, 2012 10:52am | Edited 11:02am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

it seems i wasn't finished.

i realized i forgot to limit the updates to once per bar which will save a tonne of cpu cycles and stop mt4 from getting slowed down. i also realized i forgot to account for non-standard symbol names when dealing with the label x positions of the different columns of data. i've also made it automatically remove the introduction text after 5 bars if you don't already have it turned off. and i've also made it remove symbols that receive invalid values and are therefore either not valid symbol names or are symbols the broker does not deal with. invalid symbols get removed after 5 bars of bogus data.

this means that after 5 minutes the intro text and possibly a large amount of symbols will get cleared and leave you with just the good stuff.

Inserted Code

#property indicator_separate_window

extern bool ShowIntroduction = True;

extern bool ShowEUR = true;
extern bool ShowGBP = true;
extern bool ShowUSD = true;
extern bool ShowJPY = true;
extern bool ShowAUD = true;
extern bool ShowNZD = true;
extern bool ShowCAD = true;
extern bool ShowCHF = true;
extern bool ShowDKK = true;

extern int ColumnSpacers = 10;

extern string SymbolPrefix = "";
extern string SymbolMiddleSplitter = "";
extern string SymbolSuffix = "";

/*extern string SymbolPrefix = "test1";
extern string SymbolMiddleSplitter = "test2";
extern string SymbolSuffix = "test3";*/

extern string EqualChar = "=";
extern color EqualColor = White;
extern string LessThanChar = "-";
extern color LessThanColor = Red;
extern string GreaterThanChar = "+";
extern color GreaterThanColor = Lime;

extern color LabelDefaultColor = White;
extern string LabelFontName = "Verdana";
extern int LabelFontSize = 8;
extern int LabelXDist = 20;
extern int LabelYDist = 20;
extern int LabelXSpacing = 7;
extern int LabelYSpacing = 15;

#define thisshortname "TFObserver"

#define objprefix "tfobsobj_"

string reg_objectnamearray[];
string reg_badsymbolarray[];
int reg_badsymbolhitarray[];  //counts bad return values on a symbol name

int xdist, ydist;  //absolute values, not relative values
bool updatexdist, updateydist;
color labelcolor;

int windowindex;

datetime lastbartime;
int introcountdown;

///// object cleanup funcs

void RegisterObject(string objname) {
  int i, i2;
  bool found;
  
  i = ArraySize(reg_objectnamearray);
  i2 = 0;
  found = false;
  while (i2 < i) {
    if (reg_objectnamearray[i2] == objname) {
      i2 = i;
      found = true;
    }
    
    i2++;
  }
  
  if (!found) {
    ArrayResize(reg_objectnamearray, i + 1);
    reg_objectnamearray[i] = objname;
  }
}

void DeleteRegisteredObjects() {
  int i;
  
  i = ArraySize(reg_objectnamearray);
  while (i > 0) {
    ObjectDelete(reg_objectnamearray[i-1]);
    i--;
  }
  ArrayResize(reg_objectnamearray, 0);
}

///// end of object cleanup funcs

///// bad symbol detection funcs

void RegisterSymbol(string symbolname, bool goodreturnvalue) {
  int i, i2, index;
  
  i = ArraySize(reg_badsymbolarray);
  i2 = 0;
  index = -1;
  while (i2 < i) {
    if (reg_badsymbolarray[i2] == symbolname) {
      index = i2;
      i2 = i;
    }
    
    i2++;
  }
  
  if (index < 0) {  //doesn't currently exist in the arrays
    ArrayResize(reg_badsymbolarray, i + 1);
    ArrayResize(reg_badsymbolhitarray, i + 1);
    reg_badsymbolarray[i] = symbolname;
    reg_badsymbolhitarray[i] = 0;
    index = i;
  }
  
  if (goodreturnvalue) {
    reg_badsymbolhitarray[index] = -1;  //received a valid value from iclose.  is valid symbol.  never set as a bad symbol
  } else {
    if (reg_badsymbolhitarray[index] > -1) {
      reg_badsymbolhitarray[index]++;  //increment bad value received counter, unless previously marked as receiving good data
    }
  }  
}

bool f_ValidSymbol(string symbolname) {
  bool r;
  int i, i2;
  
  r = true;
  i = ArraySize(reg_badsymbolarray);
  i2 = 0;
  while (i2 < i) {
    if (reg_badsymbolarray[i2] == symbolname) {
      if (reg_badsymbolhitarray[i2] > 4) r = false;  //5 + times this symbol has returned a bad value, so ignore from now on
      i2 = i;
    }
    
    i2++;
  }

  return(r);
}

///// end of bogus pairs detection funcs

void UpdateLabel(string labelname, string labeltext) {
  labelname = objprefix + labelname;

  RegisterObject(labelname);

  if (ObjectFind(labelname) < 0) ObjectCreate(labelname, OBJ_LABEL, windowindex, 0, 0);
   ObjectSetText(labelname, labeltext, LabelFontSize, LabelFontName, labelcolor);
   ObjectSet(labelname, OBJPROP_CORNER, 0);
   ObjectSet(labelname, OBJPROP_XDISTANCE, xdist);
   ObjectSet(labelname, OBJPROP_YDISTANCE, ydist);
   
   if (updatexdist) xdist += (LabelXSpacing * StringLen(labeltext));
   if (updateydist) ydist += LabelYSpacing;
}

void SetXDist(int newxdist) { xdist = LabelXDist + newxdist; }
void SetYDist(int newydist) { ydist = LabelYDist + newydist; }

void SetXYDist(int newxdist, int newydist) {
  SetXDist(newxdist);
  SetYDist(newydist);
}

color f_DecideColor(double d1, double d2) {
  color col;
  
  col = EqualColor;
  if (d1 > d2) col = GreaterThanColor;
  if (d1 < d2) col = LessThanColor;
  
  return (col);
}

string f_DecideChar(double d1, double d2) {
  string s;
  
  s = EqualChar;
  if (d1 > d2) s = GreaterThanChar;
  if (d1 < d2) s = LessThanChar;
  
  return(s);
}

void PopulateLine(string currency1, string currency2, int startingxdist) {
  string thissymbol, s;
  double d1, d2;
  int i;
  
  thissymbol = SymbolPrefix + currency1 + SymbolMiddleSplitter + currency2 + SymbolSuffix;
  
  if (f_ValidSymbol(thissymbol) == false) {
    //remove any invalid symbol label objects that might still exist
    ObjectDelete(objprefix + "header_" + thissymbol);    
    for (i = 1; i < 8; i++) ObjectDelete(objprefix + thissymbol + "_m1_" + i);        
    for (i = 1; i < 4; i++) {
      ObjectDelete(objprefix + thissymbol + "_m5_" + i);
      ObjectDelete(objprefix + thissymbol + "_m15_" + i);
      ObjectDelete(objprefix + thissymbol + "_h1_" + i);
      ObjectDelete(objprefix + thissymbol + "_h4_" + i);
    }
  } else {  //currently valid symbol
    //register symbol return values from a H1 request test.
    //server, and therefore local history, should at least have H1 data if the symbol is valid
    d1 = iClose(thissymbol,PERIOD_H1, 1);
    if (d1 > 0) RegisterSymbol(thissymbol, true);  //register valid return value
    else RegisterSymbol(thissymbol, false);  //register bad return value  
  
    updatexdist = true;
    updateydist = false;
    
    xdist = LabelXDist + startingxdist;
    
    labelcolor = LabelDefaultColor;
    UpdateLabel("header_" + thissymbol, thissymbol + " ");
        
    for (i = 1; i < 8; i++) {  
      d1 = iClose(thissymbol,PERIOD_M1, i);
      d2 = iClose(thissymbol,PERIOD_M1, i + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      UpdateLabel(thissymbol + "_m1_" + i, s);
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      d1 = iClose(thissymbol,PERIOD_M5, i);
      d2 = iClose(thissymbol,PERIOD_M5, i + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      UpdateLabel(thissymbol + "_m5_" + i, s);
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      d1 = iClose(thissymbol,PERIOD_M15, i);
      d2 = iClose(thissymbol,PERIOD_M15, i + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      UpdateLabel(thissymbol + "_m15_" + i, s);
    }
  
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      d1 = iClose(thissymbol,PERIOD_H1, i);
      d2 = iClose(thissymbol,PERIOD_H1, i + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      UpdateLabel(thissymbol + "_h1_" + i, s);      
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      d1 = iClose(thissymbol,PERIOD_H4, i);
      d2 = iClose(thissymbol,PERIOD_H4, i + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      UpdateLabel(thissymbol + "_h4_" + i, s);
    }
    
    ydist += LabelYSpacing;
  }
}
void IterateCurrencies(string base, int xdist) {
  if (base != "USD") PopulateLine(base, "USD", xdist);  
  if (base != "EUR") PopulateLine(base, "EUR", xdist);    
  if (base != "GBP") PopulateLine(base, "GBP", xdist);
  if (base != "CAD") PopulateLine(base, "CAD", xdist);
  if (base != "JPY") PopulateLine(base, "JPY", xdist);
  if (base != "AUD") PopulateLine(base, "AUD", xdist);
  if (base != "NZD") PopulateLine(base, "NZD", xdist);    
  if (base != "CHF") PopulateLine(base, "CHF", xdist);
  if (base != "DKK") PopulateLine(base, "DKK", xdist);
}

int init() {
  IndicatorShortName(thisshortname);
  
  labelcolor = LabelDefaultColor;

  ArrayResize(reg_objectnamearray, 0);
  ArrayResize(reg_badsymbolarray, 0);
  ArrayResize(reg_badsymbolhitarray, 0);
  
  if (Period() != PERIOD_M1) Alert("This indicator is designed for use on M1 charts only!");
  
  introcountdown = 5;  //get rid of intro message after 5 bars
  
  return(0);
}

int deinit() {
  DeleteRegisteredObjects();
  
  ArrayResize(reg_badsymbolarray, 0);
  ArrayResize(reg_badsymbolhitarray, 0);

  return(0);
}

int start() {
  int c;
  int startingydist;  //this is an absolute value, not a relative value
  int col2xdist;
  
  if (lastbartime < Time[0]) {
    lastbartime = Time[0];
    
    if (introcountdown > 0) {
      introcountdown--;
    } else {
      ShowIntroduction = false;
      for (c = 1; c < 12; c++) ObjectDelete(objprefix + "title_instr" + c);
      ObjectDelete(objprefix + "title_nubcake");
    }
  
    windowindex = WindowFind(thisshortname);
    
    SetXYDist(0, 0);
    updatexdist = false;
    updateydist = false;
  
    labelcolor = LabelDefaultColor;
  
    //introduction
    if (ShowIntroduction) {
      updateydist = true;
      
      UpdateLabel("title_instr1", "This indicator is for use determining entry and exit points for");
      UpdateLabel("title_instr2", "trades based on larger timeframes (H4 and larger). The indi");
      UpdateLabel("title_instr3", "shows the real body direction of the most recent candles in the");
      UpdateLabel("title_instr4", "time frames. They are to be read from LEFT to RIGHT with the");
      UpdateLabel("title_instr5", "most recent candle being on the left side. If the most recent");
      UpdateLabel("title_instr6","candle close was bullish in relation to the one before it, the");
      UpdateLabel("title_instr7","signal will be green. Otherwise, it will be red. If there is no");
      UpdateLabel("title_instr8","price change b/t the two, it will be white. This indi watches");
      UpdateLabel("title_instr9","the most recent 7 M1 candles and the most recent 3 candles");
      UpdateLabel("title_instr10","from each of the other timeframes.");
    
      SetXDist(100);
      UpdateLabel("title_instr11","Good luck!     -Rich");
      ydist += LabelYSpacing;  //create a blank line
      
      SetXDist(0);
      UpdateLabel("title_nubcake", "... code reworked by the mighty nubcake! ...");
      ydist += LabelYSpacing;  //create a blank line
    }  
    ///// end of introduction
    
    startingydist = ydist;
  
    // column 1
    updatexdist = true;
    updateydist = false;
    
    SetXDist(LabelXSpacing * StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " "));
    UpdateLabel("header_col1_m1", "M1      ");
    UpdateLabel("header_col1_m5", "M5  ");
    UpdateLabel("header_col1_m15", "M15 ");
    UpdateLabel("header_col1_h1", "H1  ");
    updateydist = true;
    UpdateLabel("header_col1_h4", "H4");
    
    if (ShowEUR) {
      IterateCurrencies("EUR", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowGBP) {  
      IterateCurrencies("GBP", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowUSD) {
      IterateCurrencies("USD", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowJPY) {
      IterateCurrencies("JPY", 0);
      ydist += LabelYSpacing;
    }  
    
    //column 2
    labelcolor = LabelDefaultColor;
    
    updatexdist = true;
    updateydist = false;
    
    col2xdist = LabelXSpacing * (StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " ") + 24 + ColumnSpacers);
    
    ydist = startingydist;
    SetXDist(col2xdist + LabelXSpacing * StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " "));
    UpdateLabel("header_col2_m1", "M1      ");
    UpdateLabel("header_col2_m5", "M5  ");
    UpdateLabel("header_col2_m15", "M15 ");
    UpdateLabel("header_col2_h1", "H1  ");
    updateydist = true;
    UpdateLabel("header_col2_h4", "H4");
  
    if (ShowAUD) {
      IterateCurrencies("AUD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowNZD) {
      IterateCurrencies("NZD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowCAD) {
      IterateCurrencies("CAD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowCHF) {
      IterateCurrencies("CHF", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowDKK) {
      IterateCurrencies("DKK", col2xdist);
    }
  }
  
  return(0);
}

chew on that for awhile. i'm going back to my damn boat. hey, look, an iceberg.

p.s. for anyone wondering why i bothered writing this little indi? i'm procrastinating / avoiding my own work for awhile. this was a nice little distraction until i get balls-deep into my own coding tasks which will be, let us say, not as 'easy' as the above code. let's see you do any better...

Congratulations ScalaFX for coming out of the closet!

#10
Edited 2:07am Feb 13, 2012 1:16am | Edited 2:07am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

hopefully the last time....

bullshit pairs get removed after 10 ticks instead of after 5 bars. i could make it do it immediately, but i don't trust mt4 to always correctly return certain values so i give it 10 chances before finally giving-up on seemingly bogus symbols.

if the indicator is unable to retrieve a certain piece of data it now displays an orange X symbol at that location.

if you don't have the symbols loaded into your market watch list then you will get a wall of X symbols due to mt4 not receiving any recent data for the currency pairs you don't have in the market watch list. just load the indicator onto a chart, close and then restart mt4, and mt4 should automatically have populated your market watch list with all of the symbols and therefore start updating all of the required history and the wall of X's should now be gone.

previously there was a total mismatch of data. each column now correctly shows the appropriate data for each symbol + period + specific time. if, for some reason, mt4 isn't able to return data for a specific time then you will see an orange X symbol at that symbol + period + specific time, as i previously mentioned above.

this brings me to an issue i don't understand. if someone knows why this happens i'm all ears, but often mt4 randomly won't give me a particular piece of bar data, for example a recent EURUSD M1 bar might show an X symbol. i actually have the chart open and can refer to it and see that all bars have data and volume and therefore mt4 has no reason why it should not have the data loaded into it's history for the indicator to grab the data from, but with a little debugging and stepping through the iTime shift values of recent bars for whatever chart happens to be showing as missing a piece of data shows that mt4 is entirely missing that particular piece of data at that time. e.g. stepping through iTime shift values from 0 to 3 might show "09:30", "09:29", "09:27", "09:26".... completely missing "09:28", whereas i can visually refer to the chart and see that at this time there was a bar with volume and therefore should be reported via iTime. i'm at a loss for what is happening there, so perhaps it's just another 'feature' of mt4. pos.

apart from that issue / bug / feature, i'm confident that this piece of code is fucking robust as.

if it's still buggy / broken elsewhere let me know.

Inserted Code

#property indicator_separate_window

#property indicator_buffers 1

extern bool ShowIntroduction = true;

extern bool ShowEUR = true;
extern bool ShowGBP = true;
extern bool ShowUSD = true;
extern bool ShowJPY = true;
extern bool ShowAUD = true;
extern bool ShowNZD = true;
extern bool ShowCAD = true;
extern bool ShowCHF = true;
extern bool ShowDKK = true;

extern int ColumnSpacers = 10;

extern string SymbolPrefix = "";
extern string SymbolMiddleSplitter = "";
extern string SymbolSuffix = "";

extern string EqualChar = "=";
extern color EqualColor = White;
extern string LessThanChar = "-";
extern color LessThanColor = Red;
extern string GreaterThanChar = "+";
extern color GreaterThanColor = Lime;
extern string ErroneousChar = "X";
extern color ErroneousColor = Orange;

extern color LabelDefaultColor = White;
extern string LabelFontName = "Verdana";
extern int LabelFontSize = 8;
extern int LabelXDist = 20;
extern int LabelYDist = 20;
extern int LabelXSpacing = 8;
extern int LabelYSpacing = 15;

#define thisshortname "TFObserver"

#define objprefix "tfobsobj_"

string reg_objectnamearray[];
string reg_badsymbolarray[];
int reg_badsymbolhitarray[];  //counts bad return values on a symbol name

int xdist, ydist;  //absolute values, not relative values
bool updatexdist, updateydist;
color labelcolor;

int windowindex;

datetime lastbartime;
bool allsymbolsupdated;
datetime introclosetime;

double nullbuffer[];

///// object cleanup funcs

void RegisterObject(string objname) {
  int i, i2;
  bool found;

  i = ArraySize(reg_objectnamearray);
  i2 = 0;
  found = false;
  while (i2 < i) {
    if (reg_objectnamearray[i2] == objname) {
      i2 = i;
      found = true;
    }
    
    i2++;
  }
  
  if (!found) {
    ArrayResize(reg_objectnamearray, i + 1);
    reg_objectnamearray[i] = objname;
  }
}

void DeleteRegisteredObjects() {
  int i;
  
  i = ArraySize(reg_objectnamearray);
  while (i > 0) {
    ObjectDelete(reg_objectnamearray[i-1]);
    i--;
  }
  ArrayResize(reg_objectnamearray, 0);
}

///// end of object cleanup funcs

///// bad symbol detection funcs

void RegisterSymbol(string symbolname, bool goodreturnvalue) {
  int i, i2, index;
  
  i = ArraySize(reg_badsymbolarray);
  i2 = 0;
  index = -1;
  while (i2 < i) {
    if (reg_badsymbolarray[i2] == symbolname) {
      index = i2;
      i2 = i;
    }
    
    i2++;
  }
  
  if (index < 0) {  //doesn't currently exist in the arrays
    ArrayResize(reg_badsymbolarray, i + 1);
    ArrayResize(reg_badsymbolhitarray, i + 1);
    reg_badsymbolarray[i] = symbolname;
    reg_badsymbolhitarray[i] = 0;
    index = i;
  }
  
  if (goodreturnvalue) {
    reg_badsymbolhitarray[index] = -1;  //received a valid value from iclose.  is valid symbol.  never set as a bad symbol
  } else {
    if (reg_badsymbolhitarray[index] > -1) {
      reg_badsymbolhitarray[index]++;  //increment bad value received counter, unless previously marked as receiving good data
    }
  }  
}

bool f_ValidSymbol(string symbolname) {
  bool r;
  int i, i2;
  
  r = true;
  i = ArraySize(reg_badsymbolarray);
  i2 = 0;
  while (i2 < i) {
    if (reg_badsymbolarray[i2] == symbolname) {
      if (reg_badsymbolhitarray[i2] > 9) r = false;  //10 + times this symbol has returned a bad value, so ignore from now on
      i2 = i;
    }
    
    i2++;
  }

  return(r);
}

///// end of bogus pairs detection funcs

void UpdateLabel(string labelname, string labeltext) {
  labelname = objprefix + labelname;

  RegisterObject(labelname);

  if (ObjectFind(labelname) < 0) ObjectCreate(labelname, OBJ_LABEL, windowindex, 0, 0);
   ObjectSetText(labelname, labeltext, LabelFontSize, LabelFontName, labelcolor);
   ObjectSet(labelname, OBJPROP_CORNER, 0);
   ObjectSet(labelname, OBJPROP_XDISTANCE, xdist);
   ObjectSet(labelname, OBJPROP_YDISTANCE, ydist);
   
   if (updatexdist) xdist += (LabelXSpacing * StringLen(labeltext));
   if (updateydist) ydist += LabelYSpacing;
}

void SetXDist(int newxdist) { xdist = LabelXDist + newxdist; }
void SetYDist(int newydist) { ydist = LabelYDist + newydist; }

void SetXYDist(int newxdist, int newydist) {
  SetXDist(newxdist);
  SetYDist(newydist);
}

color f_DecideColor(double d1, double d2) {
  color col;
  
  col = EqualColor;
  if (d1 > d2) col = GreaterThanColor;
  if (d1 < d2) col = LessThanColor;
  
  return (col);
}

string f_DecideChar(double d1, double d2) {
  string s;
  
  s = EqualChar;
  if (d1 > d2) s = GreaterThanChar;
  if (d1 < d2) s = LessThanChar;
  
  return(s);
}

int f_FindIBar(string symbolname, int symbolperiod, datetime symboldatetime) {
  int i, i2, maxbars;
  
  i = -2;
  i2 = 0;
  maxbars = iBars(symbolname, symbolperiod);
  while(i2 < maxbars) {
    if (iTime(symbolname, symbolperiod, i2) == symboldatetime) {
      i = i2;
      i2 = maxbars;
    }
    i2++;
  }
    
  return(i);
}

void PopulateLine(string currency1, string currency2, int startingxdist) {
  string thissymbol, s;
  double d1, d2;
  int i, i2;
    
  thissymbol = SymbolPrefix + currency1 + SymbolMiddleSplitter + currency2 + SymbolSuffix;
  
  if (f_ValidSymbol(thissymbol) == false) {
    //remove any invalid symbol label objects that might still exist
    ObjectDelete(objprefix + "header_" + thissymbol);    
    for (i = 1; i < 8; i++) ObjectDelete(objprefix + thissymbol + "_m1_" + i);        
    for (i = 1; i < 4; i++) {
      ObjectDelete(objprefix + thissymbol + "_m5_" + i);
      ObjectDelete(objprefix + thissymbol + "_m15_" + i);
      ObjectDelete(objprefix + thissymbol + "_h1_" + i);
      ObjectDelete(objprefix + thissymbol + "_h4_" + i);
    }
  } else {  //currently valid symbol
    //register symbol return values from a H1 request test.
    //server, and therefore local history, should at least have H1 data if the symbol is valid
    d1 = iClose(thissymbol,PERIOD_H1, 1);
    if (d1 > 0) RegisterSymbol(thissymbol, true);  //register valid return value
    else {
      RegisterSymbol(thissymbol, false);  //register bad return value  
      allsymbolsupdated = false;  //force a new attempt on all symbols next tick
    }
    
    updatexdist = true;
    updateydist = false;
    
    xdist = LabelXDist + startingxdist;
    
    labelcolor = LabelDefaultColor;
    UpdateLabel("header_" + thissymbol, thissymbol + " ");
        
    for (i = 1; i < 8; i++) {  
      i2 = f_FindIBar(thissymbol, PERIOD_M1, iTime(NULL, PERIOD_M1, i));
      d1 = iClose(thissymbol,PERIOD_M1, i2);
      d2 = iClose(thissymbol,PERIOD_M1, i2 + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      if (i2 < 0) {
        labelcolor = ErroneousColor;
        s = ErroneousChar;
      }
      UpdateLabel(thissymbol + "_m1_" + i, s);
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      i2 = f_FindIBar(thissymbol, PERIOD_M5, iTime(NULL, PERIOD_M5, i));
      d1 = iClose(thissymbol,PERIOD_M5, i2);
      d2 = iClose(thissymbol,PERIOD_M5, i2 + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      if (i2 < 0) {
        labelcolor = ErroneousColor;
        s = ErroneousChar;
      }      
      UpdateLabel(thissymbol + "_m5_" + i, s);
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      i2 = f_FindIBar(thissymbol, PERIOD_M15, iTime(NULL, PERIOD_M15, i));
      d1 = iClose(thissymbol,PERIOD_M15, i2);
      d2 = iClose(thissymbol,PERIOD_M15, i2 + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      if (i2 < 0) {
        labelcolor = ErroneousColor;
        s = ErroneousChar;
      }      
      UpdateLabel(thissymbol + "_m15_" + i, s);
    }
  
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      i2 = f_FindIBar(thissymbol, PERIOD_H1, iTime(NULL, PERIOD_H1, i));
      d1 = iClose(thissymbol,PERIOD_H1, i2);
      d2 = iClose(thissymbol,PERIOD_H1, i2 + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      if (i2 < 0) {
        labelcolor = ErroneousColor;
        s = ErroneousChar;
      }      
      UpdateLabel(thissymbol + "_h1_" + i, s);      
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      i2 = f_FindIBar(thissymbol, PERIOD_H4, iTime(NULL, PERIOD_H4, i));
      d1 = iClose(thissymbol,PERIOD_H4, i2);
      d2 = iClose(thissymbol,PERIOD_H4, i2 + 1);
      labelcolor = f_DecideColor(d1, d2);
      s = f_DecideChar(d1, d2);
      if (i2 < 0) {
        labelcolor = ErroneousColor;
        s = ErroneousChar;
      }      
      UpdateLabel(thissymbol + "_h4_" + i, s);
    }
    
    ydist += LabelYSpacing;
  }
}
void IterateCurrencies(string base, int xdist) {
  if (base != "USD") PopulateLine(base, "USD", xdist);  
  if (base != "EUR") PopulateLine(base, "EUR", xdist);    
  if (base != "GBP") PopulateLine(base, "GBP", xdist);
  if (base != "CAD") PopulateLine(base, "CAD", xdist);
  if (base != "JPY") PopulateLine(base, "JPY", xdist);
  if (base != "AUD") PopulateLine(base, "AUD", xdist);
  if (base != "NZD") PopulateLine(base, "NZD", xdist);    
  if (base != "CHF") PopulateLine(base, "CHF", xdist);
  if (base != "DKK") PopulateLine(base, "DKK", xdist);
}

int init() {
  IndicatorShortName(thisshortname);
  
  labelcolor = LabelDefaultColor;

  ArrayResize(reg_objectnamearray, 0);
  ArrayResize(reg_badsymbolarray, 0);
  ArrayResize(reg_badsymbolhitarray, 0);
  
  if (Period() != PERIOD_M1) Alert("This indicator is designed for use on M1 charts only!");
  
  introclosetime = TimeCurrent() + (60 * 5);
  
  SetIndexBuffer(0, nullbuffer);
  SetIndexStyle(0, DRAW_NONE);
  
  return(0);
}

int deinit() {
  DeleteRegisteredObjects();
  
  ArrayResize(reg_badsymbolarray, 0);
  ArrayResize(reg_badsymbolhitarray, 0);

  return(0);
}

int start() {
  int c;
  int startingydist;  //this is an absolute value, not a relative value
  int col2xdist;
  
  if ((lastbartime < Time[0]) || (!allsymbolsupdated)) {
    allsymbolsupdated = true;
    lastbartime = Time[0];
    
    if (ShowIntroduction && (TimeCurrent() > introclosetime)) {
      ShowIntroduction = false;
      for (c = 1; c < 12; c++) ObjectDelete(objprefix + "title_instr" + c);
      ObjectDelete(objprefix + "title_nubcake");
    }

    windowindex = WindowFind(thisshortname);
    
    SetXYDist(0, 0);
    updatexdist = false;
    updateydist = false;
  
    labelcolor = LabelDefaultColor;
  
    //introduction
    if (ShowIntroduction) {
      updateydist = true;
      
      UpdateLabel("title_instr1", "This indicator is for use determining entry and exit points for");
      UpdateLabel("title_instr2", "trades based on larger timeframes (H4 and larger). The indi");
      UpdateLabel("title_instr3", "shows the real body direction of the most recent candles in the");
      UpdateLabel("title_instr4", "time frames. They are to be read from LEFT to RIGHT with the");
      UpdateLabel("title_instr5", "most recent candle being on the left side. If the most recent");
      UpdateLabel("title_instr6","candle close was bullish in relation to the one before it, the");
      UpdateLabel("title_instr7","signal will be green. Otherwise, it will be red. If there is no");
      UpdateLabel("title_instr8","price change b/t the two, it will be white. This indi watches");
      UpdateLabel("title_instr9","the most recent 7 M1 candles and the most recent 3 candles");
      UpdateLabel("title_instr10","from each of the other timeframes.");
    
      SetXDist(100);
      UpdateLabel("title_instr11","Good luck!     -Rich");
      ydist += LabelYSpacing;  //create a blank line
      
      SetXDist(0);
      UpdateLabel("title_nubcake", "... code reworked by the mighty nubcake! ...");
      ydist += LabelYSpacing;  //create a blank line
    }  
    ///// end of introduction
    
    startingydist = ydist;
  
    // column 1
    updatexdist = true;
    updateydist = false;
    
    SetXDist(LabelXSpacing * StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " "));
    UpdateLabel("header_col1_m1", "M1      ");
    UpdateLabel("header_col1_m5", "M5  ");
    UpdateLabel("header_col1_m15", "M15 ");
    UpdateLabel("header_col1_h1", "H1  ");
    updateydist = true;
    UpdateLabel("header_col1_h4", "H4");
    
    if (ShowEUR) {
      IterateCurrencies("EUR", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowGBP) {  
      IterateCurrencies("GBP", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowUSD) {
      IterateCurrencies("USD", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowJPY) {
      IterateCurrencies("JPY", 0);
      ydist += LabelYSpacing;
    }  
    
    //column 2
    labelcolor = LabelDefaultColor;
    
    updatexdist = true;
    updateydist = false;
    
    col2xdist = LabelXSpacing * (StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " ") + 24 + ColumnSpacers);
    
    ydist = startingydist;
    SetXDist(col2xdist + LabelXSpacing * StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " "));
    UpdateLabel("header_col2_m1", "M1      ");
    UpdateLabel("header_col2_m5", "M5  ");
    UpdateLabel("header_col2_m15", "M15 ");
    UpdateLabel("header_col2_h1", "H1  ");
    updateydist = true;
    UpdateLabel("header_col2_h4", "H4");
  
    if (ShowAUD) {
      IterateCurrencies("AUD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowNZD) {
      IterateCurrencies("NZD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowCAD) {
      IterateCurrencies("CAD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowCHF) {
      IterateCurrencies("CHF", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowDKK) {
      IterateCurrencies("DKK", col2xdist);
    }
  }
  
  return(0);
}

edit : it has come to my attention that some people with non-standard currency symbol names ("chittychittyUSDJPYbangbang" type symbols) aren't aware of the SymbolPrefix/MiddleSplitter/Suffix indicator settings. with chittychittyUSDJPYbangbang type names you would set SymbolPrefix to chittychitty and SymbolSuffix to bangbang. you are welcome.

Congratulations ScalaFX for coming out of the closet!

#11
Edited 12:01pm Feb 13, 2012 11:13am | Edited 12:01pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

as per further pm's...

no longer removes pairs where there exists a valid inverse currency pair. highlighted in blue.

i'm over this for today, so let me know what, if anything, is currently broken / missing.

Inserted Code

#property indicator_separate_window

#property indicator_buffers 1

extern bool ShowIntroduction = true;

extern bool ShowEUR = true;
extern bool ShowGBP = true;
extern bool ShowUSD = true;
extern bool ShowJPY = true;
extern bool ShowAUD = true;
extern bool ShowNZD = true;
extern bool ShowCAD = true;
extern bool ShowCHF = true;
extern bool ShowDKK = true;

extern int ColumnSpacers = 10;

extern string SymbolPrefix = "";
extern string SymbolMiddleSplitter = "";
extern string SymbolSuffix = "";

extern string EqualChar = "=";
extern color EqualColor = White;
extern string LessThanChar = "-";
extern color LessThanColor = Red;
extern string GreaterThanChar = "+";
extern color GreaterThanColor = Lime;
extern string ErroneousChar = "X";
extern color ErroneousColor = Orange;

extern color LabelDefaultColor = White;
extern color LabelInvertedSymbolColor = Aqua;
extern string LabelFontName = "Verdana";
extern int LabelFontSize = 8;
extern int LabelXDist = 20;
extern int LabelYDist = 20;
extern int LabelXSpacing = 8;
extern int LabelYSpacing = 15;

#define thisshortname "TFObserver"

#define objprefix "tfobsobj_"

#define symbolstate_unknown 0
#define symbolstate_bad 1
#define symbolstate_normal 2
#define symbolstate_inverted 3

string reg_objectnamearray[];

string reg_symbolnamearray[];
int reg_badsymbolhitarray[];  //counts bad return values on a symbol name, or sets negative for normal or inverted

string reg_ibarindexnamearray[];  //for use with f_FindIBar
int reg_ibarindexvaluearray[];

int xdist, ydist;  //absolute values, not relative values
bool updatexdist, updateydist;
color labelcolor;

int windowindex;

datetime lastbartime;
bool allsymbolsupdated;
datetime introclosetime;

double nullbuffer[];

void ResetArrays() {
  ArrayResize(reg_objectnamearray, 0);
  ArrayResize(reg_symbolnamearray, 0);
  ArrayResize(reg_badsymbolhitarray, 0);
  ArrayResize(reg_ibarindexnamearray, 0);
  ArrayResize(reg_ibarindexvaluearray, 0);
}

///// object cleanup funcs

void RegisterObject(string objname) {
//keep a list of all created object names for later easy deletion
  int i;
  bool found;

  i = ArraySize(reg_objectnamearray) - 1;
  found = false;
  while (i > -1) {
    if (reg_objectnamearray[i] == objname) {
      i = -1;
      found = true;
    }
    
    i--;
  }
  
  if (!found) {
    i = ArraySize(reg_objectnamearray);
    ArrayResize(reg_objectnamearray, i + 1);
    reg_objectnamearray[i] = objname;
  }
}

void DeleteRegisteredObjects() {
//delete all registered objects 
  int i;
  
  i = ArraySize(reg_objectnamearray) - 1;
  while (i > -1) {
    ObjectDelete(reg_objectnamearray[i-1]);
    i--;
  }
  ArrayResize(reg_objectnamearray, 0);
}

///// end of object cleanup funcs

///// symbol state funcs

void RegisterSymbolState(string symbolname, int state) {
//register a known valid good / inverted symbol
//or register an incrementing count of how many bad values have been returned for this symbol.
//an inverted symbol is a symbol that doesn't exist, but reversing the currency pair names
//is a valid symbol.
  int i, index;
  
  i = ArraySize(reg_symbolnamearray) - 1;
  index = -1;
  while (i > -1) {
    if (reg_symbolnamearray[i] == symbolname) {
      index = i;
      i = -1;
    }
    
    i--;
  }
  
  if (index < 0) {  //doesn't currently exist in the arrays
    i = ArraySize(reg_symbolnamearray);
    ArrayResize(reg_symbolnamearray, i + 1);
    ArrayResize(reg_badsymbolhitarray, i + 1);
    reg_symbolnamearray[i] = symbolname;
    reg_badsymbolhitarray[i] = 0;
    index = i;
  }
  
  if ((state == symbolstate_normal) || (state == symbolstate_inverted)) {
    //valid state.  permanently mark as good / inverted
    if (state == symbolstate_normal) {
      reg_badsymbolhitarray[index] = -1;
    } else {
      reg_badsymbolhitarray[index] = -2;
    }
  } else {
    //bad state.  increment counter
    if (state == symbolstate_bad) reg_badsymbolhitarray[index]++;
  }
}

int f_SymbolState(string symbolname) {
//return unknown for new symbols or pending bad symbols, bad for symbols that have
//registered too many times as not recieving valid data from mt4,
//or return good / inverted for known usable symbol names
  int i, result;
  
  result = symbolstate_unknown;
  i = ArraySize(reg_symbolnamearray) - 1;
  while (i > -1) {
    if (reg_symbolnamearray[i] == symbolname) {
      if (reg_badsymbolhitarray[i] == -2) result = symbolstate_inverted;
      if (reg_badsymbolhitarray[i] == -1) result = symbolstate_normal;
      if (reg_badsymbolhitarray[i] > 9) result = symbolstate_bad;
    
      i = -1;
    }
    
    i--;
  }
  
  return(result);
}

///// end of symbol state funcs

///// FindIBar index booster

void RegisterIBarIndex(string indexname, int indexvalue) {
//register an ibar index value so the next f_FindIBar call can start crawling
// through the iTime history from an already known close index instead of always starting
// from the extremes of index 0 or max ibars - 1
  int i, index;
  bool found;
  
  i = ArraySize(reg_ibarindexnamearray) - 1;
  index = -1;
  while (i > -1) {
    if (reg_ibarindexnamearray[i] == indexname) {
      index = i;
      i = -1;
    }
    
    i--;
  }
  
  if (index < 0) {
    i = ArraySize(reg_ibarindexnamearray);    
    ArrayResize(reg_ibarindexnamearray, i + 1);
    ArrayResize(reg_ibarindexvaluearray, i + 1);
    reg_ibarindexnamearray[i] = indexname;
    index = i;
  }
  
  reg_ibarindexvaluearray[index] = indexvalue;
}

int f_LastKnownIBarIndex(string indexname) {
//find the matching symbol + period name and return the last iTime index value used
  int i, result;
  
  result = -1;
  i = ArraySize(reg_ibarindexnamearray) - 1;
  while (i > -1) {
    if (reg_ibarindexnamearray[i] == indexname) {
      result = reg_ibarindexvaluearray[i];
      i = -1;
    }
    
    i--;
  }
  
  return(result);
}

///// end of index booster

void UpdateLabel(string labelname, string labeltext) {
  labelname = objprefix + labelname;

  RegisterObject(labelname);

  if (ObjectFind(labelname) < 0) ObjectCreate(labelname, OBJ_LABEL, windowindex, 0, 0);
   ObjectSetText(labelname, labeltext, LabelFontSize, LabelFontName, labelcolor);
   ObjectSet(labelname, OBJPROP_CORNER, 0);
   ObjectSet(labelname, OBJPROP_XDISTANCE, xdist);
   ObjectSet(labelname, OBJPROP_YDISTANCE, ydist);
   
   if (updatexdist) xdist += (LabelXSpacing * StringLen(labeltext));
   if (updateydist) ydist += LabelYSpacing;
}

void SetXDist(int newxdist) { xdist = LabelXDist + newxdist; }
void SetYDist(int newydist) { ydist = LabelYDist + newydist; }

void SetXYDist(int newxdist, int newydist) {
  SetXDist(newxdist);
  SetYDist(newydist);
}

int f_FindIBar(string symbolname, int symbolperiod, datetime symboldatetime) {
//locate the bar index for this datetime by crawling the iTime history array using the
//booster funcs above to speed-up searches by starting at a known closest bar index
  int maxbars, index, result;
  string s;
  datetime dt, errortolerance;  //this allows m1 times to be used when searching non-m1 periods

  result = -1;
  
  errortolerance = symbolperiod * 60;
  
  s = symbolname + symbolperiod;
  index = f_LastKnownIBarIndex(s);  //retrieve the index value last used for this symbol + period to begin crawling from this location
  
  maxbars = iBars(symbolname, symbolperiod);
  
  if (index < 0) index = 0;
  if (index > maxbars - 1) index = maxbars - 1;
  
  //crawl right then left to align with the closest matching datetime 
  while( (index > 0) && (iTime(symbolname, symbolperiod, index) < symboldatetime) ) index--; //crawl right
  while( (index < maxbars - 1) && (iTime(symbolname, symbolperiod, index) > symboldatetime) ) index++;  //crawl left
  
  dt = iTime(symbolname, symbolperiod, index);  //closest match datetime 
  //if closest match is not to the right of the desired date (i.e. hit the max ibars left search limit),
  //and is within the granularity of this period time step then a match has been located
  if ((dt <= symboldatetime) && (symboldatetime - dt < errortolerance)) result = index;
  
  //store this last used index value for this symbol + period so the next time this
  //symbol + period is searched the crawl can begin from this known closest location
  RegisterIBarIndex(s, index);
  
  return(result);
}

void _SetColorAndChar(string symbolname, bool isinverted, int symbolperiod, int referencebar, color& col, string& s) {
  double d1, d2;
  int shift;
  
  shift = f_FindIBar(symbolname, symbolperiod, Time[0] - (referencebar * symbolperiod * 60)); //iTime(NULL, symbolperiod, referencebar));

  col = ErroneousColor;
  s = ErroneousChar;
  
  if (shift >= 0) {
    if (!isinverted) {  //symbol is standard
      d1 = iClose(symbolname, symbolperiod, shift);
      d2 = iClose(symbolname, symbolperiod, shift + 1);
    } else {  //symbol is non-standard.  values should result be opposite to normal
      d1 = iClose(symbolname, symbolperiod, shift + 1);
      d2 = iClose(symbolname, symbolperiod, shift);            
    }
    
    col = EqualColor;
    s = EqualChar;
    if (d1 > d2) {
      col = GreaterThanColor;
      s = GreaterThanChar;
    }
    if (d1 < d2) {
      col = LessThanColor;
      s = LessThanChar;
    }
  }
}

void PopulateLine(string currency1, string currency2, int startingxdist) {
//spits out a currency heading then the subsequent timeframes data
//then drops down a line ready for the next call
  string thissymbol, invertedsymbol, calcwithsymbol;
  string s;
  double d1, d2;
  int state, regstate;
  int i, i2;
  bool isinverted;
    
  thissymbol = SymbolPrefix + currency1 + SymbolMiddleSplitter + currency2 + SymbolSuffix;
  invertedsymbol = SymbolPrefix + currency2 + SymbolMiddleSplitter + currency1 + SymbolSuffix;
  isinverted = false;
  
  state = f_SymbolState(thissymbol);
  
  if (state == symbolstate_bad) {
    //remove any invalid symbol label objects that might still exist
    ObjectDelete(objprefix + "header_" + thissymbol);    
    for (i = 1; i < 8; i++) ObjectDelete(objprefix + thissymbol + "_m1_" + i);        
    for (i = 1; i < 4; i++) {
      ObjectDelete(objprefix + thissymbol + "_m5_" + i);
      ObjectDelete(objprefix + thissymbol + "_m15_" + i);
      ObjectDelete(objprefix + thissymbol + "_h1_" + i);
      ObjectDelete(objprefix + thissymbol + "_h4_" + i);
    }  
  } else {  //currently valid symbol
    switch(state) {
      case symbolstate_unknown : {
        regstate = symbolstate_bad;
        
        i = f_FindIBar(thissymbol, PERIOD_M1, Time[0]);
        i2 = f_FindIBar(invertedsymbol, PERIOD_M1, Time[0]);
        d1 = iClose(thissymbol,PERIOD_M1, i);  //test if normal currency orientation works
        d2 = iClose(invertedsymbol,PERIOD_M1, i2);  //test if inverted works
        if (d1 > 0) regstate = symbolstate_normal;
        if (d2 > 0) regstate = symbolstate_inverted;

        i = f_FindIBar(thissymbol, PERIOD_M5, Time[0]);
        i2 = f_FindIBar(invertedsymbol, PERIOD_M5, Time[0]);
        d1 = iClose(thissymbol,PERIOD_M5, i);  //test if normal currency orientation works
        d2 = iClose(invertedsymbol,PERIOD_M5, i2);  //test if inverted works
        if (d1 > 0) regstate = symbolstate_normal;
        if (d2 > 0) regstate = symbolstate_inverted;

        i = f_FindIBar(thissymbol, PERIOD_M15, Time[0]);
        i2 = f_FindIBar(invertedsymbol, PERIOD_M15, Time[0]);
        d1 = iClose(thissymbol,PERIOD_M15, i);  //test if normal currency orientation works
        d2 = iClose(invertedsymbol,PERIOD_M15, i2);  //test if inverted works
        if (d1 > 0) regstate = symbolstate_normal;
        if (d2 > 0) regstate = symbolstate_inverted;

        i = f_FindIBar(thissymbol, PERIOD_H1, Time[0]);
        i2 = f_FindIBar(invertedsymbol, PERIOD_H1, Time[0]);
        d1 = iClose(thissymbol,PERIOD_H1, i);  //test if normal currency orientation works
        d2 = iClose(invertedsymbol,PERIOD_H1, i2);  //test if inverted works
        if (d1 > 0) regstate = symbolstate_normal;
        if (d2 > 0) regstate = symbolstate_inverted;
        
        i = f_FindIBar(thissymbol, PERIOD_H4, Time[0]);
        i2 = f_FindIBar(invertedsymbol, PERIOD_H4, Time[0]);
        d1 = iClose(thissymbol,PERIOD_H4, i);  //test if normal currency orientation works
        d2 = iClose(invertedsymbol,PERIOD_H4, i2);  //test if inverted works
        if (d1 > 0) regstate = symbolstate_normal;
        if (d2 > 0) regstate = symbolstate_inverted;
        
        RegisterSymbolState(thissymbol, regstate);
        //if appears bad so far then force another attempt on all symbols next tick
        if (regstate == symbolstate_bad) allsymbolsupdated = false;
        break;
      }
      case symbolstate_inverted : {
        isinverted = true;        
        break;
      }
    }  
    
    updatexdist = true;
    updateydist = false;
    
    xdist = LabelXDist + startingxdist;
        
    labelcolor = LabelDefaultColor;
    calcwithsymbol = thissymbol;
    if (isinverted) {
      labelcolor = LabelInvertedSymbolColor;
      calcwithsymbol = invertedsymbol;
    }
    UpdateLabel("header_" + thissymbol, thissymbol + " ");
        
    for (i = 1; i < 8; i++) {  
      _SetColorAndChar(calcwithsymbol, isinverted, PERIOD_M1, i, labelcolor, s);
      UpdateLabel(thissymbol + "_m1_" + i, s);
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      _SetColorAndChar(calcwithsymbol, isinverted, PERIOD_M5, i, labelcolor, s);
      UpdateLabel(thissymbol + "_m5_" + i, s);
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      _SetColorAndChar(calcwithsymbol, isinverted, PERIOD_M15, i, labelcolor, s);
      UpdateLabel(thissymbol + "_m15_" + i, s);
    }
  
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      _SetColorAndChar(calcwithsymbol, isinverted, PERIOD_H1, i, labelcolor, s);
      UpdateLabel(thissymbol + "_h1_" + i, s);      
    }
    
    xdist += LabelXSpacing;  
    for (i = 1; i < 4; i++) {  
      _SetColorAndChar(calcwithsymbol, isinverted, PERIOD_H4, i, labelcolor, s);
      UpdateLabel(thissymbol + "_h4_" + i, s);
    }
    
    ydist += LabelYSpacing;
  }
}
void IterateCurrencies(string base, int xdist) {
//spits out a paragraph of pair combinations with the specified base currency
  if (base != "USD") PopulateLine(base, "USD", xdist);  
  if (base != "EUR") PopulateLine(base, "EUR", xdist);    
  if (base != "GBP") PopulateLine(base, "GBP", xdist);
  if (base != "CAD") PopulateLine(base, "CAD", xdist);
  if (base != "JPY") PopulateLine(base, "JPY", xdist);
  if (base != "AUD") PopulateLine(base, "AUD", xdist);
  if (base != "NZD") PopulateLine(base, "NZD", xdist);    
  if (base != "CHF") PopulateLine(base, "CHF", xdist);
  if (base != "DKK") PopulateLine(base, "DKK", xdist);
}

int init() {
  ResetArrays();

  IndicatorShortName(thisshortname);
  
  labelcolor = LabelDefaultColor;

  if (Period() != PERIOD_M1) Alert("This indicator is designed for use on M1 charts only!");

  introclosetime = Time[0] + (60 * 5);  //auto-close the intro after 5 mins
  
  SetIndexBuffer(0, nullbuffer);
  SetIndexStyle(0, DRAW_NONE);
  
  return(0);
}

int deinit() {
  //basic cleanup
  DeleteRegisteredObjects();  
  ResetArrays();

  return(0);
}

int start() {
  int c;
  int startingydist;  //this is an absolute value, not a relative value
  int col2xdist;
  
  if ((lastbartime < Time[0]) || (!allsymbolsupdated)) {
    allsymbolsupdated = true;
    lastbartime = Time[0];
   
    if (ShowIntroduction && (Time[0] >= introclosetime)) {
      ShowIntroduction = false;
      for (c = 1; c < 12; c++) ObjectDelete(objprefix + "title_instr" + c);
      ObjectDelete(objprefix + "title_nubcake");
    }

    windowindex = WindowFind(thisshortname);
    
    SetXYDist(0, 0);
    updatexdist = false;
    updateydist = false;
  
    labelcolor = LabelDefaultColor;
  
    //introduction
    if (ShowIntroduction) {
      updateydist = true;
      
      UpdateLabel("title_instr1", "This indicator is for use determining entry and exit points for");
      UpdateLabel("title_instr2", "trades based on larger timeframes (H4 and larger). The indi");
      UpdateLabel("title_instr3", "shows the real body direction of the most recent candles in the");
      UpdateLabel("title_instr4", "time frames. They are to be read from LEFT to RIGHT with the");
      UpdateLabel("title_instr5", "most recent candle being on the left side. If the most recent");
      UpdateLabel("title_instr6","candle close was bullish in relation to the one before it, the");
      UpdateLabel("title_instr7","signal will be green. Otherwise, it will be red. If there is no");
      UpdateLabel("title_instr8","price change b/t the two, it will be white. This indi watches");
      UpdateLabel("title_instr9","the most recent 7 M1 candles and the most recent 3 candles");
      UpdateLabel("title_instr10","from each of the other timeframes.");
    
      SetXDist(100);
      UpdateLabel("title_instr11","Good luck!     -Rich");
      ydist += LabelYSpacing;  //create a blank line
      
      SetXDist(0);
      UpdateLabel("title_nubcake", "... code reworked by the mighty nubcake! ...");
      ydist += LabelYSpacing;  //create a blank line
    }  
    ///// end of introduction
    
    startingydist = ydist;
  
    // column 1
    updatexdist = true;
    updateydist = false;
    
    SetXDist(LabelXSpacing * StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " "));
    UpdateLabel("header_col1_m1", "M1      ");
    UpdateLabel("header_col1_m5", "M5  ");
    UpdateLabel("header_col1_m15", "M15 ");
    UpdateLabel("header_col1_h1", "H1  ");
    updateydist = true;
    UpdateLabel("header_col1_h4", "H4");
    
    if (ShowEUR) {
      IterateCurrencies("EUR", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowGBP) {  
      IterateCurrencies("GBP", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowUSD) {
      IterateCurrencies("USD", 0);
      ydist += LabelYSpacing;
    }
    
    if (ShowJPY) {
      IterateCurrencies("JPY", 0);
      ydist += LabelYSpacing;
    }  
    
    //column 2
    labelcolor = LabelDefaultColor;
    
    updatexdist = true;
    updateydist = false;
    
    col2xdist = LabelXSpacing * (StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " ") + 24 + ColumnSpacers);
    
    ydist = startingydist;
    SetXDist(col2xdist + LabelXSpacing * StringLen(SymbolPrefix + "abc" + SymbolMiddleSplitter + "xyz" + SymbolSuffix + " "));
    UpdateLabel("header_col2_m1", "M1      ");
    UpdateLabel("header_col2_m5", "M5  ");
    UpdateLabel("header_col2_m15", "M15 ");
    UpdateLabel("header_col2_h1", "H1  ");
    updateydist = true;
    UpdateLabel("header_col2_h4", "H4");
  
    if (ShowAUD) {
      IterateCurrencies("AUD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowNZD) {
      IterateCurrencies("NZD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowCAD) {
      IterateCurrencies("CAD", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowCHF) {
      IterateCurrencies("CHF", col2xdist);
      ydist += LabelYSpacing;
    }
    
    if (ShowDKK) {
      IterateCurrencies("DKK", col2xdist);
    }
  }
  
  return(0);
}

p.s. this indi also works during backtesting. this here isn't a limpwood-level script kiddie bullshit hack job.

edit : it's been nagging me and i keep forgetting to ask. originally (or at least how i recall it) you were starting from bar 1, and not the current bar. i have kept it this way also, but i wonder if this was an oversight on your part and you intended the indicator to start showing the current close value onwards i.e. bar 0 onwards instead of from bar 1 onwards.

Congratulations ScalaFX for coming out of the closet!

#12
Feb 13, 2012 11:18am Feb 13, 2012 11:18am

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

Quote

Disliked

p.s. this indi also works during backtesting. this here isn't a limpwood-level script kiddie bullshit hack job.

fuck no it isnt. haven't said thanks enough in this thread yet. I've said it in PMs but I need to say it here, too. You've done more than I could have hoped with this and I can't thank you enough, man.

I don't blame you for getting burned out on this. It's not a shitty indicator. It's a goddamned control center dumped into a separate window.

Thanks many times, man. Gonna check out this version now.

All the best..

R

#13
Feb 13, 2012 12:33pm Feb 13, 2012 12:33pm

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

Dude, you fucking nailed it. Out of the park. I'm actually licking my monitor in between keystrokes.

For real, cake, thanks. I'll be learning from your code for a long time and... let it be known. There are good people out there with incredible skill. nublet, you are the perpetual MAN!

Thank you so much.

R

#14
Edited 1:05pm Feb 13, 2012 12:55pm | Edited 1:05pm

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

For submission to the annals of FF and the greater internet beyond, this indi is now fundamentally finished. Compile from the code in nubcake's most recent post and be sure to make use of the "suffix," "prefix" etc values if your broker names your pairs anything other than the standard XXXYYY (GBPJPYm, for example). nubcake had the foresight to include this by default. Cause he's the fucking man.

Thanks again, nubcake. I'm indebted to you. I'll buy you a fucking ham sandwich if we ever meet up, man

. Based on the level of utility of the indicator, I suspect many more will be using it and will similarly owe you thanks.

All the best and good luck trading,

R

*edit

just saw your edit, man

Quote

Disliked

edit : it's been nagging me and i keep forgetting to ask. originally (or at least how i recall it) you were starting from bar 1, and not the current bar. i have kept it this way also, but i wonder if this was an oversight on your part and you intended the indicator to start showing the current close value onwards i.e. bar 0 onwards instead of from bar 1 onwards.

I'm indifferent to that concept at this point. I didn't want to make it too bulky on the screen (too wide cause its fking huge already) and felt it needed at least the most recent 3 full bars. If you want to add it, by all means, man. Add it, tweak it, use the hell out of it. I'm not gonna bother you any more about it cause... damn... this thing is tops.

Attached Image (click to enlarge)

Click to Enlarge

Name: 10.gif
Size: 16 KB

#15
Feb 13, 2012 1:08pm Feb 13, 2012 1:08pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

more could be done to it and made even more robust again (e.g. allow you to specify whatever pairs you wanted. make it play nice when unpaused in backtesting, and so on), but the gains are not really worth the effort of me bothering to implement them. someone else can have a play instead.

unless there are bugs or something breaks then i suppose it's time i fuck off and get back to doing my own shit that i have been avoiding.

i like ham.

Congratulations ScalaFX for coming out of the closet!

#16
Last Post: Feb 13, 2012 1:09pm Feb 13, 2012 1:09pm

ra457
| Joined Mar 2007 | Status: Sleep deprived | 81 Posts

how the fuck do you vouch for someone on here? I'm gonna make it rain ham sandwiches in this bitch.

Platform Tech
/
Mega Behemoth SOB Indicator is kicking my butt
Reply to Thread

0 traders viewing now

Options

Similar Threads

Mega Behemoth SOB Indicator is kicking my butt