Attachments: My TimeBased EA doesn't work - Please help

My TimeBased EA doesn't work - Please help

#1
First Post: Edited 2:00pm Feb 10, 2012 10:41am | Edited 2:00pm

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

I have no idea what the Magic Number is all about. The EA simply didn't execute when it should of at a certain price and time last night.

Attached File(s)

TimeBasedEA.mq4 3 KB | 435 downloads

The trend is my friend? The world casino is my friend!

#2
Feb 10, 2012 7:22pm Feb 10, 2012 7:22pm

cyber1
Joined Jan 2011 | Status: Trader | 1,299 Posts

Quoting CapitalismPr

Disliked

I have no idea what the Magic Number is all about. The EA simply didn't execute when it should of at a certain price and time last night.

Ignored

What trade was it that it should have opened?
Here are the trades from the Strategy Tester for this week.

Attached Image (click to enlarge)

Click to Enlarge

Name: TimeBasedEATrades.PNG
Size: 140 KB

#3
Feb 10, 2012 9:27pm Feb 10, 2012 9:27pm

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

I tried to have it execute a short on EURUSD at 1.3200 after 5 am mountain standard time. Nothing happened.

The trend is my friend? The world casino is my friend!

#4
Feb 10, 2012 9:43pm Feb 10, 2012 9:43pm

cyber1
Joined Jan 2011 | Status: Trader | 1,299 Posts

Quoting CapitalismPr

Disliked

I tried to have it execute a short on EURUSD at 1.3200 after 5 am mountain standard time. Nothing happened.

Ignored

Did you set the OpenSell to TRUE?

Inserted Code

extern int     MagicNumber = 16384;
extern double  TakeProfit = 50;
extern double  StopLoss = 50;
extern double  Lots = 0.1;
extern int     OpenTradeTime = 1100;      // Open Trade time
extern bool    OpenBuy = true;
extern bool    OpenSell = false;
extern int     NumBuys = 1;
extern int     NumSells = 1;
extern int     Slippage = 3;

#5
Feb 11, 2012 12:09am Feb 11, 2012 12:09am

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

yes i did.

The trend is my friend? The world casino is my friend!

#6
Feb 20, 2012 1:44am Feb 20, 2012 1:44am

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

Cyber1, i noticed you didn't include a value for the "mPrice" in your data table. Was there a reason for leaving mPrice out? What is the "mPrice" for?

The trend is my friend? The world casino is my friend!

#7
Feb 20, 2012 6:10am Feb 20, 2012 6:10am

cyber1
Joined Jan 2011 | Status: Trader | 1,299 Posts

Quoting CapitalismPr

Disliked

Cyber1, i noticed you didn't include a value for the "mPrice" in your data table. Was there a reason for leaving mPrice out? What is the "mPrice" for?

Ignored

Here is the code in its entirety. I don't see mPrice.

Inserted Code

//+------------------------------------------------------------------+
//|                                                  MACD Sample.mq4 |
//|                      Copyright © 2005, MetaQuotes Software Corp. |
//|                                       http://www.metaquotes.net/ |
//+------------------------------------------------------------------+

extern int     MagicNumber = 16384;
extern double  TakeProfit = 50;
extern double  StopLoss = 50;
extern double  Lots = 0.1;
extern int     OpenTradeTime = 1100;      // Open Trade time
extern bool    OpenBuy = true;
extern bool    OpenSell = false;
extern int     NumBuys = 1;
extern int     NumSells = 1;
extern int     Slippage = 3;



//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
int start()
  {
   int cnt, ticket, total;
   int ct;
   
   
// initial data checks
// it is important to make sure that the expert works with a normal
// chart and the user did not make any mistakes setting external 
// variables (Lots, StopLoss, TakeProfit, 
// TrailingStop) in our case, we check TakeProfit
// on a chart of less than 100 bars
   if(Bars<100)
     {
      Print("bars less than 100");
      return(0);  
     }
   if(TakeProfit<10)
     {
      Print("TakeProfit less than 10");
      return(0);  // check TakeProfit
     }
   ct = Hour() * 100 + Minute();

   total=OrdersTotal();
   if(total<1) 
     {
      // no opened orders identified
      if(AccountFreeMargin()<(1000*Lots))
        {
         Print("We have no money. Free Margin = ", AccountFreeMargin());
         return(0);  
        }
      // check for long position (BUY) possibility
      if(ct == OpenTradeTime && OpenBuy)
        {
         for ( cnt = 0; cnt < NumBuys; cnt++)
         {
           ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,Bid - StopLoss * Point,Ask+TakeProfit*Point,"",MagicNumber,0,Green);
           if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
           }
           else Print("Error opening BUY order : ",GetLastError()); 
         }
         return(0); 
        }
      // check for short position (SELL) possibility
      if(ct == OpenTradeTime && OpenSell)
        {
         for ( cnt = 0; cnt < NumSells; cnt++)
         {
           ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,Ask + StopLoss * Point,Bid-TakeProfit*Point,"",MagicNumber,0,Red);
           if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
           }
           else Print("Error opening SELL order : ",GetLastError());
         } 
         return(0); 
        }
     }
   return(0);
  }
// the end.

#8
Feb 20, 2012 6:36am Feb 20, 2012 6:36am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

like i keep having to say to people.... USE BRACKETS IN YOUR IF STATEMENTS.... stop using run-on boolean sequences because some day you will not know why something isn't evaluating correctly (when it is, you just aren't writing it as you mean it to run and it is evaluating in its standard order of priority).

also, who is to say that there is any volume at the time you set for the trade to go off? no volume = no start function call = no trade. you need some slippage value on the time as well and a flag to track if you have opened the intended order or not.

possibly not even the actual issues, but certainly shit to be addressed regardless. nothing else stands out from reading just the code online.

Congratulations ScalaFX for coming out of the closet!

#9
Feb 20, 2012 10:47am Feb 20, 2012 10:47am

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

I thought it was the variable for price execution.

Attached Image (click to enlarge)

Click to Enlarge

Name: mPrice.jpg
Size: 404 KB

The trend is my friend? The world casino is my friend!

#10
Feb 20, 2012 11:14am Feb 20, 2012 11:14am

cyber1
Joined Jan 2011 | Status: Trader | 1,299 Posts

Quoting CapitalismPr

Disliked

I thought it was the variable for price execution.

Ignored

Did you post the wrong file?
Heres what mine looks like which you can also see from the inputs in the EA.
There is no mPrice variable in mine.

Attached Image (click to enlarge)

Click to Enlarge

Name: TimeBasedEASS.PNG
Size: 78 KB

#11
Feb 21, 2012 12:33am Feb 21, 2012 12:33am

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

See if this one shows the mPrice variable.

Attached File(s)

TimeBasedEA (1).mq4 3 KB | 385 downloads

The trend is my friend? The world casino is my friend!

#12
Feb 22, 2012 1:09am Feb 22, 2012 1:09am

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

Anybody still there?

The trend is my friend? The world casino is my friend!

#13
Feb 22, 2012 1:36am Feb 22, 2012 1:36am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

you ignored my last post, to your own peril.

what do you want? you haven't posted any error codes. you haven't posted what the price was at the time it should have executed, or even better a screenshot. all you posted was that it doesn't work, and then you posted the wrong code to boot.

my guess is that if it's not what i previously posted, which was to do with the code that WAS available on here and NOT what you have now just put out, then it is simply a case of you specifying the wrong price and so nothing gets attempted and so no error codes and no anything really.

if you specified a sell and put a price less than the close price at the specified time, or if you specified a buy and the price was greater than the close price at the specified time, or there was no volume for the bar at the specified time..... then you will get nothing happening.

now THAT is assuming that the code isn't broken elsewhere apart from just those basic bits of logic.

Congratulations ScalaFX for coming out of the closet!

#14
Feb 22, 2012 2:57pm Feb 22, 2012 2:57pm

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

Nubcake, you mentioned the issue of not having enough volume to initiate a trade at the specified price but all i want is a market order when the pair crosses a certain price and has stayed on that side of the price after a certain time. My understanding was this EA would do that. E.G. i setup a short after 5am if EUR/USD crosses below 1.3200 but nothing happened. I didn't receive any error messages.

The trend is my friend? The world casino is my friend!

#15
Feb 22, 2012 3:17pm Feb 22, 2012 3:17pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

Quoting CapitalismPr

Disliked

Nubcake, you mentioned the issue of not having enough volume to initiate a trade at the specified price but all i want is a market order when the pair crosses a certain price and has stayed on that side of the price after a certain time. My understanding was this EA would do that. E.G. i setup a short after 5am if EUR/USD crosses below 1.3200 but nothing happened. I didn't receive any error messages.

Ignored

either your, or my, understanding of the code is wrong.

my understanding (i have not compiled this i'm simply reading it in text form) is that AT THE SPECIFIED TIME the EA will attempt to open whatever order types it has been set to open, and only if price is above the specified price for a buy or below it for a sell.

BUT, for the start function to trigger requires an incoming tick ON THE BAR OF THE SPECIFIED TIME. if you are setting your open time at a time that just so happens to be thin and the bar does not receive any ticks then the start function will not be called for that bar and therefore the ea will never open anything. the EA is NOT designed to open a trade if the start function runs on OR AFTER the specified chart 24hr time, and this is why i indicated in my initial post that you need to consider a time slippage in case the ea doesn't run on the specific time you set it to but within some set tolerance of time after that time to account for the possibility of no volume bars.

also, if you are setting the price incorrectly then you are again setting yourself up for having no position open and without having any messages printed advising why nothing happened.

there seems to be only a few things that can be going wrong.

look, let me just fuck with it for an hour or so and i'll make it work, ok? we'll just be going back and forth i'm sure.

Congratulations ScalaFX for coming out of the closet!

#16
Edited 6:26pm Feb 22, 2012 5:30pm | Edited 6:26pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

try something like this instead. i've only had little sleep, and although alert, i've probably fucked something up quite nicely. it appears to work for me in backtesting and sits there happily doing nothing on live...

Inserted Code

//written by nubcake

extern int     MagicNumber = 16384;
extern double  TakeProfit = 50;
extern double  StopLoss = 50;
extern double  Lots = 0.01;
extern datetime OpenTradeTime = D'2012.01.01 00:00';
extern int OpenTradeTimeSlippageMinutes = 0;
extern double  mPrice = 1.5000;
extern int NumBuys = 0;
extern int NumSells = 0;
extern int Slippage = 3;

extern color InfoColor = White;

#define objinfolabel "EACapPRInfoLabel"
#define objtimerlabel "EACapPrTimerLabel"
#define objpricelevel "EACapPRPrice"

datetime setopentime;
string infostring, triggeredmessage;
bool isok, hastriggered;

void addbadmsg(string s) {
  if (infostring != "") s = " " + s;
  
  infostring = infostring + s;
  isok = false;
}

int init() {
  hastriggered = false;
  
  return(0);
}

int deinit() {
  ObjectDelete(objinfolabel);
  ObjectDelete(objtimerlabel);
  ObjectDelete(objpricelevel);

  return(0);
}

int start() {
  int ticket;
  int i;
  double d;
  string s, s2;
  datetime dt, dthour, dtmin;
     
  isok = true;
  
  infostring = "";
  
  if ((NumBuys == 0) && (NumBuys == 0)) addbadmsg("No buy or sell set to open!");  
  
  dt = OpenTradeTime + (60 * OpenTradeTimeSlippageMinutes);
  if (Time[0] < OpenTradeTime) addbadmsg("Currently before set open time.");
  if (Time[0] > dt) addbadmsg("Past set open time + time slippage.");  
  
  if (Lots < MarketInfo(Symbol(), MODE_MINLOT)) addbadmsg("Lots too small!");
  if (TakeProfit < MarketInfo(Symbol(), MODE_STOPLEVEL)) addbadmsg("TP too small!");    
  if (StopLoss < MarketInfo(Symbol(), MODE_STOPLEVEL)) addbadmsg("SL too small!");
  
  d = Lots * MarketInfo(Symbol(), MODE_MARGINREQUIRED);
  if (AccountFreeMargin() < d) addbadmsg("Margin too low!");

  if (OrdersTotal() > 0) addbadmsg("Orders currently open!");
  
  if (hastriggered) isok = false;
  
  if (isok) {
    triggeredmessage = "";
    hastriggered = true;    
    
    if (NumBuys > 0) {
      if (Ask < mPrice) {
        triggeredmessage = "Tried to buy but Ask < mPrice! ";
      } else {
        triggeredmessage = "Buy/s attempted! ";
        for (i = 0; i < NumBuys; i++) {
          ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, Bid - StopLoss * Point, Ask + TakeProfit * Point, "", MagicNumber,0,Green);
          if (ticket < 0) {
            Print("Buy error = " + GetLastError());
          } else {
            OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES);
            Print("Buy opened @ " + OrderOpenPrice());
          }
        }
      }
    }
    
    if (NumSells > 0) {
      if (Bid > mPrice) {
        triggeredmessage = triggeredmessage + "Tried to sell but Bid > mPrice";
      } else {
        triggeredmessage = triggeredmessage + "Sell/s attempted!";
        for (i = 0; i < NumSells; i++) {
          ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, Ask + StopLoss * Point, Bid - TakeProfit * Point, "", MagicNumber,0,Red);          
          if (ticket < 0) {
            Print("Sell error = " + GetLastError());
          } else {
            OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES);
            Print("Sell opened @ " + OrderOpenPrice());
          }
        }      
      }
    }    
  }
  
  if (hastriggered) infostring = triggeredmessage;
  
  s = objinfolabel;
  if (ObjectFind(s) < 0) {
    ObjectCreate(s, OBJ_LABEL, 0, 0,0);
    ObjectSet(s, OBJPROP_CORNER, 0);
    ObjectSet(s, OBJPROP_XDISTANCE, 20);
    ObjectSet(s, OBJPROP_YDISTANCE, 20);
  }
  ObjectSetText(s, infostring, 10, "Courier New", InfoColor);
  
  s = objtimerlabel;
  if (ObjectFind(s) < 0) {
    ObjectCreate(s, OBJ_LABEL, 0, 0,0);
    ObjectSet(s, OBJPROP_CORNER, 0);
    ObjectSet(s, OBJPROP_XDISTANCE, 20);
    ObjectSet(s, OBJPROP_YDISTANCE, 40);    
  }
  if ((Time[0] >= OpenTradeTime) && (Time[0] <= dt)) {
    s2 = "NOW!";
  } else {
    if (Time[0] < OpenTradeTime) dt = OpenTradeTime - Time[0];
    else dt = dt - Time[0];
    
    dthour = 0;
    dtmin = 0;
    while (dt > (59 * 60)) {
      dthour++;
      
      dt -= 60 * 60;
    }
    while (dt < (-59 * 60)) {
      dthour--;
      
      dt += 60 * 60;
    }
    dtmin = dt / 60;
    
    s2 = dthour + " hours " + dtmin + " mins";
  }
  ObjectSetText(s, "Time Until Open: " + s2, 10, "Courier New", InfoColor);
  
  s = objpricelevel;
  if (ObjectFind(s) < 0) {
    ObjectCreate(s, OBJ_HLINE, 0, 0,0);
    ObjectSet(s, OBJPROP_WIDTH, 1);
    ObjectSet(s, OBJPROP_COLOR, InfoColor);
    ObjectSet(s, OBJPROP_STYLE, STYLE_DOT);
    ObjectSetText(s, "EA Price Level");
  }
  ObjectSet(s, OBJPROP_PRICE1, mPrice);

  return(0);
}

edit : perhaps replace where i have written bid or ask. the way it currently is will open both types of orders if the mPrice value sits within the spread at the time of triggering.

Congratulations ScalaFX for coming out of the closet!

#17
Feb 22, 2012 6:50pm Feb 22, 2012 6:50pm

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

Ok thx for the help.

The trend is my friend? The world casino is my friend!

#18
Edited 7:49pm Feb 22, 2012 6:59pm | Edited 7:49pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

of course as soon as you saw it i noticed i was checking NumBuys twice by mistake.... fixed that. i've also altered the mPrice test so the spread has to be entirely on one side or the other for an order to trigger. ignore the previous code and just try the below.

Inserted Code

//written by nubcake

extern int     MagicNumber = 16384;
extern double  TakeProfit = 50;
extern double  StopLoss = 50;
extern double  Lots = 0.01;
extern datetime OpenTradeTime = D'2012.01.01 00:00';
extern int OpenTradeTimeSlippageMinutes = 0;
extern double  mPrice = 1.5000;
extern int NumBuys = 0;
extern int NumSells = 0;
extern int Slippage = 3;

extern color InfoColor = White;

#define objinfolabel "EACapPRInfoLabel"
#define objtimerlabel "EACapPrTimerLabel"
#define objpricelevel "EACapPRPrice"

string infostring, triggeredmessage;
bool isok, hastriggered;

void addbadmsg(string s) {
  if (infostring != "") s = " " + s;
  
  infostring = infostring + s;
  isok = false;
}

int init() {
  hastriggered = false;
  
  return(0);
}

int deinit() {
  ObjectDelete(objinfolabel);
  ObjectDelete(objtimerlabel);
  ObjectDelete(objpricelevel);

  return(0);
}

int start() {
  int ticket;
  int i;
  double d;
  string s, s2;
  datetime dt, dthour, dtmin;
     
  isok = true;
  
  infostring = "";
  
  if ((NumBuys == 0) && (NumSells == 0)) addbadmsg("No buy or sell set to open!");  
  
  dt = OpenTradeTime + (60 * OpenTradeTimeSlippageMinutes);
  if (Time[0] < OpenTradeTime) addbadmsg("Currently before set open time.");
  if (Time[0] > dt) addbadmsg("Past set open time + time slippage.");  
  
  if (Lots < MarketInfo(Symbol(), MODE_MINLOT)) addbadmsg("Lots too small!");
  if (TakeProfit < MarketInfo(Symbol(), MODE_STOPLEVEL)) addbadmsg("TP too small!");    
  if (StopLoss < MarketInfo(Symbol(), MODE_STOPLEVEL)) addbadmsg("SL too small!");
  
  d = Lots * MarketInfo(Symbol(), MODE_MARGINREQUIRED);
  if (AccountFreeMargin() < d) addbadmsg("Margin too low!");

  if (OrdersTotal() > 0) addbadmsg("Orders currently open!");
  
  if (hastriggered) isok = false;
  
  if (isok) {
    triggeredmessage = "";
    hastriggered = true;    
    
    if (NumBuys > 0) {
      if (Bid < mPrice) {
        triggeredmessage = "Tried to buy but Bid < mPrice! ";
      } else {
        triggeredmessage = "Buy/s attempted! ";
        for (i = 0; i < NumBuys; i++) {
          ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, Bid - StopLoss * Point, Ask + TakeProfit * Point, "", MagicNumber,0,Green);
          if (ticket < 0) {
            Print("Buy error = " + GetLastError());
          } else {
            OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES);
            Print("Buy " + ticket + " opened @ " + OrderOpenPrice());
          }
        }
      }
    }
    
    if (NumSells > 0) {
      if (Ask > mPrice) {
        triggeredmessage = triggeredmessage + "Tried to sell but Ask > mPrice";
      } else {
        triggeredmessage = triggeredmessage + "Sell/s attempted!";
        for (i = 0; i < NumSells; i++) {
          ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, Ask + StopLoss * Point, Bid - TakeProfit * Point, "", MagicNumber,0,Red);          
          if (ticket < 0) {
            Print("Sell error = " + GetLastError());
          } else {
            OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES);
            Print("Sell " + ticket + " opened @ " + OrderOpenPrice());
          }
        }      
      }
    }    
  }
  
  if (hastriggered) infostring = triggeredmessage;
  
  s = objinfolabel;
  if (ObjectFind(s) < 0) {
    ObjectCreate(s, OBJ_LABEL, 0, 0,0);
    ObjectSet(s, OBJPROP_CORNER, 0);
    ObjectSet(s, OBJPROP_XDISTANCE, 20);
    ObjectSet(s, OBJPROP_YDISTANCE, 20);
  }
  ObjectSetText(s, infostring, 10, "Courier New", InfoColor);
  
  s = objtimerlabel;
  if (ObjectFind(s) < 0) {
    ObjectCreate(s, OBJ_LABEL, 0, 0,0);
    ObjectSet(s, OBJPROP_CORNER, 0);
    ObjectSet(s, OBJPROP_XDISTANCE, 20);
    ObjectSet(s, OBJPROP_YDISTANCE, 40);    
  }
  if ((Time[0] >= OpenTradeTime) && (Time[0] <= dt)) {
    s2 = "NOW!";
  } else {
    if (Time[0] < OpenTradeTime) dt = OpenTradeTime - Time[0];
    else dt = dt - Time[0];
    
    dthour = 0;
    dtmin = 0;
    while (dt > (59 * 60)) {
      dthour++;
      
      dt -= 60 * 60;
    }
    while (dt < (-59 * 60)) {
      dthour--;
      
      dt += 60 * 60;
    }
    dtmin = dt / 60;
    
    s2 = dthour + " hours " + dtmin + " mins";
  }
  ObjectSetText(s, "Time Until Open: " + s2, 10, "Courier New", InfoColor);
  
  s = objpricelevel;
  if (ObjectFind(s) < 0) {
    ObjectCreate(s, OBJ_HLINE, 0, 0,0);
    ObjectSet(s, OBJPROP_WIDTH, 1);
    ObjectSet(s, OBJPROP_COLOR, InfoColor);
    ObjectSet(s, OBJPROP_STYLE, STYLE_DOT);
    ObjectSetText(s, "EA Price Level");
  }
  ObjectSet(s, OBJPROP_PRICE1, mPrice);

  return(0);
}

Congratulations ScalaFX for coming out of the closet!

#19
Feb 22, 2012 8:20pm Feb 22, 2012 8:20pm

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

It won't attach to my chart.

The trend is my friend? The world casino is my friend!

#20
Feb 22, 2012 8:27pm Feb 22, 2012 8:27pm

CapR
| Joined Aug 2010 | Status: Capitalism Prevails | 288 Posts

I got it fixed now.

The trend is my friend? The world casino is my friend!

Platform Tech
/
My TimeBased EA doesn't work - Please help
Reply to Thread
- Page 1 2 3
- Page 1 2 3

0 traders viewing now

Options

Similar Threads

My TimeBased EA doesn't work - Please help