coding and variable help needed | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help Needed- Coding an alert between two indicators 4 replies

Indicator coding help needed 2 replies

Coding question about "i" variable 5 replies

Coding help needed to reverse BUY/SELL execution 1 reply

very quick coding help needed 0 replies

coding and variable help needed

  • #1
  • First Post: Jan 30, 2012 1:54pm Jan 30, 2012 1:54pm
Hi everybody,

I need help to solve a little problem; I did create this simple code
PHP Code
int start()
{
   int Candles = 4;
   int dig = MarketInfo(Symbol(), MODE_DIGITS);
   int modifier = 1;
   if(dig == 3 || dig == 5) modifier = 10;
   double factor = Point * modifier;
   
   for(int i = 0; i <= Candles; i++)
   {
      if(Close[i] >= Open[i]) {Up[i] = (High[i] - Close[i]); Dn[i] = (Open[i]  - Low[i]);}
      if(Close[i] <  Open[i]) {Up[i] = (High[i] - Open[i]);  Dn[i] = (Close[i] - Low[i]);}
   }     
      
   double upsum = (Up[0] + Up[1] + Up[2] + Up[3] + Up[4]) / factor;
   double dnsum = (Dn[0] + Dn[1] + Dn[2] + Dn[3] + Dn[4]) / factor;
   double bullpower = dnsum/upsum;
   double bearpower = upsum/dnsum;
I don't know how to get the 2 variables upsum and dnsum calculated having to change the "Candles" parameter without change the formula all the time... I suppose that I'll have to use an array but my mq4 knowledge is not so deep...

Your help will be really appreciated...

Best Regards
brax64
  • #2
  • Jan 30, 2012 2:20pm Jan 30, 2012 2:20pm
You didn't show us the declarations for your array variables. I assume you using something like double up[4], dn[4] and you want to use Candle values like 5 or 15. The simplest way is to declare up and dn as arrays with lots of extra storage allocated like 99. The correct way is to use ArrayResize() in the Init() function once value of Candles has been determined.
  • #3
  • Edited 5:07pm Jan 30, 2012 3:13pm | Edited 5:07pm
Thanks CodeMaster for your reply; below the entire code so you can better understand what I'm trying to get..

PHP Code
#property copyright "brax64"
#property link      "brax64"

#property indicator_chart_window

extern color Up_power_color = Lime;
extern color Dn_power_color = Red;
extern color Bkgrnd_Color   = DimGray;
extern int   Pan_X          = 10;
extern int   Pan_Y          = 10;
extern int   Candles        = 4;

double Up[], Dn[];
string ID = "B_B Power ";

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
   IndicatorBuffers(2); 
   IndicatorShortName("PA candlestick");
   SetIndexBuffer(0,Up); SetIndexStyle(0,DRAW_NONE);
   SetIndexBuffer(1,Dn); SetIndexStyle(1,DRAW_NONE);
    
   return(0);
}

int deinit()
{
   
   return(0);
}

//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
   int dig = MarketInfo(Symbol(), MODE_DIGITS);
   int modifier = 1;
   if(dig == 3 || dig == 5) modifier = 10;
   double factor = Point * modifier;
   
   for(int i = 0; i <= Candles; i++)
   {
      if(Close[i] >= Open[i]) {Up[i] = (High[i] - Close[i]); Dn[i] = (Open[i]  - Low[i]);}
      if(Close[i] <  Open[i]) {Up[i] = (High[i] - Open[i]);  Dn[i] = (Close[i] - Low[i]);}
   }     
      
   double upsum = (Up[0] + Up[1] + Up[2] + Up[3] + Up[4]) / factor;
   double dnsum = (Dn[0] + Dn[1] + Dn[2] + Dn[3] + Dn[4]) / factor;
   double bullpower = dnsum/upsum;
   double bearpower = upsum/dnsum;
   return(0);
}
My problem is that I don't know how to get "upsum = Up[0] + Up[1] + ....... + Up[candles]"
brax64
  • #4
  • Jan 30, 2012 3:38pm Jan 30, 2012 3:38pm
Now I understand. Your variable declaration is OK.

Why don't you put the Upsum, Dnsum calculation in the loop? Initialize Upsum to 0 and then Upsum = Upsum + Up[i].
  • #5
  • Last Post: Jan 30, 2012 4:26pm Jan 30, 2012 4:26pm
Hi CodeMeister,

thanks a lot! Is working beautifully... I was getting lost in a glass of water!!

Best Regards


Quoting CodeMeister
Now I understand. Your variable declaration is OK.

Why don't you put the Upsum, Dnsum calculation in the loop? Initialize Upsum to 0 and then Upsum = Upsum + Up[i].
brax64
0 traders viewing now