Need advice on EA icustom

I have an indicator that shows up and down arrows and I want to use it in an EA. Knowing that the 0 is for up and 1 for down arrow respectevily withing the indicator code.

I amtrying to write the code to detect the up arrow as,

if (iCustom(NULL, NULL, "D0-3",89,0,0) != (iCustom(NULL, NULL, "D0-3",89,1,0)))

and for down the opposite;

if (iCustom(NULL, NULL, "D0-3",89,0,0) != (iCustom(NULL, NULL, "D0-3",89,1,0)))

My questions is would this icustom code determine the existence of up and down arrows as they appears on the chart.

Thanks in advance,

Your code as shown either will or will not work depending on your EA logic. If you test the condition every tick, it won't work because the current bar's value will be flipping back and forth and will generate lots of false signals. If you test the condition at the start of every bar it should work fine.

Edit: I just noticed that your up and down logic is identical. I assume that is a typo and you have some way to determine the direction correctly. I would use > and < personally but there are other ways to do it.

Thanks CodeMeister, very kind on your part. I was using every tick and getting false signals; I am going to try as you suggested. Yes, it is a typo error on the logic arguments.

I forgot to mention in my previous post that if you use bar opening logic, you should probably do a comparison between bar 1 and 2 not 0 and 1. Bars 0 and 1 might have the same or very close values depending on how the indicator value is calculated and of course bar 0 will change during tick updates.

First of all if your indicator shows up and down arrows and has 1 buffer for each arrow why do you need to check previous bar or whether the up arrow and down arrow is showing on the same bar?

The bars with no up arrow the up value would be 0.
The bars with no down arrow the down value would be 0.

This is how I would do it:

It would help if you posted the indicator but this should work.

Thanks to all for the help. I was delaying a reply because I believe first on self-endeavor. Yes, I turned this code upside down to no available good results.

If someone will like to fix it for me; my blessings; It a is very simple EA.

When Up Or Down arrow appears open a position if there is none already open.
Close the opossite order if one exist. Place an order.

Here is a not working (false signals) Ea mixed with the given suggestions.

// Expert start
int start()
{
if (Bars < 10)
{
Comment("Not enough bars");
return (0);
}
if (Terminated == true)
{
Comment("EA Terminated.");
return (0);
}

OnEveryNewBar12();

}

void OnEveryNewBar12()
{
if (true == false && true) PipValue = 10;
if (true && (NDigits == 3 || NDigits == 5)) PipValue = 10;
if (BarTime12 < Time[0])
{
// we have a new bar opened
BarTime12 = Time[0]; // keep the new bar open time
TechnicalAnalysis20();
TechnicalAnalysis14();
PrintInfoToChart11();
SpreadFilter13();

}
}

void TechnicalAnalysis20()
{
if (iCustom(NULL, NULL, "D0-3",89,0,1) > 0)
{
IfOrderDoesNotExist19();

}
}

void IfOrderDoesNotExist19()
{
bool exists = false;
for (int i=OrdersTotal()-1; i >= 0; i--)
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
{
if (OrderType() == OP_BUY && OrderSymbol() == Symbol() && OrderMagicNumber() == 1)
{
exists = true;
}
}
else
{
Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
}

if (exists == false)
{
CloseOrder16();

}
}

void CloseOrder16()
{
int orderstotal = OrdersTotal();
int orders = 0;
int ordticket[30][2];
for (int i = 0; i < orderstotal; i++)
{
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if (OrderType() != OP_SELL || OrderSymbol() != Symbol() || OrderMagicNumber() != 1)
{
continue;
}
ordticket[orders][0] = OrderOpenTime();
ordticket[orders][1] = OrderTicket();
orders++;
}
if (orders > 1)
{
ArrayResize(ordticket,orders);
ArraySort(ordticket);
}
for (i = 0; i < orders; i++)
{
if (OrderSelect(ordticket[i][1], SELECT_BY_TICKET) == true)
{
bool ret = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 3, Red);
if (ret == false)
Print("OrderClose() error - ", ErrorDescription(GetLastError()));
}
}
BuyOrder21();

}

void BuyOrder21()
{
double SL = Ask - BuyStoploss21*PipValue*Point;
if (BuyStoploss21 == 0) SL = 0;
double TP = Ask + BuyTakeprofit21*PipValue*Point;
if (BuyTakeprofit21 == 0) TP = 0;
int ticket = -1;
if (false)
ticket = OrderSend(Symbol(), OP_BUY, BuyLots21, Ask, 3, 0, 0, "system1", 1, 0, Blue);
else
ticket = OrderSend(Symbol(), OP_BUY, BuyLots21, Ask, 3, SL, TP, "system1", 1, 0, Blue);
if (ticket > -1)
{
if (false)
{
OrderSelect(ticket, SELECT_BY_TICKET);
bool ret = OrderModify(OrderTicket(), OrderOpenPrice(), SL, TP, 0, Blue);
if (ret == false)
Print("OrderModify() error - ", ErrorDescription(GetLastError()));
}

}
else
{
Print("OrderSend() error - ", ErrorDescription(GetLastError()));
}
}

void TechnicalAnalysis14()
{
if (iCustom(NULL, NULL, "D0-3",89,1,1) > 0)
{
IfOrderDoesNotExist18();

}
}

void IfOrderDoesNotExist18()
{
bool exists = false;
for (int i=OrdersTotal()-1; i >= 0; i--)
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
{
if (OrderType() == OP_SELL && OrderSymbol() == Symbol() && OrderMagicNumber() == 1)
{
exists = true;
}
}
else
{
Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
}

if (exists == false)
{
CloseOrder17();

}
}

void CloseOrder17()
{
int orderstotal = OrdersTotal();
int orders = 0;
int ordticket[30][2];
for (int i = 0; i < orderstotal; i++)
{
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if (OrderType() != OP_BUY || OrderSymbol() != Symbol() || OrderMagicNumber() != 1)
{
continue;
}
ordticket[orders][0] = OrderOpenTime();
ordticket[orders][1] = OrderTicket();
orders++;
}
if (orders > 1)
{
ArrayResize(ordticket,orders);
ArraySort(ordticket);
}
for (i = 0; i < orders; i++)
{
if (OrderSelect(ordticket[i][1], SELECT_BY_TICKET) == true)
{
bool ret = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 3, Red);
if (ret == false)
Print("OrderClose() error - ", ErrorDescription(GetLastError()));
}
}
SellOrder15();

}

void SellOrder15()
{
double SL = Bid + SellStoploss15*PipValue*Point;
if (SellStoploss15 == 0) SL = 0;
double TP = Bid - SellTakeprofit15*PipValue*Point;
if (SellTakeprofit15 == 0) TP = 0;
int ticket = -1;
if (false)
ticket = OrderSend(Symbol(), OP_SELL, SellLots15, Bid, 3, 0, 0, "System1", 1, 0, Red);
else
ticket = OrderSend(Symbol(), OP_SELL, SellLots15, Bid, 3, SL, TP, "System1", 1, 0, Red);
if (ticket > -1)
{
if (false)
{
OrderSelect(ticket, SELECT_BY_TICKET);
bool ret = OrderModify(OrderTicket(), OrderOpenPrice(), SL, TP, 0, Red);
if (ret == false)
Print("OrderModify() error - ", ErrorDescription(GetLastError()));
}

}
else
{
Print("OrderSend() error - ", ErrorDescription(GetLastError()));
}
}

void PrintInfoToChart11()
{
string temp = "EURUSDnExecuted : " + Count11 + "n"
+ "Spread: " + DoubleToStr(MarketInfo(Symbol(), MODE_SPREAD)/PipValue, 2)+ "n"
+ "------------------------------------------------n"
+ "ACCOUNT INFORMATION:n"
+ "n"
+ "Account Name: " + AccountName()+ "n"
+ "Account Leverage: " + DoubleToStr(AccountLeverage(), 0)+ "n"
+ "Account Balance: " + DoubleToStr(AccountBalance(), 2)+ "n"
+ "Account Equity: " + DoubleToStr(AccountEquity(), 2)+ "n"
+ "Free Margin: " + DoubleToStr(AccountFreeMargin(), 2)+ "n"
+ "Used Margin: " + DoubleToStr(AccountMargin(), 2)+ "n"
+ "------------------------------------------------n";
Comment(temp);
Count11++;

}

void SpreadFilter13()
{
if ((Ask-Bid) / Point / PipValue < MaxSpread13)
{

}
}



int deinit()
{
if (true) ObjectsDeleteAll();


}

Will need the indicator and would be helpful if you also posted the EA code as an attachment.

The code you posted will be mangled if I try to copy and paste into my code editor.
Always use the CODE tags or PHP tags when posting code or better yet post as an attachment.

Cyber1!

Thanks for showing interest in helping me. My apologies with the missing .mql
it is included below. I have been working very hard on it, without positve results.

Will take a look but really need the indicator in order to test it. Being the indicator is one I've not heard of.

ALso what errors are you getting or what do you mean by not getting positive results?
Does that mean not profitable or you can't get it to work?

In reference to the errors; as it is right now on the mql, it is ordering and closing on everybar. If I changed the logical operator let say to != it will pick some arrows and miss others. In general it gives false signals.

I need to see the indicator. Just too many things that could be happening.

Maybe someone else can decipher your code without running it but I can't.

Thanks, for the asking and the offer of help. I was trying to learn mt4 and needed a little push with a template that I was familiar with it. Anyhow, I received last night my main indicator which is base on price action (no other indicator needed) converted to mq5 and it is working perfectly!!!!. MT5, is my direction.