Help coding Pending Order Close

Quoting iwjw

Disliked

Don't think so
- If you don't want to hide your levels from your broker you should always use trades with predefined SL/TP in case you lose the server connection

Ignored

Quote

Disliked

- It's much easier to restart the EA using the trade history

Quoting nubcake

Disliked

pretty sure no one has ever asked you to prove yourself. pretty sure you have taken it upon yourself time and time again to prove yourself for some reason, to the point where you look for opportunities to 'prove yourself' whenever you can. so, whatever perspective you have on things is a world away from what i see. shit happens. i'm simply not interested in pulling my pants down and comparing. there are plenty of people on the forum ready to play that game, so pick and choose.

Ignored

Quoting pah

Disliked

@pip_seeker

Not sure what your problem is nor how you see your code/solution as being technically better than everyone else posting here.

If your broker deletes history on a live account then I suggest changing brokers. I have two accounts over 12&24 months old and the entire history is present.

Ignored

Quoting pah

Disliked

As for the 'advanced' code you posted, that also has issues which you might want to consider.

A forward incrementing loop which also deletes trades is not correct when trades might be closed on the server due to SL or TP being hit whilst the loop is running. May or may not be an issue depending on how the EA/strategy works.

You also ought to think about sending server commands in a delay/retry loop to ensure that failed commands are retried until successful. Also checking for trade context busy would be wise, especially if you have multiple...

Ignored

Quoting pip_seeker

Disliked

I am not looking for credit or another notch in my belt. I just submitted an answer to what I saw could be a big problem down the road... if not dealt with correctly.

It doesn't mean there isn't some other solution. Nothing is what I would call perfect.

Ignored

Quoting pah

Disliked

I wouldn't feel the need to pick further at your posted code: but instead of

Inserted Code

if ( OrderType() == OP_BUYLIMIT || 
                    OrderType() == OP_SELLLIMIT || 
                    OrderType() == OP_BUYSTOP || 
                    OrderType() == OP_SELLSTOP )

why not be efficient and say

Inserted Code

if ( OrderType() >= OP_BUYLIMIT )

And always check if an OrderSelect() succeeded, don't just assume it did.


Just a few thoughts...

Ignored