Help coding Pending Order Close | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

MT4 Order Pending Order/Order Modify Issue 1 reply

Coding for a pending order EA needed 9 replies

Need help!! Close order on this bar close 5 replies

Close pending order in X time 4 replies

Using a pending order to partialy close out an order. 2 replies

Help coding Pending Order Close

  • #1
  • First Post: Dec 29, 2011 7:58am Dec 29, 2011 7:58am
Here is the scenario.

I place a buy stop order(Ticket1) and sell stop order(Ticket2)
Both the tickets have the stop loss and take profits filled in.

Now lets for example say the buy order(Ticket1) gets filled in.

I want to delete the other pending order(Ticket2) only if my TP level is hit.

Here is my piece of code.

Inserted Code
if (OrdersTotal() == 1 ) 
      {//a
         if(OrderSelect(Ticket1, SELECT_BY_TICKET,MODE_TRADES)==true) 
            {//b
               order_type = OrderType();
               if (order_type == OP_BUY && OrderProfit() > 0 )
                  {
                     OrderDelete(Ticket2);
                     
                  }
                  
              }//b-
         }//a-

My current Problem - The pending order is getting deleted the moment the active trade either hits the SL or TP. However, it must only get delete when the TP is hit.

Please help.
  • #2
  • Dec 29, 2011 8:49am Dec 29, 2011 8:49am
This should do what you want I think. Basically all I am doing is setting a flag (switch) if your symbol goes into profit then I turn the flag "on" if the symbol goes into loss I shut the switch off. Being that it's a global variable switch it will retain it's memory in the event of shutting down over the weekend or system crash in which you need to reboot.

Inserted Code
string OrderFlag;
int valOrderFlag, NumBuys, NumSells;
double SymbolPL;
 
 
// put this at top of Start() function
OrderFlag = Symbol()+"OrderFlag";
if ( !GlobalVariableCheck(OrderFlag) ) GlobalVariableSet(OrderFlag,0);
valOrderFlag = GlobalVariableGet(OrderFlag);  
 
 
 
 
//+-----------------------------------------------------+
//| Please tell me if there is profit on me symbol               |
//+-----------------------------------------------------+
NumBuys = 0;
NumSells = 0;
SymbolPL = 0;
for(i = 0; i < OrdersTotal(); i++)
{
  OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
  if ( OrderSymbol() == Symbol() )
   {
    SymbolPL += OrderProfit();
 
 
    if ( OrderType() == OP_BUY  ) NumBuys++;
    if ( OrderType() == OP_SELL ) NumSells++;
    }
}   
 
// Set Order Flag
 
if (SymbolPL > 0 && NumBuys+NumSells =1 )
    {
      GlobalVariableSet(OrderFlag,1);
    }
 
if (SymbolPL <= 0 && NumBuys+NumSells = 1)
    {
      GlobalVariableSet(OrderFlag,0);
    }
valOrderFlag =GlobalVariableGet(OrderFlag); 
 
 
if (OrdersTotal() == 1 && valOrderFlag == 1) 
      {//a
         for(i = 0; i < OrdersTotal(); i++)
             {
              OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
              if ( OrderSymbol() == Symbol() )             
              if ( OrderType() == OP_BUYLIMIT || 
                    OrderType() == OP_SELLLIMIT || 
                    OrderType() == OP_BUYSTOP || 
                    OrderType() == OP_SELLSTOP ) 
                   {
                   OrderDelete(OrderTicket(),LimeGreen);
                   }                  
              }//b-
         }//a-
  • #3
  • Dec 29, 2011 8:48pm Dec 29, 2011 8:48pm
Quoting pip_seeker
This should do what you want I think. Basically all I am doing is setting a flag (switch) if your symbol goes into profit then I turn the flag "on" if the symbol goes into loss I shut the switch off. Being that it's a global variable switch it will retain it's memory in the event of shutting down over the weekend or system crash in which you need to reboot.

[code]
string OrderFlag;
int valOrderFlag, NumBuys, NumSells;
double SymbolPL;


// put this at top of Start() function
OrderFlag = Symbol()+"OrderFlag";
if ( !GlobalVariableCheck(OrderFlag)...

Thank You pip seeker for the reply. I am not sure if you understood my problem exactly.

Here is my doubt. When we check OrdersTotal() and then OderType() of a particular ticket and if we find that the ordertype is OP_BUY, this means we are in an active trade.

Now , isnt there something that tells that this trade was executed and is now closed.
  • #4
  • Dec 29, 2011 9:14pm Dec 29, 2011 9:14pm
OrderSelect() with SELECT_BY_POS will give you the open and pending orders. You can track a particular order by using OrderSelect() with SELECT_BY_TICKET. If the OrderCloseTime() is not null, the order has been closed.
  • #5
  • Dec 30, 2011 12:01am Dec 30, 2011 12:01am
Quoting CodeMeister
OrderSelect() with SELECT_BY_POS will give you the open and pending orders. You can track a particular order by using OrderSelect() with SELECT_BY_TICKET. If the OrderCloseTime() is not null, the order has been closed.

Thank You once again :-)
  • #6
  • Dec 31, 2011 12:05am Dec 31, 2011 12:05am
Quoting CodeMeister
OrderSelect() with SELECT_BY_POS will give you the open and pending orders. You can track a particular order by using OrderSelect() with SELECT_BY_TICKET. If the OrderCloseTime() is not null, the order has been closed.

Hi CodeMeister,

Although the orderclosetime() works here is the problem

I place 2 orders

Buy pending order
Price - 500
Target - 700
Stop - 400

Sell pending order
Price - 300
target - 200
stop - 400

Now lets say the buy order gets executed at 500 and the market falls and stop(400) get triggered... in this case the orderclosetime() is not null and hence the sell pending order is automatically deleted.

Where as I need it to be deleted only if my tp is hit.
  • #7
  • Dec 31, 2011 8:48am Dec 31, 2011 8:48am
Quoting deedeed
Thank You pip seeker for the reply. I am not sure if you understood my problem exactly.

Here is my doubt. When we check OrdersTotal() and then OderType() of a particular ticket and if we find that the ordertype is OP_BUY, this means we are in an active trade.

Now , isnt there something that tells that this trade was executed and is now closed.

Well I think I am doing it a bit different than what you are accustomed to is all.

For one I am not checking OrdersTotal() to see if I am in a trade I do it on my own by seperating Buy count from Sell count.

Orderstotal() doesn't give you sell or buy information unless you ask for it and it's easier code wise to do an ordercount and seperating the buys from the sells.

Additionally Orderstotal does not seperate symbols... where as my buy and sell count is symbol specific.

On top of all that... you have the functionality of having multiple orders and know how many orders what kind (buys or sells) on each tick.

There is always another way to do something... I think my way is better from a looking forward perspective.
  • #8
  • Edited 9:18am Dec 31, 2011 9:02am | Edited 9:18am
you have to look into the history of the trades
if(OrderClosePrice()==OrderTakeProfit())
you know that TP was hit
In the OrderSelect Statement you have to use MODE_HISTORY as third parameter and run through OrdersHistoryTotal()

To make it safer, you could give the buy/sell pair a unique marker...like comment, magicnumber
If there's only one open stop order but no running trade you have to look into the history and find the trade with the same unique marker and compare the prices as mentioned above

EDIT:
To decide whether it was SL or TP a comparison between OrderOpenPrice() and OrderClosePrice() could even be safer than OrderTakeProfit() in case of spikes...as soon as your TP is reached you get closed at the next availlable price and that could be lower than TP
  • #9
  • Dec 31, 2011 9:07am Dec 31, 2011 9:07am
Quoting iwjw
you have to look into the history of the trades
if(OrderClosePrice()==OrderTakeProfit())
you know that TP was hit
In the OrderSelect Statement you have to use MODE_HISTORY as third parameter and run through OrdersHistoryTotal()

To make it safer, you could give the buy/sell pair a unique marker...like comment, magicnumber
If you do have one open stop order but no running trade you have to look into the history and find the trade with the same unique marker and compare the prices as mentioned above

Some brokers go in and delete your order history... which is one more reason I never use this. Usually the brokers only delete this after months of data... but I don't like being at the mercy of a data deleting broker...
  • #10
  • Dec 31, 2011 9:24am Dec 31, 2011 9:24am
1. If you don't want to check the history for the closed trade(s) status you will have to use a zero take profit on the pending orders. When one is then triggered and converted to an open order, monitor the pips as the trade runs and close it (in code) when appropriate. At this point you can also delete the remaining pending order as you know your take profit level was satisfied on the one you just closed.

2. If you still want to use a take profit in the usual way, you will have to scan the history and check for the closed order ClosePrice() being near to the OrderTakeProfit() value. You are not guaranteed to see an exact match of the take profit and order close prices due to possible slippage and other factors, etc. when running it live.

Option 1 is the easiest to handle in code and more robust.

Regards, Paul.
  • #11
  • Dec 31, 2011 9:27am Dec 31, 2011 9:27am
Quoting pip_seeker
Some brokers go in and delete your order history... which is one more reason I never use this. Usually the brokers only delete this after months of data... but I don't like being at the mercy of a data deleting broker...
I've never seen history go missing but what does happen often is that you set a filter on your history window view of your trades (e.g. only show today's trades).

Unfortunately this filter also affects the orders you 'see' in code when iterating through history. You need to ensure you leave enough recent trades showing to satisfy whatever you want to check.

Regards, Paul
  • #12
  • Dec 31, 2011 9:31am Dec 31, 2011 9:31am
Quoting pah
...Option 1 is the easiest to handle in code and more robust....
Don't think so
- If you don't want to hide your levels from your broker you should always use trades with predefined SL/TP in case you lose the server connection
- It's much easier to restart the EA using the trade history
- even if the broker deletes the history after a few month (by the way never heard of that) it doesn't matter because you only need the last trade/symbol from the history
  • #13
  • Dec 31, 2011 9:56am Dec 31, 2011 9:56am
Quoting pah
I've never seen history go missing but what does happen often is that you set a filter on your history window view of your trades (e.g. only show today's trades).
The only way you ever hear of that is run an account for longer than a few months. If you keep changing accounts you don't learn as much. (Not trying to sound harsh... but I don't like chasing tail when dealing with code related issues.)

I think it will come down to what the OP can use and sleep at night confident that the EA will do what it's supposed to.

The last thing you want is to run an account with an EA for 3 months and all of a sudden it doesn't work. (maybe that's just me... it's ok. I'm used to being a lone wolf. lol)

You sit there and scratch your head after 3 months what happened? Trading is psychological... one you've lost faith you've lost it all.

OK I'll say it again... my way is forward looking. Probably a good 50 miles down the road.

If you don't believe me about the deleted data do a search for my journal page. "my demo journal" -- look at the equity graph to see the trades that have been chopped off toward the end of the journal.

Optionally you can talk to Danny who was in charge of the FF explorer testing and bug reporting. Just so you don't have to take my measely word for it.
  • #14
  • Dec 31, 2011 11:01am Dec 31, 2011 11:01am
Demo account. Nuf said. No legit account has their history tampered with. Get real.

Funny that nobody mentions magic numbers and ticket numbers. If your matching ticket closed at or past it's tp that tells you all you need to know. There is no point trying to be too clever for such a simple situation.
Congratulations ScalaFX for coming out of the closet!
  • #15
  • Dec 31, 2011 11:20am Dec 31, 2011 11:20am
Quoting nubcake
Demo account. Nuf said. No legit account has their history tampered with. Get real.

Funny that nobody mentions magic numbers and ticket numbers. If your matching ticket closed at or past it's tp that tells you all you need to know. There is no point trying to be too clever for such a simple situation.

Uh yeah they do... again don't believe me ask Danny.

I have proof from my own live account but I don't share this for explicit reasons... but you would rather disbelieve and that's ok.

Why oh why Nubby would I go to all the lengths in this thread? What do I have to gain.

I am like an open book and all you can do is stumble over yourselves.

But ya know that's the difference from someone who is successful and one who is not. The only way you know this is by keeping an account (live or demo) open and active for more than a few weeks or a few months.

I guess this still explains your dilema. Sorry to hear about that actually.
  • #16
  • Dec 31, 2011 11:35am Dec 31, 2011 11:35am
Quoting nubcake
Demo account. Nuf said. No legit account has their history tampered with. Get real.
pip_seeker is correct. Can't speak to Demo accounts, but Live accounts yes.

In my case IBFX removes it from the Metatrader history but I can log in to my online account at IBFX and every trade I ever made is there to analyze or download as CSV file which I then reformat a bit and by using a script can plot those trades back onto a Metatrader chart.
  • #17
  • Dec 31, 2011 11:43am Dec 31, 2011 11:43am
Fine I fucked up. Still has no bearing on someone wanting to auto remove a pending when a live has closed so I don't see why that was ever brought up. But hey what do I know. Clearly my dick isn't as big as some
Congratulations ScalaFX for coming out of the closet!
  • #18
  • Dec 31, 2011 5:46pm Dec 31, 2011 5:46pm
Quoting nubcake
Fine I fucked up. Still has no bearing on someone wanting to auto remove a pending when a live has closed so I don't see why that was ever brought up. But hey what do I know. Clearly my dick isn't as big as some

I am glad to see you took ownership Nubcake. What I said to you was pretty harsh and I'm sorry for that.

but I am also so tired going around with you and others and having to prove myself over and over and yet you and others never have to prove anything you say at all.

It's always dog pile on the guy who thinks differently. How much has herd mentality paid you? If nothing why run with the herd?

My whole point in saying what I did is this:

When you write an EA you write it so there is little to no chance it can get messed up... it will work on any broker etc.

Over the past couple of years I've changed live brokers more than 3 times which is quite unusual for me. But to think you will stay with just one broker for life is quite unlikely... so you write an EA write one in which it will work on any broker.

Again I say... the programming is looking down the road about 50 miles or so.

How many EA's are cast aside as worthless? An EA is only as good as the code contained therein. With that said can you stand to leave anything at chance?

When the EA gets to 500 lines of code with a potential problem such as this will the OP / coder bug check 500 lines of code? 1000 lines? 2000 lines?

I am not looking for credit or another notch in my belt. I just submitted an answer to what I saw could be a big problem down the road... if not dealt with correctly.

It doesn't mean there isn't some other solution. Nothing is what I would call perfect.

It's threads like this that make me wonder why the hell I do what I do. I guess it's like the question of how many licks does it take to get to the center of a tootsie pop... the world may never know.

Happy New Year
  • #19
  • Dec 31, 2011 6:34pm Dec 31, 2011 6:34pm
Quoting pip_seeker
but I am also so tired going around with you and others and having to prove myself over and over and yet you and others never have to prove anything you say at all.
pretty sure no one has ever asked you to prove yourself. pretty sure you have taken it upon yourself time and time again to prove yourself for some reason, to the point where you look for opportunities to 'prove yourself' whenever you can. so, whatever perspective you have on things is a world away from what i see. shit happens. i'm simply not interested in pulling my pants down and comparing. there are plenty of people on the forum ready to play that game, so pick and choose.

i don't think there is a need to 'look 50 steps down the road' in a case like this. the problem is somewhat trivial, and the solution should match this. unless your broker does not keep any history whatsoever then it's not really a big problem to solve. the fact is i'm not sure the OP specified enough of what he was doing and trying to accomplish and his 'problem' could be seen from too many different angles. but, maybe that's just me skimming due to reading on a small handheld screen. i'll cop that one too if that's the case.

and with that, i'm done on this thread unless the OP has some specific coding question to further this along.
Congratulations ScalaFX for coming out of the closet!
  • #20
  • Dec 31, 2011 11:19pm Dec 31, 2011 11:19pm
@pip_seeker

Not sure what your problem is nor how you see your code/solution as being technically better than everyone else posting here.

If your broker deletes history on a live account then I suggest changing brokers. I have two accounts over 12&24 months old and the entire history is present.

As for the 'advanced' code you posted, that also has issues which you might want to consider.

A forward incrementing loop which also deletes trades is not correct when trades might be closed on the server due to SL or TP being hit whilst the loop is running. May or may not be an issue depending on how the EA/strategy works.

You also ought to think about sending server commands in a delay/retry loop to ensure that failed commands are retried until successful. Also checking for trade context busy would be wise, especially if you have multiple EAs running.

If you weren't so arrogant I wouldn't feel the need to pick further at your posted code: but instead of
Inserted Code
if ( OrderType() == OP_BUYLIMIT || 
                    OrderType() == OP_SELLLIMIT || 
                    OrderType() == OP_BUYSTOP || 
                    OrderType() == OP_SELLSTOP )
why not be efficient and say
Inserted Code
if ( OrderType() >= OP_BUYLIMIT )

And always check if an OrderSelect() succeeded, don't just assume it did.


Just a few thoughts...
0 traders viewing now