Coding help required | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Indicator coding help required 1 reply

Coding Help Required 6 replies

Coding Help Required for a Sell & Buy EA 10 replies

Coding Help Required for Breakout EA 1 reply

Coding Help Required on EA 2 replies

Attachments: Coding help required
Exit Attachments

Coding help required

  • #1
  • First Post: Dec 28, 2011 12:23am Dec 28, 2011 12:23am
I am trying to write a EA and am stuck and need some help. Here is the actual formula I am trying to write a code for, but am unsuccessful in doing it. Pls help.

(sqrt(close[1]) + (10/180))^2

 

  1. 10/180 means 10 degrees
  2. sqrt(close[1]) means square root of the close value of the previous bar.
  3. ^2 the whole squared.


The Problems I am facing.
For example if the previous close is 1.34567

1. I have a five digit broker. So when I print close[1], I get a 4 digit value.

2. Many a times most the values are getting rounded off.

3. In excel if I punch in a whole number(which are the digits after the point like 34567) I get the correct answer. But when I type in the actual close which is 1.34567 I get some other answer.

So I need a formula that will compute it properly on MT4.

Thanks

  • #2
  • Dec 28, 2011 12:48am Dec 28, 2011 12:48am
The problem isn't with the calculation or MT4. You are displaying the answer with the default format which is 4 digits. Try DoubleToStr(answer, Digits) and you will see the right number of digits.
  • #3
  • Dec 28, 2011 2:29am Dec 28, 2011 2:29am
I love this site...helps alot when i have a question and everyone seems to have a different answer for the same thing.

http://docs.mql4.com/math/MathSqrt

Read all the sections and you will have a better understanding of how to code your EA/indicator properly.

Once you do take the time to read it all...you will have all your answers to the questions you have asked.
  • #4
  • Edited 2:57am Dec 28, 2011 2:55am | Edited 2:57am
Thanks CodeMeister and dredding82,

Not really sure if this is the way I have to go about it. But here is my trial. If there is a better way of doing this pls let me know.

Please take a look and guide me from here.. I am trying to make this ea for eurusd

Now I am stuck with an integer which is actually the value of the decimal points.

so if the previous close is 1.30614, this little piece of code will give u an output of 30731 where as my actual output must be 1.30731.

if(Hour() >= 8 && Minute() >= 0 )
{
double C1 = Close[1] ;

string D1 = DoubleToStr(((C1-1)*100000),0); //actual close without points.
Print("D1 is ", D1);

double D11 = StrToDouble( D1 );
Print("D11 is ", D11);

double D12 = (MathSqrt( D11)+ 0.33333) ; //sqroot of the number without points + 60 degree
Print("D12 is ", D12);

int D13 = MathRound(D12*D12);
Print("D13 is ", D13);




}
  • #5
  • Dec 28, 2011 3:14am Dec 28, 2011 3:14am
(sqrt(close[1]) + (10/180))^2

Inserted Code
double Result=MathPow(MathSqrt(Close[1]) + (10.0/180.0), 2);
Result=NormalizeDouble(Result,Digits);
Comment("Result="+DoubleToStr(Result,Digits));


Inserted Code
double Result=NormalizeDouble(MathPow(MathSqrt(Close[1])+10.0/180.0, 2),Digits);
Comment("Result="+DoubleToStr(Result,Digits));
  • #6
  • Dec 28, 2011 3:33am Dec 28, 2011 3:33am
Quoting Xaphod
(sqrt(close[1]) + (10/180))^2

Inserted Code
double Result=MathPow(MathSqrt(Close[1]) + (10.0/180.0), 2);
Result=NormalizeDouble(Result,Digits);
Comment("Result="+DoubleToStr(Result,Digits));


Inserted Code
double Result=NormalizeDouble(MathPow(MathSqrt(Close[1])+10.0/180.0, 2),Digits);
Comment("Result="+DoubleToStr(Result,Digits));

Thank you Xaphod for the code,

But it is not compling. Metaeditor says that its compiling, but it never finishes compiling
  • #7
  • Edited 3:49am Dec 28, 2011 3:38am | Edited 3:49am
It compiles and runs on my system.

Inserted Code
//+------------------------------------------------------------------+
//|                                                        testt.mq4 |
//+------------------------------------------------------------------+
#property copyright "©"
#property link      ""

//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
int start() {
  double Result=NormalizeDouble(MathPow(MathSqrt(Close[1])+10.0/180.0, 2),Digits);
  Comment("Result="+DoubleToStr(Result,Digits));
  return(0);
}

I think you may need to study a bit more mql4 programming. Here are some useful links:
http://articles.mql4.com/404
http://articles.mql4.com/417
http://articles.mql4.com/466
http://articles.mql4.com/516
http://articles.mql4.com/536
http://www.forexfactory.com/showthread.php?t=6011
http://book.mql4.com/samples/expert
  • #8
  • Dec 28, 2011 3:46am Dec 28, 2011 3:46am
Quoting Xaphod
It compiles and runs on my system.

[code]
//+------------------------------------------------------------------+
//| testt.mq4 |
//+------------------------------------------------------------------+
#property copyright ""
#property link ""

//+------------------------------------------------------------------+
//| script program start function |
//+------------------------------------------------------------------+
int start() {
double...


Thanks for the quick reply. I managed to compile it as well. But the output is still not right.

In excel when I run the formula remove the 1 before the decimal. Meaning

if the previous close is 1.30739 and I run the formula for 30739 I get the 10 degrees as 30758

But when I run the script on mt4 the result as per your code the answer is 1.43752.

why is this happening.

cheers
  • #9
  • Dec 28, 2011 3:52am Dec 28, 2011 3:52am
here is the excel screenshot
Attached Image
  • #10
  • Edited 3:54am Dec 28, 2011 3:53am | Edited 3:54am
I just converted the formula you provided to mql4:
(sqrt(close[1]) + (10/180))^2
Nothing more.
  • #11
  • Dec 28, 2011 3:56am Dec 28, 2011 3:56am
Quoting Xaphod
I just converted the formula you provided to mql4:
(sqrt(close[1]) + (10/180))^2
Nothing more.

With my method I managed to get the decimal points right but did not know how to put a 1 and a point before the decimals.

Can you please help me with this formula.
  • #12
  • Dec 28, 2011 4:09am Dec 28, 2011 4:09am
subtract 1 from the close, multiply it by 100000 and then plug that value into the formula instead of the close.
  • #13
  • Dec 28, 2011 10:30am Dec 28, 2011 10:30am
Quoting Xaphod
subtract 1 from the close, multiply it by 100000 and then plug that value into the formula instead of the close.
valuable!
  • #14
  • Dec 29, 2011 6:08am Dec 29, 2011 6:08am
For 60 degrees


double C1 = Close[1] ;

string D1 = DoubleToStr(((C1-1)*100000),0); //actual close without points.

double D11 = StrToDouble( D1 );

double D12 = (MathSqrt( D11)+ 0.33333) ; //sqroot of the number without points + 60 degree

int D13 = MathRound(D12*D12);

double D14 = D13;

double D15 = D14*0.00001;

double D16 = 1+D15; //final 60 degree
Comment ("d15 ", D16);

yes I know there could be a better way of doing this. But this thing is working at least now. All inputs welcome.

Cheers
  • #15
  • Edited 7:05am Dec 29, 2011 6:43am | Edited 7:05am
Inserted Code
//+------------------------------------------------------------------+
//|                                                        testt.mq4 |
//+------------------------------------------------------------------+
#property copyright "Copyright ©"

//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
int start() {  
 Comment("Result="+CalcThing(Close[1],60));
 return(0);  
}

double CalcThing(double dClose, double dAngle) {
  double dInputValue, dResult;
  
  dInputValue=(dClose-1)*MathPow(10,Digits);
  dResult=MathPow(MathSqrt(dInputValue)+dAngle/180.0, 2);
  dResult=1+dResult/MathPow(10,Digits);
  
  return(dResult);
}
  • #16
  • Last Post: Dec 29, 2011 7:49am Dec 29, 2011 7:49am
Quoting Xaphod
[code]
//+------------------------------------------------------------------+
//| testt.mq4 |
//+------------------------------------------------------------------+
#property copyright "Copyright "

//+------------------------------------------------------------------+
//| script program start function |
//+------------------------------------------------------------------+
int start() {
Comment("Result="+CalcThing(Close[1],60));
return(0);...

You are awesome :-) Thank You once again.
0 traders viewing now