Make MACD Bars indi non-repainting for higher TFs | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Please help to make this indi into a Multiple Time Frame (MTF) indi 3 replies

Volume Indi that only shows for bars that make a high/low 14 replies

Repainting indi into Non-Repainting Indi - Help 2 replies

Higher TFs vs Lower TFs 0 replies

Calculating Function values for higher TFs, Programming help 6 replies

Attachments: Make MACD Bars indi non-repainting for higher TFs
Exit Attachments

Make MACD Bars indi non-repainting for higher TFs

  • #1
  • First Post: Dec 17, 2011 7:49pm Dec 17, 2011 7:49pm
Hi, if anyone is kind enough to look at this and tell me what I am doing wrong. I want to see the MACD condition as bars for M15 but on the M5 so it can change 3 times per M15 bar. I don't want it to change color after the bar is closed. My code in the Start() section simply calculates the current bar and then moves to history on bar change but it all disappears when I close the chart so I want to calculate prior bars on Init(). The code I added to Init() seems right to my thinking but all my bars are green so it is not calculating correctly. 'i' is the M5 bar and 'j' is the M15 bar. I add the Close[i] prices to the ClosedPrice array and then calculate the MACD based on current close and prior M15 'j' closes. Thanks if you can help.

Only the Init() section is the problem.
Attached File(s)
File Type: mq4 MACDBars-static.mq4   7 KB | 1,334 downloads
  • #2
  • Dec 18, 2011 12:45pm Dec 18, 2011 12:45pm
I'll add the code here so it is not necessary to download the indicator.

Inserted Code
 
   if(MaximumBars%(TimeFrame/Period())==0)
      int firstbar = MaximumBars/(TimeFrame/Period());
   else 
      firstbar = MaximumBars/(TimeFrame/Period()) - MaximumBars%(TimeFrame/Period()) + 1;
 
   j=firstbar;
   for(int i=MaximumBars; i>0; i--)
   {
      if(TimeMinute(Time[i])%TimeFrame==0)
      {
         j--;
         ClosedPrice[j+1]=Close[i+1];
      }
 
      ClosedPrice[j]=Close[i];
      MacdBuffer[j]=iMAOnArray(ClosedPrice,0,FastEma,0,MODE_EMA,j)-iMAOnArray(ClosedPrice,0,SlowEma,0,MODE_EMA,j);
 
      SignalBuffer[j]=iMAOnArray(MacdBuffer,0,SignalSMMA,0,MODE_SMA,j);
 
      if (MacdBuffer[j] >= SignalBuffer[j])
      {
         ExtMapBuffer1[i] = 1;
         ExtMapBuffer2[i] = 0;
      }
      else 
        if (MacdBuffer[j] < SignalBuffer[j])
      {
         ExtMapBuffer2[i] = 1;
         ExtMapBuffer1[i] = 0;
      }
   }
  • #3
  • Dec 18, 2011 12:56pm Dec 18, 2011 12:56pm
I removed the = from the line:

if (MacdBuffer[j] >= SignalBuffer[j])

and all the bars disappeared so apparently these values are exactly the same all the time here. Since I'm looking for M15 MACD on the M5, I would expect to get true values by bar 78 (3x26).
  • #4
  • Dec 18, 2011 2:10pm Dec 18, 2011 2:10pm
Quoting ericjschroed
I removed the = from the line:

if (MacdBuffer[j] >= SignalBuffer[j])

and all the bars disappeared so apparently these values are exactly the same all the time here. Since I'm looking for M15 MACD on the M5, I would expect to get true values by bar 78 (3x26).
What is it you are trying to do, can you post a screenshot?
Are you trying to keep it from repainting?

Whatever it is I suggest running it in the Strategy Tester as all I see is Green bars.
  • #5
  • Dec 18, 2011 2:38pm Dec 18, 2011 2:38pm
Quoting cyber1
What is it you are trying to do, can you post a screenshot?
I want to see the MACD condition as bars for M15 but on the M5 so it can change 3 times per M15 bar. Obviously, I don't have a screenshot of the working indicator or I wouldn't be asking for help. Here is a screen of the live calculation, which only modifies the current bar, however all historical bars disappear when I close the chart so I want to calculate it once when I open the chart/indicator. The bottom 2 indicators are the M15.
Quoting cyber1
Are you trying to keep it from repainting?
Yes, I don't want it to change color after the bar is closed.
Quoting cyber1
Whatever it is I suggest running it in the Strategy Tester as all I see is Green bars.
I know, I said all my bars are green so it is not calculating correctly. When I removed the "=" the bars disappeared because apparently these values (MacdBuffer[j] and SignalBuffer[j]) are exactly the same because the calculation isn't working as expected. In my experience many indicators like this do not show correctly in Strategy Tester.
Attached Image (click to enlarge)
Click to Enlarge Name: macdstat2.gif Size: 17 KB
  • #6
  • Dec 18, 2011 3:10pm Dec 18, 2011 3:10pm
Quoting ericjschroed
I want to see the MACD condition as bars for M15 but on the M5 so it can change 3 times per M15 bar. Obviously, I don't have a screenshot of the working indicator or I wouldn't be asking for help. Here is a screen of the live calculation, which only modifies the current bar, however all historical bars disappear when I close the chart so I want to calculate it once when I open the chart/indicator. The bottom 2 indicators are the M15.

Yes, I don't want it to change color after the bar is closed.

I.
Usually the reason for the repainting is the for loop starts with 0 instead of 1.
Have you tried that?

On this page there are a lot of MACD MTF and included are some MACD Bars indicators.
http://www.forex-tsd.com/setup-quest...indicator.html
  • #7
  • Dec 18, 2011 9:24pm Dec 18, 2011 9:24pm
Thanks for the link but No, none of the bars or MTFs do what I want. They all call the MACD so you only see the history of the closed M15, not what happened during that time, such as crossed up, then back down. And your suggestion that "repainting is the loop starts with 0 instead of 1" implies that you do not code indicators or at least you haven't posted any here or on tsd, that I can see. The 0 or 1 has nothing to do with repainting prior bars. Thank you for your interest, cyber1, but if you cannot help me fix my code, you do not need to post any more replies.
  • #8
  • Dec 19, 2011 12:21am Dec 19, 2011 12:21am
This might do what you want. There are more efficient ways, but I'll leave that up to you.
Attached File(s)
File Type: mq4 MACD-MTF-Bars.mq4   5 KB | 2,152 downloads
  • #9
  • Last Post: Dec 19, 2011 10:04am Dec 19, 2011 10:04am
thanks, this seems to work just fine. I have been running it alongside my MACD bars indi that only writes the current bar and they appear identical.
0 traders viewing now