What's wrong with this simple calculation code line? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

What's Wrong With This Code (Time calculation)? 20 replies

Need simple excel sheet/program for risk calculation please 8 replies

Help with a simple calculation 2 replies

simple cross line code 0 replies

Help to code a simple line indicator 2 replies

What's wrong with this simple calculation code line?

  • #1
  • First Post: Edited 6:37pm Nov 21, 2011 6:15pm | Edited 6:37pm
Hello Folks.

I'm going trough the roof in a minute.
Why is the calculation below returning "0"?

Inserted Code
double MyNewSL = OrderOpenPrice() -(StopLoss * Point * BrokerDigitCalc);
OrderSelect for OrderOpenPrice was called and orderOpenPrice returns the proper value.
StopLoss = double, Value "15",
BrokerDigitCalc = double, Value "10".

I don't understand it? Is MT having trouble with bracket calculations?
If I just replace everything in the brackets with a "0",
Inserted Code
double MyNewSL = OrderOpenPrice() -(0)
"MyNewSL" it the OrderOpenPrice, as expected.

I know it's simple, but at this point I don't get it...

Regards.
WorstCases
  • #2
  • Nov 21, 2011 7:03pm Nov 21, 2011 7:03pm
Quoting MikeFT
Hello Folks.

I'm going trough the roof in a minute.
Why is the calculation below returning "0"?

Inserted Code
double MyNewSL = OrderOpenPrice() -(StopLoss * Point * BrokerDigitCalc);
OrderSelect for OrderOpenPrice was called and orderOpenPrice returns the proper value.
StopLoss = double, Value "15",
BrokerDigitCalc = double, Value "10".

I don't understand it? Is MT having trouble with bracket calculations?
If I just replace everything in the brackets with a "0",
Inserted Code
double MyNewSL = OrderOpenPrice() -(0)
"MyNewSL"...

Try this:
double MyNewSL = OrderOpenPrice() -(StopLoss * Point) * BrokerDigitCalc;


Other than that would need to see more code.

Not sure what you mean by this:
StopLoss = double, Value "15",
BrokerDigitCalc = double, Value "10".
  • #3
  • Nov 22, 2011 12:08am Nov 22, 2011 12:08am
Quoting MikeFT
Hello Folks.

I'm going trough the roof in a minute.
Why is the calculation below returning "0"?

Inserted Code
double MyNewSL = OrderOpenPrice() -(StopLoss * Point * BrokerDigitCalc);
OrderSelect for OrderOpenPrice was called and orderOpenPrice returns the proper value.
StopLoss = double, Value "15",
BrokerDigitCalc = double, Value "10".

I don't understand it? Is MT having trouble with bracket calculations?
If I just replace everything in the brackets with a "0",
Inserted Code
double MyNewSL = OrderOpenPrice() -(0)
"MyNewSL" it the OrderOpenPrice,...
you've only given us part of the picture. why don't you get rid of the orderopenprice and see what just the brackets returns.

without knowing what Point equals and what chart you are on i can only guess that your math is returning a value that is outside of normal price ranges.... i.e. if Point = 1 then your orderopenprice - (150) is going to be a negative number.... hence it gets changed to zero since you cant have a negative price.
Congratulations ScalaFX for coming out of the closet!
  • #4
  • Nov 22, 2011 2:03am Nov 22, 2011 2:03am
Point = 0,00001

Quote
Not sure what you mean by this:
StopLoss = double, Value "15",
BrokerDigitCalc = double, Value "10".
So - left the brackets out (were not really necessary anyway) and everything is OK.
Inserted Code
double MyNewSL = OrderOpenPrice() -StopLoss * Point * BrokerDigitCalc;
Weird problem. Seems MT can't handle more than 2 values in a bracket...??
  • #5
  • Nov 22, 2011 2:09am Nov 22, 2011 2:09am
Quoting MikeFT
Point = 0,00001

So - left the brackets out (were not really necessary anyway) and everything is OK.
Inserted Code
double MyNewSL = OrderOpenPrice() -StopLoss * Point * BrokerDigitCalc;
Weird problem. Seems MT can't handle more than 2 values in a bracket...??
stop messing with the brackets. you have done something wrong. i'm 99.9999999% certain that mql has no issue with brackets.

remove the ORDEROPENPRICE and see what the BRACKETS returns.... we KNOW that orderopenprice is going to be correct, and you have proved that to yourself.... so find out what is happening in the OTHER part. from there you can start trying to work-out what is going wrong. we don't need to know the value that is correct, we need to know the value that is wrong!

if you don't resolve the issue in this case then you'll never resolve it if it ever comes up again.... so find what the issue is now and always make sure you don't make the same mistake (because i'm betting it's something you have done wrong somewhere).
Congratulations ScalaFX for coming out of the closet!
  • #6
  • Nov 22, 2011 3:19am Nov 22, 2011 3:19am
Quoting MikeFT
Hello Folks.

I'm going trough the roof in a minute.
Why is the calculation below returning "0"?
Have you checked for type casting errors? I have been caught with that before! Have a read of this if you haven't done so already...

http://docs.mql4.com/basis/types/casting
  • #7
  • Last Post: Nov 22, 2011 7:54am Nov 22, 2011 7:54am
I have seen math errors with MT4 when you don't fully encase the formula in ()'s. (when the formula is doing more than just multiplication.)


double xyz = OrderOpenPrice()-myValue*Point*DigitSpace;

double xyz = (OrderOpenPrice()-((myValue*Point)*DigitSpace) );

Normal operation of math equations is always to multiply first, but to ensure the outcome or solution to the formula as to what you mean you should use brackets.
0 traders viewing now