Help with fixing hi/low indicator issue

I have a hi/low indicator that sqaulou had made for me and it was suppose to work like this:

The previous days hi/low are calculated and with fib extensions and the lines are projected into the current day. As each candle closes, the lines are extended to each new candle. When the end of the day is reached, it re-draws the hi/low from the current day and leaves the old hi/low from the previous day on the chart for visual reference only. It works perfect and flows from Friday into Monday with no issues on brokers that do not have a Sunday candle, like Go Markets (pic 1).

The problem is on a broker with Sunday candles, like the IBFX example in picture #2 below. It show the individual lines for Sunday only and what it should do is include Sunday's data in Friday's calculations, so Friday and Sunday should act like one day instead of two individual days. I have no coding experience and sqaulou is busy with other projects and hasn't e-mailed back yet. Any help would be appreciated.

No one? I figured this to be a simple fix.

ttt

ttt

I dropped it on a chart but I don't see the problem that you show above.

Steve Hopwood is the author I suggest you contact him.

That's because it only shows up on Sunday. It won't obviously won't show up on other days because after Monday passes, the Sunday data merges with Monday and that's not what I need it to do.

Hi Mer,
I was interested in the issue and have looked at the code.

It seems that this code does have a function to merge Sunday’s data into Monday’s but also has a small bug so latest lines are shown in an unexpected manner in the beginning of week.

I think modifying the code to avoid this and include Sunday’s data in Monday’s is better than including Sunday’s data in Friday’s but the latter change also could be done.

Which do you think is best?

Well, I need it to merge Friday with Sunday because the strategy I'm using it for relies on the hi/low of the previous day and the short Sunday data produces a very small picture (as in the second pic above in post #1) and distorts the whole strategy and makes trading on Monday unusable. I think when sqaulou modified it after Steve gave it to me, he misunderstood what I wanted and merged the data with Monday instead of Friday.

I basically want:

(1) the Friday and Sunday to merge and act as one day just like a broker with no Sunday candle.

Or even if it's possible to:

(2) completely skip over or not include Sunday's data and have the lines from Friday project into Monday, skipping over Sunday altogether.

Either fix would work, but I would prefer the first option.

Waiting to here back from Miyagi, but still needing help with this one if any one has any ideas.

Have you tried running the indy on a br0ker MT4 that doesn't generate the annoying Sunday candles? (GoMarkets is one such br0ker; I'm sure there are plenty of others in this list. A br0ker who is GMT+2 time-zoned shouldn't generate Sunday candles).

If this works, you could perform your analysis on a demo account on one br0ker platform, and still place orders with your preferred br0ker. It's perfectly possible to run multiple MT4 platforms on the same computer.

Mer, I understand that your strategy prefers to include Sunday’s data in previous Friday’s.

I modified the code so that Sunday and Friday act like one day and also fixed the bug not to draw the latest lines in a way as shown in post #1 in the beginning of week.

I haven’t tested it throughly (it's Wednesday today:-) but should work, so please check to see if it works for you.

Oh yeah, it works great on Go Markets and Pepperstone, but I want others that use a broker with a Sunday candle to be able to use this also.

Looks good on The CollectiveFX, but when I load it for example on Go Markets with no Sunday candle, none of the previous lines show up on any of the previous Fridays (see pic). I'm thinking the bug you say you found might have been coded that way by sqaulou on purpose. If we can fix that minor little issue, it would be perfect. If you can't, I might just have to use to separate indicators, one for for brokers with Sunday candles and one for without .

Can anyone see anything that needs to be in the new indicator that Miyagi posted that he took out of the old indicator which is causing the Friday data to disappear in the above pic?

OK, let me explain what I thought about the code at first though you might not read the mql.

The original code you posted merges Sunday’s data with Monday’s by first drawing Sunday’s lines and then replacing them with the merged data on the next day.

This algo works perfectly fine for the past data because all Sunday’s lines are replaced in hindsight, but does not for the latest lines even though the latest lines are projections of the past and you still see the Sunday’s lines for a day (in this case on Monday as in your pic in post #1).

The correct lines are drawn only after the next day passes and I believe this is the small bug that distorts the chart in the beginning of week.

I fixed it in the previous post but changed the code no further (actually I also changed the destination of Sunday’s data from Monday to Friday at your strategy’s preference). Now I found that what you wanted was the code which includes Sunday’s data into Friday’s only if there is and works regardless of whether Sunday’s candles are present.

I think it’s a good idea to implement this so simply added some more codes.
Now this version should work for both brokers and I hope it does for you.

Just tried it out, nailed it!!!!!!! I thank you very much!

Hello Mer, I see you have discovered my secret weapon, Miyagi. I don't know who this dude is, but he codes like a magician.

Yeah, I'm glad Miyagi could help out because sqaulou was traveling to Melbourne and couldn't do anything until he got back.

Miyagi, I also have this AutoDayFibs2 indicator that does the same thing. Can you make it work by merging Friday and Sunday with this one also?

Wow I’m a weapon now, lol.

I have looked at the code above and decided to write a new one this time.

So attached version should work same as the original with a new function of treating Sundays but the code is completely different. Check it out to see if it works or there is any improvement you want.
Hope it works for you.


PS. This code is updating levels/labels every tick. Not sure you need this, but coded in such a way just because the original was doing so.

Thanks a bunch, I'll try it out this weekend and see how it reacts when the market opens up.