Anyone can check this code pls? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Can anyone modify Fisher indicator for me pls? 3 replies

Can anyone can help me code an idea? 8 replies

Pls help on 4Hr TF code . 4 replies

can anyone pls tell me what forex robot or machine is the best on meta4 5 replies

Attachments: Anyone can check this code pls?
Exit Attachments

Anyone can check this code pls?

  • #1
  • First Post: Edited 4:29am Nov 16, 2011 4:18am | Edited 4:29am
FPIbuffer[i] = (aVar/bVar/cVar);

this part is extracted from the attached mq4,

may I know why I cant get the result from the loop? but others will do

by the way, this is an EA
Attached File(s)
File Type: mq4 myfpi-ea.mq4   1 KB | 454 downloads
  • #2
  • Nov 16, 2011 5:37am Nov 16, 2011 5:37am
MQL4 gets really bothered about the evaluation order of multiplies and divides, so you have to help it.

FPIbuffer[i] = ((aVar/bVar)/cVar);
  • #3
  • Nov 16, 2011 6:06am Nov 16, 2011 6:06am
yes I have tried but the problem still persist
  • #4
  • Nov 16, 2011 6:33am Nov 16, 2011 6:33am
Either you have coded this expression wrong (in the logical sense) or the problem is somewhere else in your program and you are getting an unexpected result. So you need to determine where the problem is occurring because it is not in the statement you provided.
  • #5
  • Nov 16, 2011 6:37am Nov 16, 2011 6:37am
I replace a variable to FPIbuffer[i] and the result can be displayed, but i need array because it is in the for loop
  • #6
  • Nov 16, 2011 9:47pm Nov 16, 2011 9:47pm
hey klhh...... try declaring the the array outside the start section..... see if that works......h

//---
//---

Inserted Code
 
extern string Symbol1 = "EURJPY";
extern string Symbol2 = "EURUSD";
extern string Symbol3 = "USDJPY";
       double aVar     =       0;
       double bVar     =       0;
       double cVar     =       0;
       double FPIbuffer[5];
 
int start() {
to trade and code, keep both simple... no call to impress....h
  • #7
  • Nov 16, 2011 11:07pm Nov 16, 2011 11:07pm
Quoting hayseed
hey klhh...... try declaring the the array outside the start section..... see if that works......h

//---
//---

Inserted Code
 
extern string Symbol1 = "EURJPY";
extern string Symbol2 = "EURUSD";
extern string Symbol3 = "USDJPY";
       double aVar     =       0;
       double bVar     =       0;
       double cVar     =       0;
       double FPIbuffer[5];
 
int start() {
Hello hayseed, I did, but the problem still persist
  • #8
  • Nov 16, 2011 11:42pm Nov 16, 2011 11:42pm
you've given no size to the array... only declared the pointer type to be towards an array.

this isn't an mt4 'buffer' where mt4 automagically handles the continual resizing of the array as the bar history increases. trying to read or write to any index within the array is erroneous the way you currently have it.
Congratulations ScalaFX for coming out of the closet!
  • #9
  • Nov 17, 2011 12:58am Nov 17, 2011 12:58am
Quoting nubcake
you've given no size to the array... only declared the pointer type to be towards an array.

this isn't an mt4 'buffer' where mt4 automagically handles the continual resizing of the array as the bar history increases. trying to read or write to any index within the array is erroneous the way you currently have it.
Hello nubcake, I don understand, could you pls give some example pls?
  • #10
  • Nov 17, 2011 1:58am Nov 17, 2011 1:58am
Where does your for loop start and end? You seem to have the return(0) inside your for loop.

I agree with nubcake's previous response about defining the size of your array. You need to start with an array of size 1 ie

double FPIbuffer[1];

and then every iteration through the for loop you need to increase the size of your array:-

ArrayResize( FPIbuffer, 1+i) ;
  • #11
  • Nov 17, 2011 2:13am Nov 17, 2011 2:13am
Quoting klhh
Hello nubcake, I don understand, could you pls give some example pls?
this is your code in the original post....

Inserted Code
extern string Symbol1="EURJPY";
extern string Symbol2="EURUSD";
extern string Symbol3="USDJPY";

double     aVar=0;
double     bVar=0;
double     cVar=0;

int start() {
   double lotsize;
   lotsize = MarketInfo(Symbol1,MODE_LOTSIZE);
   if(lotsize < 100000)
      {
      Symbol1 = StringConcatenate(Symbol1,"m");
      Symbol2 = StringConcatenate(Symbol2,"m");
      Symbol3 = StringConcatenate(Symbol3,"m");
      }
   int limit;
   int counted_bars=IndicatorCounted();
//---- last counted bar will be recounted
   if(counted_bars>0) counted_bars--;
      limit=Bars-counted_bars;
    //---- indicator buffers
 
      double     FPIbuffer[];
    for(int i=0; i<limit; i++)
      {
      
      aVar = MarketInfo(Symbol1,MODE_BID);       
      
      bVar = MarketInfo(Symbol2,MODE_BID);        
      
      cVar = MarketInfo(Symbol3,MODE_BID);       
      
      FPIbuffer[i] = (aVar/bVar/cVar);
            
   if(FPIbuffer[0] > 1.0005) 
         Alert("FPI High --> " + DoubleToStr(FPIbuffer[0],4));
      if(FPIbuffer[0] < 0.9996) 
         Alert("FPI Low --> " + DoubleToStr(FPIbuffer[0],4));
         
   Comment(
       
      "nFPI     = $ ", DoubleToStr(FPIbuffer[i],4), 
   "nEJ   =  ", DoubleToStr(aVar,2),
   "nEU   =  ", DoubleToStr(bVar,4),
   "nUJ   =  ", DoubleToStr(cVar,2));
   
   return (0);
   }
}
firstly, whoever decided that it was ever a good idea to stick variable declarations anywhere amongst the actual code needs to have their neck snapped. i see it everywhere these days and it's just plain wrong on many levels..... declare variables at the start of each function, not hidden in the middle of some block of code like a fucking ninja!

with that mini-rant over.....

double FPIbuffer[]; <----- this declares FPIbuffer to be an array of doubles (but, of NO SIZE. IT CAN HOLD NO VALUES)
for(int i=0; i<limit; i++)
{

aVar = MarketInfo(Symbol1,MODE_BID);

bVar = MarketInfo(Symbol2,MODE_BID);

cVar = MarketInfo(Symbol3,MODE_BID);

FPIbuffer[i] = (aVar/bVar/cVar); <--------------- now you are trying to assign to the array at index 'i' the matching avar/bvar/cvar result. the array has no index positions to fill due to having no size, therefore, your assignment is actually writing out of bounds (or probably simply failing to write anything if mql is half-serious about itself).

at no point after declaring the array did you give it any size!!!

when people write indicators and they create variables that are then used with SetIndexBuffer to assign this array of no size to one of the indicators display buffers you have told mt4 that it is to take care of all of the sizing required. each time mt4 adds a new bar to it's current history it re-sizes it's own arrays used to hold the bar information on the charts as well as takes care of resizing any arrays that any indicators have used with setindexbuffer. just as importantly, mt4 also then takes care of shifting all data in the arrays so that the latest bar data is at index zero, and the furthest oldest data is always at arraysize-1.

you have neither statically declared the array size by saying FPIbuffer[123] (where 123 is some number declaring it's static unchanging size), or by using ArrayResize to dynamically change the buffers size, or by setting this array as some type of indicator output buffer via SetIndexBuffer() that mt4 then takes care of resizing automatically.

again, your array has NO size. you have simply declared FPIbuffer to BE an array, but it points to no actual memory that it can then read and write to via you specifying some index.

as this is an indicator you need to put a SetIndexBuffer in the Init() section so that you can a) have mt4 deal with keeping the array sized correctly as well as shifting all data one place each time a new bar forms so that the arrays data always matches the chart data index for index, and b) so that you can see the actual output! what's the point of doing this maths on new bars if you aren't doing anything with it?
Congratulations ScalaFX for coming out of the closet!
  • #12
  • Nov 17, 2011 7:45am Nov 17, 2011 7:45am
ok problem solved.Thank you very much for all guides and comments
  • #13
  • Oct 15, 2015 5:04pm Oct 15, 2015 5:04pm
Hi Codemeister
Sorry if this is not how to get in touch, but I am new and visually impaired and this is the only way I could get to contact you.
I have been following your posts and wondered if you could look and check my EA I have coded.
I need it to follow rules but find it hard to check
Please, either contact me through this post or on my private email
[email protected]
Thank you in advance for your consideration and assistance
The rules and the EA are attached
Attached File(s)
File Type: mq4 Close_Minute_EA.mq4   5 KB | 332 downloads
File Type: docx Price+Action+Scalper.docx   21 KB | 361 downloads
  • #14
  • Oct 16, 2015 11:22am Oct 16, 2015 11:22am
Quoting klhh
ok problem solved.Thank you very much for all guides and comments
but what means " but others will do " in ur initial post?
"will do " with initial code?
  • #15
  • Oct 16, 2015 11:27am Oct 16, 2015 11:27am
Quoting mjonestraini
Hi Codemeister Sorry if this is not how to get in touch, but I am new and visually impaired and this is the only way I could get to contact you. I have been following your posts and wondered if you could look and check my EA I have coded. I need it to follow rules but find it hard to check Please, either contact me through this post or on my private email [email protected] Thank you in advance for your consideration and assistance The rules and the EA are attached {file} {file}
hmm..
Hour() is a time function, Close[] contains close prices.
How you compare time and prices and which result u expect??
if((Close[60]<Hour())&&(Close[30]<Hour())&&(Close[15]<Hour())&&(Close[5]<Hour())) // Here is your open Sell rule
{
  • #16
  • Oct 17, 2015 5:35am Oct 17, 2015 5:35am
Hi
Thank you, this is beginning to make sense, so now I know this will set up the sell signal, I should be able to do it for the buy signal and try and sort out the sL and TP.

I may be back in touch very soon, as I learn more about coding.

Again, many thanks for the help
  • #17
  • Oct 18, 2015 12:51pm Oct 18, 2015 12:51pm
Ok,
but I propose to describe and discuss your strategy before coding.
Lookin like, you try to generate signal BUY/SELL as a result of comparison closes
on the 1 hour interval.
But your rule dont check the real behavior in the end of this interval...
  • #18
  • Oct 19, 2015 4:41am Oct 19, 2015 4:41am
Hi
Yes, I want to place an order if the 1 hour, 30 min, 15 min and 5 min candles close the same colour, then place a stop loss 20 pips below the order and a take profit 20 pips above the order for a buy signal and opposite for a sell signal.
Could you explain more please. This is only my 2nd EA I have tried coding and any help for me to learn more about coding will be appreciated.
  • #19
  • Nov 24, 2015 1:09pm Nov 24, 2015 1:09pm
Hi
I had some help with the ea and got it finished. But, although the strategy was around 75% profitable, it did not perform that way and was losing 75%. So, I reversed the trades to see if this would make it more profitable, but it had similar results.
Someone said it may need optimizing, but I am not sure how to do this.
Can anyone help. Can they find the most profitable settings for this ea, or, tell me if it is not worth pursuing this any further.
The EA is provided below and basically places a trade when the 4 timeframes all match the same direction
If you need any further info, plz contact me
Thanks in advance
Attached File(s)
File Type: ex4 PriceActionScalper2_EA.ex4   48 KB | 342 downloads
  • #20
  • Nov 25, 2015 9:47am Nov 25, 2015 9:47am
Quoting mjonestraini
Hi I had some help with the ea and got it finished. But, although the strategy was around 75% profitable, it did not perform that way and was losing 75%. So, I reversed the trades to see if this would make it more profitable, but it had similar results. Someone said it may need optimizing, but I am not sure how to do this. Can anyone help. Can they find the most profitable settings for this ea, or, tell me if it is not worth pursuing this any further. The EA is provided below and basically places a trade when the 4 timeframes all match the same...
hi mjonestraini,
you can search the most profitable setting by your self with optimized strategy tester in your MT4 app. i just want to say that it is pointless if you just give us here an ex4 file with no mq4. again, just look for a good setting?, do it yourself
0 traders viewing now