EA - Wait 40 pips before taking a trade

//---- input parameters  
extern double    TakeProfit=2000; //100pips 
extern double    StopLoss = 400;  //10pips
extern double    Lots=1; 
extern double    PriceOffset = 400; //40pips
bool             TradeOpenAllowed=false; 
int              MagicNumber=12345;  
//+------------------------------------------------------------------+  
//| expert initialization function                                   |  
//+------------------------------------------------------------------+  
int init()  
  {  
//----   
 
//----  
   return(0);  
  }  
//+------------------------------------------------------------------+  
//| expert deinitialization function                                 |  
//+------------------------------------------------------------------+  
int deinit()  
  {  
//----   
 
//----  
   return(0);  
  }  
 
//+------------------------------------------------------------------+  
//| expert start function                                            |  
//+------------------------------------------------------------------+  
int start()  
  {  
   if(Bars<100)  
     {  
      Print("bars less than 100");  
      return(0);    
     }  
   if(TakeProfit<10)  
     {  
      Print("TakeProfit less than 10");  
      return(0);  // check TakeProfit  
     }  
   //double PriceNow = Bid;
 
   //if ((Close[1] < iMA(NULL, NULL,55,0,MODE_EMA,PRICE_CLOSE,1)) && (PriceNow < PriceNow-PriceOffset*Point))
   if (Close[1] < iMA(NULL, NULL,55,0,MODE_EMA,PRICE_CLOSE,1))
   {
      if (TradeOpenAllowed)
      {
         //int ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,Bid+StopLoss*Point,Bid-TakeProfit*Point,"EMA",MagicNumber,0,Green);  
         int ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,0,0,0,"EMA",MagicNumber,0,Green); 
         if(ticket>=0)  
         { 
 
           if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))  
           { 
             OrderModify(ticket,0,OrderOpenPrice()+StopLoss*Point,OrderOpenPrice()-TakeProfit*Point,0,0);  
             //Print("SELL order opened : ",OrderOpenPrice()); 
             TradeOpenAllowed=false; //Don't allow further trades on this signal 
           }  
         }  
      else
         {  
            Print("Error opening SELL order : ",GetLastError());   
         }
 
      }
      else
      { 
         //Allow new trades when price above MA and last trade has closed 
         if (getOpenOrders()==0) TradeOpenAllowed=true; 
 
         if (Close[1] > iMA(NULL, NULL,55,0,MODE_EMA,PRICE_CLOSE,1)) CloseAll(3, 12345);
      }
   }
}
int getOpenOrders() 
  { 
   int myOrders = 0; 
   for (int i = OrdersTotal()-1; i >=0 ; i--) 
     { 
      if (!OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) continue; 
      if (OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber) myOrders++; 
     } 
   return(myOrders); 
  } 
void CloseAll(int Slippage, int MagicNumber) 
{
   bool closed;
   for (int i = 0; i < OrdersTotal(); i++) {
    OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
    while(IsTradeContextBusy()) Sleep(100);
    RefreshRates();
    if (OrderType() == OP_BUY && MagicNumber == OrderMagicNumber()) { 
        closed = OrderClose(OrderTicket(),OrderLots(),
         NormalizeDouble(MarketInfo(OrderSymbol(),
         MODE_BID),MarketInfo(OrderSymbol(),MODE_DIGITS)),Slippage,White);
    }
    if (OrderType() == OP_SELL && MagicNumber == OrderMagicNumber()) { 
        closed = OrderClose(OrderTicket(),OrderLots(),
         NormalizeDouble(MarketInfo(OrderSymbol(),
         MODE_ASK),MarketInfo(OrderSymbol(),MODE_DIGITS)),Slippage,White);
    }
}
} 

Quoting CodeMeister

Disliked

Look at this statement and plug in some values:
if (PriceNow < PriceNow-PriceOffset*Point)

if (1.20 < 1.20 - 40*.0001)

The statement will never evaluate to true. I think you meant to use this instead:

if (Close[1] < PriceNow-PriceOffset*Point)

Ignored

Quoting CodeMeister

Disliked

PriceOffset*Point evaluates to a price difference (0.0040) not to a price like 1.2345. PriceNow+PriceOffset*Point should do what you want.

MA = 1.25000
PriceNow = 1.2459
PriceNow+PriceOffset*Point = 1.2499

Ignored

Quoting CodeMeister

Disliked

That shows what I thought you meant, but obviously the code is not working like you intended. I took another look at it, but nothing suggested the problem. As I suggested in the previous post, you need to look the the actual calculated values in the program to see what they are and if they are what you expect. There is probably something trivial like a missing bracket or comma that is hard to spot.

Ignored

Quoting Georgebaker

Disliked

It might be easier to see what i mean on this picture below

http://johnnylai.me/Forex/ForexPictures/EMA_EA.jpg

Ignored

Quoting cyber1

Disliked

You have 2 problems with the approach you have been working on.

1. You cannot execute a Market Order at 40 pips below the current Bid/Ask unless you scan back a few bars and check your EMA and if the current Bid/Ask is 40 pips below then execute your order.

2. You'll need to check if the bar High is above the EMA and Low below, otherwise say your order was executed correctly and hits the TP and now theres no orders the EA will just open another and now you are way below the EMA(maybe this was in your EA was not able to get it to work)

The...

Ignored