jor1234's PwR always-in auto trader by Steve Hopwood | Page 6 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

SSS EA v1.0 - Auto Trader Bot 623 replies

Candle Stick Pattern Auto Trader 12 replies

PwR EVA 16 replies

Auto trader for Currenex? 2 replies

MoForce's PwR System 25 replies

Attachments: jor1234's PwR always-in auto trader by Steve Hopwood
Exit Attachments

jor1234's PwR always-in auto trader by Steve Hopwood

  • #101
  • Sep 24, 2011 5:42pm Sep 24, 2011 5:42pm
Quoting SteveHopwood
Even better. I shall invent self-cutting lawns and self-painting fences.

Then apply these technologies to hair and buildings.

Who needs forex when the wealth from such inventions lies within my grasp in the next few hours?

it would be easier than forex, thats the joke.
  • #102
  • Sep 24, 2011 5:59pm Sep 24, 2011 5:59pm
Quoting stimpy
it would be easier than forex, thats the joke.
Naaahhh. Trading is easy.

Dem prices they go up, den dey go down again, den dey go up again, den...

That's why we are all rich and providing the rest of the peasants with free advice because we are so munificent..................................................





Some time later..........................

Hey guys, I just had this lovely dream............................

  • #103
  • Sep 24, 2011 6:05pm Sep 24, 2011 6:05pm
Quoting SteveHopwood
Naaahhh. Trading is easy.

Dem prices they go up, den dey go down again, den dey go up again, den...

That's why we are all rich and providing the rest of the peasants with free advice because we are so munificent..................................................





Some time later..........................

Hey guys, I just had this lovely dream............................

hah, i know, the irony of me posting about those frequenting the eurusd / really useless thread and how if they were so good at trading they would be on the yacht with the playboy bunnies.

ahem.

anyway time to push the dream to reality.

I will look at spider tonight, there is something achievable with VQ will post on there not to spaff this thread up with lawnmowers.

oh wait......
  • #104
  • Sep 24, 2011 7:27pm Sep 24, 2011 7:27pm
Quoting SteveHopwood
Even better. I shall invent self-cutting lawns and self-painting fences.

Then apply these technologies to hair and buildings.

Who needs forex when the wealth from such inventions lies within my grasp in the next few hours?

Steve,

You can't extracate yourself now from people needing your help. You have created a name in the forex world reverbarating like an echo coming from a piano.

Seriously, forget what I have posted above. I know you have been too busy doing something else. Three of your latest scalping EAs so far have been on my radar demo doing what they are created to do, and I can't thank you enough for that. With your creation along with the latest T101 Basket from another thread that based from NB 10 are excellent choice as well.

God Bless you,

Ed
  • #105
  • Sep 24, 2011 7:45pm Sep 24, 2011 7:45pm
Hi Steve,

Maybe I should have been a bit more specific.

Quoting SteveHopwood
There is a huge problem with a 'simple' basket closure function when the bot is not a basket trader.

It is this: x instances of the bot spot that the basket tp/trailing sl has been hit and all try to close the trades at the same time. By the time the platform has finished with its resulting 'Trade context busy' error messages, the basket is about a gazillion pips back into dd. Several years after we have all died of rampaging old age.
Each EA must only manage it's own trades via magic number. Only when the total pips/$$$ of it's own trades meet the criteria can it close them and then only it's own trades. Whilst this is happening (on an individual EA basis) it would not simultaneously be trying to open conflicting or 'wasted' new trades.

Quoting SteveHopwood
Or this: bot A is assigned 'master' status (itself a process prone to disaster - I leave it to your imagination to work out why. Hint: dimwitted user error). It spots an opportunity to close the 'basket'. Whilst closing the basket, bots B and C spot a trading opportunity and open a trade. Which gums up bot A, with some more trade context errors.
The individual magic nos will mostly overcome this issue. If you are dim witted enough to run multiple EAs with the same magic numbers then you deserve the consequences...

Quoting SteveHopwood
.... Which gums up bot A, with some more trade context errors....
You should be free of 90% of these devil spawned errors when the EA's are acting only on their own trades. To exorcise any others there are some further changes you can make, I'll send you an example of what I mean.

Regards, Paul.
  • #106
  • Sep 25, 2011 3:08am Sep 25, 2011 3:08am
Quoting pah
Hi Steve,

Maybe I should have been a bit more specific.



Each EA must only manage it's own trades via magic number. Only when the total pips/$$$ of it's own trades meet the criteria can it close them and then only it's own trades. Whilst this is happening (on an individual EA basis) it would not simultaneously be trying to open conflicting or 'wasted' new trades.



The individual magic nos will mostly overcome this issue. If you are dim witted enough to run multiple EAs with the same magic numbers then you deserve the consequences...



You...
Thanks Paul. You are fairly new to my work and so probably unaware of how we have discussed this in the past.

Magic numbers do indeed make the coder's life much easier and make it possible for the user to achieve a number of things. Trouble is, they also make it obvious to the crims that the trader is using an EA. If that EA is successful, the suspicion is that the crim will take measures against it.

Also, if a previously unsuccessful trader suddenly starts making profits, said trader would prefer the crim not to know why or how. Granted, most crims are not actually card-darrying members of the Russian mafia, but their activities are largely un-regulated in most of the world and wholly un-regulated in the rest of it. The less they know about what we are doing, the better. That is why we are developing our stealth techniques, or what I jokingly call Stealth Technology.

  • #107
  • Sep 25, 2011 4:25am Sep 25, 2011 4:25am
Paul sent me some great code to get around the trade context busy errors - imaginative and looks effective. I have added this to jor and will gradually add it to other bots as I update them.

Cheers Paul. Fantastic contribution.

  • #108
  • Sep 25, 2011 7:27am Sep 25, 2011 7:27am
Quoting SteveHopwood
Magic numbers do indeed make the coder's life much easier and make it possible for the user to achieve a number of things. Trouble is, they also make it obvious to the crims that the trader is using an EA. If that EA is successful, the suspicion is that the crim will take measures against it.

Also, if a previously unsuccessful trader suddenly starts making profits, said trader would prefer the crim not to know why or how. Granted, most crims are not actually card-darrying members of the Russian mafia, but their activities are largely...
Well, I know this argument has been bandied about since neanderthal man wandered the earth trying to find a power socket for his laptop....

Here's my take on it.

Short version:

Don't worry about magic numbers but do add random text for the comment instead of using the same thing every time.

Long version:

As a professional coder (and I stand to be corrected if anyone knows for certain, not just gossip) I would be very, very, very surprised if an MT sever could not tell the difference between a trade coming in from a client terminal that was manually entered and one generated by an EA, regardless of the presence of the magic number.

There is almost certainly going to need to be part of the transaction record in the order process that identifies the origin of the trade (manual or EA) or possibly even a different server API call that's used by one versus the other.

All a crim then needs to do is consult one report or another on his server to determine what percentage of trades are coming in from which source and zero in on a particular client if he feels the need.

Although it's a different argument which I don't want to get involved in, I will say this; I don't see the incentive of an ECN type brokerage wanting to target you for trading profitably, whether manual or EA. The more you trade and the bigger the lots, the more money he makes. If you lose more, you trade less and with smaller lots until you eventually stop, there ends a portion of his income stream. The argument doesn't add up.

I'm not saying there aren't some who use various software to intercept your transactions and delay them in such a way as it benefits them financially at your expense but that again is a different variety of tinned subterranean wriggly things.

There is also a possibility that some strategies can be 'targeted' to make them less profitable (or so a crim can take an extra cut). This could just as easily be applied to manual or EA generated trades.

In my view, adding a fixed comment to the trade is probably more dangerous than using magic no's because it is easier to spot and act upon if a certain EA always uses the same comment text. What you could do here to reduce this possibility and also help to make the practice nearly impossible for the crims in future is to generate long random comments on the orders. Scanning all these against a database of known comments (if they exist) (or adding them to it) will become far too time consuming and nigh on impossible to implement with any degree of certainty.

Regards, Paul.
  • #109
  • Sep 25, 2011 8:18am Sep 25, 2011 8:18am
When I opened my first live account with Markets.com my Ea did not work.
It turned out they had to 'enable' the use of EA's serverside.
So here you go .
  • #110
  • Sep 25, 2011 8:27am Sep 25, 2011 8:27am
Quoting fate12
When I opened my first live account with Markets.com my Ea did not work.
It turned out they had to 'enable' the use of EA's serverside.
So here you go .
  • #111
  • Sep 25, 2011 9:08am Sep 25, 2011 9:08am
Latest update in post 1.

I decided that the best tack to take is to have a post-successful trade closure downtime. Before sending a trade, jor examines the History tab. If the most recent trade was a winner, then it should wait until CandlesWaitAfterTradeClosure candles have elapsed before trading again.

If the trade was a loser, jor assumes it was because of a change of signal, so beware of closing losing trades manually.

I am not sure if the code is correct. It is not working in strategy tester; I am not sure whether this is because it is my code or ST that is crap. We shall find out tomorrow.

  • #112
  • Sep 25, 2011 9:09am Sep 25, 2011 9:09am
Quoting fate12
When I opened my first live account with Markets.com my Ea did not work.
It turned out they had to 'enable' the use of EA's serverside.
So here you go .
I have participated on contents where EA use was prohibited and was using the same MT4 client as the normal one, so I'm sure they know server side, when you are using an EA, no matter if you set or not magic numbers or comments, they allways know, so better to concentrate on building a good EA that follow a good strategy, if it's good, it will harvest pips, no matter what the Crimes try to do to stop you.
  • #113
  • Sep 25, 2011 9:15am Sep 25, 2011 9:15am
Quoting SteveHopwood
Latest update in post 1.

I decided that the best tack to take is to have a post-successful trade closure downtime. Before sending a trade, jor examines the History tab. If the most recent trade was a winner, then it should wait until CandlesWaitAfterTradeClosure candles have elapsed before trading again.

If the trade was a loser, jor assumes it was because of a change of signal, so beware of closing losing trades manually.

I am not sure if the code is correct. It is not working in strategy tester; I am not sure whether this is because...
Steve ... just an advise, don't do this:

@@ -949,10 +953,12 @@ bool LookForTradeClosure()


//Actions when trade close succeeds
if (result)
{
+ //Ensure closed trade has shown up in the History tab
+ while (!OrderSelect(TicketNo, SELECT_BY_TICKET, MODE_HISTORY) ) Sleep(1000);
TicketNo = -1;
TradeExists = false;
}//if (!result)

Better than 'Sleep', just simple exit the function.

MT4 it's a full crap and when you Sleep it sleeps the ONLY thread that run all the EA's
  • #114
  • Sep 25, 2011 9:30am Sep 25, 2011 9:30am
Quoting SteveHopwood
Latest update in post 1.

I decided that the best tack to take is to have a post-successful trade closure downtime. Before sending a trade, jor examines the History tab. If the most recent trade was a winner, then it should wait until CandlesWaitAfterTradeClosure candles have elapsed before trading again.

If the trade was a loser, jor assumes it was because of a change of signal, so beware of closing losing trades manually.

I am not sure if the code is correct. It is not working in strategy tester; I am not sure whether this is because...
Steve,

A quick look at TimeElapsedIsOk().

I seem to recall that the order of trades in history is not guaranteed so it may not correctly find the latest trade first. It might be safer to loop through whilst keeping track of the ticket nos and latest order date. When you know the latest order, then select the ticket again and check the time elapsed.

Also, I think this might need brackets to work otherwise it will always be a very large number.

Inserted Code
OrderCloseTime() + [color="Red"]([/color]Period() * 60 * CandlesWaitAfterTradeClosure[color="red"])[/color];
  • #115
  • Sep 25, 2011 10:04am Sep 25, 2011 10:04am
Quoting rbetancor
so better to concentrate on building a good EA that follow a good strategy, if it's good, it will harvest pips, no matter what the Crimes try to do to stop you.
EXACTLY what needs to be done!

Khalid
  • #116
  • Sep 25, 2011 4:34pm Sep 25, 2011 4:34pm
OK, I give up. There is only so much I can do.

Here is what I am going to do.

 

  1. Let jor take its trades.
  2. Shut down jor.
  3. Allow the trades to make a decent profit and use mptm to close them.
  4. Wait until the following day and start again.

Anybody else with any better ideas is welcome to post them.

Anybody able to post any bloody code that actually works on this blasted platform is welcome to post it.

Until then guys, you are on your own. I strongly suggest you take the same attitude. Maybe then you might, just might make some profit out of this blasted robot.

Good luck. You are going to need it.

  • #117
  • Sep 25, 2011 4:36pm Sep 25, 2011 4:36pm
Quoting Khalaad
EXACTLY what needs to be done!

Khalid
What? Really? Gosh, that idea never occurred to me.

Watch what you say tonight guys. I am tired, pissed off and sick to death of this bloody platform and trying to code this bloody silly language for it. I am in the mood for a fight.
  • #118
  • Sep 25, 2011 4:44pm Sep 25, 2011 4:44pm
Quoting SteveHopwood
What? Really? Gosh, that idea never occurred to me.

Watch what you say tonight guys. I am tired, pissed off and sick to death of this bloody platform and trying to code this bloody silly language for it. I am in the mood for a fight.
I am the same dude.

It drives me round the fucking twist.

having to beat the market, beat the broker and then beat the tools (mt4) (mt4 a tool, hah!) you use is sometimes enough to launch my computers through the fucking window.
  • #119
  • Sep 25, 2011 4:52pm Sep 25, 2011 4:52pm
Quoting stimpy
I am the same dude.

It drives me round the fucking twist.

having to beat the market, beat the broker and then beat the tools (mt4) (mt4 a tool, hah!) you use is sometimes enough to launch my computers through the fucking window.
The fucking mt4 is specifically designed to drive anybody who has to actually fucking well use it up the sodding wall. All the problems it brings with it are designed into it at the specific request of the criminals who generously provide it free of charge.

Of course it is fucking well free of charge. Not even the most stupid and moronic of dimwits would actually pay for the damn thing.

All brokers are total bastards.

Anybody else wanting to vent some spleen here feel free. Better out than in.

  • #120
  • Sep 25, 2011 4:54pm Sep 25, 2011 4:54pm
Quoting SteveHopwood
The fucking mt4 is specifically designed to drive anybody who has to actually fucking well use it up the sodding wall. All the problems it brings with it are designed into it at the specific request of the criminals who generously provide it free of charge.

Of course it is fucking well free of charge. Not even the most stupid and moronic of dimwits would actually pay for the damn thing.

All brokers are total bastards.

Anybody else wanting to vent some spleen here feel free. Better out than in.

im quite happy to take a horse cart with burning pyre on the back to turf every wide boy cunt into it and parade through the city.

anyone got a cart big enough?
0 traders viewing now