My EA Creates a lot of sell orders! How can i avoid that?

//---- input parameters 
extern double    TakeProfit=130; 
extern double    StopLoss = 100; 
extern double    Lots=1; 
 
//+------------------------------------------------------------------+ 
//| expert initialization function                                   | 
//+------------------------------------------------------------------+ 
int init() 
  { 
//----  
 
//---- 
   return(0); 
  } 
//+------------------------------------------------------------------+ 
//| expert deinitialization function                                 | 
//+------------------------------------------------------------------+ 
int deinit() 
  { 
//----  
 
//---- 
   return(0); 
  } 
 
//+------------------------------------------------------------------+ 
//| expert start function                                            | 
//+------------------------------------------------------------------+ 
int start() 
  { 
//----  
   int ticket, total; 
 
   if(Bars<100) 
     { 
      Print("bars less than 100"); 
      return(0);   
     } 
   if(TakeProfit<10) 
     { 
      Print("TakeProfit less than 10"); 
      return(0);  // check TakeProfit 
     } 
 
   static int isCrossed  = 0; 
 
   if  
   (Close[1] < iMA(NULL, NULL,55,0,MODE_EMA,PRICE_CLOSE,1))  
 
   { 
      isCrossed = 1; 
   } 
 
   total  = OrdersTotal();  
   if(total < 1)  
     { 
       if(isCrossed == 1) 
         { 
            ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,Ask-StopLoss*Point,Ask+TakeProfit*Point,"EMA",12345,0,Green); 
            if(ticket>0) 
              { 
               if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice()); 
              } 
            else Print("Error opening BUY order : ",GetLastError());  
            return(0); 
         } 
 
     } 
  } 

int getOpenOrders(){

   int liOrders = 0;
   for (int i = 0; i < OrdersTotal(); i++){
     if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == false){
       continue;
     }
     if (OrderSymbol() != Symbol() || OrderMagicNumber() != MagicNumber){
       continue;
     }
     liOrders++;
   }
   return(liOrders);
}

[color=#007700]if([/color][color=#0000bb]isCrossed [/color][color=#007700]== [/color][color=#0000bb]1[/color][color=#007700])[/color]

if(isCrossed == 1 && getOpenOrders()==0)

Quoting Georgebaker

Disliked

ecntrader: Thanks for your reply! I have also defined a magic number, but same result, many trades.

Ignored

Quoting RaptorUK

Disliked

OK, to be clear, you don't mean many trades open at once . . you mean one open, then it closes, then another opens soon after and it closes, then another opens, etc ?

What do you want to happen ? after the first Order is opened and closes what has to happen before the next order is allowed to be placed ?

Ignored

Quoting Georgebaker

Disliked

I’m trying to make an EA that can take a short trade when the price is below a certain MA level

Ignored

//---- input parameters 
extern double    TakeProfit=130; 
extern double    StopLoss = 100; 
extern double    Lots=1; 
bool             TradeOpenAllowed=false;
int              MagicNumber=12345; 
//+------------------------------------------------------------------+ 
//| expert initialization function                                   | 
//+------------------------------------------------------------------+ 
int init() 
  { 
//----  
 
//---- 
   return(0); 
  } 
//+------------------------------------------------------------------+ 
//| expert deinitialization function                                 | 
//+------------------------------------------------------------------+ 
int deinit() 
  { 
//----  
 
//---- 
   return(0); 
  } 
 
//+------------------------------------------------------------------+ 
//| expert start function                                            | 
//+------------------------------------------------------------------+ 
int start() 
  { 
   if(Bars<100) 
     { 
      Print("bars less than 100"); 
      return(0);   
     } 
   if(TakeProfit<10) 
     { 
      Print("TakeProfit less than 10"); 
      return(0);  // check TakeProfit 
     } 
 
   if (Close[1] < iMA(NULL, NULL,55,0,MODE_EMA,PRICE_CLOSE,1))  
     {
      if (TradeOpenAllowed)  
        {
         //int ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,Bid+StopLoss*Point,Bid-TakeProfit*Point,"EMA",MagicNumber,0,Green); 
         int ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,0,0,0,"EMA",MagicNumber,0,Green);
         if(ticket>=0) 
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) 
              {
               OrderModify(ticket,0,OrderOpenPrice()+StopLoss*Point,OrderOpenPrice()-TakeProfit*Point,0,0); 
               Print("SELL order opened : ",OrderOpenPrice());
               TradeOpenAllowed=false; //Don't allow further trades on this signal
              } 
           } 
         else 
            Print("Error opening SELL order : ",GetLastError());  
        } 
     }
   else
      //Allow new trades when price above MA and last trade has closed
      if (getOpenOrders()==0) TradeOpenAllowed=true; 
  }
    
int getOpenOrders()
  {
   int myOrders = 0;
   for (int i = OrdersTotal()-1; i >=0 ; i--)
     {
      if (!OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) continue;
      if (OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber) myOrders++;
     }
   return(myOrders);
  } 

Quoting euclid

Disliked

If you just want one trade per MA crossing, you can do something like this:

[php]//---- input parameters
extern double TakeProfit=130;
extern double StopLoss = 100;
extern double Lots=1;
bool TradeOpenAllowed=false;
int MagicNumber=12345;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init()
{
//----

//----
return(0);
}...

Ignored