002097's PwR scalping auto trading robot by Steve Hopwood | Page 14 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trying scalping with a 1000 bucks - Scalping is expensive! 39 replies

1M & 5M Scalping System (Scalping Paradise) 21 replies

Random Auto Scalping to Profits 36 replies

PwR EVA 16 replies

MoForce's PwR System 25 replies

Attachments: 002097's PwR scalping auto trading robot by Steve Hopwood
Exit Attachments

002097's PwR scalping auto trading robot by Steve Hopwood

  • #261
  • Sep 9, 2011 3:20am Sep 9, 2011 3:20am
Hi Steve

the new hidden functionality appears to have thrown out the lot size calculations

for the lot size calculations it should still use the candle size (ie. true stop loss), it appears to be using the candle size + the hidden

this in turn then throws out the TP calculation

regards, john
  • #262
  • Sep 9, 2011 3:49am Sep 9, 2011 3:49am
Quoting jmw1970
Hi Steve

the new hidden functionality appears to have thrown out the lot size calculations

for the lot size calculations it should still use the candle size (ie. true stop loss), it appears to be using the candle size + the hidden

this in turn then throws out the TP calculation

regards, john
That is LUC inviting his buddies around for a party. Cheers.

  • #263
  • Sep 9, 2011 4:14am Sep 9, 2011 4:14am
Quoting jmw1970
Hi Steve

the new hidden functionality appears to have thrown out the lot size calculations

for the lot size calculations it should still use the candle size (ie. true stop loss), it appears to be using the candle size + the hidden
Fixed.

Possibly.

Update in post 1.

Quote
this in turn then throws out the TP calculation
Not a clue what this means. Sing out if whatever it is, is still wrong.

What about the minimum trigger candle size guys? This is an idea I have always had in the back of my mind.

Any thoughts?

  • #264
  • Sep 9, 2011 4:16am Sep 9, 2011 4:16am
Definitely we SHOULD have a minimum candle! Like BB...
I don't say
  • #265
  • Sep 9, 2011 4:17am Sep 9, 2011 4:17am
Quoting 0002097
Here's something that can probably help you. I never used it...
This is great Idea lets say I am 3 wins up regarding all trades taken. I want stop trading.

Another thing i noticed:

when i used TPpercendOfSL 150 on the account 10000 i got win = 102.80 I think it should be 150$ no matter how long pip range of the signal candle was right ?

Other time on accaount 10300.52 next win was 98.81 for TPPercent 100 it should be around 103 so i think it doesnt calculate include spread correctly and doesnt calculate account balance every time.

I just got another win on 10399 and it was 65 instead of 100 if you need pics or calculated ranges i can prepare it for you
  • #266
  • Sep 9, 2011 4:20am Sep 9, 2011 4:20am
Brilliant idea!!!

PC

Quoting SteveHopwood
Fixed.


What about the minimum trigger candle size guys? This is an idea I have always had in the back of my mind.

Any thoughts?

Less is more...
  • #267
  • Sep 9, 2011 5:03am Sep 9, 2011 5:03am
HI lizu

that is correct, it should be

i haven't checked if steve's latest fix for the sl calculation problem also fixes automatically the tp calculation, in theory it should do

if you are using the very very latest version and this still occurs then the tp is still being calculated off the hidden sl and not the actual

ie. tp actual should be a x percent of sl actual

sl given to broker should be x pips above actual for sell, x pips below for buy
tp given to broker should be x pips below actual for sell, x pips above for buy

eg: Buy at 1.41100 candle size 10 pips

SL we use is 1.41000
SL sent to broker is 1.40900 (with a 10 pip hidden value)

TP we use is 1.41200 (if using 100%, 150% is 1.41250)
TP sent to broker is 1.41300 (if using 100%, 150% is 1.41350)

again with a 10 pip hidden value


of course this is ignoring the spreads but you get the idea

Quoting lizu
This is great Idea lets say I am 3 wins up regarding all trades taken. I want stop trading.

Another thing i noticed:

when i used TPpercendOfSL 150 on the account 10000 i got win = 102.80 I think it should be 150$ no matter how long pip range of the signal candle was right ?

Other time on accaount 10300.52 next win was 98.81 for TPPercent 100 it should be around 103 so i think it doesnt calculate include spread correctly and doesnt calculate account balance every time.

I just got another win on 10399 and it was 65 instead of 100 if you...
  • #268
  • Edited 5:42am Sep 9, 2011 5:05am | Edited 5:42am
TP seems ok, but lotsize is screwed this time. Shuold open 0.54 lots or something like that, according to balance. Had opened 0.01.

Quoting jmw1970
HI lizu

that is correct, it should be

i haven't checked if steve's latest fix for the sl calculation problem also fixes automatically the tp calculation, in theory it should do

if you are using the very very latest version and this still occurs then the tp is still being calculated off the hidden sl and not the actual

ie. tp actual should be a x percent of sl actual

sl given to broker should be x pips above actual for sell, x pips below for buy
tp given to broker should be x pips below actual for sell, x pips above for buy

eg: Buy at 1.41100...
I don't say
  • #269
  • Sep 9, 2011 5:59am Sep 9, 2011 5:59am
Hi Steve

I think the problem is in LookForTradingOpportunities()

Once a pending trade is set and the trend changes to "No tradeable trend", or "none", the value of "price" in LookForTradingOpportunities() is not set and therefor equal to 0.

Neither of

if (trend == up && TradeLong)

or

if (trend == down && TradeShort)

is executed because trend is none and price remains as 0 and then

if (PendingBuy || PendingSell)
{
ObjectDelete(pendingpriceline);
ObjectCreate(pendingpriceline, OBJ_HLINE, 0, TimeCurrent(), price);
ObjectSet(pendingpriceline, OBJPROP_COLOR, Green);
ObjectSet(pendingpriceline, OBJPROP_WIDTH, 1);
ObjectSet(pendingpriceline, OBJPROP_STYLE, STYLE_DASH);

}//if (PendingBuy !! PendingSell)

draws the line at price of 0.

I verified this by using "Objects List" which then shows the pending price line with a price level of 0. So the line exists but is out of view.

Suggested fix:
ObjectCreate(pendingpriceline, OBJ_HLINE, 0, TimeCurrent(), PendingPrice);

Hope this helps!

Quoting SteveHopwood
The dashed green line represents the pending trade price. If anyone can work out why it is deleting prematurely.....
Regards, Nico
Success is a marathon, not a sprint!
  • #270
  • Sep 9, 2011 6:00am Sep 9, 2011 6:00am
Quoting dragosd1
TP seems ok, but lotsize is screwed this time. Shuold open 0.54 lots or something like that, according to balance. Had opened 0.01.
I think in: -

void HasSellFilled()

need to change, this: -

SendLot = CalculateLotSize(price, NormalizeDouble(stop - (HiddenPips * Point), Digits) );

to, this: -

SendLot = CalculateLotSize(NormalizeDouble(stop- (HiddenPips * Point), Digits), price );

EDIT: there shouldn't be a space between the st and op, but I can't delete the space???
  • #271
  • Sep 9, 2011 6:01am Sep 9, 2011 6:01am
system is not taking any trades .. after update i am getting alot of these errors under my expert tab ...

2011.09.09 06:53:18 Aurora EURUSD,M5: EURUSD OP_SELL order send failed with error(130): invalid stops
  • #272
  • Sep 9, 2011 6:05am Sep 9, 2011 6:05am
Quoting hogdustwilli
system is not taking any trades .. after update i am getting alot of these errors under my expert tab ...

2011.09.09 06:53:18 Aurora EURUSD,M5: EURUSD OP_SELL order send failed with error(130): invalid stops
I had the same on www.forex.com, make CrimmalECN = true, this worked for me.
  • #273
  • Sep 9, 2011 6:10am Sep 9, 2011 6:10am
Quoting NicoScholtz
Hi Steve

I think the problem is in LookForTradingOpportunities()

Once a pending trade is set and the trend changes to "No tradeable trend", or "none", the value of "price" in LookForTradingOpportunities() is not set and therefor equal to 0.

Neither of

if (trend == up && TradeLong)

or

if (trend == down && TradeShort)

is executed because trend is none and price remains as 0 and then

if (PendingBuy || PendingSell)
{
ObjectDelete(pendingpriceline);
ObjectCreate(pendingpriceline, OBJ_HLINE, 0, TimeCurrent(), price);
ObjectSet(pendingpriceline,...
Fantastic. Thanks. I had seen that but missed its significance. Your fix is indeed correct. You win the vouch.

Cheers

  • #274
  • Sep 9, 2011 6:14am Sep 9, 2011 6:14am
Quoting NicoScholtz
Hi Steve

I think the problem is in LookForTradingOpportunities()

Once a pending trade is set and the trend changes to "No tradeable trend", or "none", the value of "price" in LookForTradingOpportunities() is not set and therefor equal to 0.
Regards, Nico
I don't understand the code but you look like you're on the right track here.

I just watched 'A' delete a pending line and the screen message change to 'no tradeable trend' at the same time. It did not delete the pending trade from the screen message though. I had to reload 'A' to remove it.

Don't know if it helps but I hope so.

Cheers
  • #275
  • Sep 9, 2011 6:16am Sep 9, 2011 6:16am
Quoting SteveHopwood
Fantastic. Thanks. I had seen that but missed its significance. Your fix is indeed correct. You win the vouch.

Cheers



Thanks, Nico
Success is a marathon, not a sprint!
  • #276
  • Sep 9, 2011 6:17am Sep 9, 2011 6:17am
Quoting batemap
I think in: -

void HasSellFilled()

need to change, this: -

SendLot = CalculateLotSize(price, NormalizeDouble(stop - (HiddenPips * Point), Digits) );

to, this: -

SendLot = CalculateLotSize(NormalizeDouble(stop- (HiddenPips * Point), Digits), price );

EDIT: there shouldn't be a space between the st and op, but I can't delete the space???
Fabulous. Cheers.

  • #277
  • Sep 9, 2011 6:18am Sep 9, 2011 6:18am
Fix for the latest spotted by Nico and Paul is in post 1.

Thanks a gazillion guys. I was reaching the wrist-slashing stage.

  • #278
  • Sep 9, 2011 6:18am Sep 9, 2011 6:18am
Quoting SteveHopwood
The dashed green line represents the pending trade price. If anyone can work out why it is deleting prematurely, they will have a pal for ever and a vouch from me if they have not already got one.
Wohoo, I finally figured it out (I hope - don't tell my boss I spent most of the day doing this instead of work )

The PendingTrade-line will disappear when you change TF and when the candlebar changes.

If you give me more time I can probably tell you what needs to be changed (sometime during the weekend) or you can take a look at how its handled in the mq4-file I attached a couple of posts back (VisualTradeCloser).

You need to draw the line everytime there is an update for some reason
Something like:
int start(){
...
...
/* somewhere in the function that has found out there is a pending order */
if(ObjectFind(Pendingtradeline)<0){
ObjectCreate (.....);
ObjectSet (name, color,...);
}
...

Hope this helps!


Edit: Great, while I type away at this, NicoScholtz has already presented the correct solution
Hate it when work gets in the way of my interests
  • #279
  • Sep 9, 2011 6:55am Sep 9, 2011 6:55am
Quoting Skovjuul
Wohoo, I finally figured it out (I hope - don't tell my boss I spent most of the day doing this instead of work )

The PendingTrade-line will disappear when you change TF and when the candlebar changes.

If you give me more time I can probably tell you what needs to be changed (sometime during the weekend) or you can take a look at how its handled in the mq4-file I attached a couple of posts back (VisualTradeCloser).

You need to draw the line everytime there is an update for some reason
Something like:
int start(){
...
...
/* somewhere in...
Thanks for looking anyhow. Much appreciated.

  • #280
  • Sep 9, 2011 7:30am Sep 9, 2011 7:30am
Quoting batemap
I think in: -

void HasSellFilled()

need to change, this: -

SendLot = CalculateLotSize(price, NormalizeDouble(stop - (HiddenPips * Point), Digits) );

to, this: -

SendLot = CalculateLotSize(NormalizeDouble(stop- (HiddenPips * Point), Digits), price );

EDIT: there shouldn't be a space between the st and op, but I can't delete the space???

Hehe, thanks, Batemap, will fix it myself.
I don't say
0 traders viewing now