Quick fix for simple problem. Thank you : ) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Simple problem I am sure the great minds will fix in a couple of mins 2 replies

Problem Solved Thank you :) 0 replies

Hedging Question - Quick Question Looking for A Quick Answer 1 reply

Thank you thread? 6 replies

Quick fix for simple problem. Thank you : )

  • #1
  • First Post: Sep 4, 2011 4:41pm Sep 4, 2011 4:41pm
I would like to return the following variables :

1. The first bar open price of the last recorded Monday (Hour Bar).
2. The last bar close price of the last recorded Wednesday (Hour Bar).

Anybody know how to do this ? Ive tried getting the variables as they pass with :

//-------------------------------------------------------
if (currentday == 1 && currenttime == 0)

{
MondayOpenPrice = iOpen(Symbol(),PERIOD_H1,0);

}

//--------------------------------------------------------



The problem with the above is I cant always keep my metatrader running the whole week to keep these variables.
So I will need the EA to look back in history for the first recorded open price on a monday etc...



Thank you so much for your time.
  • #2
  • Edited 5:26pm Sep 4, 2011 5:23pm | Edited 5:26pm
I haven't actually coded what you are asking for, so I am not going to attempt a quick bit of code that may or may not work.

Here is the approach I would take. Use DayofWeek() to determine today's value. Monday is 1 so if today is Wed, the time difference is 2 days plus the number of hours (TimeHour()). That would give you the number of hour bars (nBars = 24*2 + TimeHour()) ago for the one you are looking for.

MondayOpenPrice = iOpen(Symbol(),PERIOD_H1,nBars);
  • #3
  • Sep 5, 2011 12:16am Sep 5, 2011 12:16am
don't make it so complicated... just search backwards until you hit the winning bar/s...

Inserted Code
int b;

b = 0;
while ((b < Bars) && (TimeDay(Time[b]) != xxxxx) && (TimeHour(Time[b]) != yyyyy)) b++;
if (b == Bars) youfailed...
else youfoundit....
Congratulations ScalaFX for coming out of the closet!
  • #4
  • Sep 5, 2011 8:08pm Sep 5, 2011 8:08pm
Quoting nubcake
don't make it so complicated... just search backwards until you hit the winning bar/s...

You shouldn't do easy unless it is the correct way.
  • #5
  • Last Post: Sep 5, 2011 11:21pm Sep 5, 2011 11:21pm
Quoting CodeMeister
You shouldn't do easy unless it is the correct way.
why would you choose an obscure way of trying to find a particular bar instead of just searching backwards? explain?

i believe the way you suggested is completely open to fuckups by things like missing data and weekend gaps and has no way to work around that. if just one bar is missing then you will overshoot the desired bar and be wrong. or am i missing something?
Congratulations ScalaFX for coming out of the closet!
0 traders viewing now