002097's PwR scalping auto trading robot by Steve Hopwood | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trying scalping with a 1000 bucks - Scalping is expensive! 39 replies

1M & 5M Scalping System (Scalping Paradise) 21 replies

Random Auto Scalping to Profits 36 replies

PwR EVA 16 replies

MoForce's PwR System 25 replies

Attachments: 002097's PwR scalping auto trading robot by Steve Hopwood
Exit Attachments

002097's PwR scalping auto trading robot by Steve Hopwood

  • #21
  • Sep 3, 2011 4:18pm Sep 3, 2011 4:18pm
Hi all ...

The error is on SendSingleTrade function, this line:

if (OrderType() != OP_BUY && OrderType() != OP_SELL)

Should be like this:

if (OrderType() != OP_BUYSTOP && OrderType() != OP_SELLSTOP)
  • #22
  • Sep 3, 2011 4:25pm Sep 3, 2011 4:25pm
Quoting jmw1970
Hi Steve

I might be reading the code wrong but I cannot see any call (that isn't commented out) to the

AutoTradeDirectionDetection() function

in which case the filters that you mention of UseH4 and UsePivot cannot be applied.

Regards, John
It is all in void AutoTradeDirectionDetection(), which is called from start(), within the if (AutomateDirection) block.

  • #23
  • Sep 3, 2011 4:30pm Sep 3, 2011 4:30pm
Quoting rbetancor
Hi all ...

The error is on SendSingleTrade function, this line:

if (OrderType() != OP_BUY && OrderType() != OP_SELL)

Should be like this:

if (OrderType() != OP_BUYSTOP && OrderType() != OP_SELLSTOP)
Thanks, but the code is saying. 'Set an expiry time if the order is any kind of pending trade, not if it is a market order'. Or in other words, 'If this is not a market order, then set an expiry time'.

This cannot be the problem; this code did not change between the expiry working before the crims shut up shop for the weekend and, and not working when they did.

I think.

  • #24
  • Sep 3, 2011 4:30pm Sep 3, 2011 4:30pm
i knew it must be me reading things wrong, for some reason my MT4 editor showed the whole code as "grayed" out, ie. comments

closed the editor, reopened it and now it is fine

cheers, john

Quoting SteveHopwood
It is all in void AutoTradeDirectionDetection(), which is called from start(), within the if (AutomateDirection) block.

  • #25
  • Sep 3, 2011 4:36pm Sep 3, 2011 4:36pm
Quoting jmw1970
i knew it must be me reading things wrong, for some reason my MT4 editor showed the whole code as "grayed" out, ie. comments

closed the editor, reopened it and now it is fine

cheers, john
The greying-out thingy drives me nuts - it happens all the time when code is more than about 3 characters long. Yet another bug the developers cannot be arsed to iron out.

The solution is to press ctrl+Home to get to the top of the code, then hold the PageDown key until you reach the end of the code. Greying-out magically disappears.

Ain't MT4/mql4 wonderful?

  • #26
  • Sep 3, 2011 4:39pm Sep 3, 2011 4:39pm
Quoting rbetancor
Hi all ...

The error is on SendSingleTrade function, this line:

if (OrderType() != OP_BUY && OrderType() != OP_SELL)

Should be like this:

if (OrderType() != OP_BUYSTOP && OrderType() != OP_SELLSTOP)
Sorry ... my fault ... what I should have said is that the If statement is not needed, because it's supposed that all pending orders that are send to the brocker, MUST have expiry set.
  • #27
  • Sep 3, 2011 4:46pm Sep 3, 2011 4:46pm
Quoting rbetancor
Sorry ... my fault ... what I should have said is that the If statement is not needed, because it's supposed that all pending orders that are send to the brocker, MUST have expiry set.
My EA's all derive from my shell EA. There is a lot of redundant code in all of them.

  • #28
  • Sep 5, 2011 3:29am Sep 5, 2011 3:29am
Quoting SteveHopwood
Ok, let's name it after your eldest. What is she called? Make up a fake if you don't want to give a real one.


I like Carolco's suggestion, Aurora sounds good!
  • #29
  • Sep 5, 2011 4:24am Sep 5, 2011 4:24am
Latest update in post 1. The expiry thingy did not work this morning, so I looked at the code and saw my error immediately.

Fixed now.

  • #30
  • Sep 5, 2011 5:04am Sep 5, 2011 5:04am
Hi Steve

I think that the "bot" needs something like a minimum SL, we have a maximum SL (15 according to the rules) maybe something like 7.5

I got today some Invalid Stop errors (130) and as this is dealt with via Pendings where the ECN status of a broker is not applicable, this can only be due to a mininum stop requirement.

This would be a small change to the CalculateLotSize() function, I will implement my own fix but maybe this is something "Aurora" should have as standard (cool name much better than the original)

Regards, John
  • #31
  • Sep 5, 2011 5:11am Sep 5, 2011 5:11am
Quoting jmw1970
Hi Steve

I think that the "bot" needs something like a minimum SL, we have a maximum SL (15 according to the rules) maybe something like 7.5

I got today some Invalid Stop errors (130) and as this is dealt with via Pendings where the ECN status of a broker is not applicable, this can only be due to a mininum stop requirement.

This would be a small change to the CalculateLotSize() function, I will implement my own fix but maybe this is something "Aurora" should have as standard (cool name much better than the original)

Regards, John
You will find the majority of invalid stop errors are generated by the market being too close to the pending price, not the stop loss.

You might like to think about what to do about those. At the mo, Aurora tries to send the trade just once; if it fails, she does not try again on the current candle.

1 winner so far today. 2nd trade looks like being a loser; we shall see.

  • #32
  • Sep 5, 2011 5:17am Sep 5, 2011 5:17am
OK, here is a possible solution

if the price is too close to the pending price there is a loop

on each iteration of the loop

if the bid/ask is now greater than the pending price (ie. should of triggered) we open a market order and exit the loop (this would mean you would have to put the CriminalisECN back as a "extern")
if the bid/ask is now futher away from the pending price (ie. pending can now be set) we set the pending and exit the loop
sleep for a second or so

now as long as the markets do actually move (ie. you still have a connection to the broker) it should only perform this loop a few times at most.

What do you think?


Quoting SteveHopwood
You will find the majority of invalid stop errors are generated by the market being too close to the pending price, not the stop loss.

You might like to think about what to do about those. At the mo, Aurora tries to send the trade just once; if it fails, she does not try again on the current candle.

1 winner so far today. 2nd trade looks like being a loser; we shall see.

  • #33
  • Sep 5, 2011 5:21am Sep 5, 2011 5:21am
For me the EURUSD trade missed it's TP by 3 pippetes - then went on to be a loser - ah well
  • #34
  • Sep 5, 2011 5:27am Sep 5, 2011 5:27am
Quoting jmw1970
OK, here is a possible solution

if the price is too close to the pending price there is a loop

on each iteration of the loop

if the bid/ask is now greater than the pending price (ie. should of triggered) we open a market order and exit the loop (this would mean you would have to put the CriminalisECN back as a "extern")
if the bid/ask is now futher away from the pending price (ie. pending can now be set) we set the pending and exit the loop
sleep for a second or so

now as long as the markets do actually move (ie. you still have a connection...
Sounds like A Plan to me. Leave it with me.

2nd trade still in and looking less sorry for itself.

  • #35
  • Sep 5, 2011 6:02am Sep 5, 2011 6:02am
Hi Steve! I did put your EA on a demo chart today (our Aurora ), but it's not taking any trades and no errors on the log, is it trading with you?
I see that you already had the "risk %", nice. If you can I would like to ask for some other options.

- Is it possible to have the possibility of "disarming" the Hh Hl, Lh Ll requirement?
I ask for this because I'm testing a similar principle with other indicators and even with manual trend detection.

- How about the option to trade without the spread on profit taking levels?
Let's imagine, a long trade with 10 pips (previous candle size)+ 1.6 tp, Aurora should have the option to only go for the 10 pips. I usually do this as the price often retracts to sl after it hits tp (with no spread...).

Another thing, what happens when, on a possible long trade the price goes fast to a value where it is not possible to place a pending buy?

Does Aurora tries to place a limit order?

How about if "she" can't put the pending buy or even a limit on the market but the price retracts bellow the price where "she" should had placed the order, does "she" takes advantage of that? That is, place a market order bellow the original rules price?
This way if she can't place the pending buy because the price quickly went above our price she should place a limit order, but if she can't do that either and the price retracts to a lower value, bellow the original order price she could place a market order taking advantage of a cheaper price.
  • #36
  • Sep 5, 2011 6:21am Sep 5, 2011 6:21am
Quoting jmw1970
OK, here is a possible solution

if the price is too close to the pending price there is a loop

on each iteration of the loop

if the bid/ask is now greater than the pending price (ie. should of triggered) we open a market order and exit the loop (this would mean you would have to put the CriminalisECN back as a "extern")
if the bid/ask is now futher away from the pending price (ie. pending can now be set) we set the pending and exit the loop
sleep for a second or so

now as long as the markets do actually move (ie. you still have a connection...
Update in post 1:

 

  1. added a maximum no of retries and no of seconds to sleep inputs .
  2. Also told A to send a market trade if the Bid moves beyond what would have been the pending fill price. I made the trigger the Bid because that is what we see on our charts; I can change the buy trades to Ask if you prefer.

  • #37
  • Sep 5, 2011 6:24am Sep 5, 2011 6:24am
Quoting 0002097
Hi Steve! I did put your EA on a demo chart today (our Aurora ), but it's not taking any trades and no errors on the log, is it trading with you?
Yes. That is why I am talking about them.
Quote
I see that you already had the "risk %", nice. If you can I would like to ask for some other options.

- Is it possible to have the possibility of "disarming" the Hh Hl, Lh Ll requirement?
I ask for this because I'm testing a similar principle with other indicators and even with manual trend detection.
Yes.

Quote
- How about the option to trade without the spread on profit taking levels?
Let's imagine, a long trade with 10 pips (previous candle size)+ 1.6 tp, Aurora should have the option to only go for the 10 pips. I usually do this as the price often retracts to sl after it hits tp (with no spread...).
Yes.

Quote
Another thing, what happens when, on a possible long trade the price goes fast to a value where it is not possible to place a pending buy?

Does Aurora tries to place a limit order?

How about if "she" can't put the pending buy or even a limit on the market but the price retracts bellow the price where "she" should had placed the order, does "she" takes advantage of that? That is, place a market order bellow the original rules price?
This way if she can't place the pending buy because the price quickly went above our price she should place...
Answered in previous post.

  • #38
  • Sep 5, 2011 6:32am Sep 5, 2011 6:32am
I just realised that I answered 'yes' to the spread thingy, but it is not included in A's tp calculation.

2nd trade just hit tp. So two winners so far; no losers yet.

  • #39
  • Sep 5, 2011 6:52am Sep 5, 2011 6:52am
Already fixed the "no trading" problem, typo on the max spread.
  • #40
  • Sep 5, 2011 6:59am Sep 5, 2011 6:59am
left on overnight. 2 winners, no losers.

Dead market today (US Bank holiday). Might tell us about functionality, but probably won't reveal much about profitability.

Aurora (great name, dude) just opened a pending order that should expire. We'll see.

Thanks, 002097 and Steve

Shake
1 trader viewing now