Watch this example and correct it | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Signs of a market maker broker and a recent example to discuss 0 replies

A very good EA and framework example 29 replies

Ratio between two indicators for example Rsi5 and Rsi10 0 replies

Need example of Delta Hedging in FX Options 0 replies

Coding Example Wanted 1 reply

Watch this example and correct it

  • #1
  • First Post: Aug 4, 2011 7:10pm Aug 4, 2011 7:10pm
if we need to do some calculations like:
(iHigh("EURUSD",PERIOD_H1,0)-OrderOpenPrice())>0.0030) and used timeframe one hour, the problem when we move to the next frame may be the condition will not be available. I need to specify iHigh for the bar that i got OrderOpenPrice from it.

some people advice me to use OrderOpenTime() and shiftbar(), but i do not know how can i used them please provide me with example and many thanks.
  • #2
  • Aug 5, 2011 8:44am Aug 5, 2011 8:44am
no coder here or programmer!!!!
any way some people told me contact FF team but i do not know who FF team and how can i contact them.
  • #3
  • Aug 5, 2011 9:28am Aug 5, 2011 9:28am
Quoting hand2010
if we need to do some calculations like:
(iHigh("EURUSD",PERIOD_H1,0)-OrderOpenPrice())>0.0030) and used timeframe one hour, the problem when we move to the next frame may be the condition will not be available. I need to specify iHigh for the bar that i got OrderOpenPrice from it.

some people advice me to use OrderOpenTime() and shiftbar(), but i do not know how can i used them please provide me with example and many thanks.

You might try something like:
Inserted Code
int shift = iBarShift("EURUSD", PERIOD_H1, OrderOpenTime());
if(iHigh("EURUSD", PERIOD_H1, shift) - OrderOpenPrice() > 0.003) {
   // do something
}
Documentation:
iBarShift (http://docs.mql4.com/series/iBarShift)
iHigh (http://docs.mql4.com/series/iHigh)
OrderOpenPrice (https://sites.google.com/site/marketformula/mql4-trading-functions/mql4-specific-order-information#OrderOpenPrice)
OrderOpenTime (https://sites.google.com/site/marketformula/mql4-trading-functions/mql4-specific-order-information#OrderOpenTime)
  • #4
  • Aug 5, 2011 10:30am Aug 5, 2011 10:30am
Thanks FXEZ,

for your real helping. thaks again
  • #5
  • Aug 31, 2011 4:36pm Aug 31, 2011 4:36pm
Hi FXEZ,

I have other question. right now i got the high for the bar that i got from it order open price (). The next quetion will be:
if i want to get the highest price after orderopenprice() was opened. Is this the correct way. Please provide me with example.

iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, [ //10//number of bars], [ //shift // starting from this bar]));

then

if (iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, [ //10//number of bars], [ //shift // starting from this bar]))- (OrderOpenPrice() > 0.003)) {
// do something
}

many thanks
int shift = iBarShift("EURUSD", PERIOD_H1, OrderOpenTime());if(iHigh("EURUSD", PERIOD_H1, shift) - OrderOpenPrice() > 0.003) { // do something}
  • #6
  • Sep 1, 2011 4:27am Sep 1, 2011 4:27am
Quoting hand2010
Hi FXEZ,

I have other question. right now i got the high for the bar that i got from it order open price (). The next quetion will be:
if i want to get the highest price after orderopenprice() was opened. Is this the correct way. Please provide me with example.

iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, [ //10//number of bars], [ //shift // starting from this bar]));
You need to do this . . .

iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, shift-1, 0));

the bar count goes from right to left . . . 0 is the current bar, shift is the iBarShift where your order opened
20 pips a day isn't too much to ask . . .
  • #7
  • Sep 3, 2011 12:17am Sep 3, 2011 12:17am
Quoting RaptorUK
You need to do this . . .

iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, shift-1, 0));

the bar count goes from right to left . . . 0 is the current bar, shift is the iBarShift where your order opened
It should be shift + 1 for the count field due to the fact that the current bar is 0 and the iHighest function returns the shift (and not the count). If the highest bar were the
current bar, iHighest should return 0. The code should be:

Inserted Code
iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, shift + 1, 0));

However if you try:

Inserted Code
Print(iHighest(NULL, 0, MODE_HIGH, 0, 0));

it appears to give the highest bar index number over the entire data series (presumably the default setting).

When I try:
Inserted Code
Print(iHighest(NULL, 0, MODE_HIGH, 1, 0));
It returns 0 as the current bar is (always) the highest of the last 1 bars. If the OP doesn't want to include the entry bar's high it should just be shift and not shift + 1.

from the help file:
Inserted Code
double val;
  // calculating the highest value on the 20 consequtive bars in the range
  // from the 4th to the 23rd index inclusive on the current chart
  val=High[iHighest(NULL,0,MODE_HIGH,20,4)];
  • #8
  • Sep 3, 2011 11:56am Sep 3, 2011 11:56am
Is this will be ok:
int shift = iBarShift("EURUSD", PERIOD_H1, OrderOpenTime());
iHigh("EURUSD", PERIOD_H1, iHighest("EURUSD", PERIOD_H1, MODE_HIGH, shift , 0));
=========
Please note that: i am not a programmer.
what i want is:
1- after i got orderopenprice, i want clculate the highest for some bars independed the below conditions not before orderopneprice after it.
2-I want the bar count goes from left to right not from right to left.
please check and correct it if wrong ( with example will be very good).
======
if ihighest - orderopenprice> 0.0030 (1.3061-1.3030)>0.0030 that mean the next condition will be ((0.0031/2)> bid) the position will close with 0.0015 proft . if ((1.3090-1.3030)/2) that mean we got 30 pips
int shift = iBarShift("EURUSD", PERIOD_H1, OrderOpenTime());
iHighest("EURUSD", PERIOD_H1, MODE_HIGH, shift-5, shift);


if ( (( iHighest - OrderOpenPrice() ) > 0.0030) && ( ((iHighest + OrderOpenPrice())/2)>MarketInfo("EURUSD",MODE_BID)) )
{ close the position };

I think if we replace shift-5 with 0, maybe it will be better. it will start with shift bar and will finish with current bar which mean the same bar.if the condition happened it will look for the second condition shift bar = 1.3061 and orderopenprice()=1.3030 that mean maybe it will close in the same bar if price reach to 1.3045 or low. if did not and moving to the next bar that mean it will keep the high for the shift bar and close in 1.3045 or low if the next bar which after shift bar give us new high like 1.3091 that mean it will close when the price reach to 1.3060 or low and so on.... please help me with nice example.
  • #9
  • Sep 3, 2011 6:00pm Sep 3, 2011 6:00pm
The bar count goes from right to left . . that is how it is, the currently forming bar is bar 0 the next bar to the left is bar 1, then bar 2, etc

What FXEZ said is correct . . . you need this . .

double HighestAfterOrder = iHigh("EURUSD", 0, iHighest("EURUSD", 0, PRICE_HIGH, shift, 0));

then use that in . . .

if ( HighestAfterOrder - OrderOpenPrice() > 0.0030 && HighestAfterOrder + (OrderOpenPrice()/2) > MarketInfo("EURUSD",MODE_BID) )
{ close the position }
20 pips a day isn't too much to ask . . .
  • #10
  • Edited Sep 5, 2011 9:31am Sep 4, 2011 9:47am | Edited Sep 5, 2011 9:31am
Inserted Code
string PriceToStr(double p){ return( DoubleToStr(p, Digits) ); }
:
datetime    OOT         = OrderOpenTime();          // Assumes OrderSelect() done already
int         iOOT        = iBarShift(NULL,0, OOT);   // Bar of the open
#define     iBarCURRENT   0                         // Include current bar
int         nSince  = iOOT - iBarCURRENT + 1;       // No. Bars Since open.
int         iHi         = iHighest(NULL,0, MODE_HIGH, nSince, iBarCURRENT);
double      HH          = High[iHi];                // Highest high.
Print( "High since order opened on ", TimeToStr(OOT)," is ", PriceToStr(HH) );
  • #11
  • Sep 4, 2011 10:17pm Sep 4, 2011 10:17pm
Here are some errors for the below code.

'(' - function definition unexpected Drogram FilesFXDD Malta - MetaTrader 4expertstest2.mq4 (343, 18)
this error for string PriceToStr(double p)
for this error i do not know how can i fix it

'iBarCurrent' - variable not defined Drogram FilesFXDD Malta - MetaTrader 4expertstest2.mq4 (348, 30)
this error because you define #define iBarCURRENT then you put it as iBarCurrent
i will fix it.

2 error(s),
  • #12
  • Sep 15, 2011 8:54pm Sep 15, 2011 8:54pm
Thanks guys.

Also i have other quesition:
How can i do this conditions: if (last OrderClosePrice() for sell > before the last OrderClosePrice for sell ) && ( before the last OrderClosePrice for sell >= bid)
close the position

is something like this will be ok
if ( (OrderType == OP_SELL)&& OrderSelect(pos+1, SELECT_BY_POS,MODE_TRADES ) ) { if( pos>pos+1 && pos+1>MarketInfo("EURUSD",MODE_BID); // close the position
  • #13
  • Sep 15, 2011 10:04pm Sep 15, 2011 10:04pm
Just,
I want to know how can i get: before the last order(open or close)price() for (buy or sell) to added them for some claculations.
Many thanks.
  • #14
  • Sep 16, 2011 2:39am Sep 16, 2011 2:39am
No answer, just I need to get the order before the last order even for buy or for sell even that order it is open order or close order,waiting for nice coder to see if he/she can do that.
  • #15
  • Sep 18, 2011 12:00pm Sep 18, 2011 12:00pm
Just i need a little help then everything will be ok.( I need to know the lastest order for buy , the lastest order for sell and the previous order for whatever buy or sell )
many thanks for you.
int LastOpenTicketForBuy(){
datetime lastTime = 0;
int lastTicket = -1; // None open.
 int magi.number=0;
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--) if (
OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
 && OrderMagicNumber() == magic.number // my magic number
 && OrderSymbol() == Symbol() // and my pair.
 && OrderOpenTime() > lastTime
&& OrderType()==OP_BUY
){
lastTime = OrderOpenTime();
lastTicket = OrderTicket();
}
return(lastTicket);
}

int LastOpenTicketForSell(){
datetime lastTime = 0;
int lastTicket = -1; // None open.
 int magi.number=0;
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--) if (
OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
 && OrderMagicNumber() == magic.number // my magic number
 && OrderSymbol() == Symbol() // and my pair.
 && OrderOpenTime() > lastTime
&& OrderType()==OP_SELL
){
lastTime = OrderOpenTime();
lastTicket = OrderTicket();
}
return(lastTicket);
}

int previousorderforbuy(){
datetime lastTime = 0;
int lastTicket = -1; // None open.
 int magi.number=0;
for(int pos--; pos >= 0 ; pos--) if (
OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
 && OrderMagicNumber() == magic.number // my magic number
 && OrderSymbol() == Symbol() // and my pair.
 && OrderOpenTime() > lastTime
&& OrderType()==OP_BUY
){
lastTime = OrderOpenTime();
lastTicket = OrderTicket();
}
return(lastTicket);
}

int previousorderforsell(){
datetime lastTime = 0;
int lastTicket = -1; // None open.
 int magi.number=0;
for(int pos--; pos >= 0 ; pos--) if (
OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
 && OrderMagicNumber() == magic.number // my magic number
 && OrderSymbol() == Symbol() // and my pair.
 && OrderOpenTime() > lastTime
&& OrderType()==OP_SELL
){
lastTime = OrderOpenTime();
lastTicket = OrderTicket();
}
return(lastTicket);
}
  • #16
  • Sep 18, 2011 8:12pm Sep 18, 2011 8:12pm
No helping !!!
  • #17
  • Sep 20, 2011 9:27am Sep 20, 2011 9:27am
Some helping please
i need create some functions for:
1- function to get and keep the last order open price for buy.
2- function to get and keep the last order open price for sell.
3- function to get and keep the last close order whatover buy or sell
i tried to find threads same like what i look for and make some change but still does not work

int LastOpenTicketForBuy(){ datetime lastTime = 0; int lastTicket = -1; // None open.
int magi.number=0;
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--)
if ( OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
&& OrderMagicNumber() == magic.number // my magic number
&& OrderSymbol() == Symbol() // and my pair.
&& OrderType()==OP_BUY )
{ lastTime = OrderOpenTime();
lastTicket = OrderTicket(); }
return(lastTicket);}

int LastOpenTicketForSell()
{ datetime lastTime = 0; int lastTicket = -1; // None open. int magi.number=0;
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--)
if ( OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
&& OrderMagicNumber() == magic.number // my magic number
&& OrderSymbol() == Symbol() // and my pair.
&& OrderType()==OP_SELL )
{ lastTime = OrderOpenTime(); lastTicket = OrderTicket(); }
return(lastTicket);}

int lastcloseorder()
{ datetime lastTime = 0; int lastTicket = -1; // None open.
int magi.number=0;
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--)
if ( OrderSelect(pos, SELECT_BY_POS) // Only my orders w/
&& OrderMagicNumber() == magic.number // my magic number
&& OrderSymbol() == Symbol() // and my pair.
&& OrderCloseTime() > lastTime
&& OrderType()==OP_BUY||OP_SELL )
{ lastTime = OrderCloseTime(); lastTicket = OrderTicket(); }
return(lastTicket);}

then i will put if ((LastOpenTicketForBuy()+LastOpenTicketForSell())/2)<MarketInfo("EURUSD",MODE_BID)Close the position
  • #18
  • Last Post: Sep 20, 2011 12:49pm Sep 20, 2011 12:49pm
guys,
please direct me. I think i am in the wrong forum. Please tell me which forum i should submit!!!!!
0 traders viewing now