Code for Closing Orders Against FIFO | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Code my expert for fifo 2 replies

Partial take profit code or EA that works with FIFO 0 replies

Almost ready EA, code works for BUY orders, but not SELL orders 6 replies

Interbank FX's FIFO Solution 1 reply

Forex EAs to stop functioning in the US following FIFO rule? 0 replies

Code for Closing Orders Against FIFO

  • #1
  • First Post: Aug 21, 2011 8:54pm Aug 21, 2011 8:54pm
Okay, here's the deal. I have a block of orders I'd like to close all at once using a general closeall in order to comply with FIFO.

Below are two scenarios that I know will close a block of orders at all once, however, does anyone know whether either will close them according to FIFO or not?

PHP Code
 for(int i=OrdersTotal()-1; i>=0; i--)
  {
     OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
     if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || cmd()>1) continue;
     OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
  }
PHP Code
 for(int i=0; i<=OrdersTotal(); i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || cmd()>1) continue;
      OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
   }
Currently I'm using the first scenario for closing out the orders, however, when I check the results tab while backtesting, it shows the last orders are being closing first so, I guess this won't work the way it is. I haven't checked the second scenario yet, so I don't know? Nor do I normally use it this way (mostly for sorting and tagging).

Anyway, I need to know what is the best (or workable) solution for going about do this?

Any ideas?


Thanks!
  • #2
  • Aug 21, 2011 9:03pm Aug 21, 2011 9:03pm
hey ec..... if for some reason you want to close orders with reguard to fifo, select by orderopentime()......h
to trade and code, keep both simple... no call to impress....h
  • #3
  • Aug 21, 2011 9:17pm Aug 21, 2011 9:17pm
Yes, I can do that, but how many cycles (or ticks) will it take for this to happen? From what I understand, it only sorts the orders once so, if it's not in chronological order the first time, then it has to wait for the next cycle (or tick) in order to catch the next order.

Or, I suppose you could create a whole series of loops like this, one right after the other, but that seems awfully redundant, especially if you have a lot of orders.
  • #4
  • Aug 21, 2011 9:53pm Aug 21, 2011 9:53pm
Is there any way of telling the loop to repeat itself until all orders are closed, based upon the OrderOpenTime()? That, I think. would be ideal.

PHP Code
 for(int i=OrdersTotal()-1; i>=0; i--; T>0)
  {
     OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
     if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || cmd()>1) continue;
     OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
  }
Or, maybe I could do something like this: where T equals the number of open orders? and possibly create a second loop within the first loop in order to determine which is the the earliest order, and find it and delete it once it is "tagged" or identified.

Hey, that almost sounds plausible ... or, at least it's worth a shot.
  • #5
  • Aug 21, 2011 11:50pm Aug 21, 2011 11:50pm
don't forget to deal with trade context busy issues, but why don't you just do something like this...

Inserted Code
function FIFOCloseAll(int magicnum, int slippagepoints) {
  int i, lowestticket;
  double cp;
  bool repeat;

  repeat = true;

  while (repeat) {
    repeat = false;
    lowestticket = -1;
    i = OrdersTotal()-1;
    while(i >= 0) {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if ((OrderSymbol() == Symbol()) && (OrderMagicNumber() == magicnum) && ((OrderType() == OP_BUY) || (OrderType() == OP_SELL))) {
        repeat = true;  //force a re-iteration to check again for another lowest number next cycle
        if (lowestticket < 0) lowestticket = OrderTicket();
        if (OrderTicket() < lowestticket) lowestticket = OrderTicket();
      }
      i--;
    }

    if (lowestticket > -1) {
      OrderSelect(lowestticket, SELECT_BY_TICKET, MODE_TRADES);
      cp = Bid;
      if (OrderType() == OP_SELL) cp = Ask;
      OrderClose(OrderTicket(), OrderLots(), NormalizeDouble(cp, Digits), NormalizeDouble(Point * slippagepoints, Digits), Orange);
    }
  }

}
Congratulations ScalaFX for coming out of the closet!
  • #6
  • Aug 22, 2011 1:36am Aug 22, 2011 1:36am
Hey, thanks, that gave me an idea ...

PHP Code
void closeall()
{
  while(total()>0)
  {
     int T=0; datetime FOOT; bool close_2=false;
     for(int i=0; i<=OrdersTotal(); i++)
     {
        OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
        if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || cmd()>1) continue;
        if(cmd()<2){ T++; if(T==1 || (T>0 && OOT()<FOOT)) FOOT=OOT(); }
        if(T==total()) close_2=true;
     }
     if(close_2)
     {
        for(i=OrdersTotal()-1; i>=0; i--)
        {
           OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
           if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || cmd()>1) continue;
           if(OOT()==FOOT){ OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
           closeall=true; break; }
        }
     }
  }
}
And here, total() is selected orders, OOT() is OrderOpenTime() and cmd() is OrderType(). And hey, the gall darn thing works!
  • #7
  • Aug 22, 2011 4:43am Aug 22, 2011 4:43am
Quoting ecTrade
Yes, I can do that, but how many cycles (or ticks) will it take for this to happen?.
hey ec...... one tick should be all it takes if properly coded....

and don't forget, lowest ticket number does not guarentee it's the oldest order.....

you must select by orderopentime() only......

//---
//---

i use ibfx so fifo does not concern me in anyway..... my orders come and go with out respect to the time they were placed...... this is a tremendous benefit even though few see it.....h
to trade and code, keep both simple... no call to impress....h
  • #8
  • Aug 22, 2011 6:41am Aug 22, 2011 6:41am
Yes, I agree, one tick is all it should take.

Also, whenever I have to sort for the earliest order, I always go with OrderOpenTime(), which is what I did with the code above.

I just thought maybe there was an easy way to specify it without creating an additional loop ... and, of course trying to figure it out. If nubcake didn't use the "while" statement, which I rarely use, it probably wouldn't have occurred to me what I needed to do.

I have an IBFX account too, so this has rarely concerned me as well. It's just that I'm creating an EA for someone else and they plan on going with another broker.
  • #9
  • Sep 10, 2011 3:08pm Sep 10, 2011 3:08pm
Quoting nubcake
don't forget to deal with trade context busy issues ...
Hey, if I place the following code just prior to OrderSend() or, in the case above, OrderClose(), this is where it should be placed, correct?

PHP Code
while(IsTradeContextBusy()) Sleep(100);
RefreshRates();
I've already been doing this with OrderSend() for some time now, and thus far it hasn't interfered with my trading. So I assumed it was the correct place to put it.

I haven't done it with the OrderClose() function, however, which is even more likely to get "congested" if there are any issues, especially if I go with multiple charts.

So yeah, it would be great to know if I was doing it correctly.

Thanks!
  • #10
  • Sep 12, 2011 5:50am Sep 12, 2011 5:50am
With respect to the code above, this is where I opted to put it (in a similar configuration). Thus far I haven't encountered any problems, so I assume it is correct.

PHP Code
 if(close_2)
     {
        for(i=OrdersTotal()-1; i>=0; i--)
        {
           OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
           if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || cmd()>1) continue;
           while(IsTradeContextBusy()){ Sleep(100); } RefreshRates();
           if(OOT()==FOOT){ OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
           closeall=true; break; }
        }
     }
  • #11
  • Last Post: Sep 14, 2011 5:25am Sep 14, 2011 5:25am
If I need to delete LIFO, the i=OrdersTotal()-1; i>=0; i-- works, and if you want the other, just while OrdersTotal() > 0 delete at position 0
0 traders viewing now