Help Needed With Simple EA Code | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

SIMPLE EA for a simple method needed!! 2 replies

Someone needed to code a simple EA 6 replies

2 simple lines of code needed, please help 18 replies

Simple close script - some help with code needed 2 replies

need help: simple code for start EA at begin of new day 1 reply

Attachments: Help Needed With Simple EA Code
Exit Attachments

Help Needed With Simple EA Code

  • #1
  • First Post: Aug 18, 2011 2:33am Aug 18, 2011 2:33am
I am coding a simple EA that I want to calculate the difference between the CLOSE of the previous bar and the Low or High of the current bar. As I use 1 min charts it sometimes gaps from the previous bars Close to the Open of the current bar. I therefore don't want it to just calculate the High and Low of the current bar.

In a nutshell I'm wanting to code the following:

- The Highest point from the Close of the previous 1 Min candle to the Close of the current candle.

- The Lowest point from the Close of the previous 1 Min candle to the Close of the current candle.

This is the code I need to amend as it simply takes the high and low of the 1 candle:
SwingHigh = iHigh(NULL, PERIOD_M1, ChartShift);
SwingLow = iLow(NULL, PERIOD_M1, ChartShift);

If that's not so easy I could look at taking the High and Low between a start and finish time if that's easier.

Help would be really appreciated.
  • #2
  • Aug 18, 2011 2:42am Aug 18, 2011 2:42am
This is as about as simple as it gets. This will look at the current and previous bars high/lows. Not sure why you used iHigh instead of High because you were looking at the chart's pair.

int nbars = 2;// or whatever

double swingHigh = High[ArrayMaximum(High, nbars, 0)];
double swingLow = Low[ArrayMinimum(Low, nbars, 0)];
  • #3
  • Aug 18, 2011 2:45am Aug 18, 2011 2:45am
Quoting CodeMeister
This is as about as simple as it gets. This will look at the current and previous bars high/lows.

int nbars = 2;// or whatever

double swingHigh = High[ArrayMaximum(High, nbars, 0)];
double swingLow = Low[ArrayMinimum(Low, nbars, 0)];
Thanks for that. Problem is my EA needs to calculate the exact difference between the exact close point of the previous candle and not include the High or Low of the actual previous candle.
  • #4
  • Aug 18, 2011 3:02am Aug 18, 2011 3:02am
I must be tired to have missed that. But I'm still not sure exactly what you are after. The previous candle is indexed 1 the current one is 0. Therefore the highest point is High[0]. It would help to post an image if its any more complicated than that.
  • #5
  • Aug 18, 2011 3:23am Aug 18, 2011 3:23am
Quoting CodeMeister
I must be tired to have missed that. But I'm still not sure exactly what you are after. The previous candle is indexed 1 the current one is 0. Therefore the highest point is High[0]. It would help to post an image if its any more complicated than that.
Sure, here's a picture. I want it to calculate the High and Low between the 2 arrows ie close of previous candle till close of current candle.
Attached Image (click to enlarge)
Click to Enlarge Name: high low chart.gif Size: 11 KB
  • #6
  • Aug 18, 2011 6:09am Aug 18, 2011 6:09am
We are obviously disconnecting somewhere because your image would indicate you are looking for the High[n], where n is the index of the bar.

I am only going to make one other attempt and let someone else take over.

Do you mean the height of the gap between the close of the bar and the high of the next one? That would be MathAbs(Close[n+1] - High[n]). But to call that a SwingHigh is absolutely wrong plus the gap is usually defined as Close[n+1] - Open[n].
  • #7
  • Last Post: Aug 18, 2011 2:56pm Aug 18, 2011 2:56pm
Quoting CodeMeister
We are obviously disconnecting somewhere because your image would indicate you are looking for the High[n], where n is the index of the bar.

I am only going to make one other attempt and let someone else take over.

Do you mean the height of the gap between the close of the bar and the high of the next one? That would be MathAbs(Close[n+1] - High[n]). But to call that a SwingHigh is absolutely wrong plus the gap is usually defined as Close[n+1] - Open[n].
Thanks CodeMeister. I think that second gap formula will work. It is my explaining that is the problem. If I add the gap formula code to your other code I think it will calculate the highest and lowest points from the start of the gap (and including the gap). I'll give it a go.

Cheers
0 traders viewing now