Attachments: Screen shot help please

Screen shot help please

#21
Aug 8, 2011 3:39am Aug 8, 2011 3:39am

futurespec
Joined May 2011 | Status: If you think I'm mad, I must be mad | 1,058 Posts

Thanks all for the input.

Still did not manage to get it to work?

This is what I ended up with...

CheckIndicatorValues()
..............
..............

if(Time[0] != mLastBar)
{
while(Volume[0] < 1)
Sleep(1000);
}

if(Indicator 1 && Indicator2 && mAlert)
{
...............
................
mFile = ...............
{
WindowRedraw();
WindowScreenShot(mFile, 1280, 1024);
}
...........
...........
}
mLastBar = Time[0];

___________________________________

Is there something glaringly stupid that I have done??
(I seem to have thrown everything at it and it still does not work 100% of the time)

If you think I'm mad, I must be mad

#22
Aug 8, 2011 3:47am Aug 8, 2011 3:47am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

Quoting futurespec

Disliked

Thanks all for the input.

Still did not manage to get it to work?

This is what I ended up with...

CheckIndicatorValues()
..............
..............

if(Time[0] != mLastBar)
{
while(Volume[0] < 1)
Sleep(1000);
}

if(Indicator 1 && Indicator2 && mAlert)
{
...............
................
mFile = ...............
{
WindowRedraw();
WindowScreenShot(mFile, 1280, 1024);
}
...........
...........
}
mLastBar = Time[0];

___________________________________

Is there something glaringly...

Ignored

dude :/

if you are checking if the tick is on a new bar or not (time[0] != mLastBar) then you have no reason to check for volume, and in fact, it wouldn't surprise me one bit if you never actually see a new bar with a volume being exactly 1. in fact, you are checking for ZERO volume so should never work! chances are mt4 won't receive some of the ticks and will instead receive an update of data that magically reports a volume value not what you would expect for something that should be sequential so forget about doing tests of bars dependent on some volume value because it will work less times than it randomly does work.

also, now just reading the help on WindowRedraw() i'm not convinced this will help at all. it might, but the help file is ambiguous and suggests it might only redraw the main window and perhaps not sub-windows... but it could be all-inclusive so it's a stalement in my mind.

Inserted Code

datetime lastbartime = 0;

init() {
}

deinit() {
}

start() {
  if (lastbartime != Time[0]) {
    lastbartime = Time[0];
    if (mywhateversignal) {
      Sleep(1000);
      WindowScreenshot(blahblah);
    }
  }
}

or, simply trigger on any time except the start of a new bar...

Inserted Code

datetime lastbartime = 0;
bool doscreenshot = false;

init() {
}

deinit() {
}

start() {
  if (doscreenshot) {
    doscreenshot = false;
    WindowScreenshot(...etc).
  }

  if (lastbartime != Time[0]) {
    lastbartime = Time[0];
    if (mywhateversignal) {
      doscreenshot = true;
    }
  }
}

Congratulations ScalaFX for coming out of the closet!

#23
Aug 8, 2011 3:54am Aug 8, 2011 3:54am

futurespec
Joined May 2011 | Status: If you think I'm mad, I must be mad | 1,058 Posts

Thanks once again Nubs.

Hope this helps others to learn from my errors.

If you think I'm mad, I must be mad

#24
Aug 8, 2011 6:34am Aug 8, 2011 6:34am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

So, it has been established that taking a screen shot in an indicator on the first tick of the new bar does not work. RedrawWindow() does not help and using the win32 API to post a chart update does not work either. The problem may be due to MT4 not finishing the chart update until after the start() function has closed. start() and chart update are running in the same thread so no amount of waiting will solve the problem. One should not call sleep in indicators as it will block the MT4 thread for all windows.

Workaround:

Use a script or EA as CodeMeister suggested.
Wait with the chart update until the next tick.

Here are two examples that wait until the next tick. One generates a tick to force a quick update but requires dll's enabled. I do not know how reliable posting a tick is. If the posted tick arrives before start exits, it will probably be ignored. So post the tick at the end of start().

Attached File(s)

screenshot-post.mq4 3 KB | 325 downloads

screenshot-tick.mq4 3 KB | 306 downloads

#25
Aug 8, 2011 6:43am Aug 8, 2011 6:43am

futurespec
Joined May 2011 | Status: If you think I'm mad, I must be mad | 1,058 Posts

Thanks Xaphod and all the others that helped. The help is really appreciated.

This really started out as a 1 liner with the expectation of possibly just 1 reply.

I think that the damned thing should now be beaten truly into submission.

If you think I'm mad, I must be mad

#26
Aug 8, 2011 9:51am Aug 8, 2011 9:51am

CodeMeister
Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts

It just this comes down to a choice. Pursuing the indicator route until success or every possibility is exhausted and still not achieving success.

Doing it with an EA and having a working solution within an hour. Literally this is possible with a few lines of code. I would clean up my code and post it but today is not possible.

#27
Aug 8, 2011 11:43am Aug 8, 2011 11:43am

futurespec
Joined May 2011 | Status: If you think I'm mad, I must be mad | 1,058 Posts

No problem CM.
Thanks anyway; if I go that route hopefully it will not be too much of a problem.

If you think I'm mad, I must be mad

#28
Last Post: Aug 10, 2011 4:46am Aug 10, 2011 4:46am

futurespec
Joined May 2011 | Status: If you think I'm mad, I must be mad | 1,058 Posts

Resorted to the EA and appears to be the only way to get the thing to work
(as at least 1 kind person (CM) suggested).

It works now so all is good.

Thanks guys.

If you think I'm mad, I must be mad

Platform Tech
/
Screen shot help please
Reply to Thread
- 1 Page 2
- 1 Page 2

0 traders viewing now

Options

Similar Threads

Screen shot help please