OrderModify problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Why ordermodify error 1? 9 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify problem 3 replies

Question about OrderModify() 2 replies

OrderModify problem

  • #1
  • First Post: Aug 2, 2011 6:16am Aug 2, 2011 6:16am
I have this piece of code:

Inserted Code
ticket = OrderSend(Symbol(), OP_SELLLIMIT, tradedLots, Bid + StopLossSell * myPoint, Slippage, 0, 0, "Sell(#" + MagicNumber + ")", MagicNumber, expiration, DeepPink);
         if(ticket>0)
            {
               if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) {
                  OrderModify(ticket, OrderOpenPrice(), 0, OrderOpenPrice() - TP * myPoint, 0, Red);
                  Print("SELL Order opened : ",OrderOpenPrice());
               }
            }
            else Print("Error opening SELL Order : ",GetLastError());

I open a pending order with expiration, then modify the order with SL and TP. The problem is that the expiration is deleted and if I put the expiration in the OrderModify, the TP will not be set.

How I can fix the code to set the SL, TP and expiration at the same time?
Today I BUY, tomorrow I SELL!
  • #2
  • Aug 2, 2011 1:34pm Aug 2, 2011 1:34pm
Most brokers don't support Expiration. You are going somewhere where very few have gone. You always "expire" the trade in the EA by calculating the expiration time and then deleting the trade when the time has come.
  • #3
  • Aug 2, 2011 2:53pm Aug 2, 2011 2:53pm
My broker supports expiration. If I set the expiration without SL and TP works, but if I put SL, TP and expiration in the same line then it doesn't I don't know why...the expiration is set for 24 hours.

Inserted Code
expiration=CurTime()+PERIOD_D1*60;
Today I BUY, tomorrow I SELL!
  • #4
  • Aug 2, 2011 3:21pm Aug 2, 2011 3:21pm
hey ecn...... use TimeCurrent()...... and it always helps when someone provides all the code upfront......

we can code or fix most anything, but need to see it in complete form.....h


Inserted Code
 
 
          expiration  = TimeCurrent()+60*60*5;   //--- expiration declared in the input section.... where 5 is number of hours
      int limit       = 2000;
 
 
   if((SellLimit && Count(OP_SELLLIMIT) == 0))     
     {
     ticket = OrderSend(Symbol(),OP_SELLLIMIT, Lots, Bid+limit*Point,0,0,0,"Sell",MagicNumber, expiration, Blue);
     if(ticket>0)
     {
     if(OrderSelect(ticket, SELECT_BY_TICKET))
     {
     OrderModify(ticket, OrderOpenPrice(), OrderOpenPrice()+ pips*Point , OrderOpenPrice()- pips*Point, OrderExpiration(), Blue );     
     }
     }
     }
to trade and code, keep both simple... no call to impress....h
  • #5
  • Aug 2, 2011 5:03pm Aug 2, 2011 5:03pm
I modified CurTime() to TimeCurrent().

Anyway, the code did not solved my problem.

I even tried to put OrderExpiration() in the OrderModify() and did not worked.

I also tried to add a second OrderModify() only for expiration, with the previous SL and TP set, by getting OrderStopLoss() and OrderTakeProfit(). Nothing.

I also got this in Journal, using OrderExpiration()

2011.08.03 00:57:07 '400935': modification of pending order #10550237 sell limit 0.10 USDCAD at 0.96620 sl: 0.00000 tp: 0.00000 -> price: 0.96620 sl: 0.00000 tp: 0.96520 failed [Invalid volume]
Today I BUY, tomorrow I SELL!
  • #6
  • Last Post: Aug 2, 2011 5:17pm Aug 2, 2011 5:17pm
timecurrent() replaced curtime() several years back.... both are ok, just best to use newest version.....

my code example works..... it places the order correctly then modifys the order correctly..... the order expires in 5 hours if not activated.....

the pips offset is declared in the inputs and adjusted for 4 or 5 digits in the int section.....

it is from a working ea.....

//---
//---

no one can say why yours does not without seeing the code and knowing the broker.....h
to trade and code, keep both simple... no call to impress....h
1 trader viewing now