OrderOpenPrice() | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Problems in getting orderopenprice 3 replies

How do I specify OrderopenPrice for two separate pairs? 2 replies

OrderOpenPrice()

  • #1
  • First Post: Jul 11, 2011 4:36pm Jul 11, 2011 4:36pm
Hi guys,

i really need a help from all of you. I already created EA. My EA work well except the below part.

Please note that: i used
1- OrdersTotal()-1 to get the last orderopenprice.
2-OrderMagicNumber()==MagicNumberLong to be sure there is still orderopenprice for the long position before the last orderopenprice.
3-OrderMagicNumber()==MagicNumberShort to be sure there is still orderopenprice for the short position before the last orderopenprice.

PHP Code
for(int i=0; i<OrdersTotal(); i++) {
    OrderSelect(OrdersTotal()-1, SELECT_BY_POS, MODE_TRADES); 
if ( (iCustom("EURUSD",PERIOD_H1,"Aroon_Up_Down(6)",6,1,0)  <  100.00000)&& (OrderMagicNumber()==MagicNumberLong) ) 
      { if ( OrderType()==OP_SELL )
          { if ((OrderOpenPrice()-0.0009)>=MarketInfo("EURUSD",MODE_BID)) 
                {  CLOSESHORT("EURUSD") ;}}}
if  ( (iCustom("EURUSD",PERIOD_H1,"Aroon_Up_Down(6)",6,0,0)  <  100.00000)&& (OrderMagicNumber()==MagicNumberShort) )
      { if ( OrderType()==OP_BUY )
          { if ((OrderOpenPrice()+0.0008)<=MarketInfo("EURUSD",MODE_BID))
                { CLOSELONG("EURUSD") ;}}}
what i want :

in the first line start with if:
if the all conditions happened & the last order type for sell do this condition OrderOpenPrice()-0.0009)>=MarketInf("EURUSD",MODE_BID)
and close the short position.

in the second line start with if:
if the all conditions happened & the last order type for buy do this condition OrderOpenPrice()+0.0008)<=MarketInfo("EURUSD",MODE_BID)
and close the long position.
=========
one more quetion:
if we need to do some calculations like:
(iHigh("EURUSD",PERIOD_H1,0)-OrderOpenPrice())>0.0030) and used timeframe one hour, the problem when we move to the next frame may be the condition will not be available. I need to specify iHigh for the bar that i got OrderOpenPrice from it.

some people advice me to use OrderOpenTime() and shiftbar(), but i do not know how can i used them please provide me with example and many thanks.
  • #2
  • Jul 11, 2011 6:01pm Jul 11, 2011 6:01pm
You need to cycle through in reverse order for this to work, like so:

for (i=OrdersTotal()-1;i>=0;i--)
Old Benjamin was right
  • #3
  • Jul 12, 2011 7:43am Jul 12, 2011 7:43am
Lou G,

Thanks.would you make some change in my code to let it work.

Thank a lot for your reply.
  • #4
  • Jul 12, 2011 10:46am Jul 12, 2011 10:46am
No helping!!!
  • #5
  • Jul 12, 2011 3:46pm Jul 12, 2011 3:46pm
Change this:

OrderSelect(OrdersTotal()-1, SELECT_BY_POS, MODE_TRADES);

to this (along with the change to the "for" statement):

OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

since you are now stepping backward through the open orders.
Old Benjamin was right
  • #6
  • Jul 13, 2011 9:57am Jul 13, 2011 9:57am
Who is experter in forex side to ask him to answer my quetion
  • #7
  • Jul 15, 2011 11:05am Jul 15, 2011 11:05am
hi, re. your pm, i am not an expert in mt4 coding, would suggest you post a request for help on popular threads with a link to this thread...
  • #8
  • Edited 10:10am Jul 16, 2011 9:54am | Edited 10:10am
Inserted Code
   if (OrdersTotal() > 0)
   {
      for (int i=OrdersTotal()-1;i>=0;i--)
      {
         if (OrderSelect(i, SELECT_BY_POS))
         {
            if (OrderSymbol()==Symbol()) [b]Replace this line with your close logic[/b]
            {
               if (!OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),0))
               {
                  int error=GetLastError();
                  Print("Error on close ",ErrorDescription(error));
                  Comment("Error on close ", ErrorDescription(error));
               }
            }               
         }
      }
   }
I hope this example helps you - I can't tell from from your code what you are trying to do.

If you are trying to close orders based on whether they are profitable or not it would better to use OrderProfit() - then you would not need to distinguish between buy or sell orders and your logic would be much simpler.

You will need to add this:

Inserted Code
#include <stderror.mqh>
#include <stdlib.mqh>

to the EA to use the error logic in the above example.
Old Benjamin was right
  • #9
  • Jul 19, 2011 1:17pm Jul 19, 2011 1:17pm
Thanks a lot Lou G,

Please Note that: I am not a programmer, what i want is:

1- if all the conditions available & the last orderopenprice() for sell
do this:
if ((OrderOpenPrice()-0.0009)>=MarketInfo("EURUSD",MODE_BID))

close the position.


thanks
  • #10
  • Last Post: Jul 19, 2011 3:35pm Jul 19, 2011 3:35pm
I received your PM.

I think we have a language barrier here:

As I said in my reply to your PM, I do not have the time or the inclination to take on custom programming projects.

I also said that I would be glad to help you here on FF but I have asked you very specific questions about what your EA is trying to do and you have not explained.

Since you are not a programmer I suggest you enlist the services of one of the many people here on FF that do contract programming.

Best,

Lou G
Old Benjamin was right
0 traders viewing now