I need help with Ehlers Sinewave

Over the past year or two I've successfully converted at least a half dozen Ehlers indicators from TradeStation (EasyLanguage) to MQL4 but this one is giving me fits.

There is a version available that runs but I don't believe it is correct because the output is so wrong (misses major trends). I can't mention the source (it's a commercial site) but googling "Ehlers Sinewave.mq4" will lead to a free download.

Attached is what I have done so far - I used the original TradeStation code from Ehlers book which can be found at the end of my code.

I have more than enough coding skill to do this job (40+ years coding in many languages) but lack the advanced math skills to know what I'm looking at. Or, maybe I just need another pair of eyes.

If someone with the necessary knowledge can help it will be greatly appreciated.

TIA,
Lou G

Hi Lou,
probably you already know this, but from this site http://www.mqlsoft.com/download/indicators you can download 25 indicators from from the book "Cybernetics Analysis for Stock and Futures"
There is an indicator called Sinewave but i don't know if is it the one you are looking for.

gspe

Yes, that's the one I did not mention because it is a commercial site

There are two versions of the indicator there neither of which appears correct to me.

Attached is an example of the questionable sinewave in action - when the blue line crosses the red line (up or down) a trade is supposed to be placed in the corresponding direction...a huge mistake in the example shown.

Either the concept of the indicator is flawed or the realization is flawed and I don't know which.

Lou

I have converted some of Ehler's indicators including the Sinewave from the TS code in the book to vb. I didn't find Sinewave to be useful - it crosses over far too many times on my data to have any value for trading. My conclusion on this indicator is that one or more of the underlying premises must be false. On the chart time frame that you posted (H1) phase must continue to advance/change causing the lines to cross over. I think this is the more common reality of the markets / time frames rather than a static phase during trends as on the stylized single (daily) chart that Ehlers repeatedly provides throughout the book.