EA Problem with hammer identification | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Ranging market identification indicator 0 replies

Trend identification and trend change spotting 8 replies

Compiler problem or code problem ? 3 replies

indicator identification 0 replies

problem, problem, is it MT4 platform or EA, Please help................ 1 reply

EA Problem with hammer identification

  • #1
  • First Post: Jun 13, 2011 11:18pm Jun 13, 2011 11:18pm
I hope someone can help with this problem. I am a very new coder and am attempting to create the logic that will recognize a hammer or inverted hammer. Once it's detecting them to my satisfaction I will continue to create the EA for orders and such.

The code is supposed to mark all candles where the close = high or close = Low. It marks some but not others. Any help would be greatly appreciated.

Does the computer see more digits in the price than we do. For example, we see 1.44551 on both the close and the high; does the computer possibly see 1.445519?

Quote
#property copyright "VMesquita"
#property indicator_chart_window // an indicator is drawn in the main chart window
#property indicator_buffers 1
int limit;
int init ()
{
//----
return(0);
}
int deinit()
{
return(0);
}
int start()
{
double O,C,H,L,O1,C1,H1,L1,O2,C2,H2,L2;
string text;
int counted_bars=IndicatorCounted();
limit=Bars-counted_bars;
//---- check for possible errors
if(counted_bars<0) {
Alert("No Bars..");
return(-1);
}
//---- last counted bar will be recounted
for(int i=1; i<limit; i++) {
O=iOpen(NULL,0,i);
C=iClose(NULL,0,i);
H=iHigh(NULL,0,i);
L=iLow(NULL,0,i);

O1=iOpen(NULL,0,i-1);
C1=iClose(NULL,0,i-1);
H1=iHigh(NULL,0,i-1);
L1=iLow(NULL,0,i-1);
O2=iOpen(NULL,0,i+1);
C2=iClose(NULL,0,i+1);
H2=iHigh(NULL,0,i+1);
L2=iLow(NULL,0,i+1);


text="";
if(((H-L)>4*(O-C))&&((C-L)/(0.001+H-L)>=0.75)&&((O-L)/(0.001+H-L)>=0.75)) text="Hang";
if(H==C)text="BUY";
if(C==L)text="SELL";

//If we found a special candlem write in the Chart
if(text!="")
{
ObjectCreate(DoubleToStr(i,0)+" label", OBJ_TEXT, 0, Time[i], H);
ObjectSetText(DoubleToStr(i,0)+" label", text, 15, "Arial", Blue);
PlaySound("wait.wav");
}
}
}

Original credit to VMesquita for code...I changed it very little.
  • #2
  • Jun 13, 2011 11:27pm Jun 13, 2011 11:27pm
Quoting MaximusPips
I hDoes the computer see more digits in the price than we do. For example, we see 1.44551 on both the close and the high; does the computer possibly see 1.445519?
You are correct in your assumption, but the tricky part is that situation doesn't happen 100% of the time. It happens often enough that you should always write code to handle it. First of all never do a equality comparison with doubles. If you must compare them, subtract one from the other and then set a tolerance such as Point which is .00001 in a 5 digit sytem. Second, use NormalizeDouble() to strip away the extraneous digits. Do this and you will avoid a lot of annoying hard to find errors.
  • #3
  • Jun 14, 2011 12:07am Jun 14, 2011 12:07am
Ok so you made that sound very easy...somehow doing it seems much harder. I won't tell you how long it took to do the very little that I did complete. Also how would I make it tolerant to a difference of .00002 between the high and the close.
  • #4
  • Jun 14, 2011 12:18am Jun 14, 2011 12:18am
You should avoid hardcoding anything in your program. Rather than comparing to .00002, compare to nps*Point, where nps is set to 2 or some number. This will make the code work on Yen pairs as well as others and make changes easier to make.

bool hammer = MathAbs(High[1] - Close[1]) < nps*Point;
  • #5
  • Jun 14, 2011 8:03pm Jun 14, 2011 8:03pm
What does the nps stand for?
  • #6
  • Jun 14, 2011 8:20pm Jun 14, 2011 8:20pm
Quoting MaximusPips
What does the nps stand for?
It's the tolerance (that you were talking about in your previous post) in points. A point is one tenth of a pip, for a 5-digit br0ker.

With a 5 digit br0ker, Point = .00001 for non-JPY pairs, and .001 for JPY pairs

Hence if you set nps to a tolerance of 2, then nps*Point will be 2 points irrespective of the pair, allowing your indy to work correctly on all pairs.
  • #7
  • Jun 15, 2011 4:10pm Jun 15, 2011 4:10pm
Thanks Hanover and CodeMeister!

I am now having a problem in that the signal isn't placed on the chart on the opening of the following bar. In one case it didn't show until 3 or 4 bars later.

Any suggestions?
  • #8
  • Jun 15, 2011 9:22pm Jun 15, 2011 9:22pm
You need to check your code first by placing a Print() statement whenever a signal is generated. Assuming that's not the problem, it could be in MT4. I have had problems with Objects when MT4 is busy or my computer is under load. I haven't seen delayed objects, always they never got created/deleted/updated.

Assume the problem is coding first.
  • #9
  • Jun 22, 2011 7:15pm Jun 22, 2011 7:15pm
Kudos to those that have taught themselves to program! I can't believe how hard this is.

This is my last attempt but I don't understand what exactly it is that I am writing. The following keeps giving me errors.

My goal is the following: place an arrow and print to the log file any time the close is within .00002 (.002 on JPY) of the high or or low. If within the high range I would want it to signal if over the 21 ema and vice versa for the low.

int start()
{
int counter=1;
for(int i=1; i<=Bars; i++)

NormalizeDouble(Close[1],5);
NormalizeDouble (High[1],5);
NormalizeDouble (Low[1],5);
double nps=2


bool High[1]-Close[1]<= nps*Point;
return(0);
  • #10
  • Jun 22, 2011 9:36pm Jun 22, 2011 9:36pm
First of all, as I told you before you can't hardcode stuff and expect it work. For instance in the NormalizeDouble() call you have 5 which doesn't work with Yen pairs. Use the predefined variable Digits instead.

I already supplied this code and it wasn't used properly.

bool hammer = MathAbs(High[1] - Close[1]) < nps*Point;

The rest of the code is incomprehensible to me. You need to properly indent code and put it in hash tags when posting.
  • #11
  • Jun 22, 2011 11:18pm Jun 22, 2011 11:18pm
Quoting MaximusPips
Kudos to those that have taught themselves to program! I can't believe how hard this is.

This is my last attempt but I don't understand what exactly it is that I am writing.
hey max..... don't let it be your last attempt..... and keep in mind quite a few on this forum have many spent years and/or many thousands of dollars in college money to learn what your trying to learn in a few months on your own......

//---

if your goal is to identify a candlestick pattern and place trades accordingly, it might be better to just code the requirements into the ea....

it's simplier and cleaner......

not clear on just what your definition of a hammer and inverted hammer are so the example below repesents a bullish engulfing pattern.....h

Inserted Code
 
 
 bool bull()
      {
      if((Close[2]<Open[2]) && (Open[1]<Close[2]) && (Close[1]>Open[2])) 
      return(true);
      else
      return(false);
      }

//---
//---


you can also use digits to satisfy differing symbols....

Inserted Code
 
NormalizeDouble(Close[1],Digits);
to trade and code, keep both simple... no call to impress....h
  • #12
  • Jun 23, 2011 12:27am Jun 23, 2011 12:27am
Codemeister,

Yes, you did supply the code and I thank you very much for your time and energy. The problem lies with me and my inability to put the pieces together to form a coherent code. Of course I'm sure you hear all the time how easy it should be to code for this or that.

I'll get back to the drawing board in an attempt to understand how the pieces need to flow. Do you know of any book etc that starts you off small and gradually gives you the pieces you need? All that I've seen make quite a few assumptions about info the learner may not be aware of.

Is C theclosest programming language to MQL?
  • #13
  • Last Post: Jun 23, 2011 12:36am Jun 23, 2011 12:36am
Thank you very much for your input as any help is very much appreciated. I'm not looking for a bullish engulfing as I am not overly concerned about the previous candle, rather I am looking for a combination of the close being within <= .00002 and the same close being >= to the 21 ema. For shorts I would be looking for the same closing strategy but under the 21 ema rather than over it.

Also I didn't realeaize I had to specify true or false. Is the same true for CodeMeister's response?

Again thanks to all!


Quoting hayseed
hey max..... don't let it be your last attempt..... and keep in mind quite a few on this forum have many spent years and/or many thousands of dollars in college money to learn what your trying to
Inserted Code
 
 
 bool bull()
      {
      if((Close[2]<Open[2]) && (Open[1]<Close[2]) && (Close[1]>Open[2])) 
      return(true);
      else
      return(false);
      }

//---
//---


you can also use digits to satisfy differing symbols....

Inserted Code
 
NormalizeDouble(Close[1],Digits);
0 traders viewing now