Loop not grabbing all orders | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

mt4 - 'While Loop Operator' issue - ( not responding ) 5 replies

Grabbing trend lines in MT4 2 replies

Is there a script for Loop orders? 0 replies

While loop in Script not updating... 1 reply

Using Bid in While Loop? 11 replies

Attachments: Loop not grabbing all orders
Exit Attachments

Loop not grabbing all orders

  • #1
  • First Post: Jun 12, 2011 9:40am Jun 12, 2011 9:40am
Hi Guys,
I am having issues with my code. I am trying to modify all open positions to have the same take profit value "x" pips away from the most recent orders open price.

I am getting ordermodify error 1, and some orders are not even being modified.
All orders are initially opened with no takeprofit value assigned, so this modification should be flowing through all orders and it is not.

Here is the code for the ordermodify:

Inserted Code
void  OrderModifications()
   {
   for(int i = (OrdersTotal()-1); i >= 0; i --)
      {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if (OrderType()==OP_BUYLIMIT && CountBuyOrders()==0)
         {
         OrderDelete(OrderTicket());
         }
//-----------------Long Order Management-------------------------------------------------
      if (OrderType()==OP_BUY && OrderSymbol()==Symbol())
         {
//----------------Modify all orders Take Profit Levels-----------------------------------
         if (CountBuyOrders()<4 && OrderTakeProfit()>LastOrder()+(120*Point))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),LastOrder()+(120*Point),0,0);
            }

Here is the code for the Last order function:
Inserted Code
double LastOrder()
   {
   int LargestTicket = 0;
   double Openprice = 0.0;
   
      for(int i = (OrdersTotal()-1); i >= 0; i --)
         {
         OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
         if (OrderType()==OP_BUY)
            {     
            if(OrderTicket() > LargestTicket)
               {
               LargestTicket = OrderTicket();
               Openprice = OrderOpenPrice();
            
               return(Openprice);
               }
            }
         }
   }
  • #2
  • Jun 12, 2011 9:56am Jun 12, 2011 9:56am
never use a for do loop if you are removing items from the list you are iterating through.

straight away in your modify function i see a call to an order delete function intended to remove certain buy_limits, but this is within a for do loop.

let's say you have 5 orders. you look at the 1st order, it meets the criteria, it is removed. everything in the list is now positioned one space down the list (due to select by pos). your loop now steps to the second item in the list, but this was originally the third item, and what WAS the second item in the list got shifted to the first position which the for loop just dealt with and has since moved-on from. each time the conditions are met that cause the orderdelete to fire you are then going to completely miss testing the next item in the list because it gets shifted to the position the for loop is currently on, but the for loop then moves forward and never gets to test this item.

use a while do loop.

Inserted Code
  int c;
  
  c = 0;
  while (c < OrdersTotal()) {
    OrderSelect(c, selectbypos,modetrades);
    if (conditionmet) {
      deleteorder;
      c--;  <------ this plus the following c++ moves the index zero spaces forcing this list/array index to be checked all over again!
    }
    c++;
  }

edit : oh, and regarding the ordermodify error... you say you are trying to set all orders to have same values to the last order you just created. no doubt your loops is hitting this last order and is trying to set it's own takeprofit to the value it already is, hence the error complaining that no value has been changed.

obviously check if the order takeprofit value is not already the same as what you want them all set to, if it's the same ignore it else change it. easy.
Congratulations ScalaFX for coming out of the closet!
  • #3
  • Jun 12, 2011 10:11am Jun 12, 2011 10:11am
Thank you for the quick reply!

I completely removed the order delete and made it into its own seperate function and I am now getting ordermodify error 1 and it is not changing the take profit levels of existing orders.
Here is the modified code:

Inserted Code
void  OrderModifications()
   {
   int total=OrdersTotal();
   for(int cnt=0;cnt<total;cnt++)
      {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
//-----------------Long Order Management-------------------------------------------------
      if (OrderType()==OP_BUY && OrderSymbol()==Symbol())
         {
//----------------Modify all orders Take Profit Levels-----------------------------------
         if (CountBuyOrders()<3 && OrderTakeProfit()!=LastOrder()+(120*Point))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),LastOrder()+(120*Point),0,0);
            }
         if (CountBuyOrders()==3 && OrderTakeProfit()!=LastOrder()+(130*Point))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),LastOrder()+(130*Point),0,0);
            }
..............
  • #4
  • Edited 10:54am Jun 12, 2011 10:37am | Edited 10:54am
dude.............

Inserted Code
double LastOrder()
   {
   int LargestTicket = 0;
   double Openprice = 0.0;
   
      for(int i = (OrdersTotal()-1); i >= 0; i --)
         {
         OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
         if (OrderType()==OP_BUY)
            {     
            if(OrderTicket() > LargestTicket)
               {
               LargestTicket = OrderTicket();
               Openprice = OrderOpenPrice();
            
               return(Openprice);
               }
            }
         }
   }
that return is going to trigger on the very first (edit : i meant "last") order in the list. this is how i would write this part :

Inserted Code
double LastOrder() {
  int LargestTicket;
  double Openprice;
  int c;

  LargetTicket = -1;
  OpenPrice = -1;

  for (c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if ((OrderType() == OP_BUY) && (OrderSymbol() == Symbol())) {
      if(OrderTicket() > LargestTicket) {
         LargestTicket = OrderTicket();
         Openprice = OrderOpenPrice();
      }
     }
  }

  return(OpenPrice);
}
now the error you get might be something to do with not normalizing the values you are testing against. use NormalizeDouble(...somevariablename..., Digits) and see how you go, especially after the fixes i've also suggested so far.
Congratulations ScalaFX for coming out of the closet!
  • #5
  • Jun 12, 2011 10:42am Jun 12, 2011 10:42am
The last order function is working properly. I have verified this multiple times by printing the functions return value and it is accurate to what I want... (which is the most recent orders open price).

I will try normalizing all the values in being sent to the modify command, i doubt this will work though since the values being pulled are orderopenprice plus a whole number i specify.
  • #6
  • Jun 12, 2011 10:53am Jun 12, 2011 10:53am
they way you have done it is still wrong. i'm not certain that the function escapes at the point or simply buffers the return value and continues to run the code until finished, but i suspect that it is meant to escape as soon as that return triggers (which is on the first order found).

it is returning the correct value to you because the way you wrote it you are starting at the LAST order in the list, which happens to be the order you want anyway. so, it hits the last order in the list first, the condition gets met and hits the return call sending back the value you expect. it never tests any orders except the very last one in the list. as far as designing something like this goes, you have designed it wrong. it works in this situation, but you should not get into the practice of doing things this way and should simply do it correctly always and avoid the pitfalls altogether of bad habits (this includes your formatting btw which is horrendous, lol)

MT4 is hokey and fickle, so something like normalizedouble might be all it needs get rid of the error issue.
Congratulations ScalaFX for coming out of the closet!
  • #7
  • Jun 12, 2011 10:59am Jun 12, 2011 10:59am
Ok, I see what your saying. I have changed it your correct formatting.
I changed the values to normalized double and it seemed to fix the issue, however now I am getting invalid stops error 130 intermittently with the order modification and some orders are still not being modified.

I have absolutely no programing background and have been learning how to code MQL4 this may be why my code is a bit sloppy, however all my ea's i have created eventually do what I want them to... it just takes me way more time to debug then it probably should

Here is what I changed the modify orders function to:

Inserted Code
      if (OrderType()==OP_BUY && OrderSymbol()==Symbol())
         {
//----------------Modify all orders Take Profit Levels-----------------------------------
         if (CountBuyOrders()<3 && OrderTakeProfit()!=NormalizeDouble(LastOrder()+(120*Point),Digits))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),NormalizeDouble(LastOrder()+(120*Point),Digits),0,0);
            }
         if (CountBuyOrders()==3 && OrderTakeProfit()!=NormalizeDouble(LastOrder()+(130*Point),Digits))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),NormalizeDouble(LastOrder()+(130*Point),Digits),0,0);
            }
         if (CountBuyOrders()==4 && OrderTakeProfit()!=NormalizeDouble(LastOrder()+(160*Point),Digits))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),NormalizeDouble(LastOrder()+(160*Point),Digits),0,0);
            }
  • #8
  • Jun 12, 2011 11:15am Jun 12, 2011 11:15am
Here is a quick pic to show you whats occurring.
I need all the orders take profits to be all the same price. It is sort of like a martingale approach except I have other things at play to limit the high risk of martingale.

at the bottom in the log you can see 3 orders3, This was just a printout that I set in place inside the ordermodify function to print out my ordercount function so I know its working correctly. so you can ignore that statement.

Here is the code which produced this failure to modify the orders.

Inserted Code
void  OrderModifications()
   {
   int total=OrdersTotal();
   for(int cnt=0;cnt<total;cnt++)
      {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
//-----------------Long Order Management-------------------------------------------------
      if (OrderType()==OP_BUY && OrderSymbol()==Symbol())
         {
//----------------Modify all orders Take Profit Levels-----------------------------------
         if (CountBuyOrders()<3 && OrderTakeProfit()!=NormalizeDouble(LastOrder()+(120*Point),Digits))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),NormalizeDouble(LastOrder()+(120*Point),Digits),0,0);
            }
         if (CountBuyOrders()==3 && OrderTakeProfit()!=NormalizeDouble(LastOrder()+(130*Point),Digits))
            {Print("3 orders",CountBuyOrders());
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),NormalizeDouble(LastOrder()+(130*Point),Digits),0,0);
            }
         if (CountBuyOrders()==4 && OrderTakeProfit()!=NormalizeDouble(LastOrder()+(160*Point),Digits))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),NormalizeDouble(LastOrder()+(160*Point),Digits),0,0);
            }
Attached Image (click to enlarge)
Click to Enlarge Name: pic.jpg Size: 506 KB
  • #9
  • Jun 12, 2011 11:40am Jun 12, 2011 11:40am
Ok, I found a work around, not as safe but I am just going to do a market order close. Rather than modify each orders take profit.

I tried it and it seems to work. I just wont always get the exact price I want.
  • #10
  • Jun 12, 2011 11:41am Jun 12, 2011 11:41am
i wonder if the price you are trying to set them to isn't too close to the the current bid/ask price, and your broker simply rejects them as such.
Congratulations ScalaFX for coming out of the closet!
  • #11
  • Jun 12, 2011 11:46am Jun 12, 2011 11:46am
That shouldnt be the case, I am using IBFX which is 3 pips, and I am modifying orders at minimum 12 pips distance from current Bid price.
  • #12
  • Jun 12, 2011 12:03pm Jun 12, 2011 12:03pm
don't know dude. stick a print before each of the ordermodify commands and make them unique like...

Print('ordermod1')
Print('ordermod2')

or even just print('a');
print('b');
print('c');

then you will see each section print and then an error will print straight after it if that's the broken ordermodify. stuff like this is tedious and usually something obvious and dumb, and neither you nor i are seeing the problem.
Congratulations ScalaFX for coming out of the closet!
  • #13
  • Jun 12, 2011 2:34pm Jun 12, 2011 2:34pm
Order modify error 1 (the "no error" error) means that you tried to modify an order and nothing was changed compared to previous state of the order, which is logical since you are trying to change the take profit without checking first if the current take profit is different at all from the one you are trying to apply

Check if it is different first (with normalization before checking) and then apply it only if it is different - you will not get that error any more
  • #14
  • Last Post: Jun 13, 2011 7:48pm Jun 13, 2011 7:48pm
i need to add my post.

i have one small quetion

how can i add this condition

if ( last OrderOpenPrice()> preview OrderOpenPrice() )

many thanks
0 traders viewing now