Attachments: ticket number not working

ticket number not working

#21
Jun 4, 2011 8:04am Jun 4, 2011 8:04am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

@ Xaphod

Quote

Disliked

Then you back up to where you open the order. Print out iTicket and run GetLastError() directly after you call OrderSend(). What is going on there?

Look to see if iTicket is being reset anywhere. Search for "iTicket=" to see where it is being set.

Generally, one should always do some error checking after order related functions. Ie check the ticket nr and run GetLastError().

cheers mate for the advice, I'll runthrough it now, it must be there somewhere!

@nubcake

Quote

Disliked

is this ea supposed to open orders on it's own automatically, or does it purely do some management of orders you manually open?

This ea handles:

new orders - position sizing, where to enter and where to set stops
open orders - it will take partial profits @ a caluclated price (algorithm is, take the stop (e.g. 30 pips), divide by 2 (15 pips), add this to entry (1.3500+0.0015=1.35015).

and I'll check out ordermodify(OrderTicket(),...) and how it related to OrderSelect.

p.s. great work on your simulator recently

@ FXEZ

Quote

Disliked

OrderSelect also returns a boolean

That may be it, I'll check that.

Quote

Disliked

Nubcake's point about using the OrderTicket() function within the OrderClose() function may be where the problem lies. The other area I would look at has to do with the number of decimals with lotsTP. Your formula multiplies lots * 0.7 and this could result in a fractional number for lotsTP like 1.03423 which will cause the order to be rejected.

Try NormalizeDouble(lotsTP,2) (if your broker has a minimum lot size of 0.01) in place of lotsTP within the OrderClose function. Use the return value (true/false) from OrderClose to debug any errors....

thats a great point. I hadn't considered that. I'll take a look

Cheers for all your time too guys, really appreciate it!

#22
Jun 4, 2011 10:03am Jun 4, 2011 10:03am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

Alright, so somehow I think I've managed to get the ticket number to get through to the equation and its working! kind of.

Inserted Code

   if(OrdersTotal()!=0)
    
   {
      tradeThisCandle=true;
      OrderSelect(iTicket, SELECT_BY_TICKET);
      
      if(OrderType()==OP_BUY)
      {
        rememberTP=memorizeH[1]+((memorizeH[1]-memorizeL[1])*TP);
        Print(rememberTP);
         if(Bid>=rememberTP && endLoop==false) {
            OrderClose(iTicket, NormalizeDouble(lotsTP,2), Bid, 5);
            GetLastError();
            endLoop=true;
         }
         
      }
      
          if(OrderType()==OP_SELL)
      {
        rememberTP=memorizeL[1]-((memorizeH[1]-memorizeL[1])*TP);
        Print(rememberTP);
         if(Ask<=rememberTP && endLoop==false) 
         GetLastError();
         {
            OrderClose(iTicket, NormalizeDouble(lotsTP,2), Ask, 5);
            GetLastError(); 
            endLoop=true;
         }
         
      }
     }

now when I try it out, it makes a propper order, then closes 70% of it right away, instead of waiting until price is either =< or => rememberTP.

The code looks perfect so I dunno why its doing this, I mean if you make an order at say 1.35, and said take partial profits at 1.3450, you'd expect it to wait until then to take partial profits. Not close them right away.

I've attached a picture of the problem to better display what I mean.

Attached Image (click to enlarge)

Click to Enlarge

Name: Weird trade.jpg
Size: 235 KB

#23
Jun 4, 2011 10:09am Jun 4, 2011 10:09am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

here's the full updated script for anyone wanting to try it out.

Inserted Code

 
//+------------------------------------------------------------------+
//|                                         Pre-Order Manager EA.mq4 |
//|                                                           Scotty |
//|                                        [url]http://www.metaquotes.net[/url] |
//+------------------------------------------------------------------+
#property copyright "Scotty"
#property link      "[url]http://www.metaquotes.net[/url]"
/* This EA will take Scalpers order and manage it until it hits it's first TP, You will have to watch the ema spacing for it. Activate once ema spacing is good*/
/* Known Issues */
/* (1)The high low function doesn't seem to be accurate, a swing high is created if a bar has two bars before and after it with lower highs by at least 1 full pip
Vice Versa for a swing low. I've tried fixing this by subtracing 0.0001 to if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) as shown below. 
            if(iHigh(Symbol(), period, shift)-0.0001<iHigh(Symbol(), period, j))
            
            This creates an error log in the journal saying it can't divide by zero. I'm not sure why this is occuring.
            
     (2) The EA doesn't set a partial close at 0.5stop. it can't seem to find the ticket number.
     
     (3) High low function declares two swing high's and swing low's then won't do anymore.
            
*/
extern int StrictLevel=2;
extern int Breakout_Definition=0;
extern double PercentRisk=3.5;
extern double TP=0.5; // if its gbp put this as 1 //keep in mind this is different than whichorder in post-order manager
/* Global Variables */
int period=PERIOD_M5;
double memorizeH[];
double memorizeL[];
int wherefirst_h, wherefirst_l;
double var, drawh, drawl;
bool moddedYet=false, tradeThisCandle=false, filled_long=false, filled_short=false, midway=false, endLoop=false;
double rememberTP, rememberSL, l;
string bought="Order filled long";
string sold="Order filled short";
/*                  */
/* This is Strat's code for determining the break of a high or low */
int localHighLow(string mode, int untilWhen, int n)
{
   double highlow;
   int shift, i, j, count=1;
   bool yet=true;
   
   if(mode=="High")
   {
      for(i=n+1;i<untilWhen;i++)
      {
         yet=true;
         shift=iBarShift(Symbol(),period, Time[i]);
         highlow=iHigh(Symbol(), period, shift); 
         for(j=shift-n;j<=shift+n;j++)
         {
            if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) {
               yet=false;
               break;
            }           
         }
         
         if(yet==true) {
            memorizeH[count]=iHigh(Symbol(), period, shift);
            count++;
            if(count==2) wherefirst_h=i;
         }   
      }
   }
   
   if(mode=="Low")
   {
      for(i=n+1;i<untilWhen;i++)
      {
         yet=true;
         shift=iBarShift(Symbol(),period, Time[i]);
         highlow=iLow(Symbol(), period, shift); 
         for(j=shift-n;j<=shift+n;j++)
         {
            if(iLow(Symbol(), period, shift)>iLow(Symbol(), period, j)) {
               yet=false;
               break;
            }           
         }
         
         if(yet==true) {
            memorizeL[count]=iLow(Symbol(), period, shift);
            count++;
            if(count==2) wherefirst_l=i;
         }   
      }
   }   
   
   return(count);
}
/** Purpose: determining whether a level is broken (mode="Long" or "Short")
* Returns true if the level was broken, false otherwise */
bool breakout(string mode, double level)
{
   double price = MarketInfo(Symbol(), MODE_BID);
   var=false;
   if(mode=="Long")
      if(/*(price>=level+10*0.0001) ||*/ (price>=level+Breakout_Definition*0.0001) && Open[0]<level)
         var=true;
   
   if(mode=="Short")
      if(/*(price<=level-10*0.0001) ||*/ (price<=level-Breakout_Definition*0.0001) && Open[0]>level)
         var=true;
   
   return (var);
}
int init()
{
   // Resets Arrays
   ArrayResize(memorizeH, Bars);
   ArrayInitialize(memorizeH, 0);
   ArrayResize(memorizeL, Bars);
   ArrayInitialize(memorizeL, 0);
   Comment("Pre-Order Manager is ready to trade");
   int x=localHighLow("High", 150, StrictLevel);int y=localHighLow("Low", 150, StrictLevel);
   ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
   ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
   ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
   ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
   drawh=memorizeH[1];
   drawl=memorizeL[1];
   return(0);
}
  
int deinit()
{
   Comment("");
   ObjectDelete("Swing High");
   ObjectDelete("Swing Low");
    
   return(0);
}
int start()
{

 
   double acc=AccountEquity();
   int iTicket;
   int lows = localHighLow("High", 150, StrictLevel); 
   int highs = localHighLow("Low", 150, StrictLevel);
   double cci=iCCI(Symbol(), period, 24, PRICE_TYPICAL, 0);   
/*Money Management function*/   
   double ris=acc*(PercentRisk/100);
   double stop=(memorizeH[1]-memorizeL[1])*100000;
   double lots=ris/stop;
   double lotsTP=lots*0.7;
/*                         */

   
   Comment("Pre-Order Manager is ready to trade");
   
   /*Order Conditions Below*/
   if(OrdersTotal()==0 && tradeThisCandle==false)                
   {
      moddedYet=false;
      if(Ask<=memorizeH[1]+Breakout_Definition*0.0001 && !(Ask>memorizeH[1]+Breakout_Definition*0.0001) && cci>=90)                              
         filled_long=true;
      else if(Ask>memorizeH[1]+Breakout_Definition*0.0001 !(cci>=90))
         filled_long=false; 
    
      if(Bid>=memorizeL[1]-Breakout_Definition*0.0001 && !(Bid<memorizeL[1]-Breakout_Definition*0.0001) && cci<=-90)
         filled_short=true;
      else if(Bid<memorizeL[1]-Breakout_Definition*0.0001 !(cci<=-90))
         filled_short=false;  
         
     /*Welcome to our Order cannons ;)*/      
           
      if(breakout("Long", memorizeH[1]) && filled_long==true) 
      {
         rememberSL=(memorizeL[1]-(3*0.0001));
         iTicket=OrderSend(Symbol(), OP_BUY, lots, Ask, 1*0.0001, (memorizeL[1]-(3*0.0001)), 0);
         GetLastError();
         Print(iTicket); 
         endLoop=false;    
         
      }
      
      if(breakout("Short", memorizeL[1]) && filled_short==true) 
      {
         rememberSL=(memorizeH[1]+(3*0.0001));
         iTicket=OrderSend(Symbol(), OP_SELL, lots, Bid, 1*0.0001, (memorizeH[1]+(3*0.0001)), 0);
         GetLastError();
         Print(iTicket);
         endLoop=false;          
        
      }
      
      /* This part of the code will close out 70% of your position at your first TP*/
      
    if(OrdersTotal()!=0)
    
   {
      tradeThisCandle=true;
      OrderSelect(iTicket, SELECT_BY_TICKET);
      
      if(OrderType()==OP_BUY)
      {
        rememberTP=memorizeH[1]+((memorizeH[1]-memorizeL[1])*TP);
        Print(rememberTP);
         if(Bid>=rememberTP && endLoop==false) {
            OrderClose(iTicket, NormalizeDouble(lotsTP,2), Bid, 5);
            GetLastError();
            endLoop=true;
         }
         
      }
      
          if(OrderType()==OP_SELL)
      {
        rememberTP=memorizeL[1]-((memorizeH[1]-memorizeL[1])*TP);
        Print(rememberTP);
         if(Ask<=rememberTP && endLoop==false) 
         GetLastError();
         {
            OrderClose(iTicket, NormalizeDouble(lotsTP,2), Ask, 5);
            GetLastError(); 
            endLoop=true;
         }
         
      }
     } 
      
         if(memorizeH[1]!=drawh || memorizeL[1]!=drawl)
   {
      ObjectDelete("Swing High");
      ObjectDelete("Swing Low");
      ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
      ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
      ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
      ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
      drawh=memorizeH[1];
      drawl=memorizeL[1];
   }
   }   
   
   
   
   
   
   
   
   }

#24
Jun 4, 2011 11:17am Jun 4, 2011 11:17am

FXEZ
Joined Jan 2007 | Status: developing... | 974 Posts

Starting bracket in wrong place for: if(Ask<=rememberTP && endLoop==false)

Inserted Code

if(OrderType()==OP_SELL)
      {
        rememberTP=memorizeL[1]-((memorizeH[1]-memorizeL[1])*TP);
        Print(rememberTP);
         if(Ask<=rememberTP && endLoop==false) 
         GetLastError();
         {
            OrderClose(iTicket, NormalizeDouble(lotsTP,2), Ask, 5);
            GetLastError(); 
            endLoop=true;
         }
         
      }

fixed with a little help on error reporting and bracket format:

Inserted Code

if(OrderType()==OP_SELL) {
        rememberTP=memorizeL[1]-((memorizeH[1]-memorizeL[1])*TP);
        Print(rememberTP);
         if(Ask<=rememberTP && endLoop==false) {
            if(OrderClose(iTicket, NormalizeDouble(lotsTP,2), Ask, 5) == false) {
                Print("Error closing 70% of sell: " + GetLastError()); 
            } else {
               endLoop=true;
            }
         }
         
      }

#25
Edited 11:57am Jun 4, 2011 11:37am | Edited 11:57am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

I've plugged that in but its not closing 70% of the position at all anymore. Not coming up with any errors either.

#26
Jun 4, 2011 12:29pm Jun 4, 2011 12:29pm

FXEZ
Joined Jan 2007 | Status: developing... | 974 Posts

Quoting scottyfromau

Disliked

I've plugged that in but its not closing 70% of the position at all anymore. Not coming up with any errors either.

Ignored

If you're not getting any errors and not getting any closes, then this condition must never be true:

Inserted Code

if(Ask<=rememberTP && endLoop==false) {

#27
Jun 4, 2011 4:22pm Jun 4, 2011 4:22pm

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting scottyfromau

Disliked

I've plugged that in but its not closing 70% of the position at all anymore. Not coming up with any errors either.

Ignored

It looks like the block of code used to close the order is inside the block of code which opens the order and that block of code does not get called if there is an order open. It is not apparent because the code is not formatted properly. You need to format/indent your code properly. If you do not, you end up with such problems and also other programmers are less likely to review your code.
http://en.wikipedia.org/wiki/Indent_style

On an unrelated not you are not using GetlastError() correctly. See FXEZ's comments and examples on how to use it.

#28
Jun 4, 2011 10:16pm Jun 4, 2011 10:16pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

i suspect somewhere along the way you have simply tossed-in a few { to make it compile... the formatting in this entire thing is horrible, and as someone above mentioned there was a section that would never trigger because it was within the wrong block of code but this was not apparent due to the way it was all formatted.

can i suggest that anyone looking at this please start by using this version i have just spent the last hour cleaning-up...

Inserted Code

 
//+------------------------------------------------------------------+
//|                                         Pre-Order Manager EA.mq4 |
//|                                                           Scotty |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Scotty"
#property link      "http://www.metaquotes.net"
/* This EA will take Scalpers order and manage it until it hits it's first TP, You will have to watch the ema spacing for it. Activate once ema spacing is good*/
/* Known Issues */
/* (1)The high low function doesn't seem to be accurate, a swing high is created if a bar has two bars before and after it with lower highs by at least 1 full pip
Vice Versa for a swing low. I've tried fixing this by subtracing 0.0001 to if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) as shown below. 
            if(iHigh(Symbol(), period, shift)-0.0001<iHigh(Symbol(), period, j))
            
            This creates an error log in the journal saying it can't divide by zero. I'm not sure why this is occuring.
            
     (2) The EA doesn't set a partial close at 0.5stop. it can't seem to find the ticket number.
     
     (3) High low function declares two swing high's and swing low's then won't do anymore.
            
*/
extern int StrictLevel = 2;
extern int Breakout_Definition = 0;
extern double PercentRisk = 3.5;
extern double TP = 0.5; // if its gbp put this as 1 //keep in mind this is different than whichorder in post-order manager
// Global Variables
int period = PERIOD_M5;
double memorizeH[];
double memorizeL[];
int wherefirst_h, wherefirst_l;
double var, drawh, drawl;
bool moddedYet = false, tradeThisCandle = false, filled_long = false, filled_short = false, midway = false, endLoop = false;
double rememberTP, rememberSL, l;
string bought = "Order filled long";
string sold = "Order filled short";

double Pip;
#include <stderror.mqh>
#include <stdlib.mqh>


// This is Strat's code for determining the break of a high or low
int localHighLow(string mode, int untilWhen, int n) {
  double highlow;
  int shift, i, j, count=1;
  bool yet=true;
   
  if(mode=="High") {
    for(i = n + 1; i < untilWhen; i++) {
      yet = true;
      shift = iBarShift(Symbol(),period, Time[i]);
      highlow = iHigh(Symbol(), period, shift); 
      for(j = shift - n; j <= shift + n; j++) {
        if(iHigh(Symbol(), period, shift) < iHigh(Symbol(), period, j)) {
          yet = false;
          break;
        }           
      }
         
      if(yet == true) {
        memorizeH[count] = iHigh(Symbol(), period, shift);
        count++;
        if(count == 2) wherefirst_h = i;
      }   
    }
   }
   
   if(mode == "Low") {
     for(i = n + 1; i < untilWhen; i++) {
       yet = true;
       shift = iBarShift(Symbol(),period, Time[i]);
       highlow = iLow(Symbol(), period, shift); 
       for(j = shift - n; j <= shift + n;j++) {
         if(iLow(Symbol(), period, shift) > iLow(Symbol(), period, j)) {
           yet = false;
           break;
          }           
       }
         
       if(yet == true) {
         memorizeL[count] = iLow(Symbol(), period, shift);
         count++;
         if(count == 2) wherefirst_l=i;
       }   
     }
   }   
   
   return(count);
}

// Purpose: determining whether a level is broken (mode="Long" or "Short").
// Returns true if the level was broken, false otherwise
bool breakout(string mode, double level) {
  double price = MarketInfo(Symbol(), MODE_BID);
  var = false;
  if(mode == "Long") {
    if(/*(price>=level+10*0.0001) ||*/ (price >= level + Breakout_Definition * Pip) && (Open[0] < level)) {
      var = true;
    }
   
    if(mode == "Short") {
      if(/*(price<=level-10*0.0001) ||*/ (price <= level - Breakout_Definition * Pip) && (Open[0] > level)) {
        var = true;
      }
    }
  }
   
  return(var);
}

int init() {
  // Resets Arrays
  ArrayResize(memorizeH, Bars);
  ArrayInitialize(memorizeH, 0);
  ArrayResize(memorizeL, Bars);
  ArrayInitialize(memorizeL, 0);
  Comment("Pre-Order Manager is ready to trade");
  int x = localHighLow("High", 150, StrictLevel);
  int y = localHighLow("Low", 150, StrictLevel);
  ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
  ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
  ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
  ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
  drawh=memorizeH[1];
  drawl=memorizeL[1];
  
  Pip = Point;
  if ((Digits == 3) || (Digits == 5)) Pip = Point * 10;  
  
  return(0);
}
  
int deinit() {
  Comment("");
  ObjectDelete("Swing High");
  ObjectDelete("Swing Low");
    
  return(0);
}

int start() { 
  double acc = AccountEquity();
  int iTicket;
  int lows = localHighLow("High", 150, StrictLevel); 
  int highs = localHighLow("Low", 150, StrictLevel);
  double cci=iCCI(Symbol(), period, 24, PRICE_TYPICAL, 0);   
// Money Management function   
  double ris = acc * (PercentRisk / 100);
  double stop = (memorizeH[1] - memorizeL[1]) * 100000;
  double lots = ris / stop;
  double lotsTP = lots * 0.7;
   
  Comment("Pre-Order Manager is ready to trade");
   
  //Order Conditions Below
  if((OrdersTotal() == 0) && (tradeThisCandle == false)) {
    moddedYet = false;
    if((Ask <= memorizeH[1] + Breakout_Definition * Pip) && !(Ask > memorizeH[1] + Breakout_Definition * Pip) && (cci >= 90)) {
      filled_long=true;
    } else {
      if((Ask > memorizeH[1] + Breakout_Definition * Pip) !(cci >= 90)) {
        filled_long=false;
      }
    }
    
    if((Bid >= memorizeL[1] - Breakout_Definition * Pip) && !(Bid < memorizeL[1] - Breakout_Definition * Pip) && (cci <= -90)) {
      filled_short=true;
    } else {
      if((Bid < memorizeL[1] - Breakout_Definition * Pip) && !(cci <= -90)) {
        filled_short=false;  
      }
    }

         
    //Welcome to our Order cannons ;)      
           
    if(breakout("Long", memorizeH[1]) && (filled_long == true)) {
      rememberSL = memorizeL[1] - (3 * Pip);
      iTicket = OrderSend(Symbol(), OP_BUY, lots, Ask, 1 * Pip, (memorizeL[1] - (3 * Pip)), 0);
Print("a: last error = ", ErrorDescription(GetLastError()));
Print("a: ticket number = ", iTicket); 
      endLoop = false;         
    }
      
    if(breakout("Short", memorizeL[1]) && (filled_short == true)) {
      rememberSL = memorizeH[1] + (3 * Pip);
      iTicket = OrderSend(Symbol(), OP_SELL, lots, Bid, 1 * Pip, (memorizeH[1] +(3 * Pip)), 0);
Print("b: last error = ", ErrorDescription(GetLastError()));
Print("b: ticket number = ", iTicket);
      endLoop = false;        
    }     
  }
      
  // This part of the code will close out 70% of your position at your first TP
      
  if(OrdersTotal() > 0) {
    tradeThisCandle = true;
    OrderSelect(iTicket, SELECT_BY_TICKET);
      
    if(OrderType() == OP_BUY) {
      rememberTP = memorizeH[1] + ((memorizeH[1] - memorizeL[1]) * TP);
Print("c: rememberTP = ", rememberTP);
      if((Bid >= rememberTP) && (endLoop == false)) {
        OrderClose(iTicket, NormalizeDouble(lotsTP, 2), Bid, 5);
Print("c: last error = ", ErrorDescription(GetLastError()));
        endLoop = true;
      }         
    }
      
    if(OrderType() == OP_SELL) {
      rememberTP = memorizeL[1] - ((memorizeH[1] - memorizeL[1]) * TP);
Print("d: rememberTP = ", rememberTP);
      if((Ask <= rememberTP) && (endLoop == false)) {
        OrderClose(iTicket, NormalizeDouble(lotsTP, 2), Ask, 5);
Print("d: last error = ", ErrorDescription(GetLastError()));
        endLoop = true;
      }         
    } 
      
    if((memorizeH[1] != drawh) || (memorizeL[1] != drawl)) {
      ObjectDelete("Swing High");
      ObjectDelete("Swing Low");
      ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
      ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
      ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
      ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
      drawh = memorizeH[1];
      drawl = memorizeL[1];
    }
  } 
} //end of start function

scotty - thx for the note about my sim. as you can tell i'm at least somewhat skooled in how to get shit done in terms of coding, so have a look through ALL of the above and you might find some things you can incorporate into your own style.

some things i have done to the script which i can remember are

1. FORMAT FORMAT FORMAT. use spaces between stuff. don't do a=b+c-d, instead go a = b + c - d. it makes it easier to read, and easier to debug and find any little errors.

2. never ever use /* blah blah */ sections for comments if you can help it, which is virtually always. when you use /* */ sections it makes it impossible to use this form of commenting to purposely comment-out sections of code when debugging because it's not like { } sections that always match to each other. a /* opens a comment block that ends as soon as the compiler finds a */. if you have a /* */ section inside of another /* */ block the comment block inside the outer comment block actually causes the compiler to end the commenting of the outer comment block...

Inserted Code

/*  
  commented out stuff
  /*
    another comment block inside the outer comment block
  */  <----- this looks like it should only undo the previous comment block start but actually ends ALL commented sections
  
  more commented out stuff from the main comment block, but the compiler treats this as not being commented out
*/  <---- this is meant to end the main outer comment block, but because of the previous ending for the 'inner comment block' the compiler will complain about this being here

3. again, use brackets to enclose math or logic blocks. you will see i've added a few brackets here and there

4. never ever do this...

Inserted Code

if (something)
  code;
blahblah;

if you are going to put the THEN part of an IF test onto a new line then always open an IF logic section with curly brackets {}. it makes it more readable, but also means that you either have an if then section on one line, or you have an if block.

Inserted Code

if (something) dosomething;

if (somethingelse) {
  dosomethingelse;
}

if (moretests) {
  a;
  b;
  c;
}

5. if using print, or comment, to do debugging then actually don't format this like normal code. stick it right at the left-hand edge to make them easy to find, firstly for debugging purposes, and secondly so you can comment them out or delete when you don't want them anymore. also, you will note that i have put a different letter at the start of each print statement depending on the section of code they are in. this means if you are expecting to see a particular block of code to print data and you don't see it printing then you can straight-away go to that block of code and debug.

6. you save yourself heaps of lines and make things more readable if you stick the opening curly bracket of a function or if test at the end of the function name or if test.

Inserted Code

int function test() {
}

if(abcd = 123) {
}

instead of....

int function test()
{
}

if ()
{
}

can't think of anything else at the moment. have a look at what i've changed-around and see what you can find that is better than what you had.

Congratulations ScalaFX for coming out of the closet!

#29
Jun 4, 2011 10:22pm Jun 4, 2011 10:22pm

FXEZ
Joined Jan 2007 | Status: developing... | 974 Posts

Quoting nubcake

Disliked

5. if using print, or comment, to do debugging then actually don't format this like normal code. stick it right at the left-hand edge to make them easy to find, firstly for debugging purposes, and secondly so you can comment them out or delete when you don't want them anymore.

Ignored

Thanks for the tip!

#30
Jun 5, 2011 3:24am Jun 5, 2011 3:24am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

fxez - no worries... the more crucial part is putting the unique identifier in each debug print/comment/ whatever text out. it's not really an issue on small projects, but once things start taking-on size and separate units/files then you generally create a dedicated debug type of function that spits text to screen or to a file. when i do this i have a descriptor as one parameter sent and then the actual debug text.

e.g. in a big project of mine i have something encroaching 20,000 lines of code across something like 10 or so different included files. when i need to send a specific error message or debug message i have a dedicated function for these that take 2 parameters, and let's say i have some unexpected situation in a 3d rendering file i would spit out to the error function something like Engine_Error("Renderer3D.pas, Sort function", "target " + inttostr(target) + " is >= arraysize of " + inttostr(arraysize));

the engine_error func then spits to screen and / or file / whatever "error in Renderer3D.pas @ Sort function : target 5 is >= arraysize of 2";

reading this back tells me everything i need to know about what just went wrong and where to start looking backwards from. this is all pseudo as i haven't looked at it for awhile, but the concept is how i do it.

.....

scotty - i just remembered 2 more things i changed that you should take note of

1. NEVER use "else if". it makes reading and debugging code impossible as the logic behind the different sections becomes confusing. if i remember correctly MS Basic actually had Else If as a part of the If syntax, but everywhere since then they are 2 separate logic block statements.

imagine trying to debug something like

Inserted Code

if (test) {
  dosomething;
} else if (test2) {
  if (asdf) lkjlkj;
  dosomethingelse;
  if (bbasfd) {
    if (uio) {
      func1;
    else if(test5) {
      a--;
    }
  }  
} else if (test3) {
  do3;
  blahblah;
} else if (test 4) {
  morestuff;
}}}}

it doesn't make sense and is not readable due to the different if, then, else blocks and the if, else if, blocks. have one if, then, else block be completely it's own thing and then have any other blocks inside of these, or have them completely separate if they can be put outside of the first if block.

Inserted Code

if () {
  asdf;
} else {
  if() {
    asdf;
  } else {
    if () {
      asdf;
    } else {
      asdf;
    }
  }
}

in this way it is easier to read and perceive the tree of If blocks.

2. it was hardcoded that 1 pip = 0.0001. this isn't always the case, just look at a jpy pair and you will see either 2 or 3 digits depending on your broker. you'll note that i created a variable named Pip and set it as 1 Point value, or if detecting that the feed is a 3 or 5 digit pair then a Point in this case is a pipette therefore the Pip value is set to 10 x Point. now it should be functional on any broker and on any chart (jpy pairs included).

Congratulations ScalaFX for coming out of the closet!

#31
Edited Jun 6, 2011 12:12am Jun 5, 2011 11:06pm | Edited Jun 6, 2011 12:12am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

i've changed a few more things around... but i'm pretty-much over this ea and ready to leave it to others capable hands.

i've done some script that will track if an order can have a partial profit close done on it, or if it has already had this done and so should be left alone for manual close or manual trailing stop etc... my understanding is that this is the entire point of this ea. HOWEVER, my scripting is being nerfed by the rest of the ea and i assume it's the "endloop" variable being the issue. i don't understand the purpose of this variable and how it relates to the rest of the ea. the way it currently stands the ea never opens any orders on its own so i assume once that part is working then my ticket tracking will also work correctly. anyway, the whole iTicket issue is gone since i killed that variable entirely.

i can manually trigger a buy or sell, and i can see that it does the partial close at least to begin with, but after that it all goes down the toilet and even manually opened trades seem to stop doing partial closes.

i've removed the LotsTP variable as this was calculating incorrectly and pointless anyway if you only want to close 70% of whatever lotsize is being used on each order

anyway, i think i'm done with this unless someone else gets it going further.

edit : wait, i just noticed i broke my own code.... removed code sample

edit2 : ok i think i fixed what i broke of my own code. the partial take-profit code that was already there is still broken. plus, i believe whatever money-management you are trying to implement is possibly broken and wrong. i suspect the math on both of these are broken in similar ways which is further breaking the partial take-profit code. i'm guessing that you are expecting some form of partial close once breaking out of the yellow bars a certain distance, but through some broken math the value you are setting as the partial close level is exponentially larger than you mean it to be... i'm purely guessing though.

Inserted Code

 
//+------------------------------------------------------------------+
//|                                         Pre-Order Manager EA.mq4 |
//|                                                           Scotty |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Scotty"
#property link      "http://www.metaquotes.net"
/* This EA will take Scalpers order and manage it until it hits it's first TP, You will have to watch the ema spacing for it. Activate once ema spacing is good*/
/* Known Issues */
/* (1)The high low function doesn't seem to be accurate, a swing high is created if a bar has two bars before and after it with lower highs by at least 1 full pip
Vice Versa for a swing low. I've tried fixing this by subtracing 0.0001 to if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) as shown below. 
            if(iHigh(Symbol(), period, shift)-0.0001<iHigh(Symbol(), period, j))
            
            This creates an error log in the journal saying it can't divide by zero. I'm not sure why this is occuring.
            
     (2) The EA doesn't set a partial close at 0.5stop. it can't seem to find the ticket number.
     
     (3) High low function declares two swing high's and swing low's then won't do anymore.
            
*/
extern int StrictLevel = 2;
extern int Breakout_Definition = 0;
extern double PercentRisk = 3.5;
extern double TP = 0.5; // if its gbp put this as 1 //keep in mind this is different than whichorder in post-order manager
/* Global Variables */
int period = PERIOD_M5;
double memorizeH[];
double memorizeL[];
int wherefirst_h, wherefirst_l;
double var, drawh, drawl;
bool moddedYet = false, tradeThisCandle = false, filled_long = false, filled_short = false, midway = false, endLoop = false;
double rememberTP, rememberSL, l;
string bought = "Order filled long";
string sold = "Order filled short";

//int iTicket;

int TicketArray[];  //stores active ticket numbers
bool IgnoreArray[];  //ignore matching ticket number as partial takeprofit has already been done

double Pip;
#include <stderror.mqh>
#include <stdlib.mqh>


/*                  */
/* This is Strat's code for determining the break of a high or low */
int localHighLow(string mode, int untilWhen, int n) {
  double highlow;
  int shift, i, j, count=1;
  bool yet=true;
   
  if(mode=="High") {
    for(i = n + 1; i < untilWhen; i++) {
      yet = true;
      shift = iBarShift(Symbol(),period, Time[i]);
      highlow = iHigh(Symbol(), period, shift); 
      for(j = shift - n; j <= shift + n; j++) {
        if(iHigh(Symbol(), period, shift) < iHigh(Symbol(), period, j)) {
          yet = false;
          break;
        }           
      }
         
      if(yet == true) {
        memorizeH[count] = iHigh(Symbol(), period, shift);
        count++;
        if(count == 2) wherefirst_h = i;
      }   
    }
   }
   
   if(mode == "Low") {
     for(i = n + 1; i < untilWhen; i++) {
       yet = true;
       shift = iBarShift(Symbol(),period, Time[i]);
       highlow = iLow(Symbol(), period, shift); 
       for(j = shift - n; j <= shift + n;j++) {
         if(iLow(Symbol(), period, shift) > iLow(Symbol(), period, j)) {
           yet = false;
           break;
          }           
       }
         
       if(yet == true) {
         memorizeL[count] = iLow(Symbol(), period, shift);
         count++;
         if(count == 2) wherefirst_l=i;
       }   
     }
   }   
   
   return(count);
}

/** Purpose: determining whether a level is broken (mode="Long" or "Short")
* Returns true if the level was broken, false otherwise */
bool breakout(string mode, double level) {
  double price = MarketInfo(Symbol(), MODE_BID);
  var = false;
  if(mode == "Long") {
    if(/*(price>=level+10*0.0001) ||*/ (price >= level + Breakout_Definition * Pip) && (Open[0] < level)) {
      var = true;
    }
   
    if(mode == "Short") {
      if(/*(price<=level-10*0.0001) ||*/ (price <= level - Breakout_Definition * Pip) && (Open[0] > level)) {
        var = true;
      }
    }
  }
   
  return(var);
}

int init() {
  // Resets Arrays
  ArrayResize(memorizeH, Bars);
  ArrayInitialize(memorizeH, 0);
  ArrayResize(memorizeL, Bars);
  ArrayInitialize(memorizeL, 0);
  Comment("Pre-Order Manager is ready to trade");
  int x = localHighLow("High", 150, StrictLevel);
  int y = localHighLow("Low", 150, StrictLevel);
  ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
  ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
  ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
  ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
  drawh=memorizeH[1];
  drawl=memorizeL[1];
  
  ArrayResize(TicketArray, 0);
  ArrayResize(IgnoreArray, 0);
  
  Pip = Point;
  if ((Digits == 3) || (Digits == 5)) Pip = Point * 10;  
  
  return(0);
}
  
int deinit() {
  Comment("");
  ObjectDelete("Swing High");
  ObjectDelete("Swing Low");
      
  return(0);
}

bool f_IgnoreTicket(int TicketNum) {
  int c;
  bool r;
  
  r = false;
  for(c = 0; c < ArraySize(TicketArray); c++) {
    if (TicketNum == TicketArray[c]) {
      r = IgnoreArray[c];
    }
  }
}

bool f_TicketIsInArray(int TicketNum) {
  int c;
  bool r;
  
  r = false;
  for(c = 0; c < ArraySize(TicketArray); c++) {
    if (TicketNum == TicketArray[c]) {
      r = true;
    }
  }  
  
  return(r);
}

int AddTicketToArray(int TicketNum, bool Ignore) {
  int c;
  c = ArraySize(TicketArray) + 1;
  ArrayResize(TicketArray, c);
  ArrayResize(IgnoreArray, c);
  
  TicketArray[c-1] = TicketNum;
  IgnoreArray[c-1] = Ignore;
Print("add ticket to array : added ticket ", TicketNum, " with ignore setting ", Ignore);  

  return(0);
}

int RemoveDeadTickets() {
  int c, c2, size;
  bool found;
  
  c = 0;
  size = ArraySize(TicketArray);
  while(c < size) {
    found = false;
    for(c2 = 0; c2 < OrdersTotal(); c2++) {
      OrderSelect(c2, SELECT_BY_POS, MODE_TRADES);
      if (TicketArray[c] == OrderTicket()) found = true;
    }
    
    if (!found) {
Print("remove dead ticket : ticket ", TicketArray[c], " not found in open orders, removing.");
      TicketArray[c] = TicketArray[size-1];
      IgnoreArray[c] = IgnoreArray[size-1];
      ArrayResize(TicketArray, size-1);
      ArrayResize(IgnoreArray, size-1);
      c--;  //force this index to recheck
    }
  
    c++;
    size = ArraySize(TicketArray);
  }
  
  return(0);
}

int start() { 
  double acc = AccountEquity();
  int lows = localHighLow("High", 150, StrictLevel); 
  int highs = localHighLow("Low", 150, StrictLevel);
  double cci=iCCI(Symbol(), period, 24, PRICE_TYPICAL, 0);   
// Money Management function   
  double ris = acc * (PercentRisk / 100);
  double stop = (memorizeH[1] - memorizeL[1]) * 100000;
  double lots = ris / stop;
//  double lotsTP = lots * 0.7;

  int c, c2, tempindex;

  double debugsignal;
  
  debugsignal = 0;
  if (GlobalVariableCheck("debugsignal")) {
    debugsignal = GlobalVariableGet("debugsignal");
  }
  GlobalVariableSet("debugsignal", 0);  //reset
  
  //1 = buy, 2 = sell, 3 = buy and sell
  if ((debugsignal == 1) || (debugsignal == 3)) {
//    iTicket = OrderSend(Symbol(), OP_BUY, 1, Ask, 0, Bid - Pip*10, 0, "", 12345, 0, Blue);
    OrderSend(Symbol(), OP_BUY, lots, Ask, 1 * Pip, (memorizeL[1] - (3 * Pip)), 0);
Print("debugsignal: lots = ", lots);
Print("debugsignal: last error = ", ErrorDescription(GetLastError()));    
  }
  if ((debugsignal == 2) || (debugsignal == 3)) {
//    iTicket = OrderSend(Symbol(), OP_SELL, 1, Bid, 0, Ask + Pip*10, 0, "", 12345, 0, Red);
    OrderSend(Symbol(), OP_SELL, lots, Bid, 1 * Pip, (memorizeH[1] +(3 * Pip)), 0);
Print("debugsignal: lots = ", lots);    
Print("debugsignal: last error = ", ErrorDescription(GetLastError()));    
  }
  if (debugsignal == 5) {
    while (OrdersTotal() > 0) {
      OrderSelect(0, SELECT_BY_POS, MODE_TRADES);
      OrderClose(OrderTicket(), OrderLots(), Bid, 100000, Purple);
    }  
  }
   
  Comment("Pre-Order Manager is ready to trade");
   
  //Order Conditions Below
  if((OrdersTotal() == 0) && (tradeThisCandle == false)) {
    moddedYet = false;
    if((Ask <= memorizeH[1] + Breakout_Definition * Pip) && !(Ask > memorizeH[1] + Breakout_Definition * Pip) && (cci >= 90)) {
      filled_long = true;
    } else {
      if((Ask > memorizeH[1] + Breakout_Definition * Pip) !(cci >= 90)) {
        filled_long = false;
      }
    }
    
    if((Bid >= memorizeL[1] - Breakout_Definition * Pip) && !(Bid < memorizeL[1] - Breakout_Definition * Pip) && (cci <= -90)) {
      filled_short=true;
    } else {
      if((Bid < memorizeL[1] - Breakout_Definition * Pip) && !(cci <= -90)) {
        filled_short=false;  
      }
    }
         
    //Welcome to our Order cannons ;)      
           
    if(breakout("Long", memorizeH[1]) && (filled_long == true)) {
      rememberSL = memorizeL[1] - (3 * Pip);
      OrderSend(Symbol(), OP_BUY, lots, Ask, 1 * Pip, (memorizeL[1] - (3 * Pip)), 0);
Print("a: last error = ", ErrorDescription(GetLastError()));
//Print("a: ticket number = ", iTicket); 
      endLoop = false;         
    }
      
    if(breakout("Short", memorizeL[1]) && (filled_short == true)) {
      rememberSL = memorizeH[1] + (3 * Pip);
      OrderSend(Symbol(), OP_SELL, lots, Bid, 1 * Pip, (memorizeH[1] +(3 * Pip)), 0);
Print("b: last error = ", ErrorDescription(GetLastError()));
//Print("b: ticket number = ", iTicket);
      endLoop = false;        
    }     
  }  
/////

  RemoveDeadTickets();

  //search for brand new orders just opened to now add to the arrays.
  //they will be just opened via debugging or via the above code,
  //therefore don't ignore these tickets.  allow partial closing
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if (!f_TicketIsInArray(OrderTicket())) AddTicketToArray(OrderTicket(), False);
    }
  }
/////

  // This part of the code will close out 70% of your position at your first TP
  
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if ((f_TicketIsInArray(OrderTicket())) && (f_IgnoreTicket(OrderTicket()) == false)) { 

        tradeThisCandle = true;
     
        if(OrderType() == OP_BUY) {
          rememberTP = memorizeH[1] + ((memorizeH[1] - memorizeL[1]) * TP);
          if((Bid >= rememberTP) && (endLoop == false)) {                
            OrderClose(OrderTicket(), NormalizeDouble(OrderLots() * 0.7, 2), Bid, 5);
Print("partial buy close: last error = ", ErrorDescription(GetLastError()));
            endLoop = true;
          }         
        }
      
        if(OrderType() == OP_SELL) {
          rememberTP = memorizeL[1] - ((memorizeH[1] - memorizeL[1]) * TP);
          if((Ask <= rememberTP) && (endLoop == false)) {
            OrderClose(OrderTicket(), NormalizeDouble(OrderLots() * 0.7, 2), Ask, 5);
Print("partial sell close: last error = ", ErrorDescription(GetLastError()));
            endLoop = true;
          }         
        } 
      }  //end of if ((c2 > -1) && (IgnoreArray[c2] == false)) { 
    }  //end of if symbol
  }  //end of for loop

  //search for new tickets just created by partial order closes
  //as they are via partial order closes mark as ignore so no further partial closing is done
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if (!f_TicketIsInArray(OrderTicket())) AddTicketToArray(OrderTicket(), True);
    }
  }
       
  if((memorizeH[1] != drawh) || (memorizeL[1] != drawl)) {
    ObjectDelete("Swing High");
    ObjectDelete("Swing Low");
    ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
    ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
    ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
    ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
    drawh = memorizeH[1];
    drawl = memorizeL[1];
  }  
} //end of start function

Congratulations ScalaFX for coming out of the closet!

#32
Jun 6, 2011 10:35am Jun 6, 2011 10:35am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

ok. fixed another error of mine, and fixed the partial close so that it does now in fact close 70% at +0.5 Reward for every order opened and is no longer nerfed.

now all you have to do is fix the money management part which should be simple enough (simpler than how you seem to be doing it), and also fix the 'order cannons' which aren't 'firing'.

Inserted Code

 
//+------------------------------------------------------------------+
//|                                         Pre-Order Manager EA.mq4 |
//|                                                           Scotty |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Scotty"
#property link      "http://www.metaquotes.net"
/* This EA will take Scalpers order and manage it until it hits it's first TP, You will have to watch the ema spacing for it. Activate once ema spacing is good*/
/* Known Issues */
/* (1)The high low function doesn't seem to be accurate, a swing high is created if a bar has two bars before and after it with lower highs by at least 1 full pip
Vice Versa for a swing low. I've tried fixing this by subtracing 0.0001 to if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) as shown below. 
            if(iHigh(Symbol(), period, shift)-0.0001<iHigh(Symbol(), period, j))
            
            This creates an error log in the journal saying it can't divide by zero. I'm not sure why this is occuring.
            
     (2) The EA doesn't set a partial close at 0.5stop. it can't seem to find the ticket number.
     
     (3) High low function declares two swing high's and swing low's then won't do anymore.
            
*/
extern int StrictLevel = 2;
extern int Breakout_Definition = 0;
extern double PercentRisk = 3.5;
extern double TP = 0.5; // if its gbp put this as 1 //keep in mind this is different than whichorder in post-order manager
/* Global Variables */
int period = PERIOD_M5;
double memorizeH[];
double memorizeL[];
int wherefirst_h, wherefirst_l;
double var, drawh, drawl;
bool moddedYet = false, tradeThisCandle = false, filled_long = false, filled_short = false, midway = false, endLoop = false;
double rememberTP, rememberSL, l;
string bought = "Order filled long";
string sold = "Order filled short";

//int iTicket;

int TicketArray[];  //stores active ticket numbers
bool IgnoreArray[];  //ignore matching ticket number as partial takeprofit has already been done

double Pip;
#include <stderror.mqh>
#include <stdlib.mqh>


/*                  */
/* This is Strat's code for determining the break of a high or low */
int localHighLow(string mode, int untilWhen, int n) {
  double highlow;
  int shift, i, j, count=1;
  bool yet=true;
   
  if(mode=="High") {
    for(i = n + 1; i < untilWhen; i++) {
      yet = true;
      shift = iBarShift(Symbol(),period, Time[i]);
      highlow = iHigh(Symbol(), period, shift); 
      for(j = shift - n; j <= shift + n; j++) {
        if(iHigh(Symbol(), period, shift) < iHigh(Symbol(), period, j)) {
          yet = false;
          break;
        }           
      }
         
      if(yet == true) {
        memorizeH[count] = iHigh(Symbol(), period, shift);
        count++;
        if(count == 2) wherefirst_h = i;
      }   
    }
   }
   
   if(mode == "Low") {
     for(i = n + 1; i < untilWhen; i++) {
       yet = true;
       shift = iBarShift(Symbol(),period, Time[i]);
       highlow = iLow(Symbol(), period, shift); 
       for(j = shift - n; j <= shift + n;j++) {
         if(iLow(Symbol(), period, shift) > iLow(Symbol(), period, j)) {
           yet = false;
           break;
          }           
       }
         
       if(yet == true) {
         memorizeL[count] = iLow(Symbol(), period, shift);
         count++;
         if(count == 2) wherefirst_l=i;
       }   
     }
   }   
   
   return(count);
}

/** Purpose: determining whether a level is broken (mode="Long" or "Short")
* Returns true if the level was broken, false otherwise */
bool breakout(string mode, double level) {
  double price = MarketInfo(Symbol(), MODE_BID);
  var = false;
  if(mode == "Long") {
    if(/*(price>=level+10*0.0001) ||*/ (price >= level + Breakout_Definition * Pip) && (Open[0] < level)) {
      var = true;
    }
   
    if(mode == "Short") {
      if(/*(price<=level-10*0.0001) ||*/ (price <= level - Breakout_Definition * Pip) && (Open[0] > level)) {
        var = true;
      }
    }
  }
   
  return(var);
}

int init() {
  // Resets Arrays
  ArrayResize(memorizeH, Bars);
  ArrayInitialize(memorizeH, 0);
  ArrayResize(memorizeL, Bars);
  ArrayInitialize(memorizeL, 0);
  Comment("Pre-Order Manager is ready to trade");
  int x = localHighLow("High", 150, StrictLevel);
  int y = localHighLow("Low", 150, StrictLevel);
  ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
  ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
  ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
  ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
  drawh=memorizeH[1];
  drawl=memorizeL[1];
  
  ArrayResize(TicketArray, 0);
  ArrayResize(IgnoreArray, 0);
  
  Pip = Point;
  if ((Digits == 3) || (Digits == 5)) Pip = Point * 10;  
  
  return(0);
}
  
int deinit() {
  Comment("");
  ObjectDelete("Swing High");
  ObjectDelete("Swing Low");
      
  return(0);
}

bool f_IgnoreTicket(int TicketNum) {
  int c;
  bool r;
  
  r = false;
  for(c = 0; c < ArraySize(TicketArray); c++) {
    if (TicketNum == TicketArray[c]) {
      r = IgnoreArray[c];
    }
  }
  
  return(r);
}

bool f_TicketIsInArray(int TicketNum) {
  int c;
  bool r;
  
  r = false;
  for(c = 0; c < ArraySize(TicketArray); c++) {
    if (TicketNum == TicketArray[c]) {
      r = true;
    }
  }  
  
  return(r);
}

int AddTicketToArray(int TicketNum, bool Ignore) {
  int c;
  c = ArraySize(TicketArray) + 1;
  ArrayResize(TicketArray, c);
  ArrayResize(IgnoreArray, c);
  
  TicketArray[c-1] = TicketNum;
  IgnoreArray[c-1] = Ignore;
Print("add ticket to array : added ticket ", TicketNum, " with ignore setting ", Ignore);  

  return(0);
}

int RemoveDeadTickets() {
  int c, c2, size;
  bool found;
  
  c = 0;
  size = ArraySize(TicketArray);
  while(c < size) {
    found = false;
    for(c2 = 0; c2 < OrdersTotal(); c2++) {
      OrderSelect(c2, SELECT_BY_POS, MODE_TRADES);
      if (TicketArray[c] == OrderTicket()) found = true;
    }
    
    if (!found) {
Print("remove dead ticket : ticket ", TicketArray[c], " not found in open orders, removing.");
      TicketArray[c] = TicketArray[size-1];
      IgnoreArray[c] = IgnoreArray[size-1];
      ArrayResize(TicketArray, size-1);
      ArrayResize(IgnoreArray, size-1);
      c--;  //force this index to recheck
    }
  
    c++;
    size = ArraySize(TicketArray);
  }
  
  return(0);
}

int start() { 
  double acc = AccountEquity();
  int lows = localHighLow("High", 150, StrictLevel); 
  int highs = localHighLow("Low", 150, StrictLevel);
  double cci=iCCI(Symbol(), period, 24, PRICE_TYPICAL, 0);   
// Money Management function   
  double ris = acc * (PercentRisk / 100);
  double stop = (memorizeH[1] - memorizeL[1]) * 100000;
  double lots = ris / stop;
//  double lotsTP = lots * 0.7;

  int c, c2, tempindex;
  double dTakeProfit;

  double debugsignal;
  
  debugsignal = 0;
  if (GlobalVariableCheck("debugsignal")) {
    debugsignal = GlobalVariableGet("debugsignal");
  }
  GlobalVariableSet("debugsignal", 0);  //reset
  
  //1 = buy, 2 = sell, 3 = buy and sell
  if ((debugsignal == 1) || (debugsignal == 3)) {
//    iTicket = OrderSend(Symbol(), OP_BUY, 1, Ask, 0, Bid - Pip*10, 0, "", 12345, 0, Blue);
    OrderSend(Symbol(), OP_BUY, lots, Ask, 1 * Pip, (memorizeL[1] - (3 * Pip)), 0);
Print("debugsignal: lots = ", lots);
Print("debugsignal: last error = ", ErrorDescription(GetLastError()));    
  }
  if ((debugsignal == 2) || (debugsignal == 3)) {
//    iTicket = OrderSend(Symbol(), OP_SELL, 1, Bid, 0, Ask + Pip*10, 0, "", 12345, 0, Red);
    OrderSend(Symbol(), OP_SELL, lots, Bid, 1 * Pip, (memorizeH[1] +(3 * Pip)), 0);
Print("debugsignal: lots = ", lots);    
Print("debugsignal: last error = ", ErrorDescription(GetLastError()));    
  }
  if (debugsignal == 5) {
    while (OrdersTotal() > 0) {
      OrderSelect(0, SELECT_BY_POS, MODE_TRADES);
      OrderClose(OrderTicket(), OrderLots(), Bid, 100000, Purple);
    }  
  }
   
  Comment("Pre-Order Manager is ready to trade");
   
  //Order Conditions Below
  if((OrdersTotal() == 0) && (tradeThisCandle == false)) {
    moddedYet = false;
    if((Ask <= memorizeH[1] + Breakout_Definition * Pip) && !(Ask > memorizeH[1] + Breakout_Definition * Pip) && (cci >= 90)) {
      filled_long = true;
    } else {
      if((Ask > memorizeH[1] + Breakout_Definition * Pip) !(cci >= 90)) {
        filled_long = false;
      }
    }
    
    if((Bid >= memorizeL[1] - Breakout_Definition * Pip) && !(Bid < memorizeL[1] - Breakout_Definition * Pip) && (cci <= -90)) {
      filled_short=true;
    } else {
      if((Bid < memorizeL[1] - Breakout_Definition * Pip) && !(cci <= -90)) {
        filled_short=false;  
      }
    }
         
    //Welcome to our Order cannons ;)      
           
    if(breakout("Long", memorizeH[1]) && (filled_long == true)) {
      rememberSL = memorizeL[1] - (3 * Pip);
      OrderSend(Symbol(), OP_BUY, lots, Ask, 1 * Pip, (memorizeL[1] - (3 * Pip)), 0);
Print("a: last error = ", ErrorDescription(GetLastError()));
//Print("a: ticket number = ", iTicket); 
      endLoop = false;         
    }
      
    if(breakout("Short", memorizeL[1]) && (filled_short == true)) {
      rememberSL = memorizeH[1] + (3 * Pip);
      OrderSend(Symbol(), OP_SELL, lots, Bid, 1 * Pip, (memorizeH[1] +(3 * Pip)), 0);
Print("b: last error = ", ErrorDescription(GetLastError()));
//Print("b: ticket number = ", iTicket);
      endLoop = false;        
    }     
  }  
/////

  RemoveDeadTickets();

  //search for brand new orders just opened to now add to the arrays.
  //they will be just opened via debugging or via the above code,
  //therefore don't ignore these tickets.  allow partial closing
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if (!f_TicketIsInArray(OrderTicket())) AddTicketToArray(OrderTicket(), False);
    }
  }
/////

  // This part of the code will close out 70% of your position at your first TP
  
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if ((f_TicketIsInArray(OrderTicket())) && (f_IgnoreTicket(OrderTicket()) == false)) { 

        tradeThisCandle = true;
     
        if(OrderType() == OP_BUY) {
//          rememberTP = memorizeH[1] + ((memorizeH[1] - memorizeL[1]) * TP);          
//          if((Bid >= rememberTP) && (endLoop == false)) {                
          dTakeProfit = OrderOpenPrice() + (OrderOpenPrice() - OrderStopLoss()) / 2;
          if (Bid >= dTakeProfit) {
            OrderClose(OrderTicket(), NormalizeDouble(OrderLots() * 0.7, 2), Bid, 5);
Print("partial buy close : ticket num = ", OrderTicket());
Print("partial buy close: ignore setting was ", f_IgnoreTicket(OrderTicket()));            
Print("partial buy close: last error = ", ErrorDescription(GetLastError()));
            endLoop = true;
          }         
        }
      
        if(OrderType() == OP_SELL) {
//          rememberTP = memorizeL[1] - ((memorizeH[1] - memorizeL[1]) * TP);
//          if((Ask <= rememberTP) && (endLoop == false)) {
          dTakeProfit = OrderOpenPrice() - (OrderStopLoss() - OrderOpenPrice()) / 2;
          if (Ask <= dTakeProfit) {
            OrderClose(OrderTicket(), NormalizeDouble(OrderLots() * 0.7, 2), Ask, 5);
Print("partial sell close: last error = ", ErrorDescription(GetLastError()));
            endLoop = true;
          }         
        } 
      }  //end of if ((c2 > -1) && (IgnoreArray[c2] == false)) { 
    }  //end of if symbol
  }  //end of for loop

  //search for new tickets just created by partial order closes
  //as they are via partial order closes mark as ignore so no further partial closing is done
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if (!f_TicketIsInArray(OrderTicket())) AddTicketToArray(OrderTicket(), True);
    }
  }
       
  if((memorizeH[1] != drawh) || (memorizeL[1] != drawl)) {
    ObjectDelete("Swing High");
    ObjectDelete("Swing Low");
    ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
    ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
    ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
    ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
    drawh = memorizeH[1];
    drawl = memorizeL[1];
  }  
} //end of start function

Congratulations ScalaFX for coming out of the closet!

#33
Jun 7, 2011 12:03am Jun 7, 2011 12:03am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

i know no one seems to care about this ea anymore since it's all me talking nowadays, but i couldn't leave it alone and gave me something to do. after tinkering away with it i think it's basically how you wanted it.

1. the order cannons open an order if no orders are already open (but open on any pair not just the chart the ea is on... easily changed if needed).
2. closes 70% (give or take depending on lot size) once it hits +0.5 Reward.
3. does NOTHING further to any open orders that are the result of already having had partial profits taken on. so it will either hit the original stoploss or you manually close it at some point.

i'm fairly sure my money management math is broken. strangely, if it is broken it's still appears to be close. the granularity of lot sizes required affects the precision on how much is at risk so you can end-up actually having a bit more at risk than specified.

there is NO code to deal with 'order context busy' type of issues and so-on when actually dealing with live trading. that is for someone else to deal with.

scotty - remember me when you have made your first million

Inserted Code

 
//+------------------------------------------------------------------+
//|                                         Pre-Order Manager EA.mq4 |
//|                                                           Scotty |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Scotty"
#property link      "http://www.metaquotes.net"
/* This EA will take Scalpers order and manage it until it hits it's first TP, You will have to watch the ema spacing for it. Activate once ema spacing is good*/
/* Known Issues */
/* (1)The high low function doesn't seem to be accurate, a swing high is created if a bar has two bars before and after it with lower highs by at least 1 full pip
Vice Versa for a swing low. I've tried fixing this by subtracing 0.0001 to if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) as shown below. 
            if(iHigh(Symbol(), period, shift)-0.0001<iHigh(Symbol(), period, j))
            
            This creates an error log in the journal saying it can't divide by zero. I'm not sure why this is occuring.
            
     (2) The EA doesn't set a partial close at 0.5stop. it can't seem to find the ticket number.
     
     (3) High low function declares two swing high's and swing low's then won't do anymore.
            
*/
extern int StrictLevel = 2;
extern int Breakout_Definition = 0;
extern double PercentRisk = 3.5;
extern double TP = 0.5; // if its gbp put this as 1 //keep in mind this is different than whichorder in post-order manager
/* Global Variables */
int period = PERIOD_M5;
double memorizeH[];
double memorizeL[];
int wherefirst_h, wherefirst_l;
double var, drawh, drawl;
bool moddedYet = false, tradeThisCandle = false, filled_long = false, filled_short = false, midway = false, endLoop = false;
string bought = "Order filled long";
string sold = "Order filled short";

int TicketArray[];  //stores active ticket numbers
bool IgnoreArray[];  //ignore matching ticket number as partial takeprofit has already been done

extern bool debug = false;

double Pip;
#include <stderror.mqh>
#include <stdlib.mqh>


/*                  */
/* This is Strat's code for determining the break of a high or low */
int localHighLow(string mode, int untilWhen, int n) {
  double highlow;
  int shift, i, j, count=1;
  bool yet=true;
   
  if(mode=="High") {
    for(i = n + 1; i < untilWhen; i++) {
      yet = true;
      shift = iBarShift(Symbol(),period, Time[i]);
      highlow = iHigh(Symbol(), period, shift); 
      for(j = shift - n; j <= shift + n; j++) {
        if(iHigh(Symbol(), period, shift) < iHigh(Symbol(), period, j)) {
          yet = false;
          break;
        }           
      }
         
      if(yet == true) {
        memorizeH[count] = iHigh(Symbol(), period, shift);
        count++;
        if(count == 2) wherefirst_h = i;
      }   
    }
   }
   
   if(mode == "Low") {
     for(i = n + 1; i < untilWhen; i++) {
       yet = true;
       shift = iBarShift(Symbol(),period, Time[i]);
       highlow = iLow(Symbol(), period, shift); 
       for(j = shift - n; j <= shift + n;j++) {
         if(iLow(Symbol(), period, shift) > iLow(Symbol(), period, j)) {
           yet = false;
           break;
          }           
       }
         
       if(yet == true) {
         memorizeL[count] = iLow(Symbol(), period, shift);
         count++;
         if(count == 2) wherefirst_l=i;
       }   
     }
   }   
   
   return(count);
}

/** Purpose: determining whether a level is broken (mode="Long" or "Short")
* Returns true if the level was broken, false otherwise */
bool breakout(string mode, double level) {
  var = false;
  if(mode == "Long") {
    if((Bid >= level + Breakout_Definition * Pip) && (Open[0] < level)) {
      var = true;
    }
  }
   
  if(mode == "Short") {
    if((Ask <= level - Breakout_Definition * Pip) && (Open[0] > level)) {
      var = true;
    }
  }
    
  return(var);
}

int init() {
  // Resets Arrays
  ArrayResize(memorizeH, Bars);
  ArrayInitialize(memorizeH, 0);
  ArrayResize(memorizeL, Bars);
  ArrayInitialize(memorizeL, 0);
  Comment("Pre-Order Manager is ready to trade");
  int x = localHighLow("High", 150, StrictLevel);
  int y = localHighLow("Low", 150, StrictLevel);
  ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
  ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
  ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
  ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
  drawh=memorizeH[1];
  drawl=memorizeL[1];
  
  ArrayResize(TicketArray, 0);
  ArrayResize(IgnoreArray, 0);
  
  Pip = Point;
  if ((Digits == 3) || (Digits == 5)) Pip = Point * 10;  
  
  return(0);
}
  
int deinit() {
  Comment("");
  ObjectDelete("Swing High");
  ObjectDelete("Swing Low");
      
  return(0);
}

bool f_IgnoreTicket(int TicketNum) {
  int c;
  bool r;
  
  r = false;
  for(c = 0; c < ArraySize(TicketArray); c++) {
    if (TicketNum == TicketArray[c]) {
      r = IgnoreArray[c];
    }
  }
  
  return(r);
}

bool f_TicketIsInArray(int TicketNum) {
  int c;
  bool r;
  
  r = false;
  for(c = 0; c < ArraySize(TicketArray); c++) {
    if (TicketNum == TicketArray[c]) {
      r = true;
    }
  }  
  
  return(r);
}

int AddTicketToArray(int TicketNum, bool Ignore) {
  int c;
  c = ArraySize(TicketArray) + 1;
  ArrayResize(TicketArray, c);
  ArrayResize(IgnoreArray, c);
  
  TicketArray[c-1] = TicketNum;
  IgnoreArray[c-1] = Ignore;
if (debug) Print("add ticket to array : added ticket ", TicketNum, " with ignore setting ", Ignore);  

  return(0);
}

int RemoveDeadTickets() {
  int c, c2, size;
  bool found;
  
  c = 0;
  size = ArraySize(TicketArray);
  while(c < size) {
    found = false;
    for(c2 = 0; c2 < OrdersTotal(); c2++) {
      OrderSelect(c2, SELECT_BY_POS, MODE_TRADES);
      if (TicketArray[c] == OrderTicket()) found = true;
    }
    
    if (!found) {
if (debug) Print("remove dead ticket : ticket ", TicketArray[c], " not found in open orders, removing.");
      TicketArray[c] = TicketArray[size-1];
      IgnoreArray[c] = IgnoreArray[size-1];
      ArrayResize(TicketArray, size-1);
      ArrayResize(IgnoreArray, size-1);
      c--;  //force this index to recheck
    }
  
    c++;
    size = ArraySize(TicketArray);
  }
  
  return(0);
}

int OpenBuy() {
  double lots, sl, temp;
  
  sl = memorizeL[1] - (3 * Pip);
  
  temp = AccountBalance() - (AccountBalance() * (PercentRisk/100));  
  lots = ( (temp - AccountBalance()) / ((sl / Ask) - 1) ) / 100000;
  lots = NormalizeDouble(lots, 2);
  OrderSend(Symbol(), OP_BUY, lots, Ask, 1 * Pip, sl, 0);
if (debug) Print("openbuy() : last error = ", ErrorDescription(GetLastError()));  
}

int OpenSell() {
  double lots, sl, temp;
  
  sl = memorizeH[1] - (3 * Pip);
  
  temp = AccountBalance() - (AccountBalance() * (PercentRisk/100));  
  lots = ( (temp - AccountBalance()) / ((Bid / sl) - 1) ) / 100000;
  lots = NormalizeDouble(lots, 2);  
  OrderSend(Symbol(), OP_SELL, lots, Bid, 1 * Pip, sl, 0);
if (debug) Print("opensell() : last error = ", ErrorDescription(GetLastError()));
}

int start() { 
  int lows = localHighLow("High", 150, StrictLevel); 
  int highs = localHighLow("Low", 150, StrictLevel);
  double cci=iCCI(Symbol(), period, 24, PRICE_TYPICAL, 0);   
 
  int c, c2, tempindex;
  double dTakeProfit;

  double debugsignal;
  
  if (debug) {
    debugsignal = 0;
    if (GlobalVariableCheck("debugsignal")) {
      debugsignal = GlobalVariableGet("debugsignal");
    }
    GlobalVariableSet("debugsignal", 0);  //reset  
  
    //1 = buy, 2 = sell, 3 = buy and sell, 5 = close all
    if ((debugsignal == 1) || (debugsignal == 3)) {
      Print("debugsignal buy");
      OpenBuy();
    }
    if ((debugsignal == 2) || (debugsignal == 3)) {
      Print("debugsignal sell");
      OpenSell();
    }
    if (debugsignal == 5) {
      while (OrdersTotal() > 0) {
        OrderSelect(0, SELECT_BY_POS, MODE_TRADES);
        OrderClose(OrderTicket(), OrderLots(), Bid, 100000, Purple);
      }  
    }
  }
   
  Comment("Pre-Order Manager is ready to trade");
   
  //Order Conditions Below
  if((OrdersTotal() == 0) && (tradeThisCandle == false)) {
    moddedYet = false;
    if((Ask <= memorizeH[1] + Breakout_Definition * Pip) && !(Ask > memorizeH[1] + Breakout_Definition * Pip) && (cci >= 90)) {
      filled_long = true;
    } else {
      if((Ask > memorizeH[1] + Breakout_Definition * Pip) !(cci >= 90)) {
        filled_long = false;
      }
    }
    
    if((Bid >= memorizeL[1] - Breakout_Definition * Pip) && !(Bid < memorizeL[1] - Breakout_Definition * Pip) && (cci <= -90)) {
      filled_short=true;
    } else {
      if((Bid < memorizeL[1] - Breakout_Definition * Pip) && !(cci <= -90)) {
        filled_short=false;  
      }
    }
         
    //Welcome to our Order cannons ;)      
           
    if(breakout("Long", memorizeH[1]) && (filled_long == true)) {
if (debug) Print("order cannon buy");    
      OpenBuy();
      endLoop = false;         
    }
  
    if(breakout("Short", memorizeL[1]) && (filled_short == true)) {
if (debug) Print("order cannon sell");    
      OpenSell();
      endLoop = false;        
    }     
  }  
/////

  RemoveDeadTickets();

  //search for brand new orders just opened to now add to the arrays.
  //they will be just opened via debugging or via the above code,
  //therefore don't ignore these tickets.  allow partial closing
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if (!f_TicketIsInArray(OrderTicket())) AddTicketToArray(OrderTicket(), False);
    }
  }
/////

  tradeThisCandle = false;

  // This part of the code will close out 70% of your position at your first TP
  
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if ((f_TicketIsInArray(OrderTicket())) && (f_IgnoreTicket(OrderTicket()) == false)) { 

        tradeThisCandle = true;
     
        if(OrderType() == OP_BUY) {
          dTakeProfit = OrderOpenPrice() + (OrderOpenPrice() - OrderStopLoss()) / 2;
          if (Bid >= dTakeProfit) {
            OrderClose(OrderTicket(), NormalizeDouble(OrderLots() * 0.7, 2), Bid, 5);
if (debug) Print("partial buy close: last error = ", ErrorDescription(GetLastError()));
            endLoop = true;
          }         
        }
      
        if(OrderType() == OP_SELL) {
          dTakeProfit = OrderOpenPrice() - (OrderStopLoss() - OrderOpenPrice()) / 2;
          if (Ask <= dTakeProfit) {
            OrderClose(OrderTicket(), NormalizeDouble(OrderLots() * 0.7, 2), Ask, 5);
if (debug) Print("partial sell close: last error = ", ErrorDescription(GetLastError()));
            endLoop = true;
          }         
        } 
      }  //end of if ((c2 > -1) && (IgnoreArray[c2] == false)) { 
    }  //end of if symbol
  }  //end of for loop

  //search for new tickets just created by partial order closes
  //as they are via partial order closes mark as ignore so no further partial closing is done
  for(c = 0; c < OrdersTotal(); c++) {
    OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
    if (OrderSymbol() == Symbol()) {
      if (!f_TicketIsInArray(OrderTicket())) AddTicketToArray(OrderTicket(), True);
    }
  }
       
  if((memorizeH[1] != drawh) || (memorizeL[1] != drawl)) {
    ObjectDelete("Swing High");
    ObjectDelete("Swing Low");
    ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
    ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
    ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
    ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
    drawh = memorizeH[1];
    drawl = memorizeL[1];
  }  
} //end of start function

Congratulations ScalaFX for coming out of the closet!

#34
Jun 7, 2011 4:30pm Jun 7, 2011 4:30pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

now that is some serious coding skill. I really can't thank you enough mate for all your effort. That is exactly what I was after!

if you ever need a favour on here man feel free to pm me. I owe ya one.

#35
Last Post: Edited 9:43pm Jun 7, 2011 9:25pm | Edited 9:43pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

over time i kept finding bugs of my own (since metaeditor is about as helpful as a kick in the pants), along with the issues i found with the existing script... so it's up to you to ensure it does what you expect at all times. from my backtesting it seems to do what is expected.

i don't entirely follow the rest of the script that was already there, but it seems to be stable and compatible with what i've since done to it.

check it, test it, enjoy it.

edit : variables like endloop and tradeThisCandle are semi-redundant, and moddedYet. endloop and moddedYet are either a part of some other code that has since been removed, or are there in anticipation of adding further functionality that isn't currently there. tradethiscandle is misleading, but i believe it's intended to only permit one order being opened per candle, however, i'm sure i have broken this aspect but it doesn't appear to be an issue since the ea doesn't appear to want to open and close within just one candle... a moot point.

i started really tearing-down some of the crud, but once i started messing with it too much i really did start to break the existing codes functionality, so it's just easier for me to simply leave it be... crud and all.

Congratulations ScalaFX for coming out of the closet!

Platform Tech
/
ticket number not working
Reply to Thread
- 1 Page 2
- 1 Page 2

0 traders viewing now

Options

Similar Threads

ticket number not working