Attachments: ticket number not working

ticket number not working

#1
First Post: Edited 12:16pm May 31, 2011 7:24am | Edited 12:16pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

This EA takes partial profit at half the value of your stop. e.g. if you stop is 50 pips, it will take partial profit at 25 pips.

This is my code for executing this function. It can't seem to recieve the ticket number though. I can see this because I put in Print(iTicket); and it prints a 0. Thus without the ticket number it won't partially take profit.

Does anyone know how to remedy this?

memorizeH[1] is resistance
memorizeL[1] is support.

Please find code below.

Inserted Code

 
if(OrdersTotal()!=0)
 
{
tradeThisCandle=true;
OrderSelect(iTicket, SELECT_BY_TICKET);
 
if(OrderType()==OP_BUY)
{
rememberTP=(memorizeH[1]+0.0001)+((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
if(Bid>=rememberTP) {
OrderClose(iTicket, lotsTP, Bid, 1*0.0001);
Print(iTicket);
endLoop=true;
}
}
 
if(OrderType()==OP_SELL)
{
rememberTP=(memorizeL[1]-0.0001)-((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
if(Ask<=rememberTP) {
OrderClose(iTicket, lotsTP, Ask, 1*0.0001);
Print(iTicket);
endLoop=true;
}
 
}
}

#2
May 31, 2011 10:43am May 31, 2011 10:43am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

if you need anymore info please let me know

#3
May 31, 2011 11:27am May 31, 2011 11:27am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

i don't know why i keep having to say this... but stick your code in the CODE TAGS so we can at least read it :/

without seeing the rest of the script it's all just guessing. did you declare iTicket OUTSIDE of the start function so that it is globally accessible to the entire ea and therefore also not reset each iteration of start() ?

Congratulations ScalaFX for coming out of the closet!

#4
May 31, 2011 12:18pm May 31, 2011 12:18pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

sorry, above is editted, yes I have declared it as a global variable. iTicket is created when the order is placed.

Inserted Code

 
#property copyright "Scotty"
#property link      "[url]http://www.metaquotes.net[/url]"
 
extern int StrictLevel=2;
extern int Breakout_Definition=0;
extern double PercentRisk=3.5;
extern double TP=0.5;
 
/* Global Variables */
int period=PERIOD_M5;
double memorizeH[];
double memorizeL[];
int wherefirst_h, wherefirst_l, ticket;
int var, drawh, drawl;
bool moddedYet=false, tradeThisCandle=false, filled_long=false, filled_short=false, endLoop=false;
double rememberTP, rememberSL;
int iTicket;
int WhichOrder=0;
/*                  */
 
/* This is Strat's code for determining the break of a high or low */
int localHighLow(string mode, int untilWhen, int n)
{
   double highlow;
   int shift, i, j, count=1;
   bool yet=true;
 
   if(mode=="High")
   {
      for(i=n+1;i<untilWhen;i++)
      {
         yet=true;
         shift=iBarShift(Symbol(),period, Time[i]);
         highlow=iHigh(Symbol(), period, shift); 
         for(j=shift-n;j<=shift+n;j++)
         {
            if(iHigh(Symbol(), period, shift)<iHigh(Symbol(), period, j)) {
               yet=false;
               break;
            }           
         }
 
         if(yet==true) {
            memorizeH[count]=iHigh(Symbol(), period, shift);
            count++;
            if(count==2) wherefirst_h=i;
         }   
      }
   }
 
   if(mode=="Low")
   {
      for(i=n+1;i<untilWhen;i++)
      {
         yet=true;
         shift=iBarShift(Symbol(),period, Time[i]);
         highlow=iLow(Symbol(), period, shift); 
         for(j=shift-n;j<=shift+n;j++)
         {
            if(iLow(Symbol(), period, shift)>iLow(Symbol(), period, j)) {
               yet=false;
               break;
            }           
         }
 
         if(yet==true) {
            memorizeL[count]=iLow(Symbol(), period, shift);
            count++;
            if(count==2) wherefirst_l=i;
         }   
      }
   }   
 
   return(count);
}
/** Purpose: determining whether a level is broken (mode="Long" or "Short")
* Returns true if the level was broken, false otherwise */
bool breakout(string mode, double level)
{
   double price = MarketInfo(Symbol(), MODE_BID);
   var=false;
   if(mode=="Long")
      if(/*(price>=level+10*0.0001) ||*/ (price>=level+Breakout_Definition*0.0001) && Open[0]<level)
         var=true;
 
   if(mode=="Short")
      if(/*(price<=level-10*0.0001) ||*/ (price<=level-Breakout_Definition*0.0001) && Open[0]>level)
         var=true;
 
   return (var);
}
int init()
{
 
   // Resets Arrays
   ArrayResize(memorizeH, Bars);
   ArrayInitialize(memorizeH, 0);
   ArrayResize(memorizeL, Bars);
   ArrayInitialize(memorizeL, 0);
   Comment("Pre-Order Manager is ready to trade");
   int x=localHighLow("High", 150, StrictLevel);int y=localHighLow("Low", 150, StrictLevel);
   ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
   ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
   ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
   ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
   drawh=memorizeH[1];
   drawl=memorizeL[1];
   return(0);
}
 
int deinit()
{
   Comment("");
   ObjectDelete("Swing High");
   ObjectDelete("Swing Low");
 
   return(0);
}
int start()
{
 
 
   double acc=AccountEquity();
   int lows = localHighLow("High", 150, StrictLevel); 
   int highs = localHighLow("Low", 150, StrictLevel);
 
   double cci=iCCI(Symbol(), period, 24, PRICE_TYPICAL, 0);   
/*Money Management function*/   
   double ris=acc*(PercentRisk/100);
   double stop=(memorizeH[1]-memorizeL[1])*100000;
   double lots=ris/stop;
   double lotsTP=lots*0.7;
/*                         */
 
 
   Comment("Pre-Order Manager is ready to trade");
 
   /*Order Conditions Below*/
   if(OrdersTotal()==0 && tradeThisCandle==false)                
   {
      moddedYet=false;
      if(Ask<=memorizeH[1]+Breakout_Definition*0.0001 && !(Ask>memorizeH[1]+Breakout_Definition*0.0001) && cci>=90)                              
         filled_long=true;
      else if(Ask>memorizeH[1]+Breakout_Definition*0.0001 !(cci>=90))
         filled_long=false; 
 
      if(Bid>=memorizeL[1]-Breakout_Definition*0.0001 && !(Bid<memorizeL[1]-Breakout_Definition*0.0001) && cci<=-90)
         filled_short=true;
      else if(Bid<memorizeL[1]-Breakout_Definition*0.0001 !(cci<=-90))
         filled_short=false;  
 
     /*Welcome to our Order cannons ;)*/      
 
      if(breakout("Long", memorizeH[1]) && filled_long==true) 
      {
         rememberTP=Ask+((memorizeH[1]-memorizeL[1])*TP);
         rememberSL=(memorizeL[1]-(3*0.0001));
         iTicket=OrderSend(Symbol(), OP_BUY, lots, Ask, 1*0.0001, (memorizeL[1]-(3*0.0001)), 0); 
         endLoop=false;    
 
      }
 
      if(breakout("Short", memorizeL[1]) && filled_short==true) 
      {
         rememberTP=Bid-((memorizeH[1]-memorizeL[1])*TP);
         rememberSL=(memorizeH[1]+(3*0.0001));
         iTicket=OrderSend(Symbol(), OP_SELL, lots, Bid, 1*0.0001, (memorizeH[1]+(3*0.0001)), 0);
         endLoop=false;          
 
      }
 
      /* This part of the code will close out 70% of your position at your first TP*/
 
    if(OrdersTotal()!=0)
 
   {
      tradeThisCandle=true;
      OrderSelect(iTicket, SELECT_BY_TICKET);
 
      if(OrderType()==OP_BUY)
      {
         rememberTP=(memorizeH[1]+0.0001)+((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
          if(Bid>=rememberTP) {
            OrderClose(iTicket, lotsTP, Bid, 1*0.0001);
            endLoop=true;
         }
      }
 
      if(OrderType()==OP_SELL)
      {
        rememberTP=(memorizeL[1]-0.0001)-((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
          if(Ask<=rememberTP) {
            OrderClose(iTicket, lotsTP, Ask, 1*0.0001);
            endLoop=true;
         }
 
      }
     } 
 
         if(memorizeH[1]!=drawh || memorizeL[1]!=drawl)
   {
      ObjectDelete("Swing High");
      ObjectDelete("Swing Low");
      ObjectCreate("Swing High", OBJ_HLINE, 0,0, memorizeH[1]);
      ObjectSet("Swing High", OBJPROP_COLOR, Yellow);
      ObjectCreate("Swing Low", OBJ_HLINE, 0,0, memorizeL[1]);
      ObjectSet("Swing Low", OBJPROP_COLOR, Yellow);
      drawh=memorizeH[1];
      drawl=memorizeL[1];
   }
   }   
 
 
 
 
 
 
 
   }

#5
May 31, 2011 5:21pm May 31, 2011 5:21pm

CodeMeister
Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts

I think I know what is happening, but it doesn't fit the description provided. I believe the ticket number (iTicket) is fine after OrderSend() - but you need to check that. I also believe the first portion is closed fine using iTicket. After that, is when the problems start. Again you have to confirm this.

What happens in MQL4 is that OrderClose() assigns a new ticket number if the original is partially closed. I know this doesn't make sense, but that is what happens. Once this occurs you can no longer find anything using the old value (except in history). You have to find the new ticket by using the OrderSelect() option SELECT_BY_POS. If you have only one trade open at any time for a currency pair, that is easy. If you have more than one trade open, you will have to come up with an imaginative solution.

#6
May 31, 2011 6:18pm May 31, 2011 6:18pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

yeah google "mt4 ticket partial close" and you will find it mentioned a few times that the ticket number changes. how frustrating.

it's probably going to be easiest to just dump all ticket numbers into an array and once you do the half-close check through the order tickets versus what is in the array. when you find a ticket number that isn't in your array then you have found the new ticket number. replace iTicket with this and you are done... at least for that part.

if you are only messing with one buy and / or one sell order in total then just use a magic number and forget about specific tickets and save yourself all of the hassle.

Congratulations ScalaFX for coming out of the closet!

#7
May 31, 2011 9:50pm May 31, 2011 9:50pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

hmm, looks like the developers took an easy procedure and turned it into a real mess

cheers guys for the help I'll be able to amend it now.

#8
Jun 2, 2011 1:48pm Jun 2, 2011 1:48pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

Quoting CodeMeister

Disliked

I think I know what is happening, but it doesn't fit the description provided. I believe the ticket number (iTicket) is fine after OrderSend() - but you need to check that. I also believe the first portion is closed fine using iTicket. After that, is when the problems start. Again you have to confirm this.

Ignored

sorry for the delay, been busy since I last replied.

The first portion isn't closing fine using iTicket. It gets to the TP but doesn't close any of the position.

This EA is only supposed to manage the first TP of the trade, I'll do the rest.

Is there any way I can get this to work?

#9
Jun 2, 2011 2:36pm Jun 2, 2011 2:36pm

CodeMeister
Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts

From what you have said my theory is wrong, so we need to look for another one. This will not be easy.

Are you sure the code works for closing the entire position?

#10
Jun 2, 2011 2:58pm Jun 2, 2011 2:58pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

I just tried coding it so it closes the whole position, that doesn't work either.

for some reason its not sending the OrderClose

#11
Jun 2, 2011 3:20pm Jun 2, 2011 3:20pm

CodeMeister
Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts

I think I understand what you are saying. The EA will not close a trade when the conditions are met. Or do you mean the conditions are never met for some reason?

#12
Jun 2, 2011 3:33pm Jun 2, 2011 3:33pm

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

I think it may be due to the conditions but I'm not sure why,

the problem code is below

Inserted Code

 
 
if(OrdersTotal()!=0)
 
{
tradeThisCandle=true;
OrderSelect(iTicket, SELECT_BY_TICKET);
 
if(OrderType()==OP_BUY)
{
rememberTP=(memorizeH[1]+0.0001)+((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
if(Bid>=rememberTP) {
OrderClose(iTicket, lotsTP, Bid, 1*0.0001);
endLoop=true;
}
}
 
if(OrderType()==OP_SELL)
{
rememberTP=(memorizeL[1]-0.0001)-((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
if(Ask<=rememberTP) {
OrderClose(iTicket, lotsTP, Ask, 1*0.0001);
endLoop=true;
}
 
}
}

I've tried putting something simple in to see where its not reading for example under rememberTP, I put Print(iTicket); but it won't print. that may mean its not reading any of the following conditions.

if(OrdersTotal()!=0) or OrderSelect(iTicket, SELECT_BY_TICKET); or if(OrderType()==OP_SELL)

#13
Jun 2, 2011 3:46pm Jun 2, 2011 3:46pm

CodeMeister
Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts

OrderSelect(iTicket, SELECT_BY_TICKET); is the most likely culprit. You need to put a Print (iTicket) before it to ensure it has a valid value. Also put a print statement after the OrderSend().

One thing I noticed about the code is that it probably won't work for the Yen pairs or at least not in the same way as for the others. This is due to the hard coding of numbers like .0001 and .0003. Be sure to use a non Yen pair for these tests.

#14
Jun 2, 2011 5:31pm Jun 2, 2011 5:31pm

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Here are a few debugging tips:

Print out all relevant variables so you can tell if they are valid and the conditions for closing are met:

PHP Code

Print("Bid=",Bid,"  rememberTP=",rememberTP,"  iTicket=",iTicket," LotsTP=",LotsTP)

Call GetLastError() after OrderSelect() and OrderClose() to determine if an error occured when they were executed:

PHP Code

int err=GetLastError(); 
Print("error(",err,"): ",ErrorDescription(err));

http://docs.mql4.com/check/GetLastError

#15
Jun 3, 2011 2:06am Jun 3, 2011 2:06am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

when printing out iTicket I've got it coming up as 1, I don't think it correct, it should have several digits.

does any1 know why this may be the case?

#16
Jun 3, 2011 2:12am Jun 3, 2011 2:12am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

Quoting scottyfromau

Disliked

when printing out iTicket I've got it coming up as 1, I don't think it correct, it should have several digits.

does any1 know why this may be the case?

Ignored

is it safe to say this is in backtesting where there won't be any ticket history before this simulated order?

Congratulations ScalaFX for coming out of the closet!

#17
Jun 3, 2011 6:17am Jun 3, 2011 6:17am

scottyfromau
| Joined Aug 2010 | Status: Trader | 149 Posts

I'm not sure if I understand you correctly, the ticket number would be created when we send the first order though. Thus we would have that order in the ticket history. (I think)

So this part of the code first creates our initial position, lets say we're buying 1 lot of eurousd.

Inserted Code

      if(breakout("Long", memorizeH[1]) && filled_long==true) 
      {
         rememberTP=Ask+((memorizeH[1]-memorizeL[1])*TP);
         rememberSL=(memorizeL[1]-(3*0.0001));
         iTicket=OrderSend(Symbol(), OP_BUY, lots, Ask, 1*0.0001, (memorizeL[1]-(3*0.0001)), 0); 
         endLoop=false;    
 
      }
 
      if(breakout("Short", memorizeL[1]) && filled_short==true) 
      {
         rememberTP=Bid-((memorizeH[1]-memorizeL[1])*TP);
         rememberSL=(memorizeH[1]+(3*0.0001));
         iTicket=OrderSend(Symbol(), OP_SELL, lots, Bid, 1*0.0001, (memorizeH[1]+(3*0.0001)), 0);
         Print(iTicket);
         endLoop=false;          
 
      }

Now we need to close out 70% of the trade, via the below code. But for some reason this code is not recieving the correct ticket number (via iTicket)

Inserted Code

   if(OrdersTotal()!=0)
 
   {
      tradeThisCandle=true;
      Print(iTicket);
      OrderSelect(iTicket, SELECT_BY_POS, MODE_TRADES);
      GetLastError();
 
      if(OrderType()==OP_BUY)
      {
         rememberTP=(memorizeH[1]+0.0001)+((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
          if(Bid>=rememberTP) {
            OrderClose(iTicket, lotsTP, Bid, 1*0.0001);
            endLoop=true;
         }
      }
 
      if(OrderType()==OP_SELL)
      {
        rememberTP=(memorizeL[1]-0.0001)-((memorizeH[1]-memorizeL[1]+0.0003)*TP);
 
          if(Ask<=rememberTP) {
            OrderClose(iTicket, lotsTP, Ask, 1*0.0001);
            endLoop=true;
         }
 
      }
     }

#18
Edited 8:05am Jun 3, 2011 7:42am | Edited 8:05am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Then you back up to where you open the order. Print out iTicket and run GetLastError() directly after you call OrderSend(). What is going on there?
Look to see if iTicket is being reset anywhere. Search for "iTicket=" to see where it is being set.

Generally, one should always do some error checking after order related functions. Ie check the ticket nr and run GetLastError().

So you need to do the following:

Print out iTicket and run GetLastError() directly after you call OrderSend().
Print out iTicket before OrderSelect().
Print out iTicket and run GetLastError() directly after you call OrderSelect().
Print out iTicket and run GetLastError() directly after you call OrderClose().

That should tell you where something is going wrong.

#19
Edited 6:03pm Jun 3, 2011 5:38pm | Edited 6:03pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

i'm having a look at the ea and doing some cleanup on a few little things that you should not be doing (missing brackets etc).

is this ea supposed to open orders on it's own automatically, or does it purely do some management of orders you manually open?

edit : i'll show you what i have seen straight away that needs cleaning-up for your future coding

Inserted Code

if((Ask<=memorizeH[1]+Breakout_Definition*0.0001) && !(Ask>memorizeH[1]+Breakout_Definition*0.0001) && (cci>=90))

and also i have changed the ordermodify(iTicket ... to ordermodify(OrderTicket() . if you have already done an OrderSelect then you don't need to specify the ticket number and you just use OrderTicket() which IS the selected ticket. it's one or the other, you use orderselect, or you don't and just specify the actual ticket. the way you have it is trying to do it both ways which is redundant.

now, with the brackets.... you WILL come unstuck if you don't learn to bracket concepts into their own sections. don't make run-on sentences of logic tests like : a OR b AND c + D - E * F / G. it is firstly human readable to bracket it properly, and you won't run into compiler issues if you bracket it all how you mean it. the run-on test might actually meant to be ((a OR b) AND ( (c + (D - E)) * (F / G) ).... now all you have to do is iteratively resolve the inner-most brackets first, and that is also what the compiler will always do. there is no ambiguity.

example : depending on the language and specific compiler the following could result in a few different results

x AND y OR z

one compiler might interpret this as (x AND y) OR z, and another might interpret it as x AND (y OR z).

this can give wildly different results. i'm not certain how mt4 handles things, but if you get into the good practice of being specific and bracket as such then you won't ever have issues with any language or different compilers.

Congratulations ScalaFX for coming out of the closet!

#20
Jun 4, 2011 1:03am Jun 4, 2011 1:03am

FXEZ
Joined Jan 2007 | Status: developing... | 974 Posts

To the OP: I think these guys have pretty well covered the major issues. I skimmed over some of the posts so apologies if there is any duplication.

As best practice, when a function has a return value with a meaning, use the return value for error checking. OrderClose returns a boolean that will tell you if the function call fails or succeeds. On failure you should print out GetLastError to figure out what went wrong.

OrderSelect also returns a boolean and often it is best to allow the selection to form a block of code so you can tell exactly where the problem lies. I like to be very explicit so I can tell exactly where an error lies due to the weakness of the MetaEditor parser in providing useful user feedback regarding code errors in some cases. Here is what I mean by a useful OrderSend block:

Inserted Code

if (OrderSelect(iTicket, SELECT_BY_TICKET)== true) {
   // do something here
} else {
    Print("Ticket# " + iTicket + " failed to select. Error#: " 
     + GetLastError() );
}

Nubcake's point about using the OrderTicket() function within the OrderClose() function may be where the problem lies. The other area I would look at has to do with the number of decimals with lotsTP. Your formula multiplies lots * 0.7 and this could result in a fractional number for lotsTP like 1.03423 which will cause the order to be rejected.

Try NormalizeDouble(lotsTP,2) (if your broker has a minimum lot size of 0.01) in place of lotsTP within the OrderClose function. Use the return value (true/false) from OrderClose to debug any errors.

Because the code doesn't look at the return value for OrderClose or the error via GetLastError, the slippage value (an integer, not a double as in your code) set at zero may be triggering a failure to close the order. If you want 1 pip of slippage on a 4 digit broker, use 1, not 1*0.0001, which through integer conversion may be rounded to zero. But knowing a bit about how MQL4 works, (or doesn't) I'm not sure if you can rely on the compiler to do integer math / rounding correctly.

Make use of the IsTradeContextBusy or IsTradeAllowed function along with the RefreshRates routine to ensure order submission in a busy market / on a busy account. You might get some ideas from the CloseAll routine example under the OrderClose function at this link:

MQL4 OrderClose OrderCloseBy OrderDelete OrderModify

OrderClose and OrderModify tend to be very picky in the exact syntax used - more so than OrderSend in my experience.

Good luck!

Platform Tech
/
ticket number not working
Reply to Thread
- Page 1 2
- Page 1 2

0 traders viewing now

Options

Similar Threads

ticket number not working