iCustom returning Empty_val

Hi

I am using the following indicator which works well on its own printing the arrows etc. Code sample below.

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Lime
#property indicator_width1 1
#property indicator_color2 Yellow
#property indicator_width2 1
extern bool UseAlert = true;
extern int BarsToCount = 1000;

double SarUpSig[];
double SarDownSig[];

datetime TT;
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_ARROW);
SetIndexArrow(0,233);
SetIndexBuffer(0,SarUpSig);

SetIndexStyle(1,DRAW_ARROW);
SetIndexArrow(1,234);
SetIndexBuffer(1,SarDownSig);

TT=iTime(Symbol(),0,0);
//----
return(0);
}

int start()
{

int limit;
int counted_bars=IndicatorCounted();
//---- last counted bar will be recounted
if(counted_bars>0) counted_bars--;
limit=Bars-counted_bars;
//---- macd counted in the 1-st buffer
if(Period()!=PERIOD_H1)
{
return(0);
}

if (BarsToCount < limit)
limit = BarsToCount;


for(int i=limit; i>=0; i--)
{
datetime time = iTime(Symbol(),0,i);
int shiftD1 = iBarShift(Symbol(), PERIOD_D1, time, false);
int shiftH4 = iBarShift(Symbol(), PERIOD_H4, time, false);
int shiftH1 = iBarShift(Symbol(),PERIOD_H1,time,false);

double OsMa1 = iCustom(Symbol(),PERIOD_H1,"OsMA",30,200,5,0,shiftH1);
double OsMa2 = iCustom(Symbol(),PERIOD_H1,"OsMA",5,35,35,0,shiftH1);

double POsMa1 = iCustom(Symbol(),PERIOD_H1,"OsMA",30,200,5,0,shiftH1+1);
double POsMa2 = iCustom(Symbol(),PERIOD_H1,"OsMA",5,35,35,0,shiftH1+1);

//double Up_ST = iCustom(Symbol(),0,"4xRider STRONG-TREND Signal v2",14,2,i);
//double Dn_ST = iCustom(Symbol(),0,"4xRider STRONG-TREND Signal v2",14,1,i);

double SARD1 = iSAR(Symbol(),PERIOD_D1,0.22,0.2,shiftD1);
double SARH4 = iSAR(Symbol(),PERIOD_H4,0.05,0.2,shiftH4);
double SARH1 = iSAR(Symbol(),PERIOD_H1,0.01,0.2,shiftH1);
//double SARlast = iSAR(Symbol(),0,0.02,0.2,i+1);
double CLOSED1 = iClose(Symbol(),PERIOD_D1,shiftD1);
double CLOSEH4 = iClose(Symbol(),PERIOD_H4,shiftH4);
double CLOSEH1 = iClose(Symbol(),PERIOD_H1,shiftH1);

double PSARD1 = iSAR(Symbol(),PERIOD_D1,0.22,0.2,shiftD1+1);
double PSARH4 = iSAR(Symbol(),PERIOD_H4,0.05,0.2,shiftH4+1);
double PSARH1 = iSAR(Symbol(),PERIOD_H1,0.01,0.2,shiftH1+1);
//double SARlast = iSAR(Symbol(),0,0.02,0.2,i+1);
double PCLOSED1 = iClose(Symbol(),PERIOD_D1,shiftD1+1);
double PCLOSEH4 = iClose(Symbol(),PERIOD_H4,shiftH4+1);
double PCLOSEH1 = iClose(Symbol(),PERIOD_H1,shiftH1+1);

SarUpSig[i]=EMPTY_VALUE;
SarDownSig[i]=EMPTY_VALUE;

string buy;
//BUY

//if(Up_ST!=EMPTY_VALUE)
//{
//SarUpSig[1] = 1.6094;
if(SarUpSig[i+1] != EMPTY_VALUE && SARH1<CLOSEH1 && OsMa2>0 &&SARH4<CLOSEH4)
{
SarUpSig[i] = SARH1;
if(TT!=iTime(Symbol(),0,0)&&UseAlert)
{
//string time = TimeToStr(TimeCurrent());
Alert("4xRider(BUY) "+Symbol());
PlaySound("alert.wav");
TT=iTime(Symbol(),0,0);
}
}
if((PSARH4>PCLOSEH4&&POsMa1<0&&PSARH1>PCLOSEH1)&&
(SARH4<CLOSEH4&&OsMa1>0&&SARH1<CLOSEH1&&SARD1<CLOSED1)&& OsMa2>0)
{
SarUpSig[i] = SARH1;
buy = "trading";
if(TT!=iTime(Symbol(),0,0)&&UseAlert)
{
//string time = TimeToStr(TimeCurrent());
Alert("4xRider (BUY) "+Symbol());
PlaySound("alert.wav");
TT=iTime(Symbol(),0,0);
}
}

//}
string sell;
//SELL

//if(Dn_ST!=EMPTY_VALUE)
//{
if(SarDownSig[i+1] != EMPTY_VALUE && SARH1>CLOSEH1 && OsMa2<0 && SARH4>CLOSEH4)
{
SarDownSig[i] = SARH1;
if(TT!=iTime(Symbol(),0,0)&&UseAlert)
{
//string time = TimeToStr(TimeCurrent());
Alert("4xRider (SELL) "+Symbol());
PlaySound("alert.wav");
TT=iTime(Symbol(),0,0);
}
}
if((PSARH4<PCLOSEH4&&POsMa1>0&&PSARH1<PCLOSEH1)&&
(SARH4>CLOSEH4&&OsMa1<0&&SARH1>CLOSEH1&&SARD1>CLOSED1)&& OsMa2<0)
{
SarDownSig[i] = SARH1;
if(TT!=iTime(Symbol(),0,0)&&UseAlert)
{
//string time = TimeToStr(TimeCurrent());
Alert("4xRider (SELL) "+Symbol());
PlaySound("alert.wav");
TT=iTime(Symbol(),0,0);
}
}

//}

//SELL

}
//----
//Comment("From indicator: ", DoubleToStr(SarUpSig[1], Digits));
return(0);
}


I'm using an EA to read the values as follows.

#define INDI "MyIndicator"

double IndiUpVal = iCustom(NULL, 0, INDI, false, 5, 0, 1);
double IndiDownVal = iCustom(NULL, 0, INDI, false, 5, 1, 1);

Comment("IndiUpVal: "+ D2S(IndiUpVal)+ ". IndiUpVal: "+ D2S(IndiDownVal));

D2S = DoubleToString with digit

No matter what I do the iCustom returns EMPTY_VAL.

If I Print the value from within the indicator at the right time SarUpSig[1]
will return the correct values. But the iCustom always gives EMPTY_VAL.

Why?

Any help is greatly appreciated.

firstly, you need to use the [code ] tags :S

secondly, from briefly looking through you aren't returning any value except zero. change the start functions return value to that of which you want to read with icustom and see how you go from there.

The return value from the indicator has nothing to do with iCustom.

iCustom reads values from the indicator buffers not the return value. The first thing to do is verify in the Data Window that the indicator is producing the expected values. Next be sure that the parameter count and value types are correct for the iCustom call. This can be done by examining all the extern variables and comparing them to the iCustom values assigned to them.

The code is a mess and I won't try to do that for you.

Yep. I have already verified that the data windows display the values correcly. I can also confirm that all values passed into the iCustom call is of the correct type. Agree that the indicator code is a mess (not mine).

I'm thinking maybe this issue is happening because the indicator goes from Limit to 0 (i--) i.e. backwards. So could it be that the iCustom is returning BEFORE the indicator has time to populate the entire array? Not sure whether the return from iCustom has a timeout. Anyone knows this? Or does the call BLOCK until the indicator runs and completes.

In order to rule this out I only sent in 5 as the Barcount parameter so that the indicator will only loop the last 5 bars. I confirmed this is happening by putting in a Print(i) in the indicator loop. But the return value is still EMPTY_VALUE. I just can't understand why. Especially because the data is printed in the data window and my Print statement from within the indicator also prints the correct values in the buffer.

I have used iCustom so many times before this is the first time I'm seeing something wierd like this.

Again I did not attempt to view the code, so I am basing my answer on your observation, not what may be happening.

The simplest method to see if your iCustom call is correct is to set an index for a bar that has closed, say the 10th bar (if that one has a value). Trying to find a value for a bar that is being recalculated (repainting) is not recommended unless you have some understanding of how to handle it.

I too have used iCustom many times without problems, but I suppose there could be a situation where the indicator is doing something that iCustom can't handle.

iCustom call of the indi gets same values as indi itself
I've copied your code into a .mq4 and named the indi 4xRider
The second indi (4xRider_call) is using iCustom to retrieve the values of 4xRider.
Same output on the chart (only 3 areas where signals occur during latest 1000 H1 bars)

codemeister you got me. my answer was wrong. i had a massive brain fart.

OP : if you do 2 things it will help you to get this sorted. 1. copy and paste the code inside CODE tags so we can then copy the code exactly. you may not realize this but the way you have just pasted the script causes MANY issues when trying to copy it into metaeditor and compile. if you want us to compile the code and look for you then you will simply HAVE TO do this FOR US. 2. explain briefly what the indi is meant to do and the expected output.

edit : nevermind. it looks like iwjw is on top of it for you.

Yes, indi to indi no issues. Cut the same part and put it into the EA and we are back to the EMPTY_VAL.

This is not all the time though. I find this issue a lot of GBPUSD. On EURUSD it works but there are instances it returns EMPTY_VAL. Hence my original assumption that its got something to do with the retuern.

Oh well. I'll keep trying.