Whereas I open mine with a fastidious anti-bacteria wipe and hot a nint of incohol.
Sixths trading - an EA by macman, Bob and Steve mk 2
Twice, I have seen box trades fill both pendings. One reaches tp and eventually EOB takes a notmal CT trade. This should send EOB into Recovery mode and the ct trade should be at twice the inputed lot size.
This is not happening, and the ct trade is being closed at its normal close level.
This is a clear bug.
- #1,644
- Apr 18, 2011 7:00pm Apr 18, 2011 7:00pm
- Joined Apr 2007 | Status: vincit qui se vincit | 6,251 Posts
Vincit qui se vincit.
- #1,647
- Apr 19, 2011 3:22am Apr 19, 2011 3:22am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I was looking into the logic that might cause EOB close the normal ct trade when it joins a loosing box trade.
I have added a message to the display to tell us when eob is in Recovery mode; it turned out that eob was not recognising that two or more buy or sell trades represented Recovery. I have tweaked the code a bit to see if I can overcome this; eob does recognise Recovery now. Whether this will cause LUC to grant itself another night at the theatre remains to be seen.
I have changed the scoobs filter thingy. Having it on only when there are no open trades effectively turns it off, which seems silly. I had not noticed before because I prefer the FxKiwi filter.
I have added a message to the display to tell us when eob is in Recovery mode; it turned out that eob was not recognising that two or more buy or sell trades represented Recovery. I have tweaked the code a bit to see if I can overcome this; eob does recognise Recovery now. Whether this will cause LUC to grant itself another night at the theatre remains to be seen.
I have changed the scoobs filter thingy. Having it on only when there are no open trades effectively turns it off, which seems silly. I had not noticed before because I prefer the FxKiwi filter.
- #1,649
- Apr 19, 2011 8:32am Apr 19, 2011 8:32am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Hi Steve and co, just a few words on TOB live. All of my bad yen trades from 2 weeks ago are now closed, and with a modest profit !! Great performance.
I've just watched TOB trying to close a GBPCHF sell trade at the green line.
What a joke Metatrader is. For one hour it was trying to close, I just kept watching the alert - failed with error (2) common error, every time price passed the green for a whole hour !!!...
- #1,650
- Apr 19, 2011 8:52am Apr 19, 2011 8:52am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
In fact, Ras, this is an even better idea than you thought.
When I cannot loll in the bath to think, I loll on the sofa instead. I just did some sofa-loll time and realised this: allow a second pair involving a particular currency only if it is a balancing trade, for example:
When I cannot loll in the bath to think, I loll on the sofa instead. I just did some sofa-loll time and realised this: allow a second pair involving a particular currency only if it is a balancing trade, for example:
- buy GU open, only allow buys where the pound is the second pair - eurgbp
- sell uj open, so only allow buys for the other xxxJPY pairs
and so on, and only allow a particular currency to be traded twice, so if there is a UJ buy and GJ sell open, then no more xxxJPY pairs.
Ras, you and my sofa make A Team. 
- #1,652
- Edited 11:47am Apr 19, 2011 11:05am | Edited 11:47am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Could the coders with a more logical mind than mine look at this, please.
The function is called just before TOB (and EOB when I have added it) sends a trade, and works out whether the proposed trade would break the only-trade-a-currency-twice-if-the-trades-balance rule.
The function splits up the chart pair into its constituent currencies and aborts the trade by returning 'false' if the trade would not balance with an existing one. Does this look ok?
The function is called just before TOB (and EOB when I have added it) sends a trade, and works out whether the proposed trade would break the only-trade-a-currency-twice-if-the-trades-balance rule.
The function splits up the chart pair into its constituent currencies and aborts the trade by returning 'false' if the trade would not balance with an existing one. Does this look ok?
Inserted Code
bool BalancedPair(int type)
{
//Only allow an individual currency to trade if it is a balanced trade
//e.g. UJ Buy open, so only allow Sell xxxJPY.
//The passed parameter is the proposed trade, so an existing one must balance that
bool TradeAllowed = true;
string c1 = StringSubstr(Symbol(), 0, 3);//First currency in the pair
string c2 = StringSubstr(Symbol(), 3, 3);//Secondcurrency in the pair
for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
{
if (!OrderSelect(cc, SELECT_BY_POS) ) continue;
if (OrderSymbol() == Symbol() ) continue;
if (StringSubstr(OrderSymbol(), 0, 3) == c1 && type == OrderType() ) return(false);
if (StringSubstr(OrderSymbol(), 3, 3) == c1 && type == OrderType() ) return(false);
if (StringSubstr(OrderSymbol(), 0, 3) == c2 && type == OrderType() ) return(false);
if (StringSubstr(OrderSymbol(), 3, 3) == c2 && type == OrderType() ) return(false);
}//for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
return(TradeAllowed);
}//bool BalancedPair(int type) - #1,653
- Apr 19, 2011 2:30pm Apr 19, 2011 2:30pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I have added the filter from my previous post to both TOB and EOB. Even if the code is not quite correct, it should not do any harm. At worst, it will kill trading stone dead - a distinct advantage at times.
- #1,655
- Apr 19, 2011 3:21pm Apr 19, 2011 3:21pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Hi Steve,
I don't think this will work. For example, you should be able to buy EUR/USD after buying USD/JPY (because one is USD sell and the other USD buy), but the logic above will not let you. This might work...
bool BalancedPair(int type)
{...
Zeljko code is added to the update in post 1, and to the attachment here.
Cheers Zeljko
- #1,656
- Apr 19, 2011 3:30pm Apr 19, 2011 3:30pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Anyone checked their EOB demo lately. Mine is barnstorming ahead - those box trades are making a huge difference.
- #1,657
- Apr 19, 2011 4:27pm Apr 19, 2011 4:27pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Hi Steve,
I don't think this will work. For example, you should be able to buy EUR/USD after buying USD/JPY (because one is USD sell and the other USD buy), but the logic above will not let you. This might work...
bool BalancedPair(int type)
{...
- #1,658
- Edited 2:03am Apr 20, 2011 1:48am | Edited 2:03am
Anyone checked their EOB demo lately. Mine is barnstorming ahead - those box trades are making a huge difference.
Doing forward testing and ST backtesting it seems the only way to get EOB to take box recovery trades is to have ct trading set to true .... this means when a box trade is in progress the ct acts as the recovery trade trigger and when there is no box trade ct works as normal ( as you would expect with a ' dual ' system ) ....... is this how you coded it / see it ?
If so can we please have an imput which would prevent normal ct trades altogether so we have the option to trade EOB purely as a box trader
Many thanks
