Attachments: How to read a buffer given by an arrow signal with iCustom?

How to read a buffer given by an arrow signal with iCustom?

#21
Edited 4:29am Mar 23, 2011 2:45am | Edited 4:29am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

For strategy tester only. Demo/Live trading requires more order handling code to check for errors and act accordingly.

PHP Code

//+------------------------------------------------------------------+
//| SupersiganlEA.mq4
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, Whatever"
#property link      "http://www.??????.com"

// Input Parameters
extern double Lots = 0.1;
extern double Slippage = 2.0;
extern double TakeProfit = 30;
extern double StopLoss = 20;
extern int    MagicNr=9502;

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() { 
  double ArrowUp, ArrowDown;
  static int iBuyTicket=-1;
  static int iSellTicket=-1;
  
  // Get Supersignal state
  ArrowUp = iCustom(NULL,0,"supersignals",1,1);
  ArrowDown = iCustom(NULL,0,"supersignals",0,1);
  
  // Open Buy order if previous bar has arrow up signal
  if  (ArrowUp!=EMPTY_VALUE && iBuyTicket<0) {
    iBuyTicket=OrderSend(Symbol(),OP_BUY,Lots, Ask, Slippage, 0, 0, 
                          "Supersignal", MagicNr, NULL, LimeGreen);    
  }
  // Open Sell order if previous bar has arrow down signal
  if  (ArrowDown!=EMPTY_VALUE && iSellTicket<0) {
    iSellTicket=OrderSend(Symbol(),OP_SELL,Lots, Bid, Slippage, 0, 0, 
                           "Supersignal", MagicNr, NULL, LimeGreen);    
  }
  
  // Check SL and TP for BUY ticket
  if (OrderSelect( iBuyTicket, SELECT_BY_TICKET)==True) {
    // Close position if SL is Hit
    if (dPips(Bid,OrderOpenPrice())<=-StopLoss)
      if ( OrderClose(iBuyTicket,Lots,Bid,Slippage)==True)
        iBuyTicket=-1; 
    // Close position if TP is Hit     
    if (dPips(Bid,OrderOpenPrice())>=TakeProfit)
      if ( OrderClose(iBuyTicket,Lots,Bid,Slippage)==True)
        iBuyTicket=-1;       
    //Print("Buy. Current Pips=",dPips(OrderOpenPrice(),Bid));  
  }
  
  // Check SL and TP for SELL ticket
  if (OrderSelect( iSellTicket, SELECT_BY_TICKET)==True) {
    // Close position if SL is Hit
    if (dPips(OrderOpenPrice(),Ask)>=StopLoss)
      if ( OrderClose(iSellTicket,Lots,Ask,Slippage)==True)
        iSellTicket=-1;   
    // Close position if TP is Hit
    if (dPips(OrderOpenPrice(),Ask)<=-TakeProfit)
      if ( OrderClose(iSellTicket,Lots,Ask,Slippage)==True)
        iSellTicket=-1;   
    //Print("Sell. Current Pips=",dPips(OrderOpenPrice(),Bid));  
  }
  
  return(0);
}


//------------------------------------------------------------
// function: dPips()
// Description: Convert a price difference to pips.
//-------------------------------------------------------------
double dPips(double dPrice1,double dPrice2,bool bAbs=false) {
  double dPipValue=(dPrice1-dPrice2)/Point; 
  if (bAbs) return( MathAbs(dPipValue));
  else return(dPipValue);
}

Attached File(s)

supersignalEA.mq4 3 KB | 932 downloads

#22
Edited 4:25am Mar 23, 2011 2:51am | Edited 4:25am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Inserted Code

extern string Symbol_1 = "EURUSD";

It is probably better to let the EA use the symbol of the chart it is placed on.
See Symbol()

Inserted Code

if(newbar==Time[0])return(0); // 
else newbar=Time[0];

There will probably be routines to manage any trade that has been opened so exiting at the beginning of the function is not a good idea.

#23
Mar 23, 2011 5:02am Mar 23, 2011 5:02am

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

XapHod,

thanks for your reply,

however i think i spotted a bug. when i enter takeprofit and stoploss at 30 and 20. it will close the trades at 2 pips and 3 pips.

to check if it will do a buy or sell at every arrow i changed the take profit from 10 to 1000 on take profit and changed from 10 to 1000 on stoploss. however then it only opens like 5 trades.

also i cant set the take profit and stoploss on 0 to see if it only opens 1 trade a bar for every arrow. because as i see how it looks now. your Ea still opens like multi orders on 1 bar when signal of the arrow is given.

also a question. at the bottom of the code you convert price to pips. is this to calculate the take profit and stoploss?

thank you

#24
Edited 7:18am Mar 23, 2011 7:07am | Edited 7:18am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

however i think i spotted a bug. when i enter takeprofit and stoploss at 30 and 20. it will close the trades at 2 pips and 3 pips.

Ignored

If you broker uses 5 digits instead of 4, then 30=3.0 pips and 20=2.0 pips.

Quoting trade4fun

Disliked

to check if it will do a buy or sell at every arrow i changed the take profit from 10 to 1000 on take profit and changed from 10 to 1000 on stoploss. however then it only opens like 5 trades.

Ignored

The EA will open a maximum of ONE buy and ONE sell position at a time. It will not open any more positions until those trades are closed. In fact, it probably would be better to open only ONE trade in ONE direction at a time.

Quoting trade4fun

Disliked

also i cant set the take profit and stoploss on 0 to see if it only opens 1 trade a bar for every arrow. because as i see how it looks now. your Ea still opens like multi orders on 1 bar when signal of the arrow is given.

Ignored

Why would anybody set the SL and TP to 0? Given a spread of a few pips every trade will end up as a loss. Are you trying to make money for your broker?

If you set the SL and TP to 0 then a trade will be opened and closed immediately, at a loss. The EA opens a new trade if there is no open trade in the direction of the signal. That is by design. It is assumed that you would have a TP and SL greater than 0.

Quoting trade4fun

Disliked

also a question. at the bottom of the code you convert price to pips. is this to calculate the take profit and stoploss?

Ignored

Convert a price difference to pips.
Yes.

The EA is for illustrative purposes only. You are building an EA without a trading strategy. 'Putting the cart before the horse' so to speak. The supersignal jumps all over the place and is therefore probably not suited to be the sole indicator for an EA.

The EA:

Opens a trade as soon as a signal is received on the last closed bar.
It does not open any more trades in the same direction until the currently open trade is closed.
It assumes you intend to make a profit and therefore set reasonable parameters for the time frame being used.

#25
Mar 23, 2011 7:26am Mar 23, 2011 7:26am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

See this post for a more complete example of an EA using iCustom. This one is also written for use in the strategy tester.
http://www.forexfactory.com/showpost.php?p=4381481

#26
Mar 24, 2011 5:00am Mar 24, 2011 5:00am

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

Hi Xaphod,

thanks for the explanation, but again this Ea is not for made for profit. i would never run it on a live account at all. it is study purpose only.

i dont think this supersignal indicator is actually good at all. but it is a simple indicator with arrows calculating fractals. good for study purpose of a n00b like i

i studied your Ea some more. and i had a question.

lets say i take 1 trade a bar based on the supersignal indicator. so 1 arrow is given. we only take 1 trade after that bar is closed.

however i want the stoploss and takeprofit be done on tick.

but so far i manage to get, either all the trades opening only by bar. and take profit and stoploss after bar is closed.

or i have all trades opening on tick and stoploss and takeprofit on tick.

but i want openings of trades. 1 per bar and takeprofit and stoploss closed on tickdata. so not wait until bar is closed.

P.S. check private mail.

i have this code at the moment

Inserted Code

// External variables
extern bool CheckOncePerBar = true;

//Global variables
datetime CurrentTimeStamp;

//init function

int()
{
CurrentTimeStamp = Time[0];

int start()

if(checkOncePerBar == true)
{
int BarShift = 1;
if(CurrentTimeStamp != Time[0];
{
CurrentTimeStamp = Time[0];
bool NewBar = true;
}
else NewBar = false;
}
else
{
NewBar = true;
Barshift = 0;
}

thanks

#27
Mar 24, 2011 7:52am Mar 24, 2011 7:52am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Added code to open trades on new bar only:

PHP Code

//+------------------------------------------------------------------+
//| SupersiganlEA.mq4
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, Whatever"
#property link      "http://www.?????.com"

// Input parameters
extern double Lots = 0.1;
extern double Slippage = 2.0;
extern double TakeProfit = 30;
extern double StopLoss = 20;
extern int    MagicNr=9502;

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() { 
  double ArrowUp, ArrowDown;
  static int iBuyTicket=-1;
  static int iSellTicket=-1;
  static datetime tCurTime;
 
  
  // Get Supersignal state
  ArrowUp = iCustom(NULL,0,"supersignals",1,1);
  ArrowDown = iCustom(NULL,0,"supersignals",0,1);
  
  // Open orders on new bar only
  if (tCurTime != Time[0]) {
    tCurTime=Time[0];
    // Open Buy order if previous bar has arrow up signal
    if  (ArrowUp!=EMPTY_VALUE && iBuyTicket<0) {
      iBuyTicket=OrderSend(Symbol(),OP_BUY,Lots, Ask, Slippage, 0, 0, 
                "Supersignal", MagicNr, NULL, LimeGreen);    
    }
    // Open Sell order if previous bar has arrow up signal
    if  (ArrowDown!=EMPTY_VALUE && iSellTicket<0) {
      iSellTicket=OrderSend(Symbol(),OP_SELL,Lots, Bid, Slippage, 0, 0,
                "Supersignal", MagicNr, NULL, LimeGreen);    
    }
  }
  
  // Check SL and TP for BUY ticket
  if (OrderSelect( iBuyTicket, SELECT_BY_TICKET)==True) {
    // Close position if SL is Hit
    if (dPips(Bid,OrderOpenPrice())<=-StopLoss)
      if ( OrderClose(iBuyTicket,Lots,Bid,Slippage)==True)
        iBuyTicket=-1; 
    // Close position if TP is Hit     
    if (dPips(Bid,OrderOpenPrice())>=TakeProfit)
      if ( OrderClose(iBuyTicket,Lots,Bid,Slippage)==True)
        iBuyTicket=-1;       
    //Print("Buy. Current Pips=",dPips(OrderOpenPrice(),Bid));  
  }
  
  // Check SL and TP for SELL ticket
  if (OrderSelect( iSellTicket, SELECT_BY_TICKET)==True) {
    // Close position if SL is Hit
    if (dPips(OrderOpenPrice(),Ask)>=StopLoss)
      if ( OrderClose(iSellTicket,Lots,Ask,Slippage)==True)
        iSellTicket=-1;   
    // Close position if TP is Hit
    if (dPips(OrderOpenPrice(),Ask)<=-TakeProfit)
      if ( OrderClose(iSellTicket,Lots,Ask,Slippage)==True)
        iSellTicket=-1;   
    //Print("Sell. Current Pips=",dPips(OrderOpenPrice(),Bid));  
  }
  
  return(0);
}


//-----------------------------------------------------------------------------
// function: dPips()
// Description: Convert a price difference to pips.
//-----------------------------------------------------------------------------
double dPips(double dPrice1,double dPrice2,bool bAbs=false) {
  double dPipValue=(dPrice1-dPrice2)/Point; 
  if (bAbs) return( MathAbs(dPipValue));
  else return(dPipValue);
}

#28
Mar 24, 2011 12:43pm Mar 24, 2011 12:43pm

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

hi Xaphod,

thanks again for helping.

i tried to modify your Ea to do what i really wanted, so far no succes.

the problem i have at the moment is to understand your logic behind the take profit and stoploss.

if add a takeprofit or stopploss of 40(5 digit broker). then it will open several orders.

however if i do a takeprofit of 40(5 digit broker) and stoploss of 400. then it will only open 1 buy order until a sell signal is given. because take profit of 40 pips is not reached yet.

i checked you static inc you add before orders. and tried to play around with removing static for example. but if i remove static infront of

Inserted Code

datetime tCurTime;

it opens orders on the bar every tick.

however if i leave static on. it opens 1 order when first arrow is given. however it will not open a new trade when arrow moves up to the new bar.

so basicly the take profit and stoploss should be dynamic if i say this right and opening the orders should be static?

thanks again.

#29
Edited 3:29pm Mar 24, 2011 1:32pm | Edited 3:29pm

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

if add a takeprofit or stopploss of 40(5 digit broker). then it will open several orders.

however if i do a takeprofit of 40(5 digit broker) and stoploss of 400. then it will only open 1 buy order until a sell signal is given. because take profit of 40 pips is not reached yet.

Ignored

If you want to have several concurrent orders open, you will need to create ticket variables for each of the orders so you can keep track of the orders and manage them. Currently it is done for one buy and one sell order only.
If you want to step it up a notch you would use arrays.
http://book.mql4.com/variables/arrays
http://docs.mql4.com/array

Quoting trade4fun

Disliked
i checked you static inc you add before orders. and tried to play around with removing static for example. but if i remove static infront of
Inserted Code
datetime tCurTime;
it opens orders on the bar every tick.

however if i leave static on. it opens 1 order when first arrow is given. however it will not open a new trade when arrow moves up to the new bar.
Ignored

http://docs.mql4.com/basis/variables/static
http://book.mql4.com/variables/types

Quoting trade4fun

Disliked

so basicly the take profit and stoploss should be dynamic if i say this right and opening the orders should be static?

Ignored

Nothing should be anything. It does what you program it to do.

Currently the SL & TP blocks do this:
On every tick:

Check that there is an open ticket.
If there is, Check the price in relation to the SL and TP.
If price has hit the SL or TP close the ticket.
If the ticket was successfully closed, Reset the ticket variable to -1.

And on every bar:

Check if there is an arrow signal AND a free ticket.
If the above conditions are met open a ticket.
If the order was successful, set the value of the free ticket to the new order ticket.

Also worth reading:
http://book.mql4.com/samples/expert

#30
Mar 25, 2011 6:04am Mar 25, 2011 6:04am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

The EA modified to handle a number of concurrent trades:

PHP Code

//+------------------------------------------------------------------+
//| BasketEA.mq4
//| By Xaphod
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, Basket Case"
#property link      "www.forexfactory.com/xaphod"

// Definitions
#define MAX_TICKETS 6

// Input parameters
extern double Lots = 0.1;
extern double Slippage = 2.0;
extern double TakeProfit = 25;
extern double StopLoss = 15;
extern int    MagicNr=100;

// Global variables
int giTicket[MAX_TICKETS];

//--------------------------------------------------------------------
// function: init()
// Description: Custom indicator initialization function.
//--------------------------------------------------------------------
int init() {
  // Reset all tickets
  for (int i=0; i<MAX_TICKETS;i++)
    giTicket[i]=-1;
}

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() { 
  double ArrowUp, ArrowDown;
  static datetime tCurTime;
  int iFreeTicket=-1;
  int i;
  
  // Get Supersignal state
  ArrowUp = iCustom(NULL,0,"supersignals",1,1);
  ArrowDown = iCustom(NULL,0,"supersignals",0,1);
  
  // Open orders on new bar only
  if (tCurTime != Time[0]) {
    tCurTime=Time[0];
    
    // Get the first free ticket
    iFreeTicket=GetFreeTicket();
    
    // Open Buy order if previous bar has arrow up signal
    if  (ArrowUp!=EMPTY_VALUE && iFreeTicket>-1) {
      giTicket[iFreeTicket]=OrderSend(Symbol(),OP_BUY,Lots, Ask, Slippage, 
                0, 0, "Supersignal", MagicNr+i, NULL, LimeGreen);    
    }
    // Open Sell order if previous bar has arrow up signal
    if  (ArrowDown!=EMPTY_VALUE && iFreeTicket>-1) {
      giTicket[iFreeTicket]=OrderSend(Symbol(),OP_SELL,Lots, Bid, Slippage, 
                0, 0, "Supersignal", MagicNr+i, NULL, LimeGreen);    
    }
  }
  
  // Check SL and TP for each ticket
  for ( i=0; i<MAX_TICKETS;i++) {    
    if (OrderSelect( giTicket[i], SELECT_BY_TICKET)==True) {
      // Check SL and TP for BUY ticket
      if (OrderType()==OP_BUY) {
        // Close position if SL is Hit
        if (ToPips(Bid,OrderOpenPrice())<=-StopLoss)
          if ( OrderClose(giTicket[i],Lots,Bid,Slippage)==True)
            giTicket[i]=-1; 
        // Close position if TP is Hit     
        if (ToPips(Bid,OrderOpenPrice())>=TakeProfit)
          if ( OrderClose(giTicket[i],Lots,Bid,Slippage)==True)
            giTicket[i]=-1;       
        //Print("Buy. Current Pips=",dPips(OrderOpenPrice(),Bid));  
      }
      // Check SL and TP for SELL ticket
      if (OrderType()==OP_SELL ) {
        // Close position if SL is Hit
        if (ToPips(OrderOpenPrice(),Ask)>=StopLoss)
          if ( OrderClose(giTicket[i],Lots,Ask,Slippage)==True)
            giTicket[i]=-1;   
        // Close position if TP is Hit
        if (ToPips(OrderOpenPrice(),Ask)<=-TakeProfit)
          if ( OrderClose(giTicket[i],Lots,Ask,Slippage)==True)
            giTicket[i]=-1;   
        //Print("Sell. Current Pips=",dPips(OrderOpenPrice(),Bid));  
      }
    }
  }
  
  return(0);
}

//---------------------------------------------------------------
// function: GetFreeTicket()
// Description: Return the index of the first free ticket, or -1
//---------------------------------------------------------------
int GetFreeTicket() {
  for (int i=0; i<MAX_TICKETS;i++)
    if (giTicket[i]==-1)
      return(i);
  return(-1);      
} 

//----------------------------------------------------------------
// function: ToPips()
// Description: Convert a price difference to pips.
//----------------------------------------------------------------
double ToPips(double dPrice1,double dPrice2,bool bAbs=false) {
  double dPipValue=(dPrice1-dPrice2)/Point; 
  if (bAbs) return( MathAbs(dPipValue));
  else return(dPipValue);
}

Attached File(s)

BasketEA.mq4 4 KB | 741 downloads

#31
Mar 25, 2011 8:56am Mar 25, 2011 8:56am

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

hi Xaphop,

thanks a lot for that basketEA.

i add below what i made last night.
i took out the use for currency symbol. so now it is everything it wants to be.

i have now a take profit inside which works on 4 digits an 5 digit brokers, without having to add or deduct a 0 depending on 4 or 5 digit brokers.

my question is why do you use i++ in your basket code. while i use i--
because i believe we do here actually the same.

we create a loop for placing orders. or am i mistaken?

i am going to study your Ea more and see if i can spot the difference.

but thanks a lot for th ehelp. i am now going to read those tutorial links.

Inserted Code

for (int i=0; i<MAX_TICKETS;i++)

Inserted Code

while i use for(int i=total-1;i>=0;i--)

Inserted Code

//+------------------------------------------------------------------+
//|                                              Supersignaltest.mq4 |
//|                      Copyright © 2011, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

extern double Lots = 0.1;
extern bool S1_Buy = true;
extern double S1_Lots = 0.1;
extern bool S2_Buy = false;
extern double S2_Lots = 0.1;
extern double PT_Buy  = 4.0; // Maximum Profit target (Buy)  in whichever Currency you have in your account
extern double PT_Sell = 4.0; // Maximum Profit target (Sell) in whichever Currency you have in your account
extern string Profit_Target= "Enter PT above To Book the Profit to that Amount in per -OPEN trade ";
extern string Use= "To Book Profits in Open Winning Trades";
extern string Use2= "Kinda TakeProfit to,OPEN Trades in Loss.In this case PT has to be a Negative Integer";

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int magic=9502;
  
   return(0);
  
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+


int start()

{

static datetime tCurTime;
 
double ArrowUp = iCustom(NULL,0,"supersignals",0,1);
double ArrowDown = iCustom(NULL,0,"supersignals",1,1);

  if (tCurTime != Time[0]) {
    tCurTime=Time[0];
if( ArrowUp != EMPTY_VALUE )

  {
    OrderSend(Symbol(),OP_BUY, S1_Lots, MarketInfo(Symbol(),MODE_ASK), 2, NULL, NULL, "RapidFire", magic, NULL, LimeGreen); 
  }
  if(ArrowDown != EMPTY_VALUE)
  
  {
  OrderSend(Symbol(),OP_SELL, S2_Lots, MarketInfo(Symbol(),MODE_BID), 2, NULL, NULL, "RapidFire", magic, NULL, FireBrick);   
  }
  }
  int total = OrdersTotal();
  for(int i=total-1;i>=0;i--)
  {
    OrderSelect(i, SELECT_BY_POS);
    int type   = OrderType();

    bool result = false;
    
    switch(type)
    {
      //Close opened long positions
      case OP_BUY       : if ( OrderProfit() >= PT_Buy)  result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
                          break;
      
      //Close opened short positions
      case OP_SELL      : if ( OrderProfit() >= PT_Sell) result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
             break;
                   
    }
    
    if(result == false)
    {
      //Alert("Order " , OrderTicket() , " failed to close. Error:" , GetLastError() );
      Sleep(0);
    }  
  }

#32
Mar 25, 2011 9:44am Mar 25, 2011 9:44am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

my question is why do you use i++ in your basket code. while i use i--
because i believe we do here actually the same.

Ignored

http://book.mql4.com/operators/for
http://docs.mql4.com/basis/operators/for

Quoting trade4fun

Disliked

we create a loop for placing orders. or am i mistaken?

Ignored

The loops are used here to loop through open tickets.

#33
Mar 26, 2011 7:05am Mar 26, 2011 7:05am

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

Xaphod thanks again for your answer.

i have to say i still dont understand it yet. i read the links a dozen of times. i just dont understand why would 1 use i-- and one i++ to me , the outcome looks the same.

to me it looks like i go from 0 to 100 in your case. and in my case we go from 100 to 0.

in result both look the same to me. i really need to study this more. i miss the logic in it.

before i proceed with something else i am first going to study this until i get it.

thank you

#34
Mar 26, 2011 5:53pm Mar 26, 2011 5:53pm

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

to me it looks like i go from 0 to 100 in your case. and in my case we go from 100 to 0.

in result both look the same to me. i really need to study this more. i miss the logic in it.

Ignored

Basic programming concepts: Iteration.
In this particular case, an analogy may illustrate best: If you count your bottles of beer from left to right or from right to left, what is the difference? What is the logic in doing it the one way and not the other?

http://en.wikipedia.org/wiki/Iteration
http://cnx.org/content/m19628/latest/

http://www.lysator.liu.se/c/bwk-tutor.html#increment
http://www.lysator.liu.se/c/bwk-tutor.html#for

#35
Mar 27, 2011 4:45pm Mar 27, 2011 4:45pm

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

hi Xaphod,

thanks a lot for the example. i checked the links and it became much more clear. i also checked the beginners guide of the linsk you send to me. bu i have to say

it was actually very simple, when i studied it it more. that said i am still not satisfied with the sample i made, compared to yours.

also your code is much more tight then mine. today have made myself a few samples, building with your code so i get that underhand.

what i want to teach myself is that when i build the code step by step. i always take in account that it is build in order. that even how complicated it could get. there is order in the way it is written. my programming still to lose.

also what would you advise to do next? first start making an indicator or continue with the EA.

actually in my head the next step would be trying to make an array. and try to indentify the orders in that EA. but maybe it is yet to far fetched.

or maybe try to add an indicator direct into an EA. so not using icustom, but try to add code direct into an EA?

Thanks

#36
Mar 28, 2011 6:28am Mar 28, 2011 6:28am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

also your code is much more tight then mine. today have made myself a few samples, building with your code so i get that underhand.
..... my programming still to lose.

Ignored

The book Code Complete is a good guide. Read it:
http://www.cc2e.com/

Quoting trade4fun

Disliked

also what would you advise to do next? first start making an indicator or continue with the EA.

Ignored

Read the documentation and Practice a lot. Indicator or Ea. It does not matter. There are many requests for modifications to indicators in 'Platform Tech'. You can use them for practice.

Quoting trade4fun

Disliked

or maybe try to add an indicator direct into an EA. so not using icustom, but try to add code direct into an EA?

Ignored

Depends on how complicated the indicator is. Unless you have performance issues, iCustom is the quick and easy.

You could improve your programming knowledge and proficiency by taking a course in programming concepts. For Example:
http://ocw.mit.edu/courses/electrica...ideo-lectures/

Or more hardcore:
http://ocw.mit.edu/courses/electrica...s-spring-2005/

Easier hardcore:
http://www.htdp.org/2003-09-26/

#37
Mar 30, 2011 9:08am Mar 30, 2011 9:08am

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

hi Xaphod,

thanks a lot for the links,

i stumbled on another problem i cant get my mind around.

i created a simple Ea again to test the attached indicator.

the indicator basicly gives every 5 minutes either a buy signal or a sell signal. however the arrow it draws only once when first buy signal is given or once for a sell arrow.

now my idea is to open a buy order when an arrow is shown and a sell order when an arrow is shown. this works fine if it goes from up arrow to down arrow.

however if 2 up arrows apear from the same signal like shown in the picture the whole logic changes.

on the first green arrow it will do a buy , then on the other green arrow it will do a sell. how does this happen?

thanks

Inserted Code

//+------------------------------------------------------------------+
//|                                                IINWMARROWSEA.mq4 |
//|                      Copyright © 2011, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

extern double Lots = 0.1;
extern double    StopLoss = 0;
extern double    TakeProfit = 4;
extern int FasterMode=3; //0=sma, 1=ema, 2=smma, 3=lwma
extern int FasterMA=  3;
extern int SlowerMode=3; //0=sma, 1=ema, 2=smma, 3=lwma
extern int SlowerMA=  3;
double UsePoint;



//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int magic=9502;
int init()
{
UsePoint = PipPoint(Symbol());
}
  
   return(0);
  
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
datetime newbar;

int start()

{

if(newbar==Time[0])return(0);

else newbar=Time[0];
 
double ArrowUp = iCustom(NULL,0,"IINWMARROWS",FasterMode,FasterMA,SlowerMode,SlowerMA,0,1);
double ArrowDown = iCustom(NULL,0,"IINWMARROWS",FasterMode,FasterMA,SlowerMode,SlowerMA,1,1);

double OpenPrice = Ask;

//Calculate Stop loss and take profit for Buys
if(StopLoss > 0) double BuyStopLoss = OpenPrice - (StopLoss * UsePoint);
if(TakeProfit > 0) double BuyTakeProfit = OpenPrice + (TakeProfit * UsePoint);

if(ArrowUp != EMPTY_VALUE )
{
    OrderSend(Symbol(),OP_BUY, 0.1, MarketInfo(Symbol(),MODE_ASK), 2, BuyStopLoss, BuyTakeProfit, "RapidFire", magic, NULL, LimeGreen); 
  }
  OpenPrice = Bid;
//Calculate Stop loss and take profit for Sells
if(StopLoss > 0) double SellStopLoss = OpenPrice + (StopLoss * UsePoint);
if(TakeProfit > 0) double SellTakeProfit = OpenPrice - (TakeProfit * UsePoint);

  if(ArrowDown != EMPTY_VALUE)
  
  {
  OrderSend(Symbol(),OP_SELL, 0.1, MarketInfo(Symbol(),MODE_BID), 2, SellStopLoss, SellTakeProfit, "RapidFire", magic, NULL, FireBrick);   
  }
  return(0);
}
// Pip Point Function
double PipPoint(string Currency)
{
int CalcDigits = MarketInfo(Currency,MODE_DIGITS);
if (CalcDigits == 2 || CalcDigits == 3) double CalcPoint = 0.01;
else if(CalcDigits == 4 || CalcDigits == 5) CalcPoint = 0.0001;
return(CalcPoint);
}

Attached Image (click to enlarge)

Click to Enlarge

Name: 2arrow.gif
Size: 26 KB

Attached File(s)

IINWMARROWS.mq4 4 KB | 686 downloads

#38
Mar 30, 2011 11:29am Mar 30, 2011 11:29am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

the indicator basicly gives every 5 minutes either a buy signal or a sell signal. however the arrow it draws only once when first buy signal is given or once for a sell arrow....

Ignored

Sorry, I don't understand what it is supposed to do or not do.

To debug the program, use the print() or comment() to print out values you need to monitor in relevant areas of your code. Verify that they are what they should be and if they are not, step backwards from that point to find the part of the code that is defective.

#39
Mar 31, 2011 5:09am Mar 31, 2011 5:09am

trade4fun
| Commercial User | Joined May 2010 | 382 Posts

hi Xaphod,

i did the print function.

and my result is this for the first few signals of that period as shown in the picture.

at 1:05 it should have opened a buy.

at 1.10 both signals are empty value , so nothing needs to be opened. so far so good.

then at 1.15 it opens a sell order. but why? on the chart were i look there is no red arrow given. however as you can see in the log at 1.15 a sell has been triggered.

then at 1.20 it opens a buy order as it actually should have.

so my question is. why was a sell order given at 1.15, when no red arrow was shown chart?

or did i just discovered that sometimes the indicator repaints?

thank you

PHP Code

11:33:23 2011.03.28 01:05  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 1.40212170, ArrowDown: 2147483647.00000000 Time: 2011.03.28 01:00
11:33:23 2011.03.28 01:05  IINWMARROWSEA4 EURUSD,M5: open #4 buy 0.10 EURUSD at 1.40247 ok
11:33:23 2011.03.28 01:10  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 2147483647.00000000 Time: 2011.03.28 01:05
11:33:23 2011.03.28 01:15  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 1.40262050 Time: 2011.03.28 01:10
11:33:23 2011.03.28 01:15  IINWMARROWSEA4 EURUSD,M5: open #5 sell 0.10 EURUSD at 1.40229 ok
11:33:23 2011.03.28 01:20  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 1.40208340, ArrowDown: 2147483647.00000000 Time: 2011.03.28 01:15
11:33:23 2011.03.28 01:20  IINWMARROWSEA4 EURUSD,M5: open #6 buy 0.10 EURUSD at 1.40259 ok
11:33:23 2011.03.28 01:25  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 2147483647.00000000 Time: 2011.03.28 01:20
11:33:23 2011.03.28 01:30  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 2147483647.00000000 Time: 2011.03.28 01:25
11:33:23 2011.03.28 01:35  IINWMARROWSEA4 EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 1.40337670 Time: 2011.03.28 01:30
11:33:23 2011.03.28 01:35  IINWMARROWSEA4 EURUSD,M5: open #7 sell 0.10 EURUSD at 1.40228 ok

#40
Edited 8:17am Mar 31, 2011 7:56am | Edited 8:17am

Xaphod
Joined Mar 2010 | Status: Trader | 1,380 Posts

Quoting trade4fun

Disliked

then at 1.15 it opens a sell order. but why? on the chart were i look there is no red arrow given. however as you can see in the log at 1.15 a sell has been triggered
11:33:23 2011.03.28 01:15 IINWMARROWSEA4 EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 1.40262050 Time: 2011.03.28 01:10
11:33:23 2011.03.28 01:15 IINWMARROWSEA4 EURUSD,M5: open #5 sell 0.10 EURUSD at 1.40229 ok

Ignored

01:15 ArrowDown: 1.40262050 Time: 2011.03.28 01:10
That looks like a sell signal to me. The signal is on the previous bar, 01:10.

Try stepping tick by tick in the strategy tester to see what is going on.

Yes, the indicator is seeing the future before it has happened. At time i=0, bar i-1 does not exist:

Inserted Code

  fasterMAnow=iMA(NULL, 0, FasterMA, 0, FasterMode, PRICE_CLOSE, i);
  fasterMAprevious=iMA(NULL, 0, FasterMA, 0, FasterMode, PRICE_CLOSE, i+1);
  fasterMAafter=iMA(NULL, 0, FasterMA, 0, FasterMode, PRICE_CLOSE, i-1);

  if ((fasterMAnow > slowerMAnow) && (fasterMAprevious < slowerMAprevious) &&
       (fasterMAafter > slowerMAafter))

Platform Tech
/
How to read a buffer given by an arrow signal with iCustom?
Reply to Thread
- 1 Page 2 3
- 1 Page 2 3

0 traders viewing now

Options

Similar Threads

How to read a buffer given by an arrow signal with iCustom?