Sixths trading - an EA by macman, Bob and Steve mk 2

Quoting greven

Disliked

I'm recovering audusd, I will try to trail the whole recover to see if it's a good idea to trail after be+10 and let the recovery run until exaustion
Pray for me!

Ignored

Quoting SteveHopwood

Disliked

Latest update in post 1. Please read the temporary section for details.

I do not recommend using this on our live accounts just yet. Would someone demo it, please, and report any bugs; also report if it works cleanly.

Ignored

Quoting SteveHopwood

Disliked

Sorry guys. I just realised the function needs an extra conditional to make sure it sets at least a breakeven stop.

Mostly this will not matter; occasionally it will.

Post 1.

Ignored

Quoting SteveHopwood

Disliked

Sorry guys. I just realised the function needs an extra conditional to make sure it sets at least a breakeven stop.

Mostly this will not matter; occasionally it will.

Post 1.

Ignored

void CalculateTrades()
{
   double target;

   bool TradingAllowed = IsTradingAllowed();
   if (!TradingAllowed) return;


  
   double SendLots = Lot;
   //Using Recovery
   if (RecoveryInProgress)
   {
      if (OpenTrades == 2) 
      {
         SendLots = Lot * 2;         
         if (Use1.1.3.3Recovery) SendLots = Lot * 3;
      }//if (OpenTrades == 2) 
      
      if (OpenTrades == 3) 
      {
         SendLots = Lot * 4;
         if (Use1.1.3.3Recovery) SendLots = Lot * 3;
      }//if (OpenTrades == 3) 
      
      if (OpenTrades == 4) return;//No further trading is possible
      
      
   }//if (RecoveryInProgress)
   
   double ReEntryLineVal = ObjectGet(reentrylinename, OBJPROP_PRICE1);
   
   double stop;

   //Sell
   target = NormalizeDouble(TopLine - (PipsBufferFromTradeLine * Point), Digits);
   if ((Bid >= target || Bid > HalfTopLine && High[1] >= TopLine) && TradeShort)
   {
      if (!UseHedging && BuyOpen == True) return;
      
      
      if (ReEntryLineVal > 0)
      {
         if (Bid < ReEntryLineVal) return;
         if (HalfTopLine < ReEntryLineVal) return;
      }//if (ReEntryLineVal > 0)
      
      [color=Red]//Market must have moved into the target area from below
      if (OldBid < target) Touches++;
      OldBid = Bid;
      if (Touches < TouchesRequired) return;[/color]
      
      
      if (!DoesTradeExist(HalfTopLine) ) 
      {
         if (UseStopLoss) stop = CalculateStop(HalfTopLine, OP_SELL);
         while(IsTradeContextBusy()) Sleep(100);
         bool result = SendSingleTrade(OP_SELLSTOP, " ", SendLots, HalfTopLine, stop, 0, 0);
         //if (result && !RecoveryInProgress && UseTplTp) DrawTakeProfitLine(OP_SELL);
      }//if (!DoesTradeExist(TopGoldLine) ) 
      
      if (result) 
      {
         CalculateReEntryLinePips();
         AddReEntryLine(NormalizeDouble(HalfTopLine + (ReEntryLinePips * Point), Digits) ); 
      }//if (result) 
      
      //if (!result) return;     
      
   }//if (Bid >= target && Primary_trades && TradeShort)
   
   
   //Buy
   stop = 0;
   target = NormalizeDouble(BottomLine + (PipsBufferFromTradeLine * Point), Digits);
   if ((Ask <= target || Ask < HalfBottomLine && Low[1] <= BottomLine) && TradeLong && Touches >= TouchesRequired)
   {
      
      if (!UseHedging && SellOpen == True) return;
      if (ReEntryLineVal > 0)
      {
         if (Ask > ReEntryLineVal) return;
         if (HalfBottomLine > ReEntryLineVal) return;
      }//if (ReEntryLineVal > 0)
      
      [color=Red]//Market must have moved into the target area from above
      if (OldBid > target) Touches++;
      OldBid = Bid;
      if (Touches < TouchesRequired) return;[/color]
      
      
      if (!DoesTradeExist(HalfBottomLine) ) 
      {
         if (UseStopLoss) stop = CalculateStop(HalfBottomLine, OP_BUY);         
         while(IsTradeContextBusy()) Sleep(100);
         result = SendSingleTrade(OP_BUYSTOP, " ", SendLots, HalfBottomLine, stop, 0, 0);
         //if (result && !RecoveryInProgress && UseTplTp) DrawTakeProfitLine(OP_BUY);
      }//if (!DoesTradeExist(HalfBottomLine) ) 
      
      if (result) 
      {
         CalculateReEntryLinePips();
         AddReEntryLine(NormalizeDouble(HalfBottomLine - (ReEntryLinePips * Point), Digits) );
         Touches = 0;
      }//if (result) 
      
      //if (!result) return;     
      
   }//if (Ask <= target && Primary_trades && TradeLong)
   

}//End void CalculateTrades()

//Should open trades be closed?
if (BasketUpl >= 0) LookForTradeClosure();

   
//Should open trades be closed?
if (BasketUpl >= 0[color=Red] && HedgingInProgress[/color]) LookForTradeClosure();

Quoting SteveHopwood

Disliked

I just had an idea that I will throw into the public domain to see what people think.

Instead of sending the pending trade at the first touch of the outer lines, what if we wait for a double/triple touch. We might lose some trades; we might avoid spending so much of our lives watching Recovery do its thing.

What does everyone else think?

Ignored

Quoting SteveHopwood

Disliked

Also, whilst looking for the best place to put the code, I noticed this in start():

Inserted Code

//Should open trades be closed?
if (BasketUpl >= 0) LookForTradeClosure();

This explains why some of my Recovery groups were closing prematurely, miles short of their tp's, so I have changed it to this:

Inserted Code

   
//Should open trades be closed?
if (BasketUpl >= 0[color=Red] && HedgingInProgress[/color]) LookForTradeClosure();

Ignored

Quoting TallCoolOne

Disliked

Hi Steve,

I think this code in your Candle Stick TS function needs to be changed.

int stoplevel = MarketInfo(Symbol(), MODE_STOPLEVEL);

to this:

int stoplevel = MarketInfo(Symbol(), MODE_STOPLEVEL) * Point;

Ignored

Quoting Pippopotamus

Disliked

The best laid plans of quants and men have failed to refine trading entries much beyond an educated guess. Changes in recovery lot sizing and schedule could greatly reduce duration of recovery process. Entry then, 2x, then 6x orig. lot size might serve well. Like this, a retracement of 0.5 of whatever interval is specified for re-entry is all that is nec. for recovery to make 0.5 of said interval in PROFITS. Ex., G/J H1 ATR1620 is 28 pips...Enter @ 1 lot. Re-enter at 1.5 ATRs against trade @2 lots. Mkt retraces 0.75 ATR, +42-21=+21 pips. Same at...

Ignored

Quoting mbkennel

Disliked

Isn't LookForTradeClosure() intended to close just-plain regular trades? Why is it restricted to Hedging?

Ignored

Quoting SteveHopwood

Disliked

Cheers. I almost always forget this.

This is an essential fix for anyone who wants to use the candlestick ts - post 1.

Ignored

Quoting TallCoolOne

Disliked

My bad Steve, we might want to define it as double and not int also.

Thanks - TCO.

Ignored

Quoting SteveHopwood

Disliked

Hmmmmm. I just tried to change my signature. Look what happened. Click on it.

Ignored

Quoting SteveHopwood

Disliked

The swap filter applies at trade-trigger time. If a pending trade is already in place, TOB will not delete it because of swap.

Ignored

Quoting ForexPete

Disliked

Thanks Steve, good answer to delete any pending trades on swap pairs when first turning on the filters.

Ignored