How to read a buffer given by an arrow signal with iCustom? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

way to get multiple buffer values with single iCustom call? 23 replies

Need help, I can't get the value of the buffer using Icustom() 5 replies

Read Buffer in the back and print result 0 replies

Problem with iCustom and T_S_R Signal Line 1 reply

Coding MACD / Laguerre Arrow Signal?? HELP 5 replies

Attachments: How to read a buffer given by an arrow signal with iCustom?
Exit Attachments

How to read a buffer given by an arrow signal with iCustom?

  • #1
  • First Post: Mar 20, 2011 5:06am Mar 20, 2011 5:06am
i dont get it.

i can do something simple like

Inserted Code
double SlopeDown = iCustom(NULL,0,"Pattern_Recognition_Master_v7",1,1);

if( SlopeUp == EMPTY_VALUE && SlopeDown != EMPTY_VALUE )

however when there is an indicator which has an arrow in it

for example VQ indicator.

SetIndexStyle(3,DRAW_ARROW);
SetIndexArrow(3,233);
SetIndexBuffer(3,UpArrow);
SetIndexStyle(4,DRAW_ARROW);
SetIndexArrow(4,234);

now i believe the right setup is like

double buyarrow = iCustom(NULL,0,"vq",3,0);
double sellarrow = iCustom(NULL,0,"vq",4,0);

but how would i be able to add into an EA that it will buy when the arrow is given? or do a sell when sellarrow is given?

i tried it with empty value but that did not work. any clue?

thanks

Trade4Fun
  • #2
  • Mar 20, 2011 5:36am Mar 20, 2011 5:36am
Quoting trade4fun
double buyarrow = iCustom(NULL,0,"vq",3,0);
double sellarrow = iCustom(NULL,0,"vq",4,0);

but how would i be able to add into an EA that it will buy when the arrow is given? or do a sell when sellarrow is given?

i tried it with empty value but that did not work. any clue?
The values of the Arrows that are not drawn/visible on the screen are not necessarily EMPTY_VALUE.

There are two issues to address here.
1. Verifying that iCustom is indeed working and returning the correct data.
2. Interperating tha data that is being returned by iCustom.

Try printing out the values returned by iCustom for each bar drawn, to see what you are actually receiving. Here is a function you can use to print data on your chart written by phy: http://forum.mql4.com/16962
PHP Code
// Usage: 
// Comment(commentList(textString));// adds and outputs comment history with timestamps
// Comment(commentList());          // null text redisplays existing comment history
// function
 string commentList(string text = ""){
  static string list[31];                                       // list size == 30
  static int r = 0;                                             // r is the array element to return to the caller
  if(text == "") return(list[r]);                               // null text received, return the current comment string
  if(r<ArraySize(list)-1)r++;                                   // increment return pointer while list grows
  for(int i=r-1;i>0;i--){list[i]=list[i-1];}list[r]="";         // make room for new item, clear old concatenated string
  list[0]="n "+TimeToStr(TimeLocal(),TIME_SECONDS)+"  "+text;  // insert new list item
  for(i=0;i<r;i++){list[r]=list[r]+list[i];}                    // recreate the concatenated string
  return(list[r]);                                              // return the concatenated string
 }
You should be receiving a null value (EMPTY_VALUE/EMPTY/0) when no arrows are drawn and a price value when there are arrows.
  • #3
  • Mar 20, 2011 5:49am Mar 20, 2011 5:49am
I look at the buffer values in the Data Window. That should tell you the expected values from iCustom(). If the values in the Data Window don't make sense (poorly coded indicator), there is no point in trying to use iCustom().
  • #4
  • Mar 20, 2011 7:59am Mar 20, 2011 7:59am
thanks for the answers,

i tried to input the code of Xaphod, but it didnt work me. gave lot of errors.

i add this though

Inserted Code
Print("ArrowUp: "+ArrowUp+", ArrowDown: "+ArrowDown+" Time: "+TimeToStr(Time[1]));

however it gave me only empty value signals when i run it in backtester.

i added in here the EA and the indicator. very simple code with very simple indicator.

both is just for learning purpose only.

all i like to know is how can i read the value in my EA and how would i add a buy trigger or sell trigger.

when a line crosses from red to green for example i can add the buy or sell trigger. but not yet with arrows.

thanks for helping already this complete N00B
Attached File(s)
File Type: mq4 supersignalEA.mq4   2 KB | 2,019 downloads
File Type: mq4 supersignals.mq4   1 KB | 2,393 downloads
  • #5
  • Edited 9:44am Mar 20, 2011 9:27am | Edited 9:44am
The commentList() function compiles without any errors.

However, the comment() function will not work in an EA within the strategy tester. Use Print() instead and look at the 'Journal' tab in the strategy tester for the printed data.

From your code it is clear you need to study up on MT4 programming. For an if statement to apply to more than 1 line after it, one has to use a block {}. And so on.

This works:
Attached File(s)
File Type: mq4 supersignalEA.mq4   3 KB | 2,761 downloads


Also, I noticed that the supersignal repaints.

Homework:
http://articles.mql4.com/404
http://articles.mql4.com/417
http://articles.mql4.com/466
http://articles.mql4.com/516
http://articles.mql4.com/536
http://www.forexfactory.com/showthread.php?t=6011
  • #6
  • Mar 20, 2011 10:21am Mar 20, 2011 10:21am
Xaphod,

thanks for helping.

i will read the links you send me and follow up.

however before i do that i just leave this here as well incase i have not find the answer yet in the links.

i know the {} for the orderstatement after IF. i had removed it prior adding the Ea on this forum.

i also know supersignal repaint. but it was the easiest indicator i could find that draw an arrow on chart.

for me the indicator itself is not important. it is the study behind it. that whenever i come across a nice indicator. that i be able to test it in a simple Ea to see how it functions.

when i run your EA and mine. the difference is that yours gives every 5 minutes a new signal. and mine every second.

if i understand it right ,that is what happens because of
[CODE static datetime tCurTime;

if (tCurTime != Time[0]) {
tCurTime=Time[0];][/code]

i checked the journal and i see this

Quote
2011.03.20 16:06:202011.03.14 09:30 supersignalEA EURUSD,M5: ArrowUp: 2147483647.00000000, ArrowDown: 1.39051425, Time: 2011.03.14 09:25

now 2147483647 = empty value if i understand it right

and arrowdown is the price.

so how would i now be able to add in the Ea that when an arrow is given a buy or sell trigger?

normally i do this when a redline crosses a greenline for example

Inserted Code
if( redline == EMPTY_VALUE && greenline != EMPTY_VALUE )

  {
    OrderSend(Symbol_1,OP_BUY, S1_Lots, MarketInfo(Symbol_1,MODE_ASK), 2, NULL, NULL, "RapidFire", magic, NULL, LimeGreen); 
  }

because that is what i dont understand. how do i define arrows in the EA as a buy or sell trigger?

thanks
  • #7
  • Mar 20, 2011 10:53am Mar 20, 2011 10:53am
Quoting trade4fun
i know the {} for the orderstatement after IF. i had removed it prior adding the Ea on this forum.
Inserted Code
int BarsCount = 0;
 
int start()
  { 
  if (Bars > BarsCount)
 
  double ArrowUp = iCustom(NULL,0,"supersignals",0,1);
  double ArrowDown = iCustom(NULL,0,"supersignals",1,1);

  Print("ArrowUp: "+ArrowUp+", ArrowDown: "+ArrowDown+
          " Time:   "+TimeToStr(Time[1]));  
  return(0);
}
The above code does not make much sense. You compare the values Bars & BarsCount and execute ArrowUp = iCustom(NULL,0,"supersignals",0,1) if the condition if filled.
The other 2 lines are always run. BarsCount is never set so the condition is always true. Therefore all three lines are always run which makes the if statement redundant.

You are essentially reading the data from iCustom and printing the data for the previous bar on every incoming tick.

Quoting trade4fun
when i run your EA and mine. the difference is that yours gives every 5 minutes a new signal. and mine every second.
Not quite. My code executes every new bar, your code executes every new tick. Do you want to open a new order on every tick until the current bar closes?

Quoting trade4fun
if i understand it right ,that is what happens because of
Inserted Code
  
static datetime tCurTime;
  if (tCurTime != Time[0]) 
  tCurTime=Time[0];]
Yes

Quoting trade4fun
now 2147483647 = empty value if i understand it right
yes

Quoting trade4fun
so how would i now be able to add in the Ea that when an arrow is given a buy or sell trigger?
You read 2 buffers. One for arrow up and the other for arrow down.
Inserted Code
  if (BufferUp[1]!= EMPTY_VALUE)
     OrderSend(...BUY...)
  else if (BufferDn[1]!= EMPTY_VALUE)
     OrderSend(...SELL...)
  • #8
  • Mar 20, 2011 11:26am Mar 20, 2011 11:26am
again Xaphod,

thanks for the answers,

i just like it to open 1 order when an arrow is given after bar is closed. not every tick or every new bar. just 1 trade.

the stoploss or trail etc that is all for later learning.

for now i simply want to focus how i can add a buy or sell triggers

in your example you talk about

Inserted Code
if (BufferUp[1]!= EMPTY_VALUE)

BufferUP = arrowup?
[1] but what is 1? is that the shift? or is that the buffer?

thanks
  • #9
  • Mar 20, 2011 12:02pm Mar 20, 2011 12:02pm
Quoting trade4fun
in your example you talk about

Inserted Code
if (BufferUp[1]!= EMPTY_VALUE)
BufferUP = arrowup?
[1] but what is 1? is that the shift? or is that the buffer?

thanks
Yes, indicator buffer, shift 1. In your case you would use ArrowUp or ArrowDown which is an indicator buffer with shift 1 received from iCustom.
  • #10
  • Mar 20, 2011 1:02pm Mar 20, 2011 1:02pm
Xaphod,

i tried this,

Inserted Code
double ArrowUp = iCustom(NULL,0,"supersignals",0,1);
double ArrowDown = iCustom(NULL,0,"supersignals",1,1);

if (ArrowUp[1]!= EMPTY_VALUE)
  {
    OrderSend(Symbol_1,OP_BUY, S1_Lots, MarketInfo(Symbol_1,MODE_ASK), 2, NULL, NULL, "RapidFire", magic, NULL, LimeGreen); 
  } 
  }

however metatrader gives me '[' - unexpected tokenCrogram FilesMetaTrader 4.1expertssupersignalEA.mq4 (46, 12)

if i do ArrowUp != EMPTY_VALUE then i get no errors.

however then EA will keep opening orders every tick, not by 1 arrow a time.

so how am i able to stop the Ea from opening so many orders?

thanks
  • #11
  • Mar 20, 2011 4:02pm Mar 20, 2011 4:02pm
Quoting trade4fun
however then EA will keep opening orders every tick, not by 1 arrow a time. so how am i able to stop the Ea from opening so many orders?
thanks
Yes, that is what we discussed earlier. Use the code I sent you in a previous post above.
http://www.forexfactory.com/attachme...hmentid=664401


Quote:
Not quite. My code executes every new bar, your code executes every new tick. Do you want to open a new order on every tick until the current bar closes?

Originally Posted by trade4fun http://www.forexfactory.com/images/buttons/viewpost.gif
if i understand it right ,that is what happens because of
Code:

static datetime tCurTime;
if (tCurTime != Time[0])
tCurTime=Time[0];]


Yes
  • #12
  • Mar 20, 2011 5:02pm Mar 20, 2011 5:02pm
you have ArrowUp DIMed as a simple dowble variable when you use ArrorwUp[ 1 ] its an array element not the ArrowUp you've decleared;

if you want to use an array then you must dim an array. that is why your getting that error.




Quoting trade4fun
Xaphod,

i tried this,

[code]

double ArrowUp = iCustom(NULL,0,"supersignals",0,1);
double ArrowDown = iCustom(NULL,0,"supersignals",1,1);

if (ArrowUp[1]!= EMPTY_VALUE)...
Trader Keit ... Methods Of A Dirt Road Mad Man....
  • #13
  • Mar 20, 2011 5:02pm Mar 20, 2011 5:02pm
Xaphod,

i think you misunderstand me. i dont want the trade to be open every 5 minutes. but once for every arrow.

please check picture.

also thanks a lot for helping me on your free sunday. not many would be willing to do that.

i am sure i almost have got it.

ArrowUp: 2147483647.00000000, ArrowDown: 1.39051425

i understand now that ArrowUp is empty value. and that ArrowDown shows us the indicator value of the previous bar.

it is just the if statements at the moment i am struggling with.

why is it only if ArrowUp != EMPTY_VALUE

and not

if ArrowUp !=Empty_VALUE && ArrowDown == EMPTY_VALUE ?

thanks again
Attached Image (click to enlarge)
Click to Enlarge Name: buy-sell.gif Size: 25 KB
  • #14
  • Mar 21, 2011 2:55am Mar 21, 2011 2:55am
You cannot write an EA in one line of code. You need to:

 

  1. Check the state of the Arrow.
  2. Check the state of a flag variable showing the status of the above arrow.
  3. Open a trade if the Arrow is on and flag var is off.
  4. Set the flag variable indicating that that arrow has been handled.
  5. Repeat for the other arrow.

This is just one method. One could probably go about it in different ways. There is no info on how you intend to proceed after you have opened a trade but that would mean even more steps need to be added to the above.

  • #15
  • Edited 5:03am Mar 21, 2011 3:08am | Edited 5:03am
Quoting trade4fun

it is just the if statements at the moment i am struggling with.

why is it only if ArrowUp != EMPTY_VALUE

and not

if ArrowUp !=Empty_VALUE && ArrowDown == EMPTY_VALUE ?

thanks again
PHP Code
 if (ArrowUp != EMPTY_VALUE)
     OrderSend(...BUY...)
 else if (ArrowDown!= EMPTY_VALUE)
     OrderSend(...SELL...)
PHP Code
bool fBuyOpened=False;
bool fSellOpened=False;
...


if (ArrowUp != EMPTY_VALUE && fBuyOpened==False) {
    if (OrderSend(...BUY...)>-1) {
        fBuyOpened=True;
        ....
    }
    
}
else if (ArrowDown!= EMPTY_VALUE && fSellOpened==False)
    if (OrderSend(...SELL...)>-1) {
        fSellOpened=True;
        ....
    }
....
  • #16
  • Mar 21, 2011 6:08am Mar 21, 2011 6:08am
Xaphod,

thanks again,

i am starting to see the light. i have it now, it opens a new order when arrow appears. however then it start opening hundreds of orders after each other.

Inserted Code
//+------------------------------------------------------------------+
//|                                                supersignalEA.mq4 |
//|                      Copyright © 2011, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

extern double Lots = 0.1;
extern string Symbol_1 = "EURUSD";
extern bool S1_Buy = true;
extern double S1_Lots = 0.1;
extern string Symbol_2 = "EURUSD";
extern bool S2_Buy = false;
extern double S2_Lots = 0.1;

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int magic=9502;
  
   return(0);
  
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+

 
int start()
{ 
 
double ArrowUp = iCustom(NULL,0,"supersignals",0,1);
double ArrowDown = iCustom(NULL,0,"supersignals",1,1);

if (ArrowDown != EMPTY_VALUE)
  {
    OrderSend(Symbol_1,OP_BUY, S1_Lots, MarketInfo(Symbol_1,MODE_ASK), 2, NULL, NULL, "RapidFire", magic, NULL, LimeGreen); 
  }
if (ArrowUp != EMPTY_VALUE)
 {
  OrderSend(Symbol_2,OP_SELL, S2_Lots, MarketInfo(Symbol_1,MODE_BID), 2, NULL, NULL, "RapidFire", magic, NULL, FireBrick);   
  }
return(0);
}

so how am i able to do it with only 1 order a time?

i was thinking about something like this. would this be alright?

Inserted Code
int Buyorder;
int Sellorder;

if (ArrowDown != EMPTY_VALUE && Buyorder == 0)

  {
    OrderSend(Symbol_1,OP_BUY, S1_Lots, MarketInfo(Symbol_1,MODE_ASK), 2, NULL, NULL, "RapidFire", magic, NULL, LimeGreen); 
  }

if OrderCloseTime() == 0 && SellTicket > 0
{
double CloseLots = orderLots();
double ClosePrice = ASK;
bool Closed = OrderClose(SellTicket,CloseLots,ClosePrice,Red)
}
  • #17
  • Mar 21, 2011 11:54am Mar 21, 2011 11:54am
Why do you not change the value of buyorder after you have opened a trade?
And reset it after you have closed the trade?
  • #18
  • Mar 21, 2011 4:20pm Mar 21, 2011 4:20pm
Xaphod,

i have added this to the EA

and it works good now

Inserted Code
datetime newbar;

int start()

{

if(newbar==Time[0])return(0);

else newbar=Time[0];

when an arrow is given and bar closes it will do a sell or a buy and will not open any new orders until next arrow is given.

Xaphod again thanks a lot for helping! i am going to continue my programming journey.

i am going to add // info tommorow into the Ea and upload it in here so it can help me and other beginners.

the problem that i face and lots of other i guess is that there is lot of info for basic coders. but for complete beginners like me it is really hard.

i have never seen an simple EA that adds some simple Icustom commands for people to learn from.

i checked codebase many times. but even that is way to complicated for me. personal for me,easiest way to learn is see a an actually working EA and rip it apart piece by piece and check what it all does.

that is why i think it would be usefull to have a section in here with some very small EAs for learning purposes.

again thank you very much. shame it is almost 11 in here. soon need to go to sleep. i want to add some more stuff
  • #19
  • Mar 22, 2011 4:03am Mar 22, 2011 4:03am
Quoting trade4fun
it works good now.
Xaphod again thanks a lot for helping! i am going to continue my programming journey.
You are welcome. Well done!.

Quoting trade4fun
i am going to add // info tommorow into the Ea and upload it in here so it can help me and other beginners.
That is nice of you.
  • #20
  • Mar 22, 2011 9:14am Mar 22, 2011 9:14am
Hi Xaphod,

here is the code + explanation. however the magic number does not do anything for me in this code so i dont know how to indentify it.

same for the
Inserted Code
if(newbar==Time[0])return(0); 
else newbar=Time[0];

i know that is stops opening new orders. just not how to describe it.

if possible could you check what i have typed in the code if correct and make some changes if it is incorrect.

thank you

Inserted Code
//+------------------------------------------------------------------+
//|                                                supersignalEA.mq4 |
//|                      Copyright © 2011, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
// This EA is for study purpose only. it is not profitable in anyway.

#property copyright "Copyright © 2011, MetaQuotes Software Corp." // #property copyright  is used for the ownership of the EA
#property link      "http://www.metaquotes.net"                   // #property ownership is used for the owners website link.

extern string Symbol_1 = "EURUSD"; // in here i have specified what Symbol i will let the Ea trade in. in my example it is EURUSD.
                                   // extern means that when i add the EA on chart at "inputs". it will be possible to change 
                                   // its value when i add the Ea on chart. so whenever you use extern in your code you will see it
                                   // at input screen. 
                                   // string is used , because to indetify which pair i want to trade. and we can only indentify
                                   // pairs by text.
                                   

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int magic=9503; //
  
   return(0);
  
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+

datetime newbar; // the part datetime newbar; so that everytime an arrow is given it wont open a new order every tick.

int start() // this starts the engine of the code.

{

if(newbar==Time[0])return(0); // 
else newbar=Time[0];

// below is the code to import a custom indicator into an EA. 
// double ArrowUp is used to give the indicator input a name called ArrowUp
// iCustom is used to import the indicator.
// (Null indicates we are using the current chart symbol ( in our case EURUSD)
// 0 is the current chart period
// "supersignals" is the name of the indicator we import in the EA
// 0 is the buffer Value of the indicator.
// 1 is the last in the sentence is the shift parameter. this checks the closing value of the last bar.

double ArrowUp = iCustom(NULL,0,"supersignals",0,1); 


double ArrowDown = iCustom(NULL,0,"supersignals",1,1);

if (ArrowDown != EMPTY_VALUE ) // when a Blue arrow is given on the chart it will give a signal to open a buy order.

// ordersend is used to open a buy or sell order. in our case a buy Order.
// Symbol_1 = the symbol that was added in extern string Symbol_1 = "EURUSD"; 
// OP_BUY = to give a buy order when a blue arrow is given.
// OP_SELL = to give a sell order when a red arrow is given.
// 0.1 = lotsize 
// MarketInfo(Symbol_1,MODE_ASK) = gives a signal to server to ask for last incoming price.
// 2 = slippage
// NULL = Stoploss. since i have not indentified it in this Ea it is not used
// NULL = TakeProfit. since i have not indentified it in this Ea it is not used
// "Rapidfire" a bunch of text i can give in the order.
// magic = the magic number i can give every order. 
// NULL = datetime expiration for pending orders. since i dont open any pending orders in this EA i have it on NULL.
// LimeGreen = the color of the arrow that you see on a chart when a buy is done.
  {
    OrderSend(Symbol_1,OP_BUY,0.1, MarketInfo(Symbol_1,MODE_ASK), 2, NULL, NULL, "RapidFire", magic, NULL, LimeGreen); 
  }
if (ArrowUp != EMPTY_VALUE ) // when a red arrow is given on the chart it will give a signal to open a sell order.
 {
  OrderSend(Symbol_1,OP_SELL,0.1, MarketInfo(Symbol_1,MODE_BID), 2, NULL, NULL, "RapidFire", magic, NULL, FireBrick);   
  }
return(0); // returns back to the start function of the program.
}
0 traders viewing now