Max risk function isn't working | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

Separating Count of Max Pending Orders and Max Open Trades 2 replies

stop loss function and edit time function for Breakout EA 1 reply

Email function not working. Code posted. 0 replies

Ordersend function stops working completely in EA! 3 replies

Max risk function isn't working

  • #1
  • First Post: Mar 4, 2011 10:16pm Mar 4, 2011 10:16pm
Very much appreciate any help on this.

A friend of mine and I are working on a code that uses short term highs and lows.
we define a short term high using memorizeH[1] and a low using memorizeL[1] (1 denotes it being the last short term high or low)

we've also inserted a condition that says

((memorizeH[1]-memorizeL[1])*10000)<=Max_pips

If this is true, then send an order to market

Max pips is a number defined at the start as 'extern double Max_Pips 50;'

Now most of the time this function works, but occasionally it won't and it'll take 70-80 pips risk.

I can't work out why it does this, if risk is 80 why would it confirm the expression as true and send an order to market? I've checked the execution and it doesn't have bad slippage or anything.

My data is 1 year of dukascopy tick data which gives me 99% modelling quality.

Any advice on why the above is occuring would be great.
  • #2
  • Mar 4, 2011 11:32pm Mar 4, 2011 11:32pm
Hi Scotty,

It is hard to debug without the full code and context.

My guess is the defined high and low stored in your memorizeH[1] and memorizeL[1] aren't having the correct values.

or worse, your values redefines itself due to errors in coding (something like repainting). possibilities are endless

you can get your codes to write log files and get the values recorded to see what's wrong. This function may help you with your investigation.

the log file will be created in your mt4/experts/files folder.

Inserted Code
void WriteToLogFile(string input)
{
   string filename = "SOME-FILENAME_"+Symbol()+"-"+Day()+"-"+Month()+"-"+Year()+".log";
   int handle = FileOpen(filename,FILE_READ|FILE_WRITE);
   if (handle>1)
   {
      string prefix = Day()+"/"+Month()+"/"+Year()+" - "+Hour()+":"+Minute()+":"+Seconds()+" => ";
      FileSeek(handle, 0, SEEK_END); // go to end of file
      FileWrite(handle, prefix+input);
      FileClose(handle);
   }
}

hope this helps.

regards,
Zen
Programming for a better future.
  • #3
  • Mar 5, 2011 12:11am Mar 5, 2011 12:11am
Shouldn't be, that memorizeH[1] is also linked to a function which draws the Highs on the chart for us so I've been checking those.

But that small bit of code you've given me will be VERY useful. cheers buddy
  • #4
  • Last Post: Mar 5, 2011 10:10am Mar 5, 2011 10:10am
Quoting scottyfromau

I'm gettin a message "Function "WriteToLogFile" is not referenced and will be removed from exp-file "

so essentially the code is not being used by the function.

I've embedded this after de init, what else do I have to do to get it working?

Appreciate your time mate,

Scotty
I was under the impression that you're fluent in programming so I didn't think I need to explain function usage...

You got that message because you put the function in but did not use it.

let's say your code is going to open a sell trade when some condition is met, if you want to a log message that shows the Ask price at that time like "Sell initiated at 1.3421"

you need to do something like this.

Inserted Code
void WriteToLogFile(string input)
{
   string filename = "SOME-FILENAME_"+Symbol()+"-"+Day()+"-"+Month()+"-"+Year()+".log";
   int handle = FileOpen(filename,FILE_READ|FILE_WRITE);
   if (handle>1)
   {
      string prefix = Day()+"/"+Month()+"/"+Year()+" - "+Hour()+":"+Minute()+":"+Seconds()+" => ";
      FileSeek(handle, 0, SEEK_END); // go to end of file
      FileWrite(handle, prefix+input);
      FileClose(handle);
   }
}


int start()
{
   //... some codes
   if (some condition satisfy to open a sell trade)
   {
      [b]WriteToLogFile("Sell initiated at "+Ask);[/b]
   }
   //... maybe some more codes
}

again... I can't help you if you don't post your codes here.

regards,
Zen
Programming for a better future.
0 traders viewing now