Zero Divide error? Where do I need to look to fix it? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Need help to solve "zero divide error" 7 replies

Help needed to fix 'Divide by zero' error 5 replies

Divide by zero error? 2 replies

Zero Divide Error 4 replies

Zero Divide Error 5 replies

Attachments: Zero Divide error? Where do I need to look to fix it?
Exit Attachments

Zero Divide error? Where do I need to look to fix it?

  • #1
  • First Post: Mar 2, 2011 7:57am Mar 2, 2011 7:57am
when i use this indicator on 4 digits broker it works fine.

however when i use this indicator on a 5 digit broker. i check the expert tap. and i see it gives a zero devine error when i add the indicator on chart.

orginally the indicator is for 4 digits.

however someone made an option so it would work on 5 digits.

extern bool UseExtraDigit = true;

but turning that on gives teh zero devide error and also different signals then 4 digits brokers.

could anybody have a look and tell me where i need to look to fix this?

i thought maybe in here?

Inserted Code
/*(L>O1)&&*/(O==C)&&((C2>O2)&&(C2-O2)/(/*0.001+*/H2-L2)>Doji_Star_Ratio)/*&&(C2<O1)*/&&(C1>O1)/*&&((H1-L1)>(3*(C1-O1)))*/&&(CL>=(Doji_MinLength*Point))) {
         if (Display_Doji == true) {

thanks
Attached File(s)
File Type: mq4 Pattern_Recognition_Master_v3.mq4   28 KB | 670 downloads
  • #2
  • Mar 2, 2011 1:56pm Mar 2, 2011 1:56pm
There is a simple way to fix this kind of error and a difficult way to fix it. Your approach is the difficult way and won't necessarily eliminate all possible errors of this kind.

The simple way to fix this is to look at every statement that involves division or a modulo operation and ensure the divisor can never be zero. In other words put a test in the code to handle the situation when the divisor evaluates to zero and skip the division statement.
  • #3
  • Mar 2, 2011 3:13pm Mar 2, 2011 3:13pm
Codemeister,

if you have some time, could you give me 1 example in the code that needs to be fixed.

or what kind of testcode do i need to write?

i only need 1 example the rest i can figure out on my own. well i hope
  • #4
  • Edited 7:23pm Mar 2, 2011 4:35pm | Edited 7:23pm
The code you posted is much too cryptic for me.

So I will provide an example from my own and hope you apply to it to yours. I want to calculate the slope of the MA and compare it to the slope several bars back to see if it has changed. To do this, I calculated the difference in EMAs at fixed points and divided one by the other. It is unlikely, but possible, for the differences to be zero. To avoid a divide by zero error, I forced the divisor to be non-zero as per the example below.

Inserted Code
     double EMAslope1 = MathAbs(EMAs[2] - EMAs[7])/6; 
     double EMAslope2 = MathMax(MathAbs(EMAs[2] - EMAs[0])/3, Point);
     double slopeRatio = EMAslope1/EMAslope2;
  • #5
  • Mar 3, 2011 3:39am Mar 3, 2011 3:39am
Codemeister,

thanks for your answer.

however as always. for any solution there is a new problem

and surely. instead of getting same signals as 4 digit broker. i get now 3 x less signals then when i add the indicator on a 5 digit broker.

anybody got a clue what i did wrong?

thanks
Attached File(s)
File Type: mq4 Pattern_Recognition_Master_v5.mq4   28 KB | 534 downloads
  • #6
  • Mar 3, 2011 4:55am Mar 3, 2011 4:55am
Hi,
first of all try to simplify and organize better your code, as is now is a bit messy and it's difficult to debug.

For example why this code is in start() ??

Inserted Code
   double Range, AvgRange;
   int counter, setalert;
   static datetime prevtime = 0;
   int shift;
   int shift1;
   int shift2;
   int shift3;
   int shift4;
   string pattern, period;
   int setPattern = 0;
   int alert = 0;
   int arrowShift;
   int textShift;
   double O, O1, O2, C, C1, C2, C3, L, L1, L2, L3, H, H1, H2, H3;
   double CL, CLmin, CL1, CL2, BL, BLa, BL90, BL1, BL2, UW, UWa, UW1, UW2, LW, LWa, LW1, LW2, BodyHigh, BodyLow;
   BodyHigh = 0;
   BodyLow = 0;
   double Doji_Star_Ratio = 0;
   double Doji_MinLength = 0;
   double Star_MinLength = 0;
   int  Pointer_Offset = 0;         // The offset value for the arrow to be located off the candle high or low point.
   int  High_Offset = 0;            // The offset value added to the high arrow pointer for correct plotting of the pattern label.
   int  Offset_ShootStar = 0;       // The offset value of the shooting star above or below the pointer arrow.
   int  Offset_Hammer = 0;          // The offset value of the hammer above or below the pointer arrow.
   int  Offset_Doji = 0;            // The offset value of the doji above or below the pointer arrow.
   int  Offset_Star = 0;            // The offset value of the star above or below the pointer arrow.
   int  Offset_Piercing_Line = 0;   // The offset value of the piercing line above or below the pointer arrow.
   int  Offset_DarkCC = 0;          // The offset value of the dark cloud cover above or below the pointer arrow.
   int  Offset_Bullish_Engulfing = 0;
   int  Offset_Bearish_Engulfing = 0;
   int  CumOffset = 0;              // The counter value to be added to as more candle types are met.
   int  IncOffset = 0;              // The offset value that is added to a cummaltive offset value for each pass through the routine so any 
                                    // additional candle patterns that are also met, the label will print above the previous label. 
   double Piercing_Line_Ratio = 0;      
   int Piercing_Candle_Length = 0;  
   int Engulfing_Length = 0;
   double Candle_WickBody_Percent = 0;
   int CandleLength = 0;

Since you define this

Inserted Code
[color="Red"]static datetime prevtime = 0;[/color]

in start() function
this piece of code doesn't do anything, the if checking is always false

Inserted Code
if(prevtime == Time[0]) {
      return(0);
   }
   prevtime = Time[0];

I'm very surprised that you got any valid signal


gspe
  • #7
  • Mar 6, 2011 7:12am Mar 6, 2011 7:12am
Codemeister,

thanks for the idea.

i did as you said and located the problem. both bullish stars gave the problem. i fixed it i believe. but to make sure will wait till i get the live signal when market goes open tommorow. after that i will upload it in here.

GSPE.

maybe indicator is not 100%, but i use it for my life trading and managed to get 492 pips on EURUSd this week.

the reason i want this indicator to work on 5 digits. so i can also trade with this indi on 5 digit brokers.
  • #8
  • Mar 6, 2011 7:59am Mar 6, 2011 7:59am
Quoting trade4fun
GSPE.

maybe indicator is not 100%, but i use it for my life trading and managed to get 492 pips on EURUSd this week.

the reason i want this indicator to work on 5 digits. so i can also trade with this indi on 5 digit brokers.
Hi,
I didn't want to offend you, sorry if you feel this. English is not my language so sometimes is difficult to say thing properly.

I just would like to say that you have to try to improve the overall code in order to eliminate every possible cause of problems.

Regards
gspe
  • #9
  • Mar 6, 2011 8:39am Mar 6, 2011 8:39am
hi trade4fun,

check attached file
Attached File(s)
File Type: mq4 Pattern_Recognition_Master_v3.mq4   28 KB | 674 downloads
  • #10
  • Mar 6, 2011 5:59pm Mar 6, 2011 5:59pm
trade4fun,

I went over the code you sent me v3 and compared it to sangane's posted v3, and it looks like sangane added code:
if(MathAbs(H-L)<0.1*Pip) continue;
if(MathAbs(H1-L1)<0.1*Pip) continue;
if(MathAbs(H2-L2)<0.1*Pip) continue;
if(MathAbs(H3-L3)<0.1*Pip) continue;

You said this stopped the zero divide error. Problem was, I had already implemented my fix (described below) to an older version 3.

I have implemented a fix that should make this indicator work the same on 4 and 5 digit brokers. What I put in header of indicator:
03-03-2011 Don Isbell (aka disbellj - Forex Factory) received v3 from trade4fun, saw variable UseExtraDigit (don't know where it came from), but consider my fix to be what's needed, so I removed external variable UseExtraDigit and associated code. I added variables Pip and RoundTo. Everywhere Point was used, I replaced with Pip. Everywhere Open, High, Low, or Close was seen, I used NormalizeDouble and used RoundTo to round these values to either 4 or 2 (for JPY pairs) decimals. This is the correct way to fix this 5 digit broker problem IMHO. Instead of making inputs to be x10, it's better to leave inputs unchanged (easy for users), and code to limit output by 5-digit brokers to 4 digits, so that 5 digit brokers act like 4 digit brokers.

I also see you have made a v5, so I will make this v6 so as to not confuse anyone. This should fix previous known problems. Please test and let me know.

Regards,

Don
Attached File(s)
File Type: mq4 Pattern_Recognition_Master_v6.mq4   30 KB | 597 downloads
  • #11
  • Mar 7, 2011 5:27am Mar 7, 2011 5:27am
Sangmane,

thanks for the help, but your fix gave basicly the same signals i had on 5 digit which means 50% less signals.

Don his fix is what was really needed. he fixed the 4 digit code to true 5 digit code + fixing the zero devide code.

today i got 9 signals or 4 digit broker. and 12 on 5 digit broker. 8 trades already closed in profit. 9th still hanging in there.

the reason why 4 digits and 5 digits are different has to do with spread of each broker. even on 2 different 4 digit brokers, not all signals will be completely same which is logical.

GSPE no offence taken

about the strategy i use. i take every signal on 5 minute chart EURUSD only with a 4 pips profit.

on eurusd you will get between 80% and 85% valid signals for 4 pips profit. on the signals that go wrong i use a recovery system. this recovery system is the next step in programming

GPBUSd looks like another nice pair to trade as well. but for the moment i focus EURUSd only.

thanks again for all who contributed
  • #12
  • Mar 7, 2011 5:50am Mar 7, 2011 5:50am
My fix was just for zero divide error. Don did a great job in fixing the rest
  • #13
  • Mar 8, 2011 8:03am Mar 8, 2011 8:03am
I still got zero divide error on FXDD, so I looked at code of v6.

I noticed that sangmane's code was if less than 0.1 * Point (1/10th pip on 5 digit broker), and when I fixed it, it became less than 0.1 * Pip (again, 1/10th of a pip on 5-digit broker, but we want this 5 digit broker to act like 4 digit broker, so count nothing less than a pip, we round to the pip. So I have changed the code to less than 1 * Pip, and here's v7.

Regards,

Don
Attached File(s)
File Type: mq4 Pattern_Recognition_Master_v7.mq4   30 KB | 595 downloads
  • #14
  • Jun 9, 2011 5:51am Jun 9, 2011 5:51am
great job Don just added a little extra code to get rid of the continuos bar counting
called it version 8 but you saved me some hastle there thanks Don and of course original poster. Have built an ea around this indicator works rather well but it took me a while and still developing so dont want to give it away free. For those who want to do the same i used 9 period stochastic and 3 emas as conformation and elimination from bad trades, 14 21 & 60 expo averages.
Attached File(s)
File Type: mq4 Pattern_Recognition_Master_v8.mq4   30 KB | 932 downloads
  • #15
  • Jun 9, 2011 5:10pm Jun 9, 2011 5:10pm
Thanks Andy for fixing it.

it is an incredible indicator. one of the most usefull i have ever found.
  • #16
  • Jun 10, 2011 5:05am Jun 10, 2011 5:05am
your welcome trade4fun are you noticing the difference in cpu usage? there is still a problem though i only found out after my post that is in version 7 and 8 , when i run my ea on back test calling either of these indicators with icustom the journal reports loaded successfully then removed on every tick which does not happen on version 3 soooo frustrating after so much work. if anyone knows what may be causing this the input would be much appreciated thing is indicator works great on charts from what i have seen.
  • #17
  • Jun 10, 2011 11:40am Jun 10, 2011 11:40am
take a look at this thread http://www.forexfactory.com/showthre...46#post4682046 page 3 to find how i fixed the -load, remove, load, remove ..... problem
many thanks to kinghigh
  • #18
  • Jun 11, 2011 6:44pm Jun 11, 2011 6:44pm
Glad you found the fix 4xAndy. Sorry about that. Hope it works good now. Sounds like it does. Good job.

Kind regards,

Don
  • #19
  • Jun 12, 2011 8:51am Jun 12, 2011 8:51am
ya well the fix to the ea was just to stop it recounting all bars needlessly the other problem was mainly my ignorance not anyones programing just the as the ea was fixed and the bool for use digits removed my icustom was calling the wrong number of parameters hence the contant load remove when backtesting so the fix was in ea not indicator what you did don was very helpfull and did not creat any extra problems with indicator. I am thinking of posting my ea in the hope someone improves it, and reposts it. Any advise on this and wheather to start a new thread? since i started creating it somehow some mods have made it worse and my coding is not the best so i'm now going backwards but i beleive this ea can be turned into a good profit one. Or if you are interested in the project i could just email it to you don.
  • #20
  • Oct 11, 2011 4:50pm Oct 11, 2011 4:50pm
I am getting the same error on a 5 digit broker for the following EA. Any suggestions on how to get it to work?
Attached File(s)
File Type: mq4 HTH.mq4   13 KB | 504 downloads
0 traders viewing now