how do you group a bunch of open orders? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Close all pending orders and open orders once they reach profit target 3 replies

Looking for EA programmer, need a bunch of EAs 1 reply

script to "close open orders" and "open opposite orders" 3 replies

Best of a bad bunch? 2 replies

how can I unable EA orders while I have some open orders? 1 reply

how do you group a bunch of open orders?

  • #1
  • First Post: Feb 26, 2011 1:04pm Feb 26, 2011 1:04pm
what i would like is that open orders are ordered automaticly in different groups.

at the moment i have this code and it works for 1 group but i want to have different groups.
Inserted Code
int TotalorderCount(string argsymbol,int argMagicNumer)
{int OrderCount;
for(Counter = 0; counter <= OrdersTotal()-1; Counter++)
{orderSelect(Counter,SELECT_BY_POS);
if(OrderMagicNumber() == argMagicNumer && OrderSymbol() == argSymbol)
{
OrderCount++'
}
}
return(OrderCount);
}

however this makes 1 group.

what i would like is an EA to group orders under different conditions.

so EA checks which orders are open.

group 1 = open buy orders in +
group 2 = open buy orders in -
group 3 = open sell orders in +
group 4 = open sell orders in -

so when i add a new order manually. an EA will arrange for me the order in groups.

This is what i try to accomplish. if anybody can help me shine some light over this problem. would be greatly appriciated.
  • #2
  • Feb 26, 2011 3:04pm Feb 26, 2011 3:04pm
You cannot sort (or group) trades by your chosen criteria. The MT4 sorting is by time and that is what your code is handling.

If you wanted to separate the logic for buy and sell orders you could put 2 "if" statements inside the loop like this. Inside the if statements use OrderProfit() to determine the trades in profit or loss.

Inserted Code
if (OrderType() == OP_BUY) {if (OrderProfit >= 0) {// do something} else {// do something}}

  if (OrderType() == OP_SELL) {if (OrderProfit >= 0) {// do something} else {// do something}}
  • #3
  • Feb 26, 2011 5:03pm Feb 26, 2011 5:03pm
thank you codemeister for your answer.

i understand MT4 is sorting by time that is not my problem.

what i try to accomplish is having a bunch of open orders with different magic numbers get into different groups specified by me.

so i was thinking what if i created arrays and store those orders by magic number in those arrays?

would that be a possibility?

thanks in advance
  • #4
  • Feb 26, 2011 5:48pm Feb 26, 2011 5:48pm
You can select by Magic Number in an "if" statement similar to the example I provided. But I would not store the results in an array. Trying to maintain the array to accurately reflect open trades is going to be a lot of trouble. For instance, you might have a buy trade in the array and on the next tick it hits the SL. You do not want to update the array every tick and if you don't do it every tick, it will probably be inaccurate.

The best way to do it is to select all orders as often as necessary (not every tick) and look up the information you need for each.
  • #5
  • Feb 27, 2011 9:07am Feb 27, 2011 9:07am
thanks again for your answer,

1 more minor question.

after i have the orders in the loop. how can i add the orders up?

for example order 1 = 20 order 2 = -20

now i would like to close both orders when they reach breakeven.

if totalorders (order1+order2=0) closeall ?
  • #6
  • Feb 27, 2011 4:47pm Feb 27, 2011 4:47pm
I have never done what you are suggesting to do, but it seems difficult because of MT4s restrictions. I am not saying it is impossible, but be prepared for lots of testing.

One of the problems I can see is that with 5 digits, 2 orders will probably never reach breakeven, so you would probably want to do the calculation with 4 digits (or 2 for Yen).

The other problem is that I don't know how many orders you are dealing with. If you only have 2 orders, that is considerably easier than 5 or more orders.

This is something that you should only undertake if you positively need it and are confident in your coding and testing skills. I can see lots of effort ahead.
  • #7
  • Feb 27, 2011 5:40pm Feb 27, 2011 5:40pm
Inserted Code
if(Get_Basket_Total()>=0)Close_All();
 
 
//+------------------------------------------------------------------+
double Get_Basket_Total()
{
double
   Basket_Profit=0;
   for(int i=OrdersTotal()-1;i>=0;i--){
      OrderSelect(i,SELECT_BY_POS);
      if(OrderSymbol()==Symbol()){
         if(OrderMagicNumber()==MagicNumber)Basket_Profit += OrderProfit() + OrderCommission() + OrderSwap();
      }
   }
   return(Basket_Profit);
}
//+------------------------------------------------------------------+
  • #8
  • Feb 28, 2011 6:09am Feb 28, 2011 6:09am
Codemeister,Kennyhubbard,

Thank you so much for the help.

what i am trying to do, is to create a recovery system using purely math.

i a big fan of price action trading. now i have found a descent strategy. but eventually i will be in for a loss. now stoploss is 1 way to look at it. however a trade might bounce back. so why not try to create a recovery system.

i was thinking no strategy i know off is 100% perfect. so instead of focussing on a perfect strategy. why not work on a recovery system.

the complete recovery system is very complicated math. but still math. so i think it should be possible to do in MQ4.

i have 1 more question about the basket.

Kennyhubbard his code is is for 1 basket. would it be possible to create more baskets ( groups ) in metatrader?

for example I open a buy trade and it will create automaticly basket1. and will store that buy order in basket 1.

i open a second buy order and third order at same time. second buy order should be stored in basket 1. while third order should be added in basket 2.

would that be possible to do?

thanks already for the help
  • #9
  • Feb 28, 2011 9:26am Feb 28, 2011 9:26am
trade4fun,

Anything can be done in MQL.....but why the complex system. Looks like a simple cost-averaging concept and you don't need baskets for that.

As CodeMeister mentioned, the orders are already stored in an internal array and there is no reason you can't work with them dynamically.

You mentioned that the third order gets added to basket 2....what is special about basket 2 that differentiates it from basket 1?
  • #10
  • Feb 28, 2011 1:20pm Feb 28, 2011 1:20pm
I understand better what you trying to do. But I have to re-iterate what I posted before. I have not written such a program as you describe.

It would be easier to do if you had one "basket" or if you had a known number of baskets with at most 2 orders.

What you are attempting to do will not be easy. But don't attempt it unless you are confident in your coding skills.
  • #11
  • Last Post: Feb 28, 2011 3:22pm Feb 28, 2011 3:22pm
KennyHubbard and Codemeister,

let me explain what i try to achive.

main reason why not 1 basket is because it is to riskfull.

what i am doing based on math is keep my drawdown as small as possible while recovering. and this is were the math kicks in.

for example lets say i have a basket of 4 orders (-120,-30,+60+60)

i want to be able to close order of -120 together with +60+60 and keep order of -30 open. this way my drawdown gets a lot smaller as well as my risk.

i actually just used this strategy to recover my bad trade on eurusd today i had done a buy at highest point. but because of this strategy i managed in 3 hours to recover the bad trade.

and that is what i like about this recovery system. for me it takes out the fear of bad trades.

it puts myself in much relaxfull state of mind. so now i am trying to create an EA of it.

however creating an Ea putsmyself out of that relaxfull state of mind

anyway i give myself a week to create it. if i cant do it. hopefully you or Kennyhubbard will take on the challenge. and if you guys want to share it on this forum. i dont mind it at all.

the only reason i dont put it wide open on the forum is because i want to have it first in small group. i have seen to many stratgies go to waste with many people in it. i dont want to see all that time and energy wasted.

thanks for understanding
0 traders viewing now