Attachments: OrderModify Error

OrderModify Error

#21
May 17, 2010 3:14pm May 17, 2010 3:14pm

kennyhubbard
Joined Sep 2008 | Status: Trader | 362 Posts

There is a curly bracket missing from the above code. I need to know where you have it.

#22
May 17, 2010 3:19pm May 17, 2010 3:19pm

bauerjj10
Joined Jul 2009 | Status: Trader | 200 Posts

The bracket is missing because I have more functions during the order counting.

Below is a continuation after the last line of code above.

Inserted Code

   if (OrderSymbol()==Symbol() && OrderType()== OP_SELL)
      {
         double BreakEvenSell = OrderOpenPrice() - (BE_Pips*Point);
         double PP_Pipsell = OrderOpenPrice() - (PP_Pips*Point);
         double PP_Lotssell = PP_Percent*OrderLots();
         
         if (PartialProfit == true)
            {
            if (PP_Pipsell >= Ask && PP_Lotssell > 0.0 && OrderLots() >= 0.2)
               {
               OrderClose(OrderTicket(),PP_Lotssell,Ask,MaxSlippage,0);
               Print ("Partial Profit Taken on Sell",OrderTicket());
               }
            }
         if (BreakEven == true)
            {
            if (BreakEvenSell >= Ask && OrderStopLoss() != OrderOpenPrice()-(BE_AddedPips*Point))
               {
               OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-(BE_AddedPips*Point),OrderTakeProfit(),0,0);
               Print ("BreakEven Executed on",OrderTicket());
               }
            }
         if (OrderStopLoss()> NormalizeDouble(stoploss,4) && RiskManagement==true && OrderStopLoss() != OrderOpenPrice()-(BE_AddedPips*Point))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),stoploss,OrderTakeProfit(),0,0);
            }
         }
      if (OrderSymbol()==Symbol() && OrderType()== OP_BUY)
         {
         double BreakEvenBuy = OrderOpenPrice() + (BE_Pips*Point);
         double PP_Pipbuy = OrderOpenPrice() + (PP_Pips*Point);
         double PP_Lotsbuy = PP_Percent*OrderLots();
         
         if (PartialProfit == true)
            {
            if (PP_Pipbuy <= Bid && PP_Lotsbuy > 0.0 && OrderLots() >= 0.2)
               {
               OrderClose(OrderTicket(),PP_Lotsbuy,Bid,MaxSlippage,0);
               Print ("Partial Profit Taken on Buy",OrderTicket());
               }
            }
         if (BreakEven == true)
            {
            if (BreakEvenBuy <= Bid && OrderStopLoss() != OrderOpenPrice()+(BE_AddedPips*Point))
               {
               OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+(BE_AddedPips*Point),OrderTakeProfit(),0,0);
               Print ("BreakEven Executed on",OrderTicket());
               }
            }
         if (OrderStopLoss()< NormalizeDouble(stoploss1,4) && RiskManagement==true &&  OrderStopLoss() != OrderOpenPrice()+(BE_AddedPips*Point))
            {
            OrderModify(OrderTicket(),OrderOpenPrice(),stoploss1,OrderTakeProfit(),0,0);
            }
         }
      }

#23
May 17, 2010 3:20pm May 17, 2010 3:20pm

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

Quoting bauerjj10

Disliked

Sangmane,
Im learning a lot from reading your code logic above....

Ignored

see my second post, it should be:
if(MathAbs(entry-OrderOpenPrice()) > StopLevel)

Make sure you have assign StopLevel variable :
StopLevel = MarketInfo(Symbol(),MODE_STOPLEVEL);

#24
May 17, 2010 3:51pm May 17, 2010 3:51pm

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

pls find the attached sample EA.
this EA will put buystop at SMA(100) if price below SMA(100), reverse for sell
attached pic show how EA modify open price when SMA change its value. but the modifying doesn't occurs at every tick, because there is limitation in modifying pending order

Attached Image (click to enlarge)

Click to Enlarge

Name: temp.gif
Size: 14 KB

Attached File(s)

OrderModify.mq4 1 KB | 385 downloads

#25
Edited 7:10pm May 17, 2010 4:34pm | Edited 7:10pm

bauerjj10
Joined Jul 2009 | Status: Trader | 200 Posts

Problem solved... i think.

I added the stoplevel function and it seems to be modifying orders only when it should.

However I did have one period of time in which it logged a bunch of Ordermodify error 1.

it passed and started working again, so i am thinking this may have just been the backtester data screwing with the code.

Anyways thank you for your help again.

I do have one more question if its not to much to ask.

My issue is once the buy or sellstop is triggered into a buy or sell order and price retraces down past the original openorderprice, a new buystop/sellstop is placed on the exact same entry point.

I am trying to create a function that will not allow MT4 to place a pending trade at the same price as a currently open trade.
for example:
if I have a buy order open at "x" price and my entry rules later say place a buystop at "x" price it will not allow this to happen.
This is what I have right now and it currently is not working.
function:

Inserted Code

 int buytradeok()
   {
   int trade=0;
//----
   for(int f=0;f<OrdersTotal();f++)
     {
      if(OrderSelect(f,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderSymbol()==Symbol())
        {
         if(OrderType()==OP_BUY)
            {
            if (OrderOpenPrice() == entry1)  trade++;
            }
        }
     }
//---- return orders volume
   if(trade>0)return(1);
   else  return(0);
   }

Ordersend:

Inserted Code

      if (total < MaxOrders)
            {
                  if (CalculateBuyOrders()==0 && Close[0]<Var1)        
                     {
                     if (buytradeok() < 1)
                        {
                        if (RiskManagement==true)
                           {
                           ticket=OrderSend(Symbol(),OP_BUYSTOP,LotValue,entry1,MaxSlippage,stoploss1,takeprofit1,NULL,0,0,Blue);
                           if(ticket>0)
                                 {
                                 if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
                                 Print("BUYSTOP opened : ",OrderOpenPrice());
                                 }
                           else Print("Error opening BUYSTOP order : ",GetLastError());
                           }

#26
May 17, 2010 9:31pm May 17, 2010 9:31pm

ecTrade
| Joined Jul 2009 | Status: Trader | 1,163 Posts

Quoting bauerjj10

Disliked

As you can see the buystop is the only function that is allowing the 2 equal values to pass through to the statement.

Ignored

Except of course you don't know that they are exactly equal. If they are off by just a little bit, they won't be recognized as equal, and the function will try and pass them in the way you are suggesting. Have you tried normalizing both sides as RR suggested? It's worth a try at least anyway.

#27
Feb 15, 2011 11:32pm Feb 15, 2011 11:32pm

rnwd
| Joined Feb 2011 | Status: Trader | 27 Posts

Quoting sangmane

Disliked

pls find the attached sample EA.
this EA will put buystop at SMA(100) if price below SMA(100), reverse for sell
attached pic show how EA modify open price when SMA change its value. but the modifying doesn't occurs at every tick, because there is limitation in modifying pending order

Ignored

Dear Sangmane,

Nice experimental EA you made here.

I was wondering if there is any variant for this kind of EA?

Say that i'm using Envelope for Entry & Exit Rules:
Upper Band acts as Trailing/Jumping Buy Stop (Jumping Stop Loss as well for Sell Position)..
Lower Band acts as Jumping/Trailing Sell Stop (Jumping/Trailing Stop Loss as well for Buy Position)..

Best Regrads,

#28
Feb 16, 2011 1:11am Feb 16, 2011 1:11am

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

hi,

please explain what you meant by envelope (bollinger band?) and jumping stop. a picture will help me understanding the logic.

merdeka!

#29
Feb 16, 2011 5:26am Feb 16, 2011 5:26am

rnwd
| Joined Feb 2011 | Status: Trader | 27 Posts

Quoting sangmane

Disliked

hi,

please explain what you meant by envelope (bollinger band?) and jumping stop. a picture will help me understanding the logic.

merdeka!

Ignored

Hi Bro,

Here is the details about my Request from Previous Post..

Merdeka,
PS: Don't forget to check your other inbox Bro!!

Attached File(s)

Entry Rules.doc 64 KB | 682 downloads

#30
Feb 16, 2011 5:35am Feb 16, 2011 5:35am

rnwd
| Joined Feb 2011 | Status: Trader | 27 Posts

Dear Sangmane,

In my POV, i prefer to call it Jumping rather than Trailing because the numbers are discrete not continuous...

Trims b4

#31
Feb 18, 2011 10:37pm Feb 18, 2011 10:37pm

rnwd
| Joined Feb 2011 | Status: Trader | 27 Posts

Dear Sangmane,

Here's a picture of you code that i modified

http://i1225.photobucket.com/albums/.../sangmane1.gif

and the code:

PHP Code

extern double Lots=0.1;

int start()
  {
    double bsline = NormalizeDouble (iEnvelopes(NULL, NULL,1,MODE_SMA,0,PRICE_OPEN,0.1,MODE_UPPER,1),Digits);
    double StopLevel=MarketInfo(Symbol(),MODE_STOPLEVEL)*Point;
    double ssline = NormalizeDouble (iEnvelopes(NULL, NULL,1,MODE_SMA,0,PRICE_OPEN,0.1,MODE_LOWER,1),Digits);
    double Spread=MarketInfo(Symbol(),MODE_SPREAD)*Point;
    double Pip = Point;
    if(Digits==3 || Digits==5) Pip = 10*Point;
    bool res = OrderSelect(0,SELECT_BY_POS);
    if(!res)
    {
      if(Bid<bsline)
      {
        OrderSend(Symbol(),OP_BUYSTOP,Lots,MathMax(Ask+StopLevel,bsline+Spread),3,ssline,bsline+26*Pip,NULL,0,0,Blue);
      }
      else
      {
        OrderSend(Symbol(),OP_SELLSTOP,Lots,MathMin(Bid-StopLevel,ssline),3,bsline,ssline+Spread-26*Pip,NULL,0,0,Red);
      }
    }
    else
    {
      if(OrderType()==OP_BUYSTOP)
      {
        if(MathAbs(bsline-OrderOpenPrice())>StopLevel)
        {
          if(bsline > Ask+StopLevel)
            OrderModify(OrderTicket(),bsline,ssline,bsline+26*Pip,0,Yellow);
        }
      }
      else if(OrderType()==OP_SELLSTOP)
      {
        if(MathAbs(ssline-OrderOpenPrice())>StopLevel)
        {
          if(ssline < Bid-StopLevel)
            OrderModify(OrderTicket(),ssline,bsline,ssline+Spread-26*Pip,0,Yellow);
        }
      }      
    }
    return;
  }

i need this EA to simustaneously Trailing Sell Stop after Buy Stop triggered, vice versa (even if TP isn't hit yet)..
i once saw people call it StopAndReverse Order somewhere on the net..

For Buy Order: Lower Band must be act as Trailing Stop Loss (act as Trailing Sell Stop as well)
For Sell Order: Upper Band must be act as Trailing Stop Loss (act as Trailing Buy Stop as well)

Merdeka!

#32
Feb 21, 2011 7:50pm Feb 21, 2011 7:50pm

rnwd
| Joined Feb 2011 | Status: Trader | 27 Posts

Quoting sangmane

Disliked

pls find the attached sample EA.
this EA will put buystop at SMA(100) if price below SMA(100), reverse for sell
attached pic show how EA modify open price when SMA change its value. but the modifying doesn't occurs at every tick, because there is limitation in modifying pending order

Ignored

Dear Sangmane,

Some coders modified your original Order Modify EA, you can check this thread..
We use Envelope & combine Trailing Pending Order with Trailing Stop.. It works simultaneously..

We might forget something & i hope you would help..

Salam

#33
Last Post: Feb 23, 2011 12:35am Feb 23, 2011 12:35am

rnwd
| Joined Feb 2011 | Status: Trader | 27 Posts

Dear Sangmane,

Please visit this new thread, i hope you would joint us to improve the system/EA

Regards

0 traders viewing now

Options

Similar Threads

OrderModify Error