Reading data from file | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Reading News from a CSV file 6 replies

Reading a text file from within EA? 7 replies

MetaTrader 4, mq4 File to Esignal EFS File 0 replies

how to include a file.txt in an mq4 file ?? 6 replies

Reading......and reading....... 21 replies

Reading data from file

  • #1
  • First Post: Jan 24, 2011 2:08pm Jan 24, 2011 2:08pm
I have a file w/ the pairs of all the symbols I currently look at in it. Here is what is in the file:
PHP Code
AUDCAD
AUDCHF
AUDJPY
AUDNZD
AUDUSD
CADJPY
CHFJPY
EURAUD
EURCHF
EURDKK
EURGBP
EURJPY
EURNZD
EURUSD
GBPAUD
GBPCAD
GBPCHF
GBPJPY
GBPNZD
GBPUSD
NZDCHF
NZDJPY
NZDUSD
USDCAD
USDCHF
USDJPY
What I want to do is read each line into it's own variables.
Inserted Code
string SymbolName[], FileName[];
I know I need to use FileOpen, FileRead, and then FileClose once I've populated the arrays. But every combination I use fails.

For anyone that's curious, I want to write the Date,OHLC data to files w/ the names of the pairs.

TIA.
  • #2
  • Jan 24, 2011 2:55pm Jan 24, 2011 2:55pm
Not sure if I understand you correctly, but if you want to output:

symbol, date/time, O, H, L, C, volume

for all of the pairs in your file of symbol names, into a separate output file for each pair, then something like this should do it:

Inserted Code
  int tf = Period();
  int h1 = FileOpen("symbol_list.csv",FILE_CSV|FILE_READ,'~');
  while (h1>0 && !FileIsEnding(h1))   {
    string symbol = FileReadString(h1);
    int h2 = FileOpen(symbol+","+tf+".csv",FILE_CSV|FILE_WRITE,',');
    Comment(symbol);
    for(int i=0; i<iBars(symbol,tf); i++)   {
      string time  = TimeToStr(iTime(symbol,tf,i));   // ..... or whatever......
      string open  = DoubleToStr(iOpen(symbol,tf,i),MarketInfo(symbol,MODE_DIGITS));
      string high  = DoubleToStr(iHigh(symbol,tf,i),MarketInfo(symbol,MODE_DIGITS));
      string low   = DoubleToStr(iLow(symbol,tf,i),MarketInfo(symbol,MODE_DIGITS));
      string close = DoubleToStr(iClose(symbol,tf,i),MarketInfo(symbol,MODE_DIGITS));
      string vol   = DoubleToStr(iVolume(symbol,tf,i),0);
      FileWrite(h2,symbol,time,open,high,low,close,vol);
    }  
    FileClose(h2);
  }
  if (h1>0)   FileClose(h1);
  return(0);

No need to use arrays.
  • #3
  • Jan 24, 2011 3:33pm Jan 24, 2011 3:33pm
Had to make a change to capturing the OHLC. W/ DoubleToString, All I got was everything to the left of the decimal.
Had to add the "m" for micro for IBFX. And I only wanted the 1-21 candles (personal pref).
Inserted Code
  int tf = Period();
  int h1 = FileOpen("allforex.txt",FILE_CSV|FILE_READ,'~');
  while (h1>0 && !FileIsEnding(h1))   
  {
    string symbol = FileReadString(h1);
    int h2 = FileOpen(symbol+".csv",FILE_CSV|FILE_WRITE,',');
    Comment(symbol);
    string sym=StringConcatenate(symbol,"m");
    for(int i=1; i<21; i++)   {
      string time  = getDate(i); //TimeToStr(iTime(symbol,tf,i));   // ..... or whatever......
      double open  = iOpen(sym,tf,i);
      double high  = iHigh(sym,tf,i);
      double low   = iLow(sym,tf,i);
      double close = iClose(sym,tf,i);
      FileWrite(h2,time,open,high,low,close);
    }  
    FileClose(h2);
  }
  if (h1>0)   FileClose(h1);
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
string getDate(int shift)
{
      datetime curtime=Time[shift];
      int theday=TimeDay(curtime);
      int themonth=TimeMonth(curtime);
      int theyear=TimeYear(curtime);
      string thedate=StringConcatenate(theyear,".",themonth,".",theday);
      return(thedate);
}
  • #4
  • Jan 24, 2011 7:35pm Jan 24, 2011 7:35pm
Quoting nondisclosure00
W/ DoubleToString, All I got was everything to the left of the decimal.
That's because the MarketInfo(symbol,Digits) would have returned 0 decimal places, i.e. because the symbol was missing the the 'm' suffix, it wouldn't have been able to find it. The list of pairs that you supplied gave no hint that the 'm' suffix was required.

Anyway, no matter, glad to hear that you have it working correctly now.
  • #5
  • Last Post: Jan 30, 2011 6:51pm Jan 30, 2011 6:51pm
Hey Hanover, sorry I sounded so corse in my last post. I really do appreciate your help.

Thanks!

Quoting hanover
That's because the MarketInfo(symbol,Digits) would have returned 0 decimal places, i.e. because the symbol was missing the the 'm' suffix, it wouldn't have been able to find it. The list of pairs that you supplied gave no hint that the 'm' suffix was required.

Anyway, no matter, glad to hear that you have it working correctly now.
0 traders viewing now