Adjusting an EA from 4 digit to 5 digit broker

Quoting luxinterior

Disliked

I made a posting on my blog that may be of use to you.

http://www.automatedtradingsoftware....-ibfx-upgrades

In short; no, yes and not sure why that would be - any errors being reported?

Lux

Ignored

Quoting Aja

Disliked

Super Easy. Put this at the top of your code (I usually make xecn a global variable so I can use it anywhere. Also ECN were the first to have 5 digits so thats where the name came from)

xecn=1; if(Digits==5||Digits==3){xecn=10;}

Now just anywhere in the code where you see:

...*Point change to *Point*xecn - and all will be handled automatically.

Ignored

Quoting Aja

Disliked

Super Easy. Put this at the top of your code - right after start() - (I usually make xecn a global variable so I can use it anywhere. Also ECN were the first to have 5 digits so thats where the name came from)

xecn=1; if(Digits==5||Digits==3){xecn=10;}

Now just anywhere in the code where you see:

...*Point change to *Point*xecn - and all will be handled automatically.

Ignored

Quoting JustJamar

Disliked

Hey Aja,

I just tried what you suggested, to no avail though....

Ignored

Quoting Aja

Disliked

You didnt define the variable type - just put 'double' in front of it. (I usually define as a global but locals work just as good)

double xecn=1; if(Digits==5||Digits==3){xecn=10;}

Also scanned your code and wherever ... /Point also change to /Point/xecn.... (in code i saw /Point/10 = /Point/xecn/10)

Ignored

Quoting Aja

Disliked

int init();double xecn=1; if(Digits==5||Digits==3){xecn=10;} - ERROR

move the line and place after the start() like this..

void start() { double xecn=1; if(Digits==5||Digits==3){xecn=10;}

In the error example you put it in the init() AND placed it before the '{'

Ignored

Quoting Aja

Disliked

Here ya go. The variable needed to be defined as a global (meaning the entire program can access the variable not just routines in the start() function) - It now compiles without error.

Ignored

extern double GapRange = 10;
extern double SL_Factor = 2;
extern double TP_Factor = 3;
extern double MM_Risk = 2;
extern int ExpertID=844478;
 
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init()
{
//----
 
//----
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
 
//----
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
//---- ONE TRADE PER BAR
 
static bool ToTrade;
 
if(NewBar() == true)
{
if(COT(1, 101187) == 0 && COT(2, 201187) == 0) ToTrade = true;
}
 
//---- GAP
 
bool GAP;
 
double CurrOpen = iOpen(NULL, 0, 0);
double PrevClose = iClose(NULL, 0, 1);
double Range = MathAbs(PrevClose - CurrOpen);
 
if(Range >= GapRange * Point * 10) GAP = true;
 
//---- TP / SL
 
double ATR = iATR(NULL, 0, 13, 1);
double Spread = MarketInfo(Symbol(), MODE_SPREAD) * Point;
 
double TakeProfit = ATR * TP_Factor;
double StopLoss = (ATR * SL_Factor) + Spread;
 
//---- TRADE
 
int Ticket;
 
if(ToTrade == true && GAP == true)
{
if(CurrOpen < PrevClose)
{
Ticket = OrderSend(Symbol(), OP_BUY, LotSize(MM_Risk, StopLoss), Ask, 3, Ask - StopLoss, Ask + TakeProfit, "Gap_Trader.B", 101187, 0, Blue);
 
if(Ticket < 0)
{
Print("Error in OrderSend : ", GetLastError());
}
else
{
ToTrade = false;
}
}
 
if(CurrOpen > PrevClose)
{
Ticket = OrderSend(Symbol(), OP_SELL, LotSize(MM_Risk, StopLoss), Bid, 3, Bid + StopLoss, Bid - TakeProfit, "Gap_Trader.S", 201187, 0, Red);
 
if(Ticket < 0)
{
Print("Error in OrderSend : ", GetLastError());
}
else
{
ToTrade = false;
}
}
}
 
//----
return(0);
}
//+------------------------------------------------------------------+
//+ Check Open Trades |
//+------------------------------------------------------------------+
int COT(int BS, int MN)
{
int Buys = 0, Sells = 0;
 
for(int cnt_COT = 0; cnt_COT < OrdersTotal(); cnt_COT++)
{
OrderSelect(cnt_COT, SELECT_BY_POS, MODE_TRADES);
 
if(OrderSymbol() == Symbol() && OrderMagicNumber() == MN && OrderType() == OP_BUY) Buys++;
if(OrderSymbol() == Symbol() && OrderMagicNumber() == MN && OrderType() == OP_SELL) Sells++;
}
 
if(BS == 1) return(Buys);
if(BS == 2) return(Sells);
}
//+------------------------------------------------------------------+
//| LotSize |
//+------------------------------------------------------------------+
double LotSize(double Risk, double SL)
{
double MaxLot = MarketInfo(Symbol(), MODE_MAXLOT);
double MinLot = MarketInfo(Symbol(), MODE_MINLOT);
 
double StopLoss = SL / Point / 10;
double Size = Risk / 100 * AccountBalance() / 10 / StopLoss;
 
if(Size < MinLot) Size = MinLot;
if(Size > MaxLot) Size = MaxLot;
 
return(NormalizeDouble(Size, 2));
}
//+------------------------------------------------------------------+
//| New Bar |
//+------------------------------------------------------------------+
bool NewBar()
{
static datetime PrevBar;
 
if(PrevBar < Time[0])
{
PrevBar = Time[0];
return(true);
}
else
{
return(false);
}
} 

Quoting dtruong4

Disliked

Hey Aja-

I need help with a code as well. I'm not quite sure where to stick the line of code {double xecn=1; if(Digits==5||Digits==3){xecn=10;} so that my EA can work. Can you help? thanks.

Ignored

Quoting ido370

Disliked

Done
Attachment

Ignored