Why is this EA's trades not going through? No errors and worked a year ago | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

an EA that worked forever 29 replies

Looking for help coding an EA - all logic has been worked out 0 replies

If old charts worked in the past 5 replies

worked with the Swiss Army EA? 2 replies

HELP PLEASE: A worked commission example 6 replies

Attachments: Why is this EA's trades not going through? No errors and worked a year ago
Exit Attachments

Why is this EA's trades not going through? No errors and worked a year ago

  • #1
  • First Post: Jan 13, 2011 11:12pm Jan 13, 2011 11:12pm
Hello,

Could use some help. See the attached EA.

I traded this EA fine a year ago and then I took time off from forex. I've come back and I still want to try this EA. The EA loads fine, no errors, and will even place a horizontal line on my charts showing the short and long entries. Price will go through my entry point by many pips and still not trigger a trade though. What's going on?

Some details:
1. I trade with IBFX.
2. When I initially traded the system they were a 4 decimal broker and are now 5 decimal. Does that matter though? I can adjust the TP/SL/other variables manually and simply increased their values by 10. So if I have a 10 pip TP then I would simply put in 100. Seems to place the line properly. Again, no errors on loading the EA.
3. I spoke with a rep at IBFX and they could not see any pending orders on my account.

So I'm wondering why the EA doesn't execute the live trades anymore. Is it the decimal thing? Would someone be willing to fix that?

Could that all be worked around easily by having the EA simply place a legit pending order that would show up on the brokers server? I don't mind if they see my order.

See attached EA.
Attached File(s)
File Type: mq4 breakoutdaily.mq4   15 KB | 503 downloads
  • #2
  • Jan 13, 2011 11:15pm Jan 13, 2011 11:15pm
Now a simple explanation of what the EA is trying to do.

The EA takes a SMA, which can be defined in the adjustable parameters, and calculates at the start of a new bar if the open price is above or below the value for the SMA at that point. If the bar opened above the MA then the EA is only looking to place a long trade. If the bar opened below the MA then the EA is only looking to place a short trade.

From there I define how many pips from open I want my trade trigger. Then once a trade is triggered the EA will set the TP/SL points. Only one trade per candle. Close out any open trades at the start of a new candle.

As you can see I can manually adjust the SMA, pips from open, TP, SL, and lot size on each chart once I load the EA.

Seems simple enough right? Why did it stop working?
  • #3
  • Jan 14, 2011 5:42am Jan 14, 2011 5:42am
I know IBFX has recently gone to market orders, where you no longer add TP and SL settings beforehand, but only add them after order is placed. I don't know if it affects pending orders or not though? I just go ahead and treat them both the same anymore, and so far I haven't had any problems.

I suggest you try contacting Ronald Raygun by PM to see if he can help. I'm sure it wouldn't more than 5 minutes to fix, if this is all the problem is. Or, if not, he's still the guy to contact. It's his EA.
  • #4
  • Jan 14, 2011 10:40am Jan 14, 2011 10:40am
Quoting ecTrade
I know IBFX has recently gone to market orders, where you no longer add TP and SL settings beforehand, but only add them after order is placed. I don't know if it affects pending orders or not though? I just go ahead and treat them both the same anymore, and so far I haven't had any problems.

I suggest you try contacting Ronald Raygun by PM to see if he can help. I'm sure it wouldn't more than 5 minutes to fix, if this is all the problem is. Or, if not, he's still the guy to contact. It's his EA.
Yea I have been. He doesn't know what the problem is. I suggested the concept of making all the pending orders actual pending orders which would show up on IBFX servers. Waiting to hear back about what he says.
  • #5
  • Jan 14, 2011 2:29pm Jan 14, 2011 2:29pm
I strongly believe the problem is that IBFX switched over to a market trade system such that the EA can only calculate the TP/SL AFTER the trade is executed.

Anyone willing to look at the code to alter this?
  • #6
  • Jan 14, 2011 5:42pm Jan 14, 2011 5:42pm
Check the log in the /experts/logs folder - the EA is generating error codes when OrderSend fails and the error message(s) will be in the logs folder.

The EA also needs to be modified to function correctly using market orders for IBFX - if you are not an experienced programmer, the changes necessary will be challenging...
Old Benjamin was right
  • #7
  • Jan 15, 2011 7:29am Jan 15, 2011 7:29am
hey juan..... below is the fix for ordersend function..... just replace those 2 lines.....

had to edit the code in other areas before it would place trades so it's possible there are other issues.....h

//---
//---

look for this line.....
Inserted Code
 
         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
    Print("BUY order opened : ", OrderOpenPrice());

change to this.......
Inserted Code
 
         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, 0,0,0, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
        OrderModify(OrderTicket(),OrderOpenPrice(),StopLossLevel, TakeProfitLevel,0,Red);
                Print("BUY order opened : ", OrderOpenPrice());

//---
//---

look for this line.....
Inserted Code
 
         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
    Print("SELL order opened : ", OrderOpenPrice());

change to this.....

Inserted Code
 
         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, 0,0,0, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
        OrderModify(OrderTicket(),OrderOpenPrice(),StopLossLevel, TakeProfitLevel,0,Red);
    Print("SELL order opened : ", OrderOpenPrice());
to trade and code, keep both simple... no call to impress....h
  • #8
  • Last Post: Jan 15, 2011 1:55pm Jan 15, 2011 1:55pm
Thank you very much. I really appreciate you putting it in very easy to follow non-coder instructions. Hopefully this will work. I'll let you know tomorrow.
0 traders viewing now