Attachments: Setting TP or SL at object line

Setting TP or SL at object line

#1
First Post: Jan 10, 2011 4:49pm Jan 10, 2011 4:49pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Hi, i created an object/line on the chart which i want to use as a TP level.
To get the value of the line is use the following code:

Inserted Code

buyarea2=ObjectGet("tpline", OBJPROP_PRICE1);

When i put the buyarea2 variable in a Comment, i see the precise value (for example 1.2970.
But how do i use this in my OrderSend command to use this as my TP? If i put something like:

Inserted Code

   OrderSend(Symbol(),OP_BUY,0.1,Ask,50,Ask-mysl*pips2dbl,Ask+buyarea2,NULL,MagicNumber,0,Blue);

i get a strange value? And also after searching on the net i found some code like this, but i doesn't work either:

Inserted Code

TP=Ask+(MathFloor(MathAbs((buyarea2-Ask)/Point)/10));

OrderSend(Symbol(),OP_BUY,0.1,Ask,50,Ask-mysl*pips2dbl,TP,NULL,MagicNumber,0,Blue);

the first line gives me the exact pips distance to the line, but i'm stuck at the ordersend command.

Who can help me?

#2
Jan 10, 2011 9:25pm Jan 10, 2011 9:25pm

hanover
Joined Sep 2006 | Status: ... | 8,113 Posts

Quoting ido370

Disliked

Hi, i created an object/line on the chart which i want to use as a TP level. .....

Ignored

Not enough info, e.g. what is pips2dbl?

Suggest that you use Comment() to output the final values of your entry, SL and TP, and check that they are sensible, i.e.
for a buy operation:

you must buy at the Ask price;
your SL must be a reasonable distance (as set by the br0ker) below the buy (entry) price;
your TP must be a reasonable distance (as set by the br0ker) above the buy (entry) price

Make sure that prices (entry, TP, SL), and number of lots are all defined as double data type.

Use NormalizeDouble(price,Digits()) to ensure that each of the entry, TP, SL are set to the correct number of digits before being used in OrderSend().

Use something like:

Inserted Code

  double minlot  = MarketInfo(Symbol(),MODE_MINLOT);
  if (minlot == 0.01)   lots = NormalizeDouble(lots,2);
  if (minlot == 0.1)    lots = NormalizeDouble(lots,1);
  if (minlot == 1)      lots = NormalizeDouble(lots,0);

to ensure that number of lots is acceptable to your br0ker, i.e. this will ensure that trade is rounded to 1 d.p. if microlots (0.01) not allowed.

Ensure that you have the parameters in the right positions in your OrderSend(). From the code you provided, that appears to be the case.

Don't forget to multiply any pip values by Point() (or 10*Point() for a 5/3 digit br0ker) to convert it to a price, i.e. 50 pips = 0.00500, before adding/subtracting to/from another price value. Then NormalizeDouble() the result before remitting it to OrderSend().

If you post ALL of the relevant source code, I'll compile it here and troubleshoot further for you.

What br0ker are you using?
What error message is being returned?

#3
Jan 10, 2011 10:24pm Jan 10, 2011 10:24pm

hayseed
Joined Nov 2006 | Status: Trader | 4,419 Posts

Quoting ido370

Disliked

Hi, i created an object/line on the chart which i want to use as a TP level.
?

Ignored

hey id.... your doing it correctly up to a point...... if a line is to be your target, just send the line....

using a true object as a target could possibly differ slightly.......

rough example below.... bpt, bsl, spt, ssl are my lines similar to yours......

as you can see, you almost have it....

....h

Inserted Code

 
 
       double buyprofittarget;
       double buystoploss;
       double sellprofittarget;
       double sellstoploss;
 
       double targetprice;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
 
   if(Digits == 3 || Digits == 5)
   {
   ProfitTarget = ProfitTarget *10;
   Stoploss     = Stoploss     *10;
   partialpips  = partialpips  *10;
   }
 
   else 
   {
   ProfitTarget = ProfitTarget;
   Stoploss     = Stoploss;
   partialpips  = partialpips;
   }
 
    //SetLine();
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
   buyprofittarget  = NormalizeDouble(ObjectGet("bpt",OBJPROP_PRICE1),Digits);   
   buystoploss      = NormalizeDouble(ObjectGet("bsl",OBJPROP_PRICE1),Digits);  
   sellprofittarget = NormalizeDouble(ObjectGet("spt",OBJPROP_PRICE1),Digits);   
   sellstoploss     = NormalizeDouble(ObjectGet("ssl",OBJPROP_PRICE1),Digits);   
 
 
OrderSend(Symbol(),OP_BUY, Lots, Ask,0,buystoploss,buyprofittarget,"Partial Close",MagicNumber, 0, Blue);

to trade and code, keep both simple... no call to impress....h

#4
Jan 11, 2011 1:20am Jan 11, 2011 1:20am

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

this is the full code i have right now:

Inserted Code

//+------------------------------------------------------------------+
//|                                             Trendlord EA v10.mq4 |
//|                                      Copyright © 2010, Ido Kasse |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2010, Ido Kasse"
#property link      ""

extern int MagicNumber = 0628;
//++++ These are adjusted for 5 digit brokers.
double  pips2points,    // slippage  3 pips    3=points    30=points
        pips2dbl;       // Stoploss 15 pips    0.0015      0.00150
int     Digits.pips;    // DoubleToStr(dbl/pips2dbl, Digits.pips)
static datetime barStart;
int count =1, existorder,ready;
double buyarea1, buyarea2, sellarea1, sellarea2, mysl,TP;

void CheckOrders()
{
   int total = OrdersTotal();
   for (int cnt = 0 ; cnt < total ; cnt++)
   {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL&& OrderMagicNumber()==MagicNumber) existorder = 1;
      if(OrderType()==OP_BUY&& OrderMagicNumber()==MagicNumber) existorder = 1; 
   }
   if (existorder==0) ready=1;
   if (existorder==1) ready=0;
}

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   if (Digits == 5 || Digits == 3)
   {    // Adjust for five (5) digit brokers.
               pips2dbl    = Point*10; pips2points = 10;   Digits.pips = 1;
   } else {    pips2dbl    = Point;    pips2points =  1;   Digits.pips = 0; }
   
   ObjectCreate("today", OBJ_LABEL, 0, 0, 0);
   ObjectSet("today", OBJPROP_CORNER, 1);
   ObjectSet("today", OBJPROP_XDISTANCE, 15);
   ObjectSet("today", OBJPROP_YDISTANCE, 15);
   
   //SIXTH
   ObjectCreate("onesixth",1,0,TimeCurrent(),High[120]);
   ObjectSet("onesixth",OBJPROP_COLOR,Lime);
   ObjectSet("onesixth",OBJPROP_STYLE,STYLE_SOLID);
   ObjectSet("onesixth",OBJPROP_WIDTH,1);     
  
   ObjectCreate("twosixth",1,0,TimeCurrent(),High[120]);
   ObjectSet("twosixth",OBJPROP_COLOR,Red);
   ObjectSet("twosixth",OBJPROP_STYLE,STYLE_SOLID);
   ObjectSet("twosixth",OBJPROP_WIDTH,1);    
      
   ObjectCreate("foursixth",1,0,TimeCurrent(),Low[120]);
   ObjectSet("foursixth",OBJPROP_COLOR,Red);
   ObjectSet("foursixth",OBJPROP_STYLE,STYLE_SOLID);
   ObjectSet("foursixth",OBJPROP_WIDTH,1);
      
   ObjectCreate("fivesixth",1,0,TimeCurrent(),Low[120]);
   ObjectSet("fivesixth",OBJPROP_COLOR,Lime);
   ObjectSet("fivesixth",OBJPROP_STYLE,STYLE_SOLID);
   ObjectSet("fivesixth",OBJPROP_WIDTH,1);
   //END SIXTH
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   ObjectDelete("today");
   ObjectDelete("onesixth");
   ObjectDelete("twosixth");
   ObjectDelete("foursixth");
   ObjectDelete("fivesixth");
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   ObjectSetText("today", StringConcatenate("", TimeToStr(CurTime())), 12, "Arial Bold", DeepSkyBlue);
   
   RefreshRates();
   
   //ADR
   double HI2 = iHigh(NULL,0,0);
   double LOW2 = iLow(NULL,0,0); 
   double HI3 = iHigh(NULL,0,1);
   double LOW3 = iLow(NULL,0,1);
   double HI4 = iHigh(NULL,0,0);
   double LOW4 = iLow(NULL,0,0);
   double HI5 = iHigh(NULL,0,2);
   double LOW5 = iLow(NULL,0,2);
   double HI6 = iHigh(NULL,0,3);
   double LOW6 = iLow(NULL,0,3);
   double HI7 = iHigh(NULL,0,4);
   double LOW7 = iLow(NULL,0,4);
   double HI8 = iHigh(NULL,0,5);
   double LOW8 = iLow(NULL,0,5);
   double HI9 = iHigh(NULL,0,6);
   double LOW9 = iLow(NULL,0,6);
   double HI10 = iHigh(NULL,0,7);
   double LOW10 = iLow(NULL,0,7);
   double HI11 = iHigh(NULL,0,8);
   double LOW11 = iLow(NULL,0,8);
   double HI12 = iHigh(NULL,0,9);
   double LOW12 = iLow(NULL,0,9);
   double HI13 = iHigh(NULL,0,10);
   double LOW13 = iLow(NULL,0,10);
   double HI14 = iHigh(NULL,0,11);
   double LOW14 = iLow(NULL,0,11);
   double HI15 = iHigh(NULL,0,12);
   double LOW15 = iLow(NULL,0,12);
   double HI16 = iHigh(NULL,0,13);
   double LOW16 = iLow(NULL,0,13);
   double HI17 = iHigh(NULL,0,14);
   double LOW17 = iLow(NULL,0,14);
   double HI18 = iHigh(NULL,0,15);
   double LOW18 = iLow(NULL,0,15);
   double HI19 = iHigh(NULL,0,16);
   double LOW19 = iLow(NULL,0,16);
   double HI20 = iHigh(NULL,0,17);
   double LOW20 = iLow(NULL,0,17);
   double HI21 = iHigh(NULL,0,18);
   double LOW21 = iLow(NULL,0,18);
   double HI22 = iHigh(NULL,0,19);
   double LOW22 = iLow(NULL,0,19);
   double HI23 = iHigh(NULL,0,20);
   double LOW23 = iLow(NULL,0,20);
   double OPEN = iOpen(NULL,0,0);
   double CLOSE = iClose(NULL,0,0);
   double ONE = (HI3-LOW3)/2;
   double FIVE = ((HI3-LOW3)+(HI5-LOW5)+(HI6-LOW6)+(HI7-LOW7)+(HI8-LOW8))/10;
   double TEN = ((HI3-LOW3)+(HI5-LOW5)+(HI6-LOW6)+(HI7-LOW7)+(HI8-LOW8)+
                  (HI9-LOW9)+(HI10-LOW10)+(HI11-LOW11)+(HI12-LOW12)+(HI13-LOW13))/20;
   double TWENTY = ((HI3-LOW3)+(HI5-LOW5)+(HI6-LOW6)+(HI7-LOW7)+(HI8-LOW8)+
               (HI9-LOW9)+(HI10-LOW10)+(HI11-LOW11)+(HI12-LOW12)+(HI13-LOW13)+
               (HI14-LOW14)+(HI15-LOW15)+(HI16-LOW16)+(HI17-LOW17)+(HI18-LOW18)+
               (HI19-LOW19)+(HI20-LOW20)+(HI21-LOW21)+(HI22-LOW22)+(HI23-LOW23))/40; 
   double AV2 = ((FIVE+TEN+TWENTY)/3)*20000;
   mysl=(NormalizeDouble(AV2,0));
   Comment("ADR: ",NormalizeDouble(AV2,0));
   //END ADR
 
   //SIXTH
   double value = WindowPriceMax(0)-WindowPriceMin(0);      //value top of the chart - value buttem
   double sixth = value/6;
   double valueS = (value*(MathPow(10,Digits)));
   double sixthS = (sixth*(MathPow(10,Digits)));
   if(ObjectFind("fivesixth")==-1)init();
   ObjectMove("onesixth",0,TimeCurrent(),WindowPriceMin(0)+sixth);
   ObjectMove("twosixth",0,TimeCurrent(),WindowPriceMin(0)+sixth+sixth);
   ObjectMove("foursixth",0,TimeCurrent(),WindowPriceMin(0)+sixth+sixth+sixth+sixth);
   ObjectMove("fivesixth",0,TimeCurrent(),WindowPriceMin(0)+sixth+sixth+sixth+sixth+sixth);
   buyarea1=ObjectGet("onesixth", OBJPROP_PRICE1);
   buyarea2=ObjectGet("twosixth", OBJPROP_PRICE1);
   sellarea1=ObjectGet("fivesixth", OBJPROP_PRICE1);
   sellarea2=ObjectGet("foursixth", OBJPROP_PRICE1);
   //END SIXTH
   
   existorder=0;
   CheckOrders();
   
   //SELL ORDER
   if (Bid<=sellarea1&& Bid>sellarea2&& ready==1) 
   {
   TP=Bid-(MathFloor(MathAbs((sellarea2-Bid)/Point)/10));
   OrderSend(Symbol(),OP_SELL,0.1,Bid,50,Bid+mysl*pips2dbl,TP,NULL,MagicNumber,0,Red);
   }
   //END SELL ORDER
   
   //BUY ORDER
   if (Ask>=buyarea1&& Ask<buyarea2&& ready==1) 
   {
   TP=Ask+(MathFloor(MathAbs((buyarea2-Ask)/Point)/10));
   OrderSend(Symbol(),OP_BUY,0.1,Ask,50,Ask-mysl*pips2dbl,TP,NULL,MagicNumber,0,Blue);
   }
   //END BUY ORDER      
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

#5
Jan 11, 2011 7:07am Jan 11, 2011 7:07am

hanover
Joined Sep 2006 | Status: ... | 8,113 Posts

Quoting ido370

Disliked

this is the full code i have right now:

Ignored

The first problem I encountered is your TP calculation. The values buyarea2 and Ask are already prices, so you shouldn't be dividing then by Point and then by 10.

I ran your EA on a EURAUD,H4 chart (after adding some of my own debugging functions to your code), and it was returning "Error 0130: Invalid stops". That's because the prices in the chart are around 1.31400, but your TP variable had a value of something like 81.3 in it.

Tell me exactly how you want your TP and SL to be calculated, and I'll attempt to change your code accordingly.

There may also be other errors that are being masked by this one, but let's take this one step at a time.

#6
Jan 11, 2011 1:27pm Jan 11, 2011 1:27pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Quoting hanover

Disliked

The first problem I encountered is your TP calculation. The values buyarea2 and Ask are already prices, so you shouldn't be dividing then by Point and then by 10.

I ran your EA on a EURAUD,H4 chart (after adding some of my own debugging functions to your code), and it was returning "Error 0130:...

Ignored

I want the value of the second line from the bottom) to be the TP point. entry is at lowest line.

#7
Jan 11, 2011 4:41pm Jan 11, 2011 4:41pm

hanover
Joined Sep 2006 | Status: ... | 8,113 Posts

Quoting ido370

Disliked

I want the value of the second line from the bottom) to be the TP point. entry is at lowest line.

Ignored

What about the stoploss?

Is the sell trade the exact mirror image of the buy trade?

#8
Jan 12, 2011 12:01am Jan 12, 2011 12:01am

hanover
Joined Sep 2006 | Status: ... | 8,113 Posts

Ido,

You didn't say who your br0ker was. Anyway, the attached is now placing both buy and sell orders correctly with my br0ker (Go Markets). They require that the SL and TP are entered as a modification to the original order.

I can not say whether it is placing the SL at the correct level. Your calculation is too difficult to follow.

There is no special error reporting or handling, should your br0ker decline to place the order, for whatever reason. You'd need to check the journals/logs. The EA will simply re-attempt to place the order on the next tick.

I can't spend any more time on this now; too busy with other work. Hope that this has at least got you to the next step.

David

Attached File(s)

Ido370.mq4 8 KB | 396 downloads

#9
Jan 12, 2011 1:42am Jan 12, 2011 1:42am

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Quoting hanover

Disliked

Ido,

You didn't say who your br0ker was. Anyway, the attached is now placing both buy and sell orders correctly with my br0ker (Go Markets). They require that the SL and TP are entered as a modification to the original order.

I can not say whether it is placing the SL at the correct level. Your calculation is too difficult to follow.

There is no special error reporting or handling, should your br0ker decline to place the order, for whatever reason. You'd need to check the journals/logs. The EA...

Ignored

Thank you for your time to look into it, i have to go to work now too, but will check your file out this evening. I'm using FXpro demo btw. The SL is just calculated by: ADR(20) / 2. the TP goes from (for buy orders) lower green line to lower red line, and same goes for sell: sell at top green line to top red line.

Greets
ido

#10
Jan 12, 2011 3:16am Jan 12, 2011 3:16am

hanover
Joined Sep 2006 | Status: ... | 8,113 Posts

Quoting ido370

Disliked

I'm using FXpro demo btw.

Ignored

I just tried running the EA on FXpro. With FXpro it's unnecessary to set the TP/SL by modifying the order, i.e. you could simply include the SL & TP in the original order. It works both ways.

Attached to this post is a version that sets the entry, SL & TP in the one order.

Attached File(s)

Ido370.mq4 8 KB | 440 downloads

#11
Jan 13, 2011 1:29am Jan 13, 2011 1:29am

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Quoting hanover

Disliked

I just tried running the EA on FXpro. With FXpro it's unnecessary to set the TP/SL by modifying the order, i.e. you could simply include the SL & TP in the original order. It works both ways.

Attached to this post is a version that sets the entry, SL & TP in the one order.

Ignored

thank you! too bad i couldn't test it last night, so i will see it tonight

#12
Jan 26, 2011 2:56pm Jan 26, 2011 2:56pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Work got me so busy lately so i finally got to test it this evening :S
right now it does give frequent ordersend errors 130, but i does take some trades. but actually i want it to take the trade when the price touches the lowest green line, and then a buy order should be placed, so i changed the code (took the old beast EA as for example code) but it won't take any trades now?

Can you tell me how to place the trade when it touches the lowest green line (or the highest green line for a sell order) ?

i attached the old beast EA also, to show you where it got the code from.
Hope you can help me with this one

Attached File(s)

Ido370.mq4 8 KB | 371 downloads

Attached File(s)

The Old Beast.mq4 86 KB | 354 downloads

#13
Jan 26, 2011 5:02pm Jan 26, 2011 5:02pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

OK, managed to get it working properly

here's the code i needed to change, if someone else is looking for it:

Inserted Code

   
buyarea1=NormalizeDouble(ObjectGet("onesixth", OBJPROP_PRICE1), Digits);
   buyarea2=NormalizeDouble(ObjectGet("twosixth", OBJPROP_PRICE1), Digits);
   sellarea1=NormalizeDouble(ObjectGet("fivesixth", OBJPROP_PRICE1), Digits);
   sellarea2=NormalizeDouble(ObjectGet("foursixth", OBJPROP_PRICE1), Digits);

and the following for the buy and sell orders:

Inserted Code

//SELL ORDER
   if (Bid == sellarea1 && ready==1)   {
     entry = NormalizeDouble(Bid,Digits);
     TP    = sellarea2;
     SL    = NormalizeDouble(entry+mysl*pips2dbl,Digits);
     Print("Taking SELL Order with ADR: ",NormalizeDouble(AV2,0));
     OrderSend(Symbol(),OP_SELL,lots,entry,100,SL,TP,NULL,MagicNumber,0,Red);
   }
   //END SELL ORDER
   
   //BUY ORDER
   if (Ask == buyarea1&& ready==1)    {
     entry = NormalizeDouble(Ask,Digits);
     TP    = buyarea2;
     SL    = NormalizeDouble(entry-mysl*pips2dbl,Digits);
     Print("Taking BUY Order with ADR: ",NormalizeDouble(AV2,0));
     OrderSend(Symbol(),OP_BUY,lots,entry,100,SL,TP,NULL,MagicNumber,0,Blue);
   }
   //END BUY ORDER

Thanks for helping so far with the code!

#14
Jan 31, 2011 8:37am Jan 31, 2011 8:37am

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

EA does not place pending orders right now, when white center line is touched? What am i doing wrong here?

Inserted Code

//+------------------------------------------------------------------+
//|                                                    ido-beast.mq4 |
//|                                      Copyright © 2010, Ido Kasse |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2010, Ido Kasse"
#property link      ""

double         BottomGoldLine;//Bottom, gold line
double         BottomGreenLine;//Bottom, green line
double         MiddleWhiteLine;//Middle, white line
double         TopGreenLine;//Top, green line
double         TopGoldLine;//Top, gold line
double         TopLine, BottomLine;
double         HalfTopLine, HalfBottomLine;
int BarCount;

extern int MagicNumber = 3;
extern double lots = 0.1;

//++++ These are adjusted for 5 digit brokers.
double  pips2points,    // slippage  3 pips    3=points    30=points
        pips2dbl;       // Stoploss 15 pips    0.0015      0.00150
int     Digits.pips;    // DoubleToStr(dbl/pips2dbl, Digits.pips)

int ready;
double TP, SL, entry;
double TPw1, SLw1, entryw1, TPw2, SLw2, entryw2;

void CheckOrders()
{
   int total = OrdersTotal();
   for (int cnt = 0 ; cnt < total ; cnt++)
   {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL&& OrderMagicNumber()==MagicNumber) ready = 0;
      if(OrderType()==OP_BUY&& OrderMagicNumber()==MagicNumber) ready= 0; 
   }
}

void CheckPending()
{
   int total = OrdersTotal();
   for (int cnt = 0 ; cnt < total ; cnt++)
   {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_BUYSTOP&& OrderMagicNumber()==MagicNumber) ready= 0; 
      if (Ask==BottomGreenLine) OrderDelete(OrderTicket());
      if(OrderType()==OP_SELLSTOP&& OrderMagicNumber()==MagicNumber) ready= 0;
      if (Ask==TopGreenLine) OrderDelete(OrderTicket());
   }
}

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   if (Digits == 5 || Digits == 3)
   {    // Adjust for five (5) digit brokers.
               pips2dbl    = Point*10; pips2points = 10;   Digits.pips = 1;
   } else {    pips2dbl    = Point;    pips2points =  1;   Digits.pips = 0; }
   
   ObjectCreate("today", OBJ_LABEL, 0, 0, 0);
   ObjectSet("today", OBJPROP_CORNER, 2);
   ObjectSet("today", OBJPROP_XDISTANCE, 15);
   ObjectSet("today", OBJPROP_YDISTANCE, 15);
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----

   ObjectSetText("today", StringConcatenate("", TimeToStr(CurTime())), 12, "Arial Bold", DeepSkyBlue);
   RefreshRates();

   double ctgl = TopGoldLine;
   double cbgl = BottomGoldLine;
   BarCount = NormalizeDouble((iATR(NULL,1440 ,200,0)/MarketInfo(Symbol(),MODE_POINT))/10,0);
   
   double value = High[iHighest(NULL,0,MODE_HIGH,BarCount,1)] - Low[iLowest(NULL,0,MODE_LOW,BarCount,1)];      //value top of the chart - value bottom
   double sixth = value/6;
   
   TopLine = NormalizeDouble(High[iHighest(NULL,0,MODE_HIGH,BarCount,1)], Digits);
   HalfTopLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth+sixth+sixth+(sixth / 2), Digits);
   BottomLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)], Digits);
   HalfBottomLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+(sixth / 2),Digits);
   BottomGoldLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth, Digits);
   BottomGreenLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth, Digits);
   MiddleWhiteLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth, Digits);
   TopGreenLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth+sixth, Digits);
   TopGoldLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth+sixth+sixth, Digits);
   
   Comment("MiddleWhiteLine value: "+MiddleWhiteLine);
   
   //if (!IsTesting() && !IsVisualMode() ) 
   //{
      //Draw the lines
      double tl = ObjectGet("fivesixth", OBJPROP_PRICE1);
      double bl = ObjectGet("onesixth", OBJPROP_PRICE1);
      
      if(tl != TopGoldLine || bl != BottomGoldLine) 
      {
         if (ObjectFind("zerosixth") == -1)
         {
            ObjectCreate("zerosixth",1,0,TimeCurrent(),BottomLine);
            ObjectSet("zerosixth",OBJPROP_COLOR,Magenta);
            ObjectSet("zerosixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("zerosixth",OBJPROP_WIDTH,2);     
         }//if (ObjectFind("zerosixth") == -1)
         else ObjectMove("zerosixth",0,TimeCurrent(),BottomLine);
      
         if (ObjectFind("halfbottomsixth") == -1)
         {
            ObjectCreate("halfbottomsixth",1,0,TimeCurrent(),HalfBottomLine);
            ObjectSet("halfbottomsixth",OBJPROP_COLOR,Magenta);
            ObjectSet("halfbottomsixth",OBJPROP_STYLE,STYLE_DASH);
            ObjectSet("halfbottomsixth",OBJPROP_WIDTH,1);     
         }//if (ObjectFind("halfbottomsixth") == -1)
         else ObjectMove("halfbottomsixth",0,TimeCurrent(),HalfBottomLine);
      
         if (ObjectFind("onesixth") == -1)
         {
            ObjectCreate("onesixth",1,0,TimeCurrent(),BottomGoldLine);
            ObjectSet("onesixth",OBJPROP_COLOR,Gold);
            ObjectSet("onesixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("onesixth",OBJPROP_WIDTH,2);     
         }//if (ObjectFind("onesixth") == -1)
         else ObjectMove("onesixth",0,TimeCurrent(),BottomGoldLine);
      
         if (ObjectFind("twosixth") == -1)
         {
            ObjectCreate("twosixth",1,0,TimeCurrent(),BottomGreenLine);
            ObjectSet("twosixth",OBJPROP_COLOR,Green);
            ObjectSet("twosixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("twosixth",OBJPROP_WIDTH,2);    
         }//if (ObjectFind(
         else ObjectMove("twosixth",0,TimeCurrent(),BottomGreenLine);

         if (ObjectFind("threesixth") == -1)
         {
            ObjectCreate("threesixth",1,0,TimeCurrent(),MiddleWhiteLine);
            ObjectSet("threesixth",OBJPROP_COLOR,White);
            ObjectSet("threesixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("threesixth",OBJPROP_WIDTH,2);
         }//if (ObjectFind(
         else ObjectMove("threesixth",0,TimeCurrent(),MiddleWhiteLine);
      
         if (ObjectFind("foursixth") == -1)
         {
            ObjectCreate("foursixth",1,0,TimeCurrent(),TopGreenLine);
            ObjectSet("foursixth",OBJPROP_COLOR,Green);
            ObjectSet("foursixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("foursixth",OBJPROP_WIDTH,2);
         }//if (ObjectFind(
         else ObjectMove("foursixth",0,TimeCurrent(),TopGreenLine);
      
         if (ObjectFind("fivesixth") == -1)
         {
            ObjectCreate("fivesixth",1,0,TimeCurrent(),TopGoldLine);
            ObjectSet("fivesixth",OBJPROP_COLOR,Gold);
            ObjectSet("fivesixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("fivesixth",OBJPROP_WIDTH,2);
         }//if (ObjectFind(
         else ObjectMove("fivesixth",0,TimeCurrent(),TopGoldLine);
            
         if (ObjectFind("halftopsixth") == -1)
         {
            ObjectCreate("halftopsixth",1,0,TimeCurrent(),HalfTopLine);
            ObjectSet("halftopsixth",OBJPROP_COLOR,Magenta);
            ObjectSet("halftopsixth",OBJPROP_STYLE,STYLE_DASH);
            ObjectSet("halftopsixth",OBJPROP_WIDTH,1);     
         }//if (ObjectFind("halftopsixth") == -1)
         else ObjectMove("halftopsixth",0,TimeCurrent(),HalfTopLine);
      
         if (ObjectFind("sixsixth") == -1)
         {
            ObjectCreate("sixsixth",1,0,TimeCurrent(),TopLine);
            ObjectSet("sixsixth",OBJPROP_COLOR,Magenta);
            ObjectSet("sixsixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("sixsixth",OBJPROP_WIDTH,2);     
         }//if (ObjectFind("sixsixth") == -1)
         else ObjectMove("sixsixth",0,TimeCurrent(),TopLine);


      }
      
   //}
   
   ready=1;
   CheckOrders();
   CheckPending();
   
   double minlot  = MarketInfo(Symbol(),MODE_MINLOT);
   if (minlot == 0.01)   lots = NormalizeDouble(lots,2);
   if (minlot == 0.1)    lots = NormalizeDouble(lots,1);
   if (minlot == 1)      lots = NormalizeDouble(lots,0);

   //SELL ORDER
   if (Bid == TopLine && ready==1)   {
     entry = HalfTopLine;
     TP    = TopGoldLine;
     SL    = TopLine;
     Print("Pending SELL Order placed");
     OrderSend(Symbol(),OP_SELLSTOP,lots,entry,100,SL,TP,NULL,MagicNumber,0,Red);
   }
   //END SELL ORDER
   
   //BUY ORDER
   if (Ask == BottomLine&& ready==1)    {
     entry = HalfBottomLine;
     TP    = BottomGoldLine;
     SL    = BottomLine;
     Print("Pending BUY Order placed");
     OrderSend(Symbol(),OP_BUYSTOP,lots,entry,100,SL,TP,NULL,MagicNumber,0,Blue);
   }
   //END BUY ORDER   
   
   //CENTERLINE ORDER
   if (Ask == MiddleWhiteLine&& ready==1)    {
     entryw1 = TopGreenLine; 
     TPw1    = TopGoldLine;
     SLw1    = MiddleWhiteLine;
     entryw2 = BottomGreenLine;
     TPw2    = BottomGoldLine;
     SLw2    = MiddleWhiteLine;
     Print("Pending GSPE Orders placed");
     OrderSend(Symbol(),OP_BUYSTOP,lots,entryw1,100,SLw1,TPw1,NULL,MagicNumber,0,Blue);
     Sleep(1000);
     OrderSend(Symbol(),OP_SELLSTOP,lots,entryw2,100,SLw2,TPw2,NULL,MagicNumber,0,Red);
   }
   //END CENTERLINE ORDER    
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

#15
Last Post: Jan 31, 2011 5:54pm Jan 31, 2011 5:54pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

OK, almost done. right now it does place the pending orders as it should, but after a while the sixth lines can move up and down, so i need to change entry, SL and TP of pending orders.
right now i have the code as below, but i get many errors in journal when backtesting. error 1 does not seem to be bad i read (1=no error?) but also a lot 130 error (wrong SL?). Can someone help me fix this?

Code:

Inserted Code

//+------------------------------------------------------------------+
//|                                                    ido-beast.mq4 |
//|                                      Copyright © 2010, Ido Kasse |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2010, Ido Kasse"
#property link      ""

double         BottomGoldLine;//Bottom, gold line
double         BottomGreenLine;//Bottom, green line
double         MiddleWhiteLine;//Middle, white line
double         TopGreenLine;//Top, green line
double         TopGoldLine;//Top, gold line
double         TopLine, BottomLine;
double         HalfTopLine, HalfBottomLine;
int BarCount;

extern double lots = 0.1;

//++++ These are adjusted for 5 digit brokers.
double  pips2points,    // slippage  3 pips    3=points    30=points
        pips2dbl;       // Stoploss 15 pips    0.0015      0.00150
int     Digits.pips;    // DoubleToStr(dbl/pips2dbl, Digits.pips)

int ready;
double TP, SL, entry;
double TPw1, SLw1, entryw1, TPw2, SLw2, entryw2;

void CheckOrders()
{
   int total = OrdersTotal();
   for (int cnt = 0 ; cnt < total ; cnt++)
   {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL) ready=0;
      if(OrderType()==OP_BUY) ready=0; 
   }
}

void CheckPending()
{
   int total = OrdersTotal();
   for (int cnt = 0 ; cnt < total ; cnt++)
   {
      OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELLSTOP&& OrderMagicNumber()==111) {
      ready=0;
      OrderModify(OrderTicket(),HalfTopLine,TopLine,TopGoldLine,0,Red);}
      if(OrderType()==OP_BUYSTOP&& OrderMagicNumber()==111) {
      ready=0;
      OrderModify(OrderTicket(),HalfBottomLine,BottomLine,BottomGoldLine,0,Blue);}
      
      if(OrderType()==OP_BUYSTOP&& OrderMagicNumber()==222) {
      ready=0; 
      OrderModify(OrderTicket(),TopGreenLine,MiddleWhiteLine,TopGoldLine,0,Blue);}
      if(OrderType()==OP_SELLSTOP&& OrderMagicNumber()==222) {
      ready=0;
      OrderModify(OrderTicket(),BottomGreenLine,MiddleWhiteLine,TopGoldLine,0,Red);}
   }
}

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   if (Digits == 5 || Digits == 3)
   {    // Adjust for five (5) digit brokers.
               pips2dbl    = Point*10; pips2points = 10;   Digits.pips = 1;
   } else {    pips2dbl    = Point;    pips2points =  1;   Digits.pips = 0; }
   
   ObjectCreate("today", OBJ_LABEL, 0, 0, 0);
   ObjectSet("today", OBJPROP_CORNER, 2);
   ObjectSet("today", OBJPROP_XDISTANCE, 15);
   ObjectSet("today", OBJPROP_YDISTANCE, 15);
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----

   ObjectSetText("today", StringConcatenate("", TimeToStr(CurTime())), 12, "Arial Bold", DeepSkyBlue);
   RefreshRates();

   double ctgl = TopGoldLine;
   double cbgl = BottomGoldLine;
   BarCount = NormalizeDouble((iATR(NULL,1440 ,200,0)/MarketInfo(Symbol(),MODE_POINT))/10,0);
   
   double value = High[iHighest(NULL,0,MODE_HIGH,BarCount,1)] - Low[iLowest(NULL,0,MODE_LOW,BarCount,1)];      //value top of the chart - value bottom
   double sixth = value/6;
   
   TopLine = NormalizeDouble(High[iHighest(NULL,0,MODE_HIGH,BarCount,1)], Digits);
   HalfTopLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth+sixth+sixth+(sixth / 2), Digits);
   BottomLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)], Digits);
   HalfBottomLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+(sixth / 2),Digits);
   BottomGoldLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth, Digits);
   BottomGreenLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth, Digits);
   MiddleWhiteLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth, Digits);
   TopGreenLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth+sixth, Digits);
   TopGoldLine = NormalizeDouble(Low[iLowest(NULL,0,MODE_LOW,BarCount,1)]+sixth+sixth+sixth+sixth+sixth, Digits);
   
   Comment("Barcount: "+BarCount);
   
   //if (!IsTesting() && !IsVisualMode() ) 
   //{
      //Draw the lines
      double tl = ObjectGet("fivesixth", OBJPROP_PRICE1);
      double bl = ObjectGet("onesixth", OBJPROP_PRICE1);
      
      if(tl != TopGoldLine || bl != BottomGoldLine) 
      {
         if (ObjectFind("zerosixth") == -1)
         {
            ObjectCreate("zerosixth",1,0,TimeCurrent(),BottomLine);
            ObjectSet("zerosixth",OBJPROP_COLOR,Magenta);
            ObjectSet("zerosixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("zerosixth",OBJPROP_WIDTH,2);     
         }//if (ObjectFind("zerosixth") == -1)
         else ObjectMove("zerosixth",0,TimeCurrent(),BottomLine);
      
         if (ObjectFind("halfbottomsixth") == -1)
         {
            ObjectCreate("halfbottomsixth",1,0,TimeCurrent(),HalfBottomLine);
            ObjectSet("halfbottomsixth",OBJPROP_COLOR,Magenta);
            ObjectSet("halfbottomsixth",OBJPROP_STYLE,STYLE_DASH);
            ObjectSet("halfbottomsixth",OBJPROP_WIDTH,1);     
         }//if (ObjectFind("halfbottomsixth") == -1)
         else ObjectMove("halfbottomsixth",0,TimeCurrent(),HalfBottomLine);
      
         if (ObjectFind("onesixth") == -1)
         {
            ObjectCreate("onesixth",1,0,TimeCurrent(),BottomGoldLine);
            ObjectSet("onesixth",OBJPROP_COLOR,Gold);
            ObjectSet("onesixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("onesixth",OBJPROP_WIDTH,2);     
         }//if (ObjectFind("onesixth") == -1)
         else ObjectMove("onesixth",0,TimeCurrent(),BottomGoldLine);
      
         if (ObjectFind("twosixth") == -1)
         {
            ObjectCreate("twosixth",1,0,TimeCurrent(),BottomGreenLine);
            ObjectSet("twosixth",OBJPROP_COLOR,Green);
            ObjectSet("twosixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("twosixth",OBJPROP_WIDTH,2);    
         }//if (ObjectFind(
         else ObjectMove("twosixth",0,TimeCurrent(),BottomGreenLine);

         if (ObjectFind("threesixth") == -1)
         {
            ObjectCreate("threesixth",1,0,TimeCurrent(),MiddleWhiteLine);
            ObjectSet("threesixth",OBJPROP_COLOR,White);
            ObjectSet("threesixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("threesixth",OBJPROP_WIDTH,2);
         }//if (ObjectFind(
         else ObjectMove("threesixth",0,TimeCurrent(),MiddleWhiteLine);
      
         if (ObjectFind("foursixth") == -1)
         {
            ObjectCreate("foursixth",1,0,TimeCurrent(),TopGreenLine);
            ObjectSet("foursixth",OBJPROP_COLOR,Green);
            ObjectSet("foursixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("foursixth",OBJPROP_WIDTH,2);
         }//if (ObjectFind(
         else ObjectMove("foursixth",0,TimeCurrent(),TopGreenLine);
      
         if (ObjectFind("fivesixth") == -1)
         {
            ObjectCreate("fivesixth",1,0,TimeCurrent(),TopGoldLine);
            ObjectSet("fivesixth",OBJPROP_COLOR,Gold);
            ObjectSet("fivesixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("fivesixth",OBJPROP_WIDTH,2);
         }//if (ObjectFind(
         else ObjectMove("fivesixth",0,TimeCurrent(),TopGoldLine);
            
         if (ObjectFind("halftopsixth") == -1)
         {
            ObjectCreate("halftopsixth",1,0,TimeCurrent(),HalfTopLine);
            ObjectSet("halftopsixth",OBJPROP_COLOR,Magenta);
            ObjectSet("halftopsixth",OBJPROP_STYLE,STYLE_DASH);
            ObjectSet("halftopsixth",OBJPROP_WIDTH,1);     
         }//if (ObjectFind("halftopsixth") == -1)
         else ObjectMove("halftopsixth",0,TimeCurrent(),HalfTopLine);
      
         if (ObjectFind("sixsixth") == -1)
         {
            ObjectCreate("sixsixth",1,0,TimeCurrent(),TopLine);
            ObjectSet("sixsixth",OBJPROP_COLOR,Magenta);
            ObjectSet("sixsixth",OBJPROP_STYLE,STYLE_SOLID);
            ObjectSet("sixsixth",OBJPROP_WIDTH,2);     
         }//if (ObjectFind("sixsixth") == -1)
         else ObjectMove("sixsixth",0,TimeCurrent(),TopLine);
      }
   //}
   
   ready=1;
   CheckOrders();
   CheckPending();
   
   double minlot  = MarketInfo(Symbol(),MODE_MINLOT);
   if (minlot == 0.01)   lots = NormalizeDouble(lots,2);
   if (minlot == 0.1)    lots = NormalizeDouble(lots,1);
   if (minlot == 1)      lots = NormalizeDouble(lots,0);

   //SELL ORDER
   if (Bid<=TopLine&& Ask>=TopLine&& ready==1)   {
     entry = HalfTopLine;
     TP    = TopGoldLine;
     SL    = TopLine;
     Print("Pending SELL Order placed");
     OrderSend(Symbol(),OP_SELLSTOP,lots,entry,100,SL,TP,NULL,111,0,Red);
     Print (GetLastError());
   }
   //END SELL ORDER
   
   //BUY ORDER
   if (Ask>= BottomLine&& Bid<=BottomLine&& ready==1)    {
     entry = HalfBottomLine;
     TP    = BottomGoldLine;
     SL    = BottomLine;
     Print("Pending BUY Order placed");
     OrderSend(Symbol(),OP_BUYSTOP,lots,entry,100,SL,TP,NULL,111,0,Blue);
     Print (GetLastError());
   }
   //END BUY ORDER   
     
   //CENTERLINE ORDER
   if (Ask>=MiddleWhiteLine && Bid<=MiddleWhiteLine&& ready==1)    {
     entryw1 = TopGreenLine; 
     TPw1    = TopGoldLine;
     SLw1    = MiddleWhiteLine;
     entryw2 = BottomGreenLine;
     TPw2    = BottomGoldLine;
     SLw2    = MiddleWhiteLine;
     Print("Pending GSPE Orders placed");
     OrderSend(Symbol(),OP_BUYSTOP,lots,entryw1,100,SLw1,TPw1,NULL,222,0,Blue);
     Print (GetLastError());
     OrderSend(Symbol(),OP_SELLSTOP,lots,entryw2,100,SLw2,TPw2,NULL,222,0,Red);
     Print (GetLastError());
   }
   //END CENTERLINE ORDER    
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

Platform Tech
/
Setting TP or SL at object line
Reply to Thread

0 traders viewing now

Options

Similar Threads

Setting TP or SL at object line