Exiting Trades on iLowest and iHighest

Can someone take a look at this and see if there is something amiss...

I am testing exits if price exceeds the highest High or the lowest Low for the last x number of bars.

My ea routine is correctly exiting short positions as programmed but is exiting longs on the next bar regardless of price.

Both exit algorithms are mirror codes of each other, and I am completely baffled here...

Again my SHORT EXITS are working properly, but my LONG EXITS are exiting too soon and there are no stops or trailing stops here...Here is the code (most of this was developed by user Cch who has been very very helpful).

*****

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

if (OrderMagicNumber() == MagicNumber)


if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;


if(OrderType() == OP_BUY) {


if (Close[0] < iLowest(NULL,0,MODE_LOW,5,1)) Order = LONG_EXIT;


if (Order == LONG_EXIT && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}

if(UseTS && TS > 0) {
if(Bid - OrderOpenPrice() > Point * TS) {
if(OrderStopLoss() < Bid - Point * TS) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TS, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
else
{


if (Close[0] > iHighest(NULL,0,MODE_HIGH,5,1)) Order = SHORT_EXIT;



if (Order == SHORT_EXIT && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);

if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}

if (UseTS && TS > 0) {
if((OrderOpenPrice() - Ask) > (Point * TS)) {
if((OrderStopLoss() > (Ask + Point * TS)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TS, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

****
END OF EXIT ROUTINE

The iHighest/iLowest functions give the SHIFT of the highest/lowest point.


See revision...

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

if (OrderMagicNumber() == MagicNumber)


if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;


if(OrderType() == OP_BUY) {


if (Close[0] < iLow(NULL, 0, iLowest(NULL,0,MODE_LOW,5,1))) Order = LONG_EXIT;


if (Order == LONG_EXIT && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}

if(UseTS && TS > 0) {
if(Bid - OrderOpenPrice() > Point * TS) {
if(OrderStopLoss() < Bid - Point * TS) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TS, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
else
{


if (Close[0] > iHigh(NULL, 0, iHighest(NULL,0,MODE_HIGH,5,1))) Order = SHORT_EXIT;



if (Order == SHORT_EXIT && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);

if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}

if (UseTS && TS > 0) {
if((OrderOpenPrice() - Ask) > (Point * TS)) {
if((OrderStopLoss() > (Ask + Point * TS)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TS, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

Ronald,

Thank you for the fast post, unfortunately I tried the alternate code but it makes it worse, keep in mind with the original code I posted that the SHORT EXIT is working as it should by calculating the highest high of the last 5 bars and exiting the trade if Close[0] exceeds that, but for whatever reason the LONG EXIT is not working the same. The code you gave me completely extends the duration with no logical exit.

Tried comparing Close[0] to and iLow setting of 5 bars back but the problem is the when using iLow you are looking at comparing the Current close to the low 5 bars ago.

This is a subtle difference to using iLowest.

I want to compare the Current close to the Lowest Low of the LAST 5 Bars and if the Current close is lower than any of the lowest lows of the last 5 bars, then I want to exit my long.

In the original code posted in my first post, my short exits are working properly using the iLowest feature, but for whatever reason it's not working right for my LONG EXITS.

I'm wondering if anyone here actually uses iLowest successfully or if I am missing a syntax error or if there is a bug in MT4.

Does anyone know?

hi,
if (Close[0] < iLowest(NULL,0,MODE_LOW,5,1)) Order = LONG_EXIT;

this function => iLowest(NULL,0,MODE_LOW,5,1)) will return value 1, 2, 3, 4 or 5, depend on which bar has the lowest value. to get price value at that bar, we have to use iLow(NULL,0,iLowest(NULL,0,MODE_LOW,5,1))
or
Low[iLowest(NULL,0,MODE_LOW,5,1)].

try the attached EA below, it will simply show the value of iLowest/iHighest with the respecting price value
hope this help

I would like to find the highest high and lowest low between start_time and end_time but EXCLUDING the start_time and end_time bars. I only want to find out the bars BETWEEN the two timings. How do I do that?

Is this the correct code?

datetime start_time = (whatever time you like: StrToTime("YYYY.MM.DD HH:II:SS"));
datetime end_time = (whatever time you like: StrToTime("YYYY.MM.DD HH:II:SS"));
int start_bar = iBarShift(Symbol(),Period(),start_time,0);
int end_bar = iBarShift(Symbol(),Period(),end_time,0);
double high = High[iHighest(Symbol(),Period(),MODE_HIGH, start_bar-end_bar, end_bar)];
double low = Low [iLowest (Symbol(),Period(),MODE_LOW, start_bar-end_bar, end_bar)];

Does it include or exclude iHighest and iLowest the the start bar and end bar?

That is determined by you. Read the documentation and try a few examples - that can be done quicker than posting a question here. I am not going to look up the documentation and quote it here; but I know it is very clear how it works.

That is not determined by me. It either works correctly or it doesn't.

I have already tried looking over the web and mq4 docs but couldn't find what I am looking for yet.

I need a specific answer to determine the precise code for the exact thing I need it to do.

I need someone who can give me a definite answer.